Page MenuHomeWildfire Games

[gui] credits/*.json white space corrections
ClosedPublic

Authored by Nescio on Dec 28 2019, 1:46 PM.

Details

Summary

As pointed out by @elexis in D2427, the use of white space in the credits json files is inconsistent.

  • balancing.json, community.json, and history.json are correct.
  • translators.json is generated from script and is therefore not touched here; it uses four spaces instead of tabs and lists Nicolas Auvray under every language, though.
  • art.json, donators.json, programming.json, and special.json are made consistent in this patch by correcting the indentation and inserting spaces between { and " and " and }.

Similar patches are D1953 (technologies), D2000 (auras), and D2222 (civs).

Test Plan

Check these files for mistakes and further inconsistencies.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Dec 28 2019, 1:46 PM
Owners added a subscriber: Restricted Owners Package.Dec 28 2019, 1:46 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/903/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1419/display/redirect

Stan requested changes to this revision.Jan 6 2020, 10:23 AM
Stan edited reviewers, added: Stan; removed: Restricted Owners Package.
Stan added a subscriber: Stan.

Needs a rebase it seems.

This revision now requires changes to proceed.Jan 6 2020, 10:23 AM
Nescio updated this revision to Diff 10898.Jan 6 2020, 1:21 PM

rebased

Vulcan added a comment.Jan 6 2020, 1:24 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/963/display/redirect

Vulcan added a comment.Jan 6 2020, 1:25 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/59/display/redirect

Vulcan added a comment.Jan 6 2020, 1:28 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1481/display/redirect

Stan accepted this revision.Jan 6 2020, 3:39 PM
This revision is now accepted and ready to land.Jan 6 2020, 3:39 PM
This revision was automatically updated to reflect the committed changes.
Nescio retitled this revision from gui/credits/*.json white space corrections to [gui] credits/*.json white space corrections.May 18 2020, 10:30 AM