Page MenuHomeWildfire Games

gui/manual/intro.txt interpunction
ClosedPublic

Authored by Nescio on Sat, Jan 11, 12:28 PM.

Details

Summary

This patch is split from D2305. It does the following:

  • replace programmer's quotes (" ") in text with proper opening and closing quotation marks (“ ”)
  • start sentences with a capital
  • etcetc.
  • remove an incorrect colon (:)
  • use imperative
Test Plan

Check for mistakes and omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Sat, Jan 11, 12:28 PM
Owners added a subscriber: Restricted Owners Package.Sat, Jan 11, 12:28 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1008/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/104/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1526/display/redirect

Gallaecio requested changes to this revision.Sat, Jan 11, 1:14 PM
Gallaecio added inline comments.
binaries/data/mods/public/gui/manual/intro.txt
84 ↗(On Diff #10972)

I think the previous phrasing was clearer.

In fact, other than maybe changing “and” to “or” to make it more obvious that they are not meant to be pressed at once, I cannot think of a way to improve the current phrasing. The only shorter alternative I can think of is “F5-F8”, but I think that would be less clear.

This revision now requires changes to proceed.Sat, Jan 11, 1:14 PM
Nescio added inline comments.Sat, Jan 11, 1:18 PM
binaries/data/mods/public/gui/manual/intro.txt
84 ↗(On Diff #10972)

The reason I changed it was for consistency with the line above. I suppose I could also change line 83 to "Ctrl + F5, Ctrl + F6, Ctrl + F7, Ctrl + F8" instead. I'm fine with either.

Nescio added inline comments.Sat, Jan 11, 1:20 PM
binaries/data/mods/public/gui/manual/intro.txt
84 ↗(On Diff #10972)

And lines 80, 81, 82.

Gallaecio accepted this revision.Sat, Jan 11, 8:20 PM
Gallaecio added inline comments.
binaries/data/mods/public/gui/manual/intro.txt
84 ↗(On Diff #10972)

You are right, I missed that. +1 for your current changes, in that case.

This revision is now accepted and ready to land.Sat, Jan 11, 8:20 PM
Freagarach requested changes to this revision.Sun, Jan 12, 8:48 AM
Freagarach added a subscriber: Freagarach.
Freagarach added inline comments.
binaries/data/mods/public/gui/manual/intro.txt
112 ↗(On Diff #10972)

Missed one ;) (Starting capital.)

This revision now requires changes to proceed.Sun, Jan 12, 8:48 AM
Nescio updated this revision to Diff 11016.Tue, Jan 14, 7:59 PM
Nescio edited the summary of this revision. (Show Details)

Highlights → Highlight

binaries/data/mods/public/gui/manual/intro.txt
112 ↗(On Diff #10972)

Thanks.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1039/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/135/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1557/display/redirect

Freagarach accepted this revision.Tue, Jan 14, 8:04 PM
  • Compleat.
  • Improves consistency -> Is an improvement.
  • Breaks nothing.
This revision is now accepted and ready to land.Tue, Jan 14, 8:04 PM

Compleat.

You do know the correct spelling is “complete”, don't you?

Aye, something of a pun around here (in real space) ;)

Yeah, I guessed so. Sometimes there is an interesting story behind deliberate misspellings. :)

This revision was automatically updated to reflect the committed changes.