Page MenuHomeWildfire Games
Differential D2574

Refactors Preprocessor testing and adds more tests
ClosedPublic
Actions

Authored by vladislavbelov on Jan 15 2020, 10:21 PM.

Details

Reviewers
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23405: Refactors Preprocessor testing and adds more tests
Summary

Subj.

Test Plan
  1. Apply the patch and compile tests
  2. Run tests
  3. Make sure that all Preprocessor tests are passed

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Jan 15 2020, 10:21 PM
Vulcan added a comment.Jan 15 2020, 10:22 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1057/display/redirect

Vulcan added a comment.Jan 15 2020, 10:24 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/153/display/redirect

Vulcan added a comment.Jan 15 2020, 10:25 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1575/display/redirect

Harbormaster completed remote builds in B10826: Diff 11045.Jan 15 2020, 10:25 PM
Stan added a subscriber: Stan.Jan 15 2020, 11:59 PM

Maybe add a test for division by 0 and #elif?

vladislavbelov added a comment.Jan 16 2020, 12:08 AM
In D2574#107740, @Stan wrote:

Maybe add a test for division by 0 and #elif?

elif is already here.

Stan added a comment.Jan 16 2020, 12:09 AM

Oh yes, my bad.

vladislavbelov updated this revision to Diff 11046.Jan 16 2020, 12:13 AM

Adds division by zero test.

Vulcan added a comment.Jan 16 2020, 12:14 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1058/display/redirect

Vulcan added a comment.Jan 16 2020, 12:17 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/154/display/redirect

Vulcan added a comment.Jan 16 2020, 12:17 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1576/display/redirect

Harbormaster completed remote builds in B10827: Diff 11046.Jan 16 2020, 12:17 AM
Stan accepted this revision.Jan 16 2020, 12:35 AM

Patch looks good test are sane and a nice addition and autobuild doesn't complain.

This revision is now accepted and ready to land.Jan 16 2020, 12:35 AM
vladislavbelov updated this revision to Diff 11047.Jan 16 2020, 12:38 AM

Used CStr8 instead of std::string.

Vulcan added a comment.Jan 16 2020, 12:40 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1059/display/redirect

Vulcan added a comment.Jan 16 2020, 12:42 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1577/display/redirect

Vulcan added a comment.Jan 16 2020, 12:42 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/155/display/redirect

Harbormaster completed remote builds in B10828: Diff 11047.Jan 16 2020, 12:42 AM
vladislavbelov updated this revision to Diff 11048.Jan 16 2020, 12:45 AM
Stan added a comment.Jan 16 2020, 12:46 AM

You could also assert there is no logger output?

source/third_party/ogre3d_preprocessor/tests/test_Preprocessor.h
24 ↗(On Diff #11047)

Nuke?

Vulcan added a comment.Jan 16 2020, 12:47 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1060/display/redirect

vladislavbelov marked an inline comment as done.Jan 16 2020, 12:49 AM
Vulcan added a comment.Jan 16 2020, 12:49 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/156/display/redirect

Vulcan added a comment.Jan 16 2020, 12:49 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1578/display/redirect

Harbormaster completed remote builds in B10829: Diff 11048.Jan 16 2020, 12:49 AM
Stan accepted this revision.Jan 16 2020, 12:54 AM
Closed by commit rP23405: Refactors Preprocessor testing and adds more tests (authored by vladislavbelov). · Explain WhyJan 16 2020, 1:02 AM
This revision was automatically updated to reflect the committed changes.
vladislavbelov added a commit: rP23405: Refactors Preprocessor testing and adds more tests.

Revision Contents
Changeset List

PathSize
ps/
trunk/
source/
third_party/
ogre3d_preprocessor/
tests/
82 lines

Diff 11049

View Options

ps/trunk/source/third_party/ogre3d_preprocessor/tests/test_Preprocessor.h

Loading...
Wildfire Games · Phabricator