Page MenuHomeWildfire Games

selection groups for support units
ClosedPublic

Authored by Nescio on Mar 26 2020, 6:15 PM.

Details

Reviewers
Freagarach
Angen
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23570: Selection groups for support units
Summary

Fewer lines, less work for mods. Effectively no changed in-game behaviour.
See also D2675 and D2681.

Test Plan

Check for mistakes and omissions. Agree this is an improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Mar 26 2020, 6:15 PM
Owners added a subscriber: Restricted Owners Package.Mar 26 2020, 6:15 PM
Nescio added inline comments.Mar 26 2020, 6:15 PM
binaries/data/mods/public/simulation/templates/units/brit_support_healer_b.xml
9 ↗(On Diff #11565)

Already defined in parent template.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1920/display/redirect

Freagarach accepted this revision.Mar 27 2020, 3:39 PM
Freagarach added a subscriber: Freagarach.

Great! I guess the rank changes can be split from this, although they are also compleat and correct.

This revision is now accepted and ready to land.Mar 27 2020, 3:39 PM
Nescio edited the summary of this revision. (Show Details)Mar 27 2020, 4:17 PM
Nescio edited the test plan for this revision. (Show Details)
Angen accepted this revision.EditedApr 6 2020, 10:48 AM
Angen added a subscriber: Angen.

Reason for female citizens was that there is separate template for women trained from house so double selection would not work.
Changed behavior is for selecting multiple women across civilizations what cannot happen because female capturing is not possible. In case it would be possible, triple click would work unchanged. Double click would select all women with patch instead all women per civilization, what seems more reasonable that one wants to select all women with double clicking.

Same logic applies to healers.

To the merchant and fishing ships. As they are not combat ships, it make sense to have separate selection groups for them with possibly more tiers for that kind of ships or captured ones if implemented. As other ships do not contain selection group nor their parent templates, double click uses template name for selection anyway so no change in this case.

This revision was automatically updated to reflect the committed changes.