Page MenuHomeWildfire Games

[WP] MesonBuild support
AbandonedPublic

Authored by Stan on May 17 2020, 4:33 PM.

Details

Reviewers
Itms
Summary

TBD

Test Plan

TBD

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
SeverityLocationCodeMessage
Auto-Fixsource\meson.build:1TXT8Leading Whitespace at BOF
Unit
No Unit Test Coverage
Build Status
Buildable 11709
Build 21651: Vulcan BuildJenkins
Build 21650: Vulcan Build (macOS)Jenkins
Build 21649: Vulcan Build (Windows)Jenkins
Build 21648: arc lint + arc unit

Event Timeline

Stan created this revision.May 17 2020, 4:33 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2148/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/734/display/redirect

Itms added a comment.Oct 28 2020, 6:25 PM

Yo Stan, I don't see the need for MesonBuild support, I would recommend creating a Trac ticket with "If Time Permits" urgency, a link to this diff in the Patch field, and then abandon this diff for the time being.

Are the source changes from another patch? Should they be reviewed elsewhere or are they already in?

Stan abandoned this revision.Nov 11 2020, 11:16 AM

I don't plan to work on this anytime soon. Was a fun experiment.

andy5995 added inline comments.Mon, Sep 19, 5:18 PM
libraries/source/fcollada/src/meson.build
20

I see this is abandoned, but thought I'd point out for future reference

In cases like this, you can do something like

src_basename = [
  'FCDAnimated.cpp',
  'FCDAnimationChannel.cpp',
  'FCDAnimationClip.cpp',
  ...
 ]

src = []
for each file : src_basename
  src += join_paths('FCollada/FCDocument', file)
endforeach

Also there's some info in the meson FAQ about how to use wildcards

https://mesonbuild.com/FAQ.html#but-i-really-want-to-use-wildcards