Page MenuHomeWildfire Games

Remove unused headers from RL interface
AbandonedPublic

Authored by irishninja on Aug 4 2020, 4:35 PM.

Details

Reviewers
wraitii
Summary

This revision removes a the unused includes from RL interface that I missed in D2199.

@wraitii - would you mind reviewing this?

Test Plan

Ensure it still compiles

Event Timeline

Vulcan added a comment.Aug 4 2020, 4:38 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2870/display/redirect

irishninja updated this revision to Diff 13049.Aug 4 2020, 4:56 PM

Added string stream back. The remaining includes removed by the diff should no longer be used. iirc, these were what each was used for:

  • GameSetup was used back when the revision D2199 included a definition of the scenario config in cpp which was used in the RLInterface. (At the time, it had a from static method which would convert from CLI args or protobuf - it was using GRPC at the beginning - to a GameConfig object.)
  • tuple was replaced with the Command struct for storing player IDs and the command
  • queue was used back when it was using a channel for synchronization across the threads rather than mutexes
Vulcan added a comment.Aug 4 2020, 4:57 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2871/display/redirect

irishninja requested review of this revision.Aug 4 2020, 6:40 PM
irishninja edited the summary of this revision. (Show Details)Aug 4 2020, 9:58 PM
irishninja added a reviewer: wraitii.
irishninja added a subscriber: wraitii.
wraitii abandoned this revision.Mon, Nov 23, 9:38 AM

Folding this into D3129