Page MenuHomeWildfire Games

[WIP] Modification templates test & fixes to 'affects'
Needs ReviewPublic

Authored by wraitii on Sat, Jan 9, 10:16 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This is WIP because atm I'm not changing anything.
As shown in the test, the behaviour is a bit odd right now. We 'AND' specific 'affects', when I think we should probably replace them (and/or force to either affect all or specify per-class).
Also the code is buggy somewhat, the modifiers are odd.

Test Plan

Run the tests, agree that some changes are needed.

Event Timeline

wraitii created this revision.Sat, Jan 9, 10:16 AM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(tinygettext.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file

See https://jenkins.wildfiregames.com/job/macos-differential/2723/display/redirect for more details.

wraitii requested review of this revision.Sat, Jan 9, 11:16 AM

For me, the current behaviour seems quite right. The whole e.g. technology file affects "ClassA" but it has some differentiation for "ClassB", which also needs to be "ClassA".