Page MenuHomeWildfire Games

[gameplay] enable maur palace
ClosedPublic

Authored by Nescio on Jan 11 2021, 10:03 PM.

Details

Summary

This patch:

  • allows the Mauryas to build their palace (limited to one);
  • gives the palace the same territory influence as the Persian apadana and tacara;
  • replaces the female citizen with the maiden guard champion in the palace training queue;
  • removes the maiden guard archer from the Chandragupta hero training queue;
  • removes the maiden guard swordwoman from the barracks;
  • renames the champion infantry maceman template and removes their unlock_champion_units requirement;
  • removes the champions and heroes from the Mauryan fortress training queue.

As a consequence, the Mauryas can immediately train their champions upon advancing to the city phase, but each at a different structure:

  • the maiden guards at the palace;
  • the maceman at the barracks;
  • the chariot at the stable;
  • the elephant at the elephant stable.

Basically the Mauryas become a bit more similar to the Persians (who also have a palace for their heroes and an infantry champion) and a bit less similar than the Macedonians (who can train champion infantry at the barracks too, but need the unlock technology, unlike the Mauryas). And since the Mauryas were historically influenced by both the Persians and the Macedonians, having a bit of both in game seems not entirely inappropiate.

Test Plan

Check for mistakes and omissions. Agree with the changes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 11 2021, 10:03 PM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Jan 11 2021, 10:03 PM
Nescio removed a subscriber: Restricted Owners Package.Jan 11 2021, 10:04 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2778/display/redirect for more details.

Nescio requested review of this revision.Jan 11 2021, 10:09 PM
borg- accepted this revision.Jan 12 2021, 3:15 AM

I'm accepting about gameplay / balancing, no code.
Perfect. I have no opposition here. Replaces heroes and maiden correctly for the palace. Removing the unlock champions makes mauryan a little different from the others, I like that, I think we are reaching our goal.

This revision is now accepted and ready to land.Jan 12 2021, 3:15 AM
Freagarach requested changes to this revision.Jan 12 2021, 8:21 AM
Freagarach added a subscriber: Freagarach.

Did you check the maps? (Sandbox needs an update.)

binaries/data/mods/public/simulation/templates/structures/maur/palace.xml
27 ↗(On Diff #15152)

DE has a nice icon (can be done later).

This revision now requires changes to proceed.Jan 12 2021, 8:21 AM

Did you check the maps? (Sandbox needs an update.)

No, I didn't, I should have. It was late and I kind of forgot I renamed a template.

No problem :) Thats where a review comes in handy ;)

Nescio updated this revision to Diff 15170.Jan 12 2021, 12:59 PM
  • fix maps/scenarios/sandbox_mauryas.xml, spotted by @Freagarach
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Jan 12 2021, 12:59 PM
Nescio removed subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package.Jan 12 2021, 1:00 PM
Nescio added inline comments.
binaries/data/mods/public/maps/scenarios/sandbox_mauryas.xml
30044–30079 ↗(On Diff #15170)

Two of each.

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2790/display/redirect for more details.

Freagarach resigned from this revision.Jan 12 2021, 1:25 PM
Freagarach removed a reviewer: Freagarach.

Nice!

This revision is now accepted and ready to land.Jan 12 2021, 1:25 PM
This revision was automatically updated to reflect the committed changes.
Owners added subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package.Jan 12 2021, 3:25 PM