Differential D3383

Fix savegame list being too long.
ClosedPublic
Actions

Authored by wraitii on Jan 16 2021, 4:43 PM.

Details

Reviewers: None
Commits: rP24677: Fix savegame list being too high.

Summary

The Load/Save game list is too long, particularly for saving where it goes on top of the input field. This fixes that.

Reported by: nifa

Test Plan

Have many save games. Save a game.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

temp

Lint

Lint OK

Severity	Location	Code	Message
Error	binaries/data/mods/public/gui/loadgame/SavegamePage.js:9	ESLintBear (no-use-before-define)	ESLintBear (no-use-before-define)
Warning	binaries/data/mods/public/gui/loadgame/SavegamePage.js:16	JSHintBear	JSHintBear

Unit

No Unit Test Coverage

Build Status

Buildable 15115
Build 32750: Vulcan Build	Jenkins
Build 32749: Vulcan Build (macOS)	Jenkins
Build 32748: Vulcan Build (Windows)	Jenkins
Build 32747: arc lint + arc unit

Event Timeline

wraitii created this revision.Jan 16 2021, 4:43 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file

See https://jenkins.wildfiregames.com/job/macos-differential/2895/display/redirect for more details.

Harbormaster completed remote builds in B15115: Diff 15387.Jan 16 2021, 5:38 PM

wraitii requested review of this revision.Jan 16 2021, 5:38 PM

Freagarach added a subscriber: nifa.Jan 17 2021, 8:16 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2021, 12:07 PM

Closed by commit rP24677: Fix savegame list being too high. (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP24677: Fix savegame list being too high..