Differential D3425
Fix target height computation when launching projectiles. Authored by wraitii on Jan 19 2021, 5:37 PM.
Details
The Y coordinate at which to fire a projectile is currently assumed to be the target's current Y position, which is incorrect if the target is moving on a slope. I'm wondering if we shouldn't actually fire a little above, just to make sure we don't hit the ground. The collision code doesn't really care (I do think we should probably rewrite it). As noted by bb in rP24701 Review the change, notice that it indeed fixes things, note that firing projectiles still works in general.
Diff Detail
Event TimelineComment Actions Build has FAILED builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2971/display/redirect Comment Actions Build has FAILED Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/4056/display/redirect Comment Actions Build has FAILED Link to build: https://jenkins.wildfiregames.com/job/docker-differential/4628/display/redirect Comment Actions Build is green builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library See https://jenkins.wildfiregames.com/job/macos-differential/2972/display/redirect for more details. Comment Actions I haven't followed the discussion, but this patch seems like a correct one to me.
Comment Actions The big question for me is whether we should target "position + 1" or something like that instead of position. It seems hacky, but it might actually help in a few cases. Otherwise this can be merged relatively straighforwardly imo Comment Actions Could you make a comparative video between position and position +1 ?
Comment Actions Might want to use the same function name in JS for consistency.
Comment Actions Height difference (__A is SVN). TBH at the moment it looks pretty bad because the projectile doesn't disappear on hit... Comment Actions Build is green builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library See https://jenkins.wildfiregames.com/job/macos-differential/3019/display/redirect for more details. | ||||||||||||||||||||||||||||||||||