Differential D35
Fix "clobbered" warning in Jenkins build Authored by Itms on Jan 4 2017, 11:31 AM.
Details
As you must have noticed by now, Jenkins comes up with a few warnings when it builds. Some of them are going to be fixed in D24, but there is a "clobbered" warning in tex_png. This stack overflow thread: http://stackoverflow.com/questions/7721854/what-sense-do-these-clobbered-variable-warnings-make explains the reason of the error. Check on your compiler that there is no warning, and validate that Jenkins doesn't show up this warning either.
Diff Detail
Event TimelineComment Actions Build is green Updating workspaces.
Build (release)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
void CChart::HandleMessage(SGUIMessage& Message)
^
Build (debug)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
void CChart::HandleMessage(SGUIMessage& Message)
^
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!http://jw:8080/job/phabricator/86/ for more details. Comment Actions It would be better to fix the issue the error message is hinting at. It might be a false positive but the function is not nicely written: an evil goto, big inconsistencies with the decode function. I propose a patch that makes encode quite similar to decode, fixes the issue and removes the goto. Comment Actions Build is green Updating workspaces.
Build (release)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
void CChart::HandleMessage(SGUIMessage& Message)
^
Build (debug)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
void CChart::HandleMessage(SGUIMessage& Message)
^
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!http://jw:8080/job/phabricator/90/ for more details. Comment Actions Build is green Updating workspaces.
Build (release)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
void CChart::HandleMessage(SGUIMessage& Message)
^
Build (debug)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
void CChart::HandleMessage(SGUIMessage& Message)
^
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!http://jw:8080/job/phabricator/91/ for more details. Comment Actions Just to clean up some confusion: The evil thing here is setjmp/longjmp which has more of those "evil" properties referenced in that (in?)famous goto paper than actual goto in C and C++. But nice that this warning finally gets fixed! (Properly that is.) |