Page MenuHomeWildfire Games

Also do a postMove update when the average speed over last turn isn't zero
AcceptedPublic

Authored by bb on Sun, Oct 10, 10:19 PM.

Details

Reviewers
Freagarach
Summary

As reported by Freagarach, units can end up showing the moving animation while being in idle state:

I suppose the following happens:
A unit moves and needs a big turn, hence the speed goes to zero, but it still had some meanspeed, so the walking anim shows. Now the next turn the unit decided to quit moving (due to be obstructed and close enough to target). Now the meanspeed will never be updated, so the unit will keep showing the walking anim.

Simply also trow a needsupdate when we have moved last turn.

Broken in rP25953.
Reported By Freagarach.

Test Plan

Try to reproduce, Freagarach's replay is fixed by this patch.

Do a rejoin test

Event Timeline

bb created this revision.Sun, Oct 10, 10:19 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5058/display/redirect

Freagarach published this revision for review.Mon, Oct 11, 7:37 PM
Freagarach added inline comments.
source/simulation2/components/CCmpUnitMotion.h
342

?

bb updated this revision to Diff 18812.Tue, Oct 12, 6:17 PM
bb edited the test plan for this revision. (Show Details)

Please don't introduce an OOS....

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5063/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Debug: 
Microsoft (R) Build Engine version 15.9.21+g9802d43bc3 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

Release: 
Microsoft (R) Build Engine version 15.9.21+g9802d43bc3 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/6154/display/redirect

Freagarach accepted this revision.Tue, Oct 12, 6:28 PM

Fixes the issue, looks good.

source/simulation2/components/CCmpUnitMotion.h
229

Do note that Last TurnSpeed and LastTurn Speed look similar.

This revision is now accepted and ready to land.Tue, Oct 12, 6:28 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5064/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5065/display/redirect