Differential D4592

Fix progress slider on autoqueued items.
ClosedPublic
Actions

Authored by Freagarach on Apr 6 2022, 5:32 PM.

Details

Reviewers

Langbart

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP26769: Fix progress slider on formerly autoqueued items.

Trac Tickets

#6492

Summary

Reported by @Langbart.

Test Plan

See ticket.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Apr 6 2022, 5:32 PM

Owners added a subscriber: Restricted Owners Package.Apr 6 2022, 5:32 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/6996/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5905/display/redirect

Harbormaster completed remote builds in B20069: Diff 20057.Apr 6 2022, 5:47 PM

Freagarach requested review of this revision.Apr 6 2022, 5:47 PM

Freagarach added inline comments.Apr 6 2022, 5:58 PM

binaries/data/mods/public/gui/session/selection_panels.js
575 ↗	(On Diff #20057)	It would be good if we wouldn't misuse the progressSlider for this. ;)

This solves the problem of the linked ticket.

This revision is now accepted and ready to land.Apr 6 2022, 7:38 PM

This revision was landed with ongoing or failed builds.Apr 9 2022, 7:34 AM

Closed by commit rP26769: Fix progress slider on formerly autoqueued items. (authored by Freagarach). · Explain Why

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP26769: Fix progress slider on formerly autoqueued items..

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

selection_panels.js

15 lines

Diff 20067

View Options

ps/trunk/binaries/data/mods/public/gui/session/selection_panels.js

Fix progress slider on autoqueued items.ClosedPublicActions