Page MenuHomeWildfire Games

Langbart
User

Projects

User Details

User Since
Jan 15 2021, 12:54 AM (98 w, 6 d)

Recent Activity

Thu, Nov 24

Langbart accepted D4832: Fix elephant mixins..

similar issue solved in rP25245

Thu, Nov 24, 10:31 AM
Langbart added a comment to rP27241: Don't (mis)use technologies to differentiate elephants..

replace op="mul" with op="mul_round" ?

Thu, Nov 24, 10:28 AM
Langbart added a comment to rP27241: Don't (mis)use technologies to differentiate elephants..

#6659, but I'm a bit lost why,,, It works fine for mercenaries.

Thu, Nov 24, 9:55 AM

Aug 16 2022

Langbart resigned from rP26015: Some fixes after the ProductionQueue split..
Aug 16 2022, 4:43 PM
Langbart added a comment to D4765: Fix Mod.json issues..

after applying the patch, the problem from the ticket is no longer reproducible. The issue is fixed .

Aug 16 2022, 4:42 PM

Aug 6 2022

Langbart abandoned D4748: Remove redundant references to deleted .dtd files.
Aug 6 2022, 7:37 PM
Langbart abandoned D4329: Copy/Open button for file path in replay window.
Aug 6 2022, 7:37 PM
Langbart abandoned D4256: Adjusting the placeholder text for inputs.
Aug 6 2022, 7:36 PM
Langbart abandoned D4749: Apply stylesheet to template files.

P238

Aug 6 2022, 7:36 PM
Langbart abandoned D3544: Regroup members at most once when formation and its members get idle.
Aug 6 2022, 7:35 PM
Langbart removed a reviewer for D4750: possible hotfix for wrong tech tooltips and structure tree: Langbart.
Aug 6 2022, 7:35 PM
Langbart resigned from rP26170: Performs texture uploads via DeviceCommandContext interface..

D4732

Aug 6 2022, 7:10 PM
Langbart resigned from rP26859: Fixes dynamic GL buffer orphaning forgotten in rP26406. Fixes #6533.
Aug 6 2022, 7:09 PM
Langbart resigned from rP26991: Add techs and auras to the list of possibly missing files..
Aug 6 2022, 7:09 PM

Aug 4 2022

Langbart updated subscribers of D4750: possible hotfix for wrong tech tooltips and structure tree.

P277 complains as well. (There should be more template files listed, but after the first entry it stops.)

Production Queue Validator
❯ python3 Production.py -v -r .
INFO - Launching 0.A.D with the following command binaries/system/pyrogenesis -mod="mod" -mod="public" --rl-interface="127.0.0.1:9090" --autostart-nonvisual --autostart="skirmishes/acropolis_bay_2p"
INFO - Calling http://127.0.0.1:9090/evaluate to get data
INFO - Killing 0 A.D.
INFO - Looking for templates with missing production queue.
ERROR - structures/generic_field has no production queue.
Aug 4 2022, 6:48 AM

Aug 3 2022

Langbart resigned from rP27009: [Gameplay] Han unit roster restructure and other balancing adjustments.
Aug 3 2022, 6:02 PM
Langbart resigned from rP27012: Use the new crossbow for han champion units..
Aug 3 2022, 5:47 PM
Langbart resigned from rP27011: New crossbow model for the han champion units..
Aug 3 2022, 5:46 PM
Langbart added a comment to P265 Fix D4514..
  • The execution of the script from the public folder worked.
    • Testing if comments will be removed from the .xml file.
  • The comment was still there after running the script.
  • The only negative side effect is that the comment did not move with the renamed component.
Aug 3 2022, 5:15 PM
Langbart raised a concern with rP27009: [Gameplay] Han unit roster restructure and other balancing adjustments.
  • Try to start the sandbox map from the Han, many errors.
  • Bisecting lead to this commit.
Aug 3 2022, 4:28 PM
Langbart raised a concern with rP27012: Use the new crossbow for han champion units..
checkrefs
python3 checkrefs.py -a
...
INFO - Collecting actors...
INFO - Validating textures...
WARNING - "public/art/actors/units/han/infantry_crossbowman_c.xml": actor contains unnecessary texture(s) "specTex" from "player_trans.xml"
Aug 3 2022, 4:16 PM
Langbart raised a concern with rP27011: New crossbow model for the han champion units..
Aug 3 2022, 4:11 PM
Langbart added a comment to P238 A23 to A24 components.

Only bad side effect is the comments are thrown under the bus.

Aug 3 2022, 3:41 PM
Langbart added a comment to P238 A23 to A24 components.

i was missing lxml

Aug 3 2022, 3:29 PM
Langbart added a comment to P238 A23 to A24 components.

I could not get it to work.

Aug 3 2022, 2:59 PM
Langbart updated the summary of D4749: Apply stylesheet to template files.
Aug 3 2022, 7:49 AM

Aug 2 2022

Langbart requested review of D4749: Apply stylesheet to template files.
Aug 2 2022, 3:15 PM
Langbart updated the diff for D4748: Remove redundant references to deleted .dtd files.

Restore catalog.xml

Aug 2 2022, 12:39 PM
Langbart updated the summary of D4748: Remove redundant references to deleted .dtd files.
Aug 2 2022, 6:30 AM
Langbart requested review of D4748: Remove redundant references to deleted .dtd files.
Aug 2 2022, 6:20 AM

Aug 1 2022

Langbart accepted D4746: Smaller adjustments to the building order.

It fixes all the problems referenced in the ticket.

Aug 1 2022, 8:35 AM

Jul 29 2022

Langbart added a comment to D4511: [gameplay] make catapult / stonethrower more useful.

Maybe even more vision, I can't see the progress on bombing the house unless I move closer.

Jul 29 2022, 6:58 AM

Jul 24 2022

Langbart added a comment to D4743: Ignore broken symlinks.

make a dangling symlink ...

❯ ln -s ~/ThisFolderDoesNotExist ~/Library/Application\ Support/0ad/mods/ThisFolderDoesNotExist
❯ ls -la ~/Library/Application\ Support/0ad/mods/ | grep ThisFolderDoesNotExist
lrwxr-xr-x   1 paria  staff     35 Jul 24 22:55 ThisFolderDoesNotExist -> /Users/paria/ThisFolderDoesNotExist

start 0ad

Jul 24 2022, 11:54 PM

Jul 23 2022

Langbart updated the diff for D3544: Regroup members at most once when formation and its members get idle.

Rebase

Jul 23 2022, 5:49 PM
Langbart commandeered D3544: Regroup members at most once when formation and its members get idle.

rebase

Jul 23 2022, 5:48 PM
Langbart updated subscribers of P281 Applying patches with Arcanist that contain empty files.

Mostly arc patch gets the job done, if not I use one of @wraitii's formulae:

However, they also do not filter out empty files.

Jul 23 2022, 3:03 PM
Langbart updated subscribers of P281 Applying patches with Arcanist that contain empty files.
In D4735#201575, @lyv wrote:

the files are always empty and not deleted

If you are applying with patch, you can use the -E flag. I generate patches using git diff which has a slightly different format (even phab shows those files as just deleted while this revision shows the files cleared). If you are using arc patch I have no idea what to do.

Jul 23 2022, 1:38 AM
Langbart created P281 Applying patches with Arcanist that contain empty files.
Jul 23 2022, 1:31 AM

Jul 22 2022

Langbart added a comment to D4735: Move all buildings to the builder mixin.

I think the problem is I don't use arcanist to upload the patch to phabricator since it is stupidly annoying to setup on windows.

😑

  • vlad is on windows also does not use arcanist and on his patches it works. (D4434)
  • works for smiley too (D4611)
Jul 22 2022, 3:15 PM

Jul 21 2022

Langbart added a comment to D4735: Move all buildings to the builder mixin.

delete the sele & mace library templates

You need to find out how to delete these files correctly when you create a patch. Every time I try to apply one of your patches with deleted files, the files are always empty and not deleted, I have to do it manually. This is also the reason why the ci in D4713 failed.

Jul 21 2022, 11:45 PM
Langbart raised a concern with rP26015: Some fixes after the ProductionQueue split..

#6587
s0600204 wrote:

The issue with the Structure Tree is that r26015 removed default Researcher/TechCostMultiplier values; and whilst r26192 fixed that for the simulation, a fix was not applied to globalscripts which expects there to be values for each possible resource specified within templates.
This is causing other technology costs to be displayed incorrectly within the Structure Tree, such as those of the Mauryan temple and the Gallic forge

Jul 21 2022, 1:13 PM
Langbart resigned from rP26632: [Han Chinese - Alpha 26] Champions trainable in captured Barracks and Stables….

rP27009

Jul 21 2022, 1:09 PM

Jul 19 2022

Langbart updated subscribers of D4735: Move all buildings to the builder mixin.

General

  • The fortress should come after the defense_tower

Civ list

athen

  • @wraitii has already began something differnt here, see rP25239
  • that is why the gymnasium and prytaneion is listed before the wonder


brit

cart

  • super_dock should sit next to the wonder (only accessible in phase 3)


gaul

han

iber

kush

mace

  • they have one extra building now


maur

pers

ptol

rome

sele

  • they have one extra building now


spart

Jul 19 2022, 6:32 PM

Jul 18 2022

Langbart raised a concern with rP26859: Fixes dynamic GL buffer orphaning forgotten in rP26406. Fixes #6533.

#6593

Jul 18 2022, 11:26 PM

Jul 14 2022

Langbart raised a concern with rP26991: Add techs and auras to the list of possibly missing files..

With rP26996 there are two new techs phase_city_pers.json and phase_town_pers.json, both are (wrongly) listed by the checkrefs.py script, see log output below for more clarity.

Jul 14 2022, 7:29 PM
Langbart updated the Trac tickets for D3544: Regroup members at most once when formation and its members get idle.
Jul 14 2022, 7:17 PM

Jun 28 2022

Langbart resigned from rP26980: [Gameplay] Han - Hero adjustments.
Jun 28 2022, 4:19 PM
Langbart raised a concern with rP26980: [Gameplay] Han - Hero adjustments.

unused aura.
#6544

Jun 28 2022, 7:29 AM
Langbart accepted D4727: Fix formation merging issue..

I am happy with it, it fixes all the errors from the ticket.

Jun 28 2022, 7:20 AM

Jun 27 2022

Langbart accepted D4725: Add techs and auras to the list of possibly missing files .

It found all unused files from the current change set and 26899. I also tested if the name of an aura/tech was the same but in a different folder, it found those correctly too. It even found techs where the autoResearch was set to false. 👌

Jun 27 2022, 4:26 PM
Langbart added a comment to D4725: Add techs and auras to the list of possibly missing files .

After applying the patch the python script successfully found the unused han_hero_wei_qing_3.json file.

Jun 27 2022, 8:49 AM

Jun 25 2022

Langbart added a comment to rP26987: revert last commit / rP26986.

Sorry for not being clearer!

Jun 25 2022, 9:11 AM
Langbart added a comment to D4727: Fix formation merging issue..

It fixes the first issue in the referenced ticket, the second issue, the selection of units, can still be reproduced after applying the patch.
Will attach a replay with latest GIT version + D4727.


The issue occurs ~1min:40secs
(PS: it needs to be viewed via replay-visual, otherwise it will not trigger any errors.)

Jun 25 2022, 8:20 AM

Jun 24 2022

Langbart added a comment to rP26986: [GUI] increase msgbox button size to fix text overlap.

I have to say that I am very disappointed with the decision to proceed with this patch. Detailed comments were simply ignored I will definitely not continue to work on this project if this carries on.

Jun 24 2022, 5:07 PM

Jun 22 2022

Langbart resigned from rP26418: Add Han Chinese Actors.

rP26961

Jun 22 2022, 4:45 AM

Jun 21 2022

Langbart added a comment to D4707: [GUI] increase msgbox button size to fix text overlap.

  • reduce the size of the dialog for the openURL(url) function, it was added with rP15062 and is with 600px unnecessarily long
    • The box showing the link is very useless and can be removed, it is broken anyway for very long links e.g. MultiplayerGame LobbyTerms of ServiceView online
      • The conformation box for opening URL's has already be removed for Mod selectionHelpModding Guide/ Visit mod.io
  • reduce the button size for the case there is only one button on the dialog box
    • make it adoptive to the text length a little bit, but the button should not stretch across the entire message box window
  • Pick a height for the red buttons, just enough to hold two lines of text and the proportions of the message box are aesthetically pleasing, 40px looks good. These confirmation options are not supposed to be very long. The string "Quit and View Summary" from rP25978 should have simply be "Summary".
    • Alternatively

my idea would be a two size solution. One for short words / one lines and one for two lines.

Jun 21 2022, 5:14 AM

Jun 20 2022

Langbart added a comment to rP26954: Choose civ randomly in gamesetup.

If you have too much time, wrap the function in a loop and see if the probability of each civ is now roughly equal when you draw 1000000 times.

Jun 20 2022, 3:52 PM
Langbart awarded rP26954: Choose civ randomly in gamesetup a Like token.
Jun 20 2022, 3:51 PM
Langbart added a comment to D4707: [GUI] increase msgbox button size to fix text overlap.
Setup:
python3 generateDebugTranslation.py --long --languages "ast" "ca" "cs" "de" "el" "en_GB" "es" "eu" "fi" "fr" "gd" "hu" "id" "it" "nl" "pl" "pt_BR" "ru" "sk" "sv" "tr" "uk"
  • start
binaries/system/pyrogenesis -conf=locale:long
Impact
Jun 20 2022, 3:32 PM
Langbart resigned from rP26949: Groups close minimap icons by path and color to decrease their visible count..

rP26969

Jun 20 2022, 9:44 AM
Langbart raised a concern with rP26949: Groups close minimap icons by path and color to decrease their visible count..

#6578

Jun 20 2022, 7:16 AM
Langbart requested review of D4717: Correction of the deco size at the bottom right of the ModernDialog sprite.
Jun 20 2022, 1:39 AM

Jun 19 2022

Langbart resigned from rP26922: Fixes LOS flickering because of float precision. Fixes #6546.

rP26950

Jun 19 2022, 6:26 AM

Jun 16 2022

Langbart added a comment to D4702: Groups close minimap icons to decrease their visible count.

Apply the patch and compile the game

ok

Check big maps like African Planes or Egypt 3v3

tested Egypt 3v3

Compare performance via F11 (especially gui rendering)


Jun 16 2022, 12:49 AM

Jun 14 2022

Langbart added a comment to D4698: Fix entvalidate.py.

Run entvalidate.py

Jun 14 2022, 6:01 AM
Langbart added a comment to D4700: Fixes same frames for LOS smooth textures.

Apply the patch and compile the game

ok

Follow the steps from #6569

Tested with delenda and with replays from the actual game for openGL & ARB. The problem from the ticket could not be reproduced. The line of sight updates accordingly when moving your units, constructing structures or doing tech vision upgrades. Checking the minimap, testing different shadow options, switching between civilisations and different game speeds could not reveal any problems.

Jun 14 2022, 5:13 AM

Jun 13 2022

Langbart accepted D4694: Fix phasing by cheat with Athens..

Ternary it shall be.

Jun 13 2022, 11:19 PM
Langbart raised a concern with rP26418: Add Han Chinese Actors.

#6566

Jun 13 2022, 11:11 PM

Jun 12 2022

Langbart resigned from rP26931: Count rice as veggie..
Jun 12 2022, 7:17 AM
Langbart raised a concern with rP26931: Count rice as veggie..
[23:49:31] elexis (revert rP26931 following rP26937)
Jun 12 2022, 3:13 AM

Jun 11 2022

Langbart raised a concern with rP26922: Fixes LOS flickering because of float precision. Fixes #6546.

#6569

Jun 11 2022, 9:06 PM
Langbart raised a concern with rP26632: [Han Chinese - Alpha 26] Champions trainable in captured Barracks and Stables….

#6560

Jun 11 2022, 4:05 PM
Langbart resigned from rP25077: Separate Game Settings from the GUI Gamesetup.

rP26933

Jun 11 2022, 4:04 PM
Langbart resigned from rP25099: MP: don't enforce game init attributes synchronization in PREGAME..

rP26933

Jun 11 2022, 4:03 PM

Jun 10 2022

Langbart added a comment to D4598: [GUI] fancy endgame message.

discuss the strings that should be displayed

better VICTORIOUS and DEFEATED
see summary tooltip


or use the string from the victory track:

Music.prototype.DEFAULT_VICTORY_TRACKS = [
	"You_are_Victorious!.ogg"
];

and for defeated YOU HAVE BEEN DEFEATED!

Jun 10 2022, 3:25 AM
Langbart awarded D4598: [GUI] fancy endgame message a Like token.
Jun 10 2022, 2:31 AM
Langbart added a comment to D4689: Cleanup CShaderParams::SItems comparisons.

For me it compiles and runs. IDK were the code is used.

Yes, for me too. macOS10.15

Jun 10 2022, 12:37 AM
Langbart added a comment to D4690: [GUI] rename minimap idle worker -> idle citizens.
/**
 * Unit classes to be checked for the idle-**worker**-hotkey.
 */
var g_WorkerTypes = ["FemaleCitizen", "Trader", "FishingBoat", "Citizen"];
Jun 10 2022, 12:20 AM

Jun 9 2022

Langbart added a comment to D4681: Fix shadow artifacts without shadow filtering in some A25 biomes/maps.


PS: Will not test this patch again, seems to be a rabbit hole. Minor problem may not be noticed by users and can be easily patched by the user themselves through activating Filtering in the options..

Jun 9 2022, 11:29 PM

Jun 6 2022

Langbart resigned from rP26906: Fixes A8 framebuffer format used for LOS interpolation and enables smooth LOS….
Jun 6 2022, 11:04 PM
Langbart added a comment to D4681: Fix shadow artifacts without shadow filtering in some A25 biomes/maps.

This problem can still be seen on the Mainland map with the generic/sahara biome for the Han civic centre.

Jun 6 2022, 9:31 PM
Langbart added a comment to D4684: Fixes LOS flickering because of float precision.

With the latest update of this patch, I can no longer reproduce the problem described in the ticket.

Jun 6 2022, 6:55 PM

Jun 3 2022

Langbart added a comment to D4684: Fixes LOS flickering because of float precision.

Check LOS changing by moving unit with enabled/disabled frame limitation with GL and GL ARB

Just some videos, they both look fine.

Jun 3 2022, 10:06 PM
Langbart added a comment to D4684: Fixes LOS flickering because of float precision.

Apply the patch and compile the game

ok

Check LOS changing by moving unit with enabled/disabled frame limitation with GL and GL ARB

Jun 3 2022, 9:54 PM
Langbart resigned from rP25562: Use new biomes for random maps,.

See patch D4681.
This commit makes the problem more visible, but is not the actual cause of the bug.

Jun 3 2022, 7:43 PM
Langbart added a comment to D4677: span and string_view for CmdLineArgs.
In D4677#199006, @Stan wrote:

@Langbart can you try to build this on your mac? It seems the tests fail to build.

Jun 3 2022, 7:11 PM
Langbart added a comment to D4681: Fix shadow artifacts without shadow filtering in some A25 biomes/maps.

The stone mine on the Anatolian Plateau looks better with this patch.

Jun 3 2022, 6:55 PM

Jun 2 2022

Langbart added a comment to D4678: Fix gamesetup breakage when matchsettings.json contains incorrect victory conditions..

It fixes the problem described in the ticket.

Jun 2 2022, 9:22 PM
Langbart raised a concern with rP25562: Use new biomes for random maps,.

#6552

Jun 2 2022, 6:54 PM
Langbart raised a concern with rP25099: MP: don't enforce game init attributes synchronization in PREGAME..

#6553

Jun 2 2022, 4:25 PM
Langbart raised a concern with rP25077: Separate Game Settings from the GUI Gamesetup.

#6553

Jun 2 2022, 4:25 PM

May 28 2022

Langbart raised a concern with rP26906: Fixes A8 framebuffer format used for LOS interpolation and enables smooth LOS….

#6546

May 28 2022, 7:23 PM

May 27 2022

Langbart awarded D4654: Fixes A8 framebuffer format a Like token.
May 27 2022, 5:53 AM
Langbart added a comment to rP26906: Fixes A8 framebuffer format used for LOS interpolation and enables smooth LOS….

With the default settings, it now looks more elegant and beautiful.

May 27 2022, 5:51 AM

May 26 2022

Langbart added a comment to D4654: Fixes A8 framebuffer format.

Apply the patch and compile the game

ok

Check that minimap looks like before with GL and GL ARB backends

ok

Check that map revealing looks like before
Check that LOS behaves like before

Yes, but it should be noted as soon as I added smoothlos = "true" to my user.cfg without the patch being applied I would crash for any rendererbackend. After applying the patch I could set smoothlos to "true" and would not crash for both rendererbackends.

May 26 2022, 5:19 AM

May 23 2022

Langbart added a comment to D4650: Adds instancing support to backend and enables it for minimap.

Patch applied

Units demo

openGL: https://ttm.sh/bad.43.png
openGL ARB: https://ttm.sh/ba2.01.png

May 23 2022, 8:51 PM
Langbart added a comment to D4661: Don't reset wonder victory timer on ally defeat..
# notes
[17:01:08] elexis we had some iconics back in the day
[17:02:06] elexis fpre had destroyed about 20 CCs in 6 minutes with mauryan warrior champions
[17:03:23] elexis if you can keep a wonder for wonder duration time, you get the victory, how can they violate that rule?
[17:04:40] elexis and I dont see any descriptions being changed, if they want to change the rules they should update the rules
[17:05:13] elexis then they can reconsider if complex conditions that dont fit into one short sentence makes sense

May 23 2022, 5:46 PM

May 22 2022

Langbart added a comment to D4249: [Gameplay] Let the mauryan working elephant build again.

elephant_worker.json could be removed.

May 22 2022, 9:27 AM

May 20 2022

Langbart added a comment to D4650: Adds instancing support to backend and enables it for minimap.

Apply the patch and compile the game

Ok

Check that GL minimap looks similar/same to GL ARB

Minimap looks good, but look at the textures on the scenarios/arcadia map. They appear more squared on openGL than on openGL ARB.

May 20 2022, 6:49 AM

May 19 2022

Langbart updated the language for P273 eslint0ad from autodetect to bash.
May 19 2022, 7:42 PM