Page MenuHomeWildfire Games
Differential D4818

Save configuration once when possible
ClosedPublic
Actions

Authored by Silier on Nov 2 2022, 8:36 AM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP27194: Save configuration once when possible
Summary

Reduce how many times configuration is written into the file pointed out by @nani and @Freagarach in D4616

Test Plan

.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 21024
Build 50817: arc lint + arc unit

Event Timeline

Silier created this revision.Nov 2 2022, 8:36 AM
Owners added a subscriber: Restricted Owners Package.Nov 2 2022, 8:36 AM
Harbormaster completed remote builds in B21024: Diff 21033.Nov 2 2022, 8:36 AM
Silier requested review of this revision.Nov 2 2022, 8:36 AM
Silier added a reviewer: Restricted Owners Package.Nov 2 2022, 8:41 AM
Silier edited the summary of this revision. (Show Details)
Silier added a subscriber: Freagarach.
This revision was not accepted when it landed; it landed in state Needs Review.Nov 3 2022, 5:45 PM
Closed by commit rP27194: Save configuration once when possible (authored by Silier). · Explain Why
This revision was automatically updated to reflect the committed changes.
Silier added a commit: rP27194: Save configuration once when possible.

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
gui/
gamesetup_mp/
15 lines
prelobby/
common/
credentials/
9 lines
splashscreen/
5 lines

Diff 21033

View Options

binaries/data/mods/public/gui/gamesetup_mp/gamesetup_mp.js

Loading...
View Options

binaries/data/mods/public/gui/prelobby/common/credentials/credentials.js

Loading...
View Options

binaries/data/mods/public/gui/splashscreen/splashscreen.js

Loading...
Wildfire Games · Phabricator