Fixed out of bounds
ClosedPublic
Actions

Authored by vladislavbelov on May 12 2017, 8:49 PM.

Details

Reviewers

elexis
Itms
echotangoecho

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP19579: Fix out of range access in CInput, patch by vladislavbelov. Fixes #4570.

Trac Tickets

#4401
#4570

Summary

There was an issue in old code in UpdateAutoScroll, it didn't check invalid cursor positions.

Test Plan

Compile the game in Debug mode
Run the game and try to open lobby

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.May 12 2017, 8:49 PM

elexis awarded a token.May 12 2017, 8:50 PM

vladislavbelov added a parent revision: D483: Upgrade the Windows bundled gloox.May 12 2017, 10:00 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1167/ for more details.

Harbormaster completed remote builds in B1679: Diff 1881.May 13 2017, 12:02 AM