Rename GetNonGaiaEntities to GetAllPlayersEntities
AbandonedPublic
Actions

Authored by elexis on May 15 2017, 2:56 PM.

Details

Reviewers

bb
fatherbushido

Summary

...because unowned entities are excluded and since adding a function to return both Gaia and AllPlayers entities would have to be called GetGaiaAndNonGaiaEntities otherwise.

Test Plan

Make sure all occurances were replaced. All files were changed in 2017 already.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 1741
Build 2756: Vulcan Build	Jenkins
Build 2755: arc lint + arc unit

Event Timeline

elexis created this revision.May 15 2017, 2:56 PM

Harbormaster completed remote builds in B1741: Diff 1946.May 15 2017, 2:56 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1215/ for more details.

Harbormaster completed remote builds in B1741: Diff 1946.May 15 2017, 6:45 PM

I click on accept as it's complete.
I am not qualified to discussed about the given name but it doesn't seem worse than the previous one.

This revision is now accepted and ready to land.May 16 2017, 3:30 PM

GetAllPlayersEntities seems confusing since Gaia is technically a player too.
Don't want to get an acceptance go to waste, but I'm not convinced of either naming. If there's no good reason to change things, then we shouldn't (might abolish and live with the fact that GetNonGaiaEntities doesn't return some entities that are not owned by gaia).

I'm not convinced of either way, dunno. Might want to pick this up again once we're confident of which naming is better.

elexis mentioned this in D1050: Add a GetAllPlayers function.Dec 7 2017, 8:21 PM

bb mentioned this in D1124: Remove the serialization of colors in Minimap.Dec 24 2017, 3:52 PM