SetID was added in r3214, refs r7555, r9286, r10903.
Details
Details
- Reviewers
phosit - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP27818: Provides entity ID for unit in its constructor.
- Apply the patch and compile the game
- Check the game works the same
- Check Atlas works the same
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| source/graphics/Unit.h | ||
|---|---|---|
| 69–71 ↗ | (On Diff #22174) | Probably also outdated. |
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8316/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7227/display/redirect
Comment Actions
This is an improvement and the things in the test plan worked.
For the future: I think it's wrong that graphics/ knows something about the simulation. A hack would be to make the CUnit a template on a id-type.
Comment Actions
I think it's vice versa. Because simulation is data and graphics is a representation of the data. Though simulation data for representation might be decoupled.