Page MenuHomeWildfire Games

Refactors Capturable Farmstead feature/templates
ClosedPublic

Authored by wowgetoffyourcellphone on Aug 26 2023, 8:29 PM.
Tags
None
Referenced Files
F5257021: D5113.diff
Fri, Oct 4, 5:51 AM
Unknown Object (File)
Mon, Sep 23, 9:56 PM
Unknown Object (File)
Fri, Sep 20, 1:06 AM
Unknown Object (File)
Thu, Sep 19, 6:00 AM
Unknown Object (File)
Wed, Sep 18, 9:59 PM
Unknown Object (File)
Aug 22 2024, 10:05 PM
Subscribers
Restricted Owners Package

Details

Summary

Attempts to address Invalid warning messages for capturable farmsteads and creates a mixin as suggested by @Langbart

Renames the "farmsteads_" template files to "mill_" to eliminate confusion with standard buildable farmsteads and changes the refs in the skirmish maps to suit.

Genericizes the name to Rotary Mill instead of Farmstead, again to eliminate confusion between the two (the former is a capturable map object, while the latter is a player-buildable structure).

Fixes #6818

Test Plan
  1. Apply patch
  1. Open Miletus Peninsula (2) or Saharan Oases (4) and hover over & click on a nearby uncaptured Rotary Mill
  1. Hopefully there are no error messages, but if so, then suggest a fix
  1. See that the Rotary Mills work as advertised
  1. Suggest improvements if desired

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8319/display/redirect

Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8901/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7230/display/redirect

This doesn't affect balance or gameplay, but it would be nice for someone to apply the patch and at least see if everything works as advertised so I can commit it.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 11 2023, 2:08 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Sep 11 2023, 2:08 AM