Page MenuHomeWildfire Games
Differential D5121

Adds printing error names to Vulkan backend
ClosedPublic
Actions

Authored by vladislavbelov on Sep 7 2023, 7:30 PM.

Details

Reviewers
phosit
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP27839: Adds printing error names to Vulkan backend.
Summary

Subj.

Test Plan
  1. Apply the patch and compile the game

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Sep 7 2023, 7:30 PM
Vulcan added a comment.Sep 7 2023, 7:30 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7256/display/redirect

Vulcan added a comment.Sep 7 2023, 7:38 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8345/display/redirect

Harbormaster completed remote builds in B22297: Diff 22215.Sep 7 2023, 7:58 PM
vladislavbelov requested review of this revision.Sep 7 2023, 7:58 PM
phosit added a subscriber: phosit.EditedSep 9 2023, 5:13 PM

Can't you use string_VkResult from vk_enum_string_helper.h?

vladislavbelov added a comment.Sep 10 2023, 9:49 PM
In D5121#217764, @phosit wrote:

Can't you use string_VkResult from vk_enum_string_helper.h?

No, since vk_enum_string_helper.h isn't present in our distribution.

phosit accepted this revision.Sep 13 2023, 11:32 AM

I didn't check if it's complete (everywhere where an error-code is printed also the string is printed)

This revision is now accepted and ready to land.Sep 13 2023, 11:32 AM
This revision was landed with ongoing or failed builds.Sep 13 2023, 7:42 PM
Closed by commit rP27839: Adds printing error names to Vulkan backend. (authored by vladislavbelov). · Explain Why
This revision was automatically updated to reflect the committed changes.
vladislavbelov added a commit: rP27839: Adds printing error names to Vulkan backend..

Revision Contents
Changeset List

PathSize
ps/
trunk/
source/
renderer/
backend/
vulkan/
3 lines
11 lines
10 lines
6 lines
6 lines
4 lines
39 lines

Diff 22257

View Options

ps/trunk/source/renderer/backend/vulkan/Buffer.cpp

Loading...
View Options

ps/trunk/source/renderer/backend/vulkan/Device.cpp

Loading...
View Options

ps/trunk/source/renderer/backend/vulkan/ShaderProgram.cpp

Loading...
View Options

ps/trunk/source/renderer/backend/vulkan/SwapChain.cpp

Loading...
View Options

ps/trunk/source/renderer/backend/vulkan/Texture.cpp

Loading...
View Options

ps/trunk/source/renderer/backend/vulkan/Utilities.h

Loading...
View Options

ps/trunk/source/renderer/backend/vulkan/Utilities.cpp

Loading...
Wildfire Games · Phabricator