Combine visual and nonvisual path so that there is only one gameloop
ClosedPublic
Actions

Authored by phosit on Oct 12 2023, 10:03 PM.

Details

Reviewers

vladislavbelov

Commits

rP27906: Combine visual and nonvisual path so that there is only one gameloop

Summary

This does deduplicate the while loop and the StartRLInterface call.

There is still some duplication in Frame and NonVisualFrame they should be combined in future.

Test Plan

Run the game.
Run it with the rlclient.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

phosit created this revision.Oct 12 2023, 10:03 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7386/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8475/display/redirect

Harbormaster completed remote builds in B22466: Diff 22408.Oct 12 2023, 10:21 PM

phosit requested review of this revision.Oct 12 2023, 10:21 PM

phosit added a child revision: D5103: Make the RLInterface local.Oct 12 2023, 10:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 28 2023, 10:54 PM

This revision was landed with ongoing or failed builds.

Closed by commit rP27906: Combine visual and nonvisual path so that there is only one gameloop (authored by phosit). · Explain Why

This revision was automatically updated to reflect the committed changes.

phosit added a commit: rP27906: Combine visual and nonvisual path so that there is only one gameloop.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

main.cpp

36 lines

Diff 22475

View Options

Combine visual and nonvisual path so that there is only one gameloopClosedPublicActions