Differential D5164

[Gameplay] Skirmish Map | Isthmus of Corinth (2 players)
ClosedPublic
Actions

Authored by wowgetoffyourcellphone on Oct 15 2023, 1:57 AM.

Details

Reviewers

real_tabasco_sauce

Group Reviewers

Balancing

Commits

rP27899: [Gameplay] Skirmish Map | Isthmus of Corinth (2 players)

Summary

This map is lovingly crafted to showcase as many of the game's features as possible. I was originally going to replace the existing Corinthian Isthmus map, but I know some people like that one so I made a separate map instead.

Test Plan

Patch
Play a skirmish match
Like or hate the map
Give requests or suggest improvements

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wowgetoffyourcellphone created this revision.Oct 15 2023, 1:57 AM

Herald added a reviewer: Balancing. · View Herald TranscriptOct 15 2023, 1:57 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7394/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8483/display/redirect

Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/9065/display/redirect

Harbormaster completed remote builds in B22477: Diff 22419.Oct 15 2023, 2:21 AM

wowgetoffyourcellphone requested review of this revision.Oct 15 2023, 2:21 AM

My only concern would be whether or not to replace the existing isthmus map, but it would be easy to make that later.

This revision is now accepted and ready to land.Oct 24 2023, 7:41 AM

In D5164#219797, @real_tabasco_sauce wrote:

My only concern would be whether or not to replace the existing isthmus map, but it would be easy to make that later.

I don't think people would care. The proposed map seems like it would play exactly the same as the old isthmus map except for maybe more features. There is also the H map, which already plays exactly the same as isthmus.

In D5164#219801, @chrstgtr wrote:

In D5164#219797, @real_tabasco_sauce wrote:

My only concern would be whether or not to replace the existing isthmus map, but it would be easy to make that later.

I don't think people would care. The proposed map seems like it would play exactly the same as the old isthmus map except for maybe more features. There is also the H map, which already plays exactly the same as isthmus.