If there are less AINames in a civilization's simulation data json file than the maximum number of players in a 0ad match, then AI-controlled player names will potentially be duplicated if all of the players have that civilization.
- Add a verification to source/tools/entity/checkrefs.py to check whether there are enough AINames in each civ's json data to prevent duplication of names in a match.
- Add a constant at the beginning of checkrefs.py, MAX_NUM_PLAYERS, the maximum number of players that can be in a 0ad match
- Add a check that there is at least one civilization defined
- Add a command line switch that controls whether checks of civilization data will be done
- Change the command line arguments in the call to checkrefs.py in docker-differential.Jenkinsfile in order to enable checks of civilization data
The current hardcoded assumption is that there is a maximum of 8 players in a 0ad match.