Page MenuHomeWildfire Games

Norse_Harold
User

Projects

User Details

User Since
Aug 7 2022, 9:14 PM (88 w, 7 h)

Recent Activity

Sep 15 2023

Norse_Harold added a comment to rP9140: # Add idle worker button, based on patch from veprbl..

The email is known and will never be fixed unless changes start…

Sep 15 2023, 6:47 PM
Norse_Harold added a comment to D5062: Replaces statically cached hCurrentThread by lazy initialized thread_local variable..

Well I believe I know why you guys don’t get something’s and funny when you broke in for the direct root and I believe I could screw you over…

Sep 15 2023, 6:46 PM

Jul 8 2023

Norse_Harold updated the summary of D4987: Access Control Lists (ACLs) for hosted games.
Jul 8 2023, 2:35 AM
Norse_Harold updated the diff for D4987: Access Control Lists (ACLs) for hosted games.
  • Correct logic for showing ACL checkbox
  • Adjust comments in IsUsernameAllowedByACLs()
Jul 8 2023, 2:35 AM
Norse_Harold updated the summary of D4987: Access Control Lists (ACLs) for hosted games.
Jul 8 2023, 2:22 AM
Norse_Harold updated the diff for D4987: Access Control Lists (ACLs) for hosted games.
  • Initial version of ACLs diff
Jul 8 2023, 2:19 AM
Norse_Harold retitled D4987: Access Control Lists (ACLs) for hosted games from Allow-list for lobby games to Access Control Lists (ACLs) for hosted games.
Jul 8 2023, 2:16 AM

Jun 7 2023

Norse_Harold added a comment to D5039: Allow changing lobby password inside 0 A.D..

@Dunedan This patch seems to be a defanged debugging version designed for testing. The key call to Engine.LobbyChangePassword(newPass) is commented out on line 122 of AccountSettingsPage.js. If you didn't uncomment that line then that would explain why the result is always request timed out.

Jun 7 2023, 6:42 PM

May 25 2023

Norse_Harold planned changes to D4987: Access Control Lists (ACLs) for hosted games.
May 25 2023, 4:34 PM
Norse_Harold added a comment to D4987: Access Control Lists (ACLs) for hosted games.

Thanks for the comments, and thanks for adding Itms as reviewer. However, please don't review the current version. I decided to add and change some features. I have the core functionality ready, I'll update the diff with it soon. The user interface can be implemented after the core functionality is not expected to change.

May 25 2023, 8:16 AM
Norse_Harold removed a reviewer for D4987: Access Control Lists (ACLs) for hosted games: Itms.
May 25 2023, 8:13 AM

May 15 2023

Norse_Harold added a comment to D4996: Disable all logging of network messages in release mode.

Regarding GDPR regulations, the data isn't personal unless it can be connected back to a real European or UK person by way of other data reasonably available to the data controller. And, the GDPR isn't applicable unless additional lines are crossed by the data controller. Those lines are automated processing of data or storing the data in a structured format (think database records with distinctly labeled columns), and processing the data for other-than personal or household purposes. This is explained in the first few paragraphs of the GDPR, Article 1, which starts on page 32 of the linked PDF. It's easy to verify.

May 15 2023, 9:15 PM

May 6 2023

Norse_Harold added inline comments to D4770: Multiplayer saved games.
May 6 2023, 9:14 PM

May 1 2023

Norse_Harold requested review of D4987: Access Control Lists (ACLs) for hosted games.
May 1 2023, 12:19 AM

Mar 15 2023

Norse_Harold added a comment to D4967: Lower enet packet fragment max size to support certain VPN.

sera wrote:

Given that it was merged

Mar 15 2023, 11:12 PM
Norse_Harold added a comment to D4967: Lower enet packet fragment max size to support certain VPN.

How about network.enet_mtu. That way, in case ENet corrects the definition of the mtu variable then 0ad's config variable will still be correct.

Mar 15 2023, 10:40 PM
Norse_Harold added a comment to D4967: Lower enet packet fragment max size to support certain VPN.

sera wrote:

Given that it was merged we can consider adding config support, just that it won't really work until server upgrades enet to HEAD. So offering [config support in 0ad for overriding the mtu] might result in user expectation that can't be fulfilled.

Mar 15 2023, 10:34 PM
Norse_Harold added a comment to D4967: Lower enet packet fragment max size to support certain VPN.

phosit and I tested this patch today in multiplayer via the lobby, and it works as expected. I hosted, and phosit connected as a client. Our MTU was 1372 bytes in every view of network statistics (server and client). We did some stress tests with cheats enabled in order to produce large packets. The maximum packet size seen was 1372 data bytes (1400 bytes on wire). There were 21 such packets sent by phosit, and 180 such packets sent by me. None of the packets were fragmented, despite the fact that I was using a Wireguard VPN. Note that phosit was not using a VPN.

Mar 15 2023, 10:01 PM

Mar 13 2023

Norse_Harold added inline comments to D4967: Lower enet packet fragment max size to support certain VPN.
Mar 13 2023, 6:48 PM
Norse_Harold added a comment to D4967: Lower enet packet fragment max size to support certain VPN.

I recommend testing this before merging it, to verify that it accomplishes solving the actual problem. I'll be available to help with testing via Wireguard VPN tomorrow evening (western hemisphere time zone).

Mar 13 2023, 6:46 PM

Mar 10 2023

Norse_Harold added a comment to D4967: Lower enet packet fragment max size to support certain VPN.

Thanks for working on this.

Mar 10 2023, 10:54 PM

Feb 17 2023

Norse_Harold updated the diff for D4871: Moderation system improvements - mute, helper and allowlist only.
  • rebase on svn master (r27552)
  • add mute of map flares from muted users. Muted users still see their own flares, but the server doesn't broadcast them to the other clients.
Feb 17 2023, 10:55 PM

Feb 13 2023

Norse_Harold added a comment to D4871: Moderation system improvements - mute, helper and allowlist only.
In D4871#210649, @Itms wrote:

(do you mean that) all the logic should be encapsulated in the (JavaScript) client(?)"

No, I am talking about the NetClient class in the engine.
Generally speaking I think all the moderation logic should be in the engine, and the GUI would only be responsible for understanding what the user wants to do, and ask the engine to do it.

Feb 13 2023, 6:59 PM
Norse_Harold added a comment to D4871: Moderation system improvements - mute, helper and allowlist only.

Itms, thank you very much for taking the time to read through the patch. I agree that the patch needs to be improved. It was written hastily in order to try to meet the feature freeze deadline. I'll reply to each of the bullet points in your comments.

Feb 13 2023, 5:56 AM

Jan 28 2023

Norse_Harold added a comment to D4871: Moderation system improvements - mute, helper and allowlist only.

I'm pasting here the feedback from trompetin17. Please specify what is a required change for merge (aka mandatory) and what is not a required change for merge (aka wishlist).

Jan 28 2023, 8:26 PM
Norse_Harold updated the diff for D4871: Moderation system improvements - mute, helper and allowlist only.
  • rebase on svn master (r27498)
Jan 28 2023, 8:13 PM

Jan 12 2023

Norse_Harold requested review of D4885: Fix /clear command in gamesetup.
Jan 12 2023, 11:21 PM
Norse_Harold updated the diff for D4871: Moderation system improvements - mute, helper and allowlist only.
  • add missing files NetModerationLUT.h and binaries/data/mods/public/gui/common/moderation/*
Jan 12 2023, 12:11 AM

Jan 11 2023

Norse_Harold updated the diff for D4871: Moderation system improvements - mute, helper and allowlist only.
  • rebase on svn master
  • change name of top-level define in NetModerationLUT.h
  • alphabetize order of include paths for us OCD types
  • correct path of include NetMessage.h in NetServer.h
  • adjust comments in ModerationLUT.js to refer to enums instead of enum classes
Jan 11 2023, 11:43 PM
Norse_Harold updated the diff for D4871: Moderation system improvements - mute, helper and allowlist only.
  • Rename NetModerationTables.h to NetModerationLUT.h
  • Rename LookupTables.js to ModerationLUT.js
  • Fix bugs in moderation response list output
  • Fix linter warnings
  • Minor style and code beautification improvements recommended by Stan, phosit and Elexis
Jan 11 2023, 12:55 AM
Norse_Harold added a comment to D4871: Moderation system improvements - mute, helper and allowlist only.

Would naming the moderation table files
ModerationEnums.js
and
NetModerationEnums.h
be acceptable?

Jan 11 2023, 12:09 AM

Jan 10 2023

Norse_Harold added a comment to D4871: Moderation system improvements - mute, helper and allowlist only.

sera said, "The names NetModerationTables and LookupTable are supposed to match and I don't like either name in particular. NetModeration.h feels better to me."

Jan 10 2023, 10:30 PM
Norse_Harold updated the diff for D4871: Moderation system improvements - mute, helper and allowlist only.
  • Use writeable aliases to CModerationMessages instead of pointers, because S_m_Identifiers is not a singleton, it's a struct.
  • add more validation checks in JS/C++ binding interface for CModerationMessages
  • minor style and code beautification improvements recommended by Stan, phosit and Elexis
  • fix linter warnings
Jan 10 2023, 8:33 PM
Norse_Harold added a comment to D4871: Moderation system improvements - mute, helper and allowlist only.

Items marked done are completed in the following updated diff.

Jan 10 2023, 8:32 PM
Norse_Harold updated the diff for D4871: Moderation system improvements - mute, helper and allowlist only.
  • translate help text
  • use accumulate instead of transform_reduce
  • fix bug in /clear command in gamesetup (clear this.chatText.list)
  • remove message in executeNetworkCommand() that "a command was found after a chat command. It was passed to the chat handler."
  • minor style and code beautification improvements as suggested by Stan, phosit and Elexis
Jan 10 2023, 7:22 AM
Norse_Harold added a comment to D4871: Moderation system improvements - mute, helper and allowlist only.

Items marked done are done in the following updated diff.

Jan 10 2023, 7:18 AM

Jan 9 2023

Norse_Harold requested review of D4871: Moderation system improvements - mute, helper and allowlist only.
Jan 9 2023, 8:13 AM
Norse_Harold removed reviewers for D4851: Moderation system improvements: trompetin17, Restricted Owners Package.
Jan 9 2023, 7:25 AM

Jan 8 2023

Norse_Harold updated the diff for D4851: Moderation system improvements.
  • Make decodeModerationResponse object oriented. Each translated format string is a static property of the class prototype, so that the strings only have to be translated once.
  • Use enum instead of enum class for moderation tables, in order to conform to the existing design for NetMessage handling
  • Use getaddrinfo() instead of inet_addr() in StunClient::u32ip_from_wstring()
  • Adjust the #ifdef in StunClient.cpp so that more OSes are included, such as Android, for including headers for getaddrinfo()
  • Use ENET_HOST_ANY instead of INADDR_ANY or INADDR_NONE in NetServer.cpp and NetClient.cpp
  • Revert some of the changes to source/lib/external_libraries/enet.h
  • Use const for interactive in KickUser()
  • Fix some lint errors like whitespace at the ends of lines, consistent return
  • Make minor adjustments to coding style, based on feedback from Stan, phosit and Elexis
  • Fix a bug where moderation helpers could hide the results of successful moderation commands from the controller if they sent moderation requests with response type set to silent
  • Add more guards in case session is null to avoid using session
  • Change wstring_from_u32ip() and u32ip_from_wstring() to work with utf8 strings instead of wide strings
  • Remove functions RemoveIPFromList() and RemoveUsernameFromList()
  • Move checks whether additions to moderation list could affect the controller or host to the end of UpdateModerationList()
Jan 8 2023, 1:19 AM

Jan 7 2023

Norse_Harold added a comment to D4851: Moderation system improvements.

These items are taken care of in the following diff update.

Jan 7 2023, 11:34 PM

Jan 4 2023

Norse_Harold added a comment to D4851: Moderation system improvements.

I've made more adjustments based on the feedback. I'll accumulate more changes before updating the diff, since it disrupts the line numbering of the comments.

Jan 4 2023, 4:59 AM

Jan 3 2023

Norse_Harold added a comment to D4847: Chat Profanity Filter - WIP.

Thanks for putting development effort into addressing the problems with verbal abuse in the lobby and in games.

Jan 3 2023, 10:47 PM
Norse_Harold added inline comments to D4851: Moderation system improvements.
Jan 3 2023, 9:14 AM
Norse_Harold updated the diff for D4851: Moderation system improvements.
  • Use object oriented moderation response decoding for info and announcements
  • Use enum class instead of enum for moderation tables
  • Use constexpr u8 instead of #define for moderation memory and network limits
  • Use constexpr instead of hardcoded values for number of elements in array of moderation identifiers
  • Remove ternary involving fullPrivileges and rename the variable to userPrivilegeLevel
  • Remove unnecessary \ line continuations and whitespace before continued lines
  • Change name of ModerationResponseCode::COMMAND to UNUSED, and use value of 0 (in C++ and JS)
  • Reduce redundant code at return from JS makeStringsFromIdentifiersHash() and at "moderationresponse" message dispatch
  • Correct bug in JS kickPlayer() to call moderation() with the correct arguments
  • Rename parse_moderation_commands.js to send_moderation_command.js
  • Rename process_moderation_response.js to receive_moderation_response.js
  • Correct copyright year. Happy new year!
Jan 3 2023, 7:41 AM
Norse_Harold added a comment to D4851: Moderation system improvements.

Thanks for the feedback Stan. This was quite helpful.

Jan 3 2023, 7:38 AM
Norse_Harold updated the diff for D4851: Moderation system improvements.
  • Changed the file name of the moderation response decoding script to ensure that it is processed by the interpreter after moderation_tables.js
  • Made some of the moderation response decoding system object oriented
Jan 3 2023, 1:13 AM

Jan 2 2023

Norse_Harold removed projects from D4851: Moderation system improvements: Restricted Project, Contributors.
Jan 2 2023, 5:15 PM
Norse_Harold updated the diff for D4851: Moderation system improvements.

Made the command line interface simpler by removing parsing of --identifiertype, --effecttype, and --responsetype switches.

Jan 2 2023, 6:49 AM

Dec 31 2022

Norse_Harold updated the diff for D4851: Moderation system improvements.
  • Added source/network/NetModerationTables.h
  • Added binaries/data/mods/public/gui/common/moderation/parse_moderation_commands.js
  • Added binaries/data/mods/public/gui/common/moderation/decode_moderation_response.js
  • Added binaries/data/mods/public/gui/common/moderation/moderation_tables.js
Dec 31 2022, 10:15 PM
Norse_Harold requested review of D4851: Moderation system improvements.
Dec 31 2022, 9:56 PM

Aug 8 2022

Norse_Harold updated Norse_Harold.
Aug 8 2022, 7:14 PM