Increase civ selection dropdown size so that the scrollbar disappears
ClosedPublic
Actions

Authored by elexis on May 20 2017, 8:23 PM.

Details

Reviewers

Commits

rP19618: Increase size of the civ selection dropdowns so that the scrollbar disappears.

Summary

As reported by @temple in the forums, the size of the civ selection dropdown list can be increased, so that all items are seen without the need to scroll.

Test Plan

The 350px size works for these elements since they are all in the first 400px of the page (thus are compatible with 1024x768).
Notice we can't add it to the ModernDropDown style, because it wouldn't suit many dropdowns in the lower half of the screen.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.May 20 2017, 8:23 PM

elexis edited the summary of this revision. (Show Details)May 20 2017, 8:25 PM

Also increase playerselection in observermode

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1273/ for more details.

Harbormaster completed remote builds in B1828: Diff 2055.May 20 2017, 11:31 PM

It looks good to me. I would've liked the player menu to be wider too, but I understand in the 1024 x 768 mode there's no horizontal space left for that. So this is fine, thanks.

This revision is now accepted and ready to land.May 20 2017, 11:55 PM

In D527#21280, @temple wrote:

It looks good to me. I would've liked the player menu to be wider too, but I understand in the 1024 x 768 mode there's no horizontal space left for that. So this is fine, thanks.

That should still be done, but in a separate patch, needs more thinking (and most likely a screensize dependent solution, relative width, additional testing)

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1274/ for more details.

Harbormaster completed remote builds in B1829: Diff 2056.May 21 2017, 12:18 AM

Closed by commit rP19618: Increase size of the civ selection dropdowns so that the scrollbar disappears. (authored by elexis). · Explain WhyMay 21 2017, 12:19 AM

This revision was automatically updated to reflect the committed changes.

Lionkanzen awarded a token.May 21 2017, 7:23 AM

Lionkanzen rescinded a token.

Lionkanzen awarded a token.

Lionkanzen rescinded a token.

Lionkanzen awarded a token.

Lionkanzen rescinded a token.

Lionkanzen awarded a token.

Lionkanzen updated a token.