Page MenuHomeWildfire Games
Differential D553

Intendation fix singleDetailsSelection
ClosedPublic
Actions

Authored by Imarok on May 26 2017, 12:04 AM.

Details

Reviewers
elexis
Commits
rP19656: Intendation fix singleDetailsSelection
Summary

. (see D516)

Test Plan

.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
https://svn.wildfiregames.com/public/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1962
Build 3138: Vulcan Build (Windows)Jenkins
Build 3137: Vulcan BuildJenkins
Build 3136: arc lint + arc unit

Event Timeline

Imarok created this revision.May 26 2017, 12:04 AM
Imarok added a child revision: D516: Allow to show capture, resource and health bar.May 26 2017, 12:05 AM
Imarok updated this revision to Diff 2197.May 26 2017, 12:07 AM

Remove testing hidden true

Harbormaster completed remote builds in B1961: Diff 2197.May 26 2017, 12:07 AM
Imarok updated this revision to Diff 2198.May 26 2017, 12:17 AM

Fix L63 indentation.

Harbormaster completed remote builds in B1962: Diff 2198.May 26 2017, 12:17 AM
Imarok updated this revision to Diff 2199.May 26 2017, 12:19 AM

Fix indentation of untouched file part

elexis accepted this revision.May 26 2017, 12:22 AM

Thanks for splitting that, we found these 3 little indentation issues that way and now phabricator shows that its solely an indentation change.

This revision is now accepted and ready to land.May 26 2017, 12:22 AM
Closed by commit rP19656: Intendation fix singleDetailsSelection (authored by Imarok). · Explain WhyMay 26 2017, 12:24 AM
This revision was automatically updated to reflect the committed changes.
Vulcan added a subscriber: Vulcan.May 26 2017, 2:14 AM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1357/
See console output for more information: http://jw:8080/job/phabricator/1357/console

Harbormaster failed remote builds in B1960: Diff 2196!May 26 2017, 2:15 AM
Vulcan added a comment.May 26 2017, 2:15 AM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1358/
See console output for more information: http://jw:8080/job/phabricator/1358/console

Harbormaster failed remote builds in B1961: Diff 2197!May 26 2017, 2:15 AM
Vulcan added a comment.May 26 2017, 2:16 AM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1359/
See console output for more information: http://jw:8080/job/phabricator/1359/console

Harbormaster failed remote builds in B1962: Diff 2198!May 26 2017, 2:16 AM
Vulcan added a comment.May 26 2017, 2:16 AM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1360/
See console output for more information: http://jw:8080/job/phabricator/1360/console

Harbormaster failed remote builds in B1963: Diff 2199!May 26 2017, 2:16 AM

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
gui/
session/
selection_panels_middle/
142 lines

Diff 2198

View Options

binaries/data/mods/public/gui/session/selection_panels_middle/single_details_area.xml

Loading...
Wildfire Games · Phabricator