fix units not removed from formation when switching to the null formation
+ fix the display of formation icon when only one entity selected
Details
Details
test the problem reported in #4599 by using the commands.txt uploaded there
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Executing section Default...
Executing section Source...
Executing section JS...
binaries/data/mods/public/simulation/helpers/Commands.js
| 881| » var·ids·=·[·id·for·(id·in·members)·];
| | [MAJOR] ESLintBear:
| | Parsing error: Unexpected token for
binaries/data/mods/public/simulation/helpers/Commands.js
| 53| var·g_Commands·=·{
| | [NORMAL] JSHintBear:
| | 'g_Commands' was used before it was defined.
binaries/data/mods/public/simulation/helpers/Commands.js
| 178| » » let·allowCapture·=·cmd.allowCapture·||·cmd.allowCapture·==·null;
| | [NORMAL] JSHintBear:
| | Use '===' to compare with 'null'.
binaries/data/mods/public/simulation/helpers/Commands.js
| 498| » » if·(notUngarrisoned·!=·0)
| | [NORMAL] JSHintBear:
| | Use '!==' to compare with '0'.
binaries/data/mods/public/simulation/helpers/Commands.js
| 512| » » » » ····&&·player·!=·+cmd.owner)
| | [NORMAL] JSHintBear:
| | Misleading line break before '&&'; readers may interpret this as an expression boundary.
binaries/data/mods/public/simulation/helpers/Commands.js
| 700| » » » » var·cmpGUIInterface·=·Engine.QueryInterface(SYSTEM_ENTITY,·IID_GuiInterface);
| | [NORMAL] JSHintBear:
| | 'cmpGUIInterface' is already defined.
binaries/data/mods/public/simulation/helpers/Commands.js
| 881| » var·ids·=·[·id·for·(id·in·members)·];
| | [NORMAL] JSHintBear:
| | 'array comprehension' is only available in Mozilla JavaScript extensions (use moz option).
binaries/data/mods/public/simulation/helpers/Commands.js
| 881| » var·ids·=·[·id·for·(id·in·members)·];
| | [NORMAL] JSHintBear:
| | Expected 'for' and instead saw 'id'.
binaries/data/mods/public/simulation/helpers/Commands.js
| 931| » » for·(var·i·=·0;·i·<·length;·++i)
| | [NORMAL] JSHintBear:
| | 'i' is already defined.
binaries/data/mods/public/simulation/helpers/Commands.js
| 944| » » var·count·=·0;
| | [NORMAL] JSHintBear:
| | 'count' is already defined.
binaries/data/mods/public/simulation/helpers/Commands.js
|1091| » » var·cmpGuiInterface·=·Engine.QueryInterface(SYSTEM_ENTITY,·IID_GuiInterface);
| | [NORMAL] JSHintBear:
| | 'cmpGuiInterface' is already defined.
binaries/data/mods/public/simulation/helpers/Commands.js
|1255| » » » if·(!(i·==·0·&&·piece.template·==·cmd.wallSet.templates.tower·&&·!cmd.startSnappedEntity))
| | [NORMAL] JSHintBear:
| | Use '===' to compare with '0'.
binaries/data/mods/public/simulation/helpers/Commands.js
|1343| » » var·piece·=·pieces[j];
| | [NORMAL] JSHintBear:
| | 'piece' is already defined.
binaries/data/mods/public/simulation/helpers/Commands.js
|1372| » » » » if·(lastTowerControlGroup·!=·null·&&·lastTowerControlGroup·!=·INVALID_ENTITY)
| | [NORMAL] JSHintBear:
| | Use '!==' to compare with 'null'.
binaries/data/mods/public/simulation/helpers/Commands.js
|1427| » » var·cmpUnitAI·=·Engine.QueryInterface(ent,·IID_UnitAI);
| | [NORMAL] JSHintBear:
| | 'cmpUnitAI' is already defined.
binaries/data/mods/public/simulation/helpers/Commands.js
|1450| » if·(formedEnts.length·==·0)
| | [NORMAL] JSHintBear:
| | Use '===' to compare with '0'.
binaries/data/mods/public/simulation/helpers/Commands.js
|1467| » » » &&·cmpFormation.GetMemberCount()·==·formation.entities.length)
| | [NORMAL] JSHintBear:
| | Misleading line break before '&&'; readers may interpret this as an expression boundary.
binaries/data/mods/public/simulation/helpers/Commands.js
|1482| » » for·(var·fid·in·formation.members)
| | [NORMAL] JSHintBear:
| | 'fid' is already defined.
binaries/data/mods/public/simulation/helpers/Commands.js
|1484| » » » var·cmpFormation·=·Engine.QueryInterface(+fid,·IID_Formation);
| | [NORMAL] JSHintBear:
| | 'cmpFormation' is already defined.
binaries/data/mods/public/simulation/helpers/Commands.js
|1501| » » » » » var·cmpUnitAI·=·Engine.QueryInterface(ent,·IID_UnitAI);
| | [NORMAL] JSHintBear:
| | 'cmpUnitAI' is already defined.
binaries/data/mods/public/simulation/helpers/Commands.js
|1524| » » » var·cmpFormation·=·Engine.QueryInterface(formationEnt,·IID_Formation);
| | [NORMAL] JSHintBear:
| | 'cmpFormation' is already defined.
Executing section XML GUI...
Executing section Python...
Executing section Perl...http://jw:8080/job/phabricator_lint/89/ for more details.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1423/ for more details.