Remove useless file entry in replays list
ClosedPublic
Actions

Authored by Imarok on Jun 21 2017, 5:23 PM.

Details

Reviewers

elexis

Commits

rP19814: Remove useless file entry in replays list

Summary

With D495 we have a dedicated script function for gettting the replay path, so we don't need to save it in the replays list nor in the replay cache.

Test Plan

open the delete dialog

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Imarok created this revision.Jun 21 2017, 5:23 PM

The "file" property was added by rP17054, which wasn't problematic since there wasn't a replay cache yet.
Using the engine function isn't problematic since it's only called upon selection and upon opening the delete dialog.
Tested and after deleting the replayCache.json, there are only relative directory entries remaining, just as it should.

This revision is now accepted and ready to land.Jun 21 2017, 5:39 PM

Closed by commit rP19814: Remove useless file entry in replays list (authored by Imarok). · Explain WhyJun 21 2017, 5:44 PM

This revision was automatically updated to reflect the committed changes.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1601/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/221/ for more details.

Harbormaster completed remote builds in B2365: Diff 2645.Jun 21 2017, 6:54 PM