There has been a typo in rP19721 noticed causing unknown_land to crash on certain seeds.
Details
Details
- Reviewers
elexis - Commits
- rP19905: Fix a typo in rP19721.
- Trac Tickets
- #4673
Dig up the old commit and see that this line is wrongly changed, notice that with this change the behaviour is correct again.
Notice this typo hasn't been made on the other unknown* maps. There the same lines has been made correct in the original commit.
refs D596
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Thanks for the digging, patch and correctness test.
It's also complete as I checked that every randInt call in the random maps directory has two arguments.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1732/ for more details.