Also some small cleanup.
Details
Details
- Reviewers
elexis - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Owners Package (Owns No Changed Paths) - Commits
- rP19936: Stop copying the territory grid when recomputing the texture.
Check that we use a ref now.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1738/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/311/ for more details.
Comment Actions
Ack if territories is inlined.
The size ctor was introduced in C++11 which is our currently minimum requirement according to https://trac.wildfiregames.com/wiki/CppSupport
http://en.cppreference.com/w/cpp/container/vector/vector
Comment Actions
Actually I do somewhat like that this shows what the issue fixed is, as opposed to inlining it.
Comment Actions
Don't see what we need that variable for when the commit message contains that information. The important part is fixing the wasteful copy either way.