Page MenuHomeWildfire Games

typo in LongPathfinder
ClosedPublic

Authored by mimo on Aug 29 2017, 8:04 PM.

Details

Summary

There is a typo in LongPathfinder.cpp i spotted by chance while looking at something else, so i don't know if we ever go in that path, or if useless (and i didn't try to understand the code).

Test Plan

check that is indeed a typo :)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mimo created this revision.Aug 29 2017, 8:04 PM
Owners added a subscriber: Restricted Owners Package.Aug 29 2017, 8:04 PM
Vulcan added a subscriber: Vulcan.Aug 29 2017, 8:51 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/1931/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jenkins-master:8080/job/phabricator_lint/449/ for more details.

fatherbushido accepted this revision.EditedAug 30 2017, 12:10 PM
fatherbushido added a subscriber: fatherbushido.
  • sounds a typo when looking quickly
  • it's a typo when looking deeper
This revision is now accepted and ready to land.Aug 30 2017, 12:10 PM

(To ensure I really read: In the case we 'move' vertically, we must be in the goal bounding box 'vertical band' which is defined by goal.x - hw <= x < goal.x + hw)
Compilation is ok and nothing bad notice in game.

This revision was automatically updated to reflect the committed changes.