Those are the random maps supporting random and selected by player biomes missing from the D852.
Details
Details
Select one of those maps and check in the game setup if the biomes dropdown is enabled and if the randomized biomes are correct.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Comment Actions
Thanks, that iteration (the one before the most recent one) is about complete, besides the few issues we have uncovered while reviewing.
I'd rather fix those separately.
- Each random map that has a call to randomizeBiome was touched. That function is now unused, but still well usable.
- Each random map that that had a variable saving the selected biome had that replaced with a call to the getter.
- Tested that every currentBiome() is compared with a global.
- Confirmed that there is exactly 1 JSON file changed for each JS file
- Every JSON file adds "true" which meets my expectation to have addressed all special cases in the first commit.
- Scrolled through all random maps to ensure that there isn't any character sequence claiming to be JSON
The patch is correct too.
Fixing those "\ No newline at end of file" while at it.
There are many maps querying g_MapInfo.biome and harbor is messed up: if (g_MapInfo.biome == 2).
That's something to fix separately, as that variable must be removed altogether.
| binaries/data/mods/public/maps/random/canyon.js | ||
|---|---|---|
| 3 | deleting this comment. there are thousands of such comments in the entire rmgen code, I'll carelessly delete them, because that patch in my github branch doing that is just rotting since months. | |
| binaries/data/mods/public/maps/random/island_stronghold.js | ||
| 531 | Thanks for fixing this thing we both didnt notice in the last commit. 7 was indeed g_BiomeTropic. | |
| binaries/data/mods/public/maps/random/unknown_land.js | ||
| 1591 | Oh another missed one :/ | |
| binaries/data/mods/public/maps/random/unknown_nomad.js | ||
| 1410 | here too? ffs | |
| binaries/data/mods/public/maps/random/wild_lake.js | ||
| 18 | thanks for the missing semicolon! L350 has another one according to jshint.com | |
| binaries/data/mods/public/maps/random/wild_lake.json | ||
| 11 | If we ever want a fixed order, we could go for an alphabetic one. I do why this CircularMap is different from the other ones, still | |