Details

Reviewers

• leper

Commits

rP20190: Fix some format specifiers in debug strings. Reviewed by leper.

Summary

just a detail

Test Plan

compile

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fatherbushido created this revision.Sep 15 2017, 11:17 AM

year

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2028/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jenkins-master:8080/job/phabricator_lint/520/ for more details.

Harbormaster completed remote builds in B3173: Diff 3666.Sep 15 2017, 12:09 PM

Should be %zu, as that is size_t and not unsigned long. (I'd also do that for the LOGERROR call, since cppformat supports that (we should really update that thing too...).)

This revision now requires changes to proceed.Sep 15 2017, 12:13 PM

update

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2029/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jenkins-master:8080/job/phabricator_lint/521/ for more details.

Harbormaster completed remote builds in B3174: Diff 3667.Sep 15 2017, 12:57 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2030/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jenkins-master:8080/job/phabricator_lint/522/ for more details.

Harbormaster completed remote builds in B3175: Diff 3668.Sep 15 2017, 1:47 PM

• leper accepted this revision.Sep 15 2017, 2:32 PM

• leper added inline comments.

source/renderer/VertexBufferManager.cpp
93 ↗	(On Diff #3668)	Would be nice if you'd do that here too, and remove the casts so it stays correct.

This revision is now accepted and ready to land.Sep 15 2017, 2:32 PM

update

thx for the tutorial ;-)

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2031/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jenkins-master:8080/job/phabricator_lint/523/ for more details.

Harbormaster completed remote builds in B3176: Diff 3669.Sep 15 2017, 4:51 PM

Closed by commit rP20190: Fix some format specifiers in debug strings. Reviewed by leper. (authored by fatherbushido). · Explain WhySep 16 2017, 5:28 PM

This revision was automatically updated to reflect the committed changes.