Details
- Agree or disagree with that schema.
- Tests already done, but you can check again:
- launching unit scenario demo map
- in game test
- attached paste are the(inherited) templates before and after .
(only parents are different in the full parsed templates as shown with a by word diff like git diff --color-words old.txt new.txt)
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jenkins-master:8080/job/phabricator/2059/ for more details.
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jenkins-master:8080/job/phabricator_lint/541/ for more details.
That (inheriting the packed from the unpacked template) is a good idea to get rid of the parent templates without copying anything to the child templates. Agree!
git diff --color-words old.txt new.txt
Guess you'd have to post the output of that or link the branch. (Using git is a very good idea when working on multiple patches depending on each other)
Couldn't really notice the difference in the files.
Tested some units on the scenario demo map and it seems to be working fine.
Accepting assuming that you edited responsibly and tested more carefully than me.
Thanks for the patch.