Differential D94
Material Requirements Cleanup Authored by Stan on Jan 24 2017, 9:55 PM.
Details
If you use the material basic_trans_spec, it will require you to add a normTex, which the name does not imply. Solution : Do not load the norm texture. Only files using it are: art/actors/units/celts/wolfhound.xml: <material>basic_trans_spec.xml</material> Which doesn't have a norm texture Not sure. It should have sent a warning, but for some reason it doesn't, maybe I need to clear the cache.
Diff Detail
Event TimelineComment Actions I think there're few materials with useless requires, but also there're places when material is used and its params are passed, but the name of the material doesn't contain this param, so it should be checked too. Comment Actions @vladislavbelov could you review this ? Making sure everything now requires the right textures because D1016 returns too much false positives for me to fix. I also need to investigate why particles appear in your script and if they use incorrect materials as well. Comment Actions Successful build - Chance fights ever on the side of the prudent. Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files... /public/art/materials/player_trans_ao_parallax.xml:0: Relax-NG validity error : Element material has extra content: text This comment was removed by Stan. Comment Actions Changes are valid (only cleaning and renaming). The xml validator still have warnings/errors, because it doesn't count a parent actor. So we'll probably need another cleaning, but after the validator fix. Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/differential/55/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/differential/59/display/redirect |