Event Timeline
Comment Actions
https://github.com/0ad/0ad/blob/master/source/lobby/XmppClient.cpp
Offending code ?
IXmppClient* IXmppClient::create(const ScriptInterface* scriptInterface, const std::string& sUsername, const std::string& sPassword, const std::string& sRoom, const std::string& sNick, const int historyRequestSize,bool regOpt) { return new XmppClient(scriptInterface, sUsername, sPassword, sRoom, sNick, historyRequestSize, regOpt); }
Comment Actions
Affected JS_CallFunctionValue in IGUIObject::ScriptEvent:
JS::AutoValueVector paramData(cx); paramData.append(mouse); JS::RootedObject obj(cx, GetJSObject()); JS::RootedValue handlerVal(cx, JS::ObjectValue(*it->second)); JS::RootedValue result(cx, JS::UndefinedValue()); if (!JS_CallFunctionValue(cx, obj, handlerVal, paramData, &result)) { // We have no way to propagate the script exception, so just ignore it // and hope the caller checks JS_IsExceptionPending }
Comment Actions
After commenting out the create XmppClient call, the conditional jump warning is gone.
So it seems IGUIObject itself is innocent.
Comment Actions
Nope, that still doesn't fix the conditional jump.
Same as in D2223, that error message occurs only with clang but not gcc.
The valgrind track-origin option was already enabled, so I don't know what it wants.