Details
Details
- Reviewers
Nescio - Commits
- rP24003: Sort nodes in templates and data.
Review changes, run checkrefs.pl.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 13005 Build 25653: Vulcan Build Jenkins Build 25652: Vulcan Build (macOS) Jenkins Build 25651: Vulcan Build (Windows) Jenkins Build 25650: arc lint + arc unit
Event Timeline
binaries/data/mods/public/simulation/data/auras/structures/wall_garrisoned.json | ||
---|---|---|
8 ↗ | (On Diff #13311) | This line shouldn't be moved. |
Comment Actions
technologies/civbonuses/celt_structures.json technologies/persians/persian_architecture.json technologies/phase_city_athen.json technologies/phase_city_generic.json technologies/phase_town_athen.json technologies/phase_town_generic.json
Comment Actions
Some techs.
binaries/data/mods/public/simulation/templates/template_formation.xml | ||
---|---|---|
5 | For the formation, yes, for this particular diff, no. |
Comment Actions
- The changes are correct.
- It appears to be complete (at least the auras and technologies part; I assumed the templates part was done by script).
- perl checkrefs.pl --validate-templates found 0 validation errors.
- No errors or warnings when running the game or opening Atlas.
binaries/data/mods/public/simulation/templates/template_formation.xml | ||
---|---|---|
5 | But it's inside a comment? |