Page MenuHomeWildfire Games

Fix formation walking following "improved ship pickup" rP23925
ClosedPublic

Authored by wraitii on Sep 8 2020, 9:56 AM.

Details

Summary

As reported by @bb and @Angen , rP23925 broke formation walking in a few situations.

The issue is that rP23867/D2871 requires formation members to get no messages until the controller is stopped, but rP23925 didn't use the correct function (on account of a missed rebase), so members stopped too early.

Test Plan

Notice that formations now work correctly, particularly in two situations:

  • Creating a formation on any skirmish start and ordering units to move.
  • Running into an obstruction.

Event Timeline

wraitii created this revision.Sep 8 2020, 9:56 AM
wraitii edited the summary of this revision. (Show Details)

Successful build - Chance fights ever on the side of the prudent.

builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1523/display/redirect

wraitii requested review of this revision.Sep 8 2020, 10:06 AM
bb accepted this revision.Sep 8 2020, 11:56 AM

All cases of CMessageMotionUpdate::OBSTRUCTED got the treatment
Both issues seem fixed.

This revision is now accepted and ready to land.Sep 8 2020, 11:56 AM
This revision was automatically updated to reflect the committed changes.