Specificaly research unlock champion technologies.
Details
run ai match
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint Passed Severity Location Code Message Error binaries/data/mods/public/simulation/ai/petra/researchManager.js:85 ESLintBear ESLintBear Error binaries/data/mods/public/simulation/ai/petra/researchManager.js:85 JSHintBear JSHintBear Error binaries/data/mods/public/simulation/ai/petra/researchManager.js:85 JSHintBear JSHintBear Error binaries/data/mods/public/simulation/ai/petra/researchManager.js:85 JSHintBear JSHintBear - Unit
No Test Coverage - Build Status
Buildable 15148 Build 32860: Vulcan Build Jenkins Build 32859: Vulcan Build (macOS) Jenkins Build 32858: Vulcan Build (Windows) Jenkins Build 32857: arc lint + arc unit
Event Timeline
Great, thanks!
Do you think you could also make the AI able to use the Seleucid choice (traditional army vs reformed army)?
A grep -r shows the "Worker" class is use in baseManager.js, headquarters.js, and startingStrategy.js and the "CitizenSoldier" class in attackPlan.js, baseManager.js, headquarters.js, and victoryManager.js.
I don't know what they're used for or how the AI works, though.
Worker class means it can build and/or gather, citizensoldier it can fight, basically it was used in attackplan to not train champions and make use of barracks in hugeattack as champions were not in barracks so barracks would not be idle,
but in some places it uses citizensoldier to decide if unit can work, as long as they can build, I think classes should not be issue
(I suggest removing the minor tech queue check L2722 of headquarters.js, as it's redundantly done in researchManager).
I think the priority of the minorTech queue needs to be bumped from 40 to something like 250. The AI currently only queues one tech at a time (it can research several at once, but only has one in its own queue), and that means it actually researches things very slowly in the beginning.
Because of how it works, it'll always try researching eco techs first, then the unlocks.
I think it's fine if the AI is too eager to research eco techs, they _are_ pretty powerful.
binaries/data/mods/public/simulation/ai/petra/researchManager.js | ||
---|---|---|
161 | I would remove the check for majorTech. |
Build is green
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Fra
See https://jenkins.wildfiregames.com/job/macos-differential/2890/display/redirect for more details.
binaries/data/mods/public/simulation/ai/petra/researchManager.js | ||
---|---|---|
85–90 | Maybe combine them? if (tech[0].indexOf("unlock_champion") != 0) |
binaries/data/mods/public/simulation/ai/petra/researchManager.js | ||
---|---|---|
89 | Has been renamed to unlock_champion_infantry. |
Build is green
builderr-debug-macos.txt ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking. ld: warning: text-based stu
See https://jenkins.wildfiregames.com/job/macos-differential/2916/display/redirect for more details.