Subj. Make sure that it works when Vulkan disabled and enabled for SDL.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP25535: Adds Vulkan check to HWDetect reports.
- Apply the patch and compile the game with different SDL settings
- Make sure no crash in any case and the function doesn't cost noticeable time
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 15268 Build 33228: Vulcan Build Jenkins Build 33227: Vulcan Build (macOS) Jenkins Build 33226: Vulcan Build (Windows) Jenkins
Event Timeline
Comment Actions
Build is green
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols ../../../source/graphics/ShaderProgram.cpp:86:15: warning: 'Reload' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual void Reload() ^ ../../../source/graphics/ShaderProgram.h:124:15: note: overridden virtual function is here virtual void Reload() = 0; ^ ../../../source/graphics/ShaderProgram.cpp:118:15: warning: 'Bind' overrides a member function
See https://jenkins.wildfiregames.com/job/macos-differential/2983/display/redirect for more details.
Comment Actions
Then it means that SDL can't find vulkan for you or SDL compiled without Vulkan support.
Maybe it makes sense to write platform specific code instead.
Comment Actions
Good news! I've figured out the problem. Or SDl dll doesn't work but updating it to 2.0.14 makes it work again. You can merge this either before or after I update the sdl. Might do so soon.
source/ps/GameSetup/HWDetect.cpp | ||
---|---|---|
221 | So what? |