Since rP24480, there is a "LeaveFormation" order to support queued-disbanding. However, I misread the code paths and FinishOrder() isn't always called.
This fixes that oversight.
Reported by: Freagarach
Differential D3450
Fix error in GATHERING when disbanding formation while members gather. wraitii on Jan 22 2021, 3:11 PM. Authored by
Details
Since rP24480, there is a "LeaveFormation" order to support queued-disbanding. However, I misread the code paths and FinishOrder() isn't always called. Reported by: Freagarach Repro: get a formation, order members to gather while in formation, then when they're gathering remove them from the formation.
Diff Detail
Event TimelineComment Actions Build is green builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/Cor See https://jenkins.wildfiregames.com/job/macos-differential/3017/display/redirect for more details.
|