This is an alternative approach on D1955. Here the string replacement is done in Identity.js instead of in a CCmp, this making it more generic and easier extendable.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 8618 Build 14116: Vulcan Build Jenkins Build 14115: arc lint + arc unit
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/simulation2/components/ICmpIdentity.h | 27| class·ICmpIdentity·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpIdentity:' is invalid C code. Use --std or --language to configure the language. source/simulation2/components/ICmpVisual.h | 35| class·ICmpVisual·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpVisual:' is invalid C code. Use --std or --language to configure the language. Executing section JS... binaries/data/mods/public/simulation/components/Identity.js | 224| » return·visualActor; | | [NORMAL] ESLintBear (consistent-return): | | Function expected no return value. Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/244/display/redirect