Trac ticket: #3920
It also has an entry on https://trac.wildfiregames.com/wiki/GameplayFeatureStatus

(about curly braces: I think this is one of the things where all current devs have sensible preferences/conventions, and for community contributors we can simply point them out during reviews. I realize that leaves uncertainty in the future, but as you say, there doesn't seem to be a "simple" rule. At least I never saw this being a problem in the codebase)

Reverts accidental comment from testing

I see no problem with this, but today is my first encounter with this aspect of the build, so I'll need a better grasp before reviewing.

In D2068#86242, @elexis wrote:

May I use the phrasing "VfsPath change accepted by historic bruno" in the commit message?

I can give a little historical context here. Once upon a time VfsPath was:

typedef std::wstring VfsPath;

In D2057#85907, @kali0ad wrote:

@historic_bruno I think this patch worked for me as I was able to build a24 without any errors. However, when I try to login to the multiplayer lobby it says "Resolving the server's hostname failed". Is that the expected result?

While I'm here:
Add --with-pic to GMP configure flags, fixing ld warning reported in #5489.

GnuTLS LIB_URL update was omitted from previous diff.

Also, requiring Homebrew to run a bundle (also an option to consider) breaks the Apple vision of apps as self-contained bundles. The 0A.D. bundle should rely only on what is inside it, and the standard macOS system libraries. That was always the design goal, and at least in the past, that was how it worked.

Another reason is that it allows building for other Apple platforms, including iOS. Even though we don't support that at all, I have tinkered with it in the past, and it helped substantially to have this infrastructure in place. Only a few differences needed between building for macOS and iOS.

So just to add onto this discussion, since myself and leper originally wrote this script.

Restore --enable-fat for GMP, and add to nettle as well.

Encountered this today while working on D2057. I mistakenly removed the flag, thinking it was only macOS "fat binaries" which are combined x86_64 and i386 archs.

Diff with full context

For a look at what disabled TCP fast open means, see https://gitlab.com/gnutls/gnutls/blob/master/lib/system/fastopen.c

Updates nettle to 3.5.1, gnutls to 3.6.8, and gloox to 1.0.22.
Fixes GnuTLS build by adding gmp to the LIBS var, otherwise it's a missing dependency in the configure script (they only add NETTLE_LIBS and HOGWEED_LIBS). NOTE: Upstream should include GMP_LIBS in the configure script.
GnuTLS 3.6.8 implements a new feature TCP Fast Open which requires a system function connectx, not available until OS X 10.11. Unfortunately GnuTLS doesn't currently support SDK-based builds, so the feature must either be enabled or disabled. I have chosen to disable it on macOS, as it's only an optional feature. We could certainly revisit an upstream patch to provide proper macOS SDK-based builds, or at least a build flag to disable TCPFO.