Page MenuHomeWildfire Games

historic_bruno (Ben Brian)
User

Projects

User does not belong to any projects.

User Details

User Since
Mon, Jul 8, 3:30 PM (1 w, 5 d)

Recent Activity

Yesterday

historic_bruno added inline comments to D1698: FCollada: Various compilation fixes for different compilers.
Sat, Jul 20, 11:06 PM
historic_bruno added a comment to D1218: New formation bonus.

Seems it was decided to hold off on this until formation attacks are mechanically practical (I agree, but wasn't sure if this still needed review), since it would be unfair if units can be physically spread apart, but still get formation bonuses.

Sat, Jul 20, 10:12 PM
historic_bruno added a comment to D1849: Clarify the use of the macmouse config option.
In D1849#87712, @elexis wrote:

Precisely because they have no idea how to fix this, the one line in options.json is the right fix isn't it?

Sat, Jul 20, 9:53 PM
historic_bruno requested changes to D1929: Clean up renderer options.
Sat, Jul 20, 9:43 PM
historic_bruno added a comment to D1929: Clean up renderer options.

I haven't build- or run-tested this yet, but the diff looks conceptually OK.

Sat, Jul 20, 9:43 PM
historic_bruno accepted D2089: Catch PSError MapReader and MapGenerator exceptions.
Sat, Jul 20, 9:36 PM
historic_bruno added inline comments to D1926: Introduce some sort of prop LOD.
Sat, Jul 20, 9:36 PM
historic_bruno added a reviewer for D1929: Clean up renderer options: historic_bruno.
Sat, Jul 20, 8:26 PM
historic_bruno accepted D1849: Clarify the use of the macmouse config option.
Sat, Jul 20, 8:09 PM
historic_bruno added a comment to D1849: Clarify the use of the macmouse config option.

Don't see the problem here. Whatever the % of users who are affected, at least some of them do play the game and have no idea how to fix this, as we don't document it anywhere.

Sat, Jul 20, 8:08 PM
historic_bruno added a reviewer for D1510: Update to Spidermonkey 45.0.2: historic_bruno.
Sat, Jul 20, 7:14 PM
historic_bruno added a reviewer for D1697: FCollada: Add missing includes in the test suite: historic_bruno.
Sat, Jul 20, 7:11 PM
historic_bruno added a reviewer for D1696: FCollada: Add gitignore and Update solution files: historic_bruno.
Sat, Jul 20, 7:11 PM
historic_bruno added a reviewer for D1698: FCollada: Various compilation fixes for different compilers: historic_bruno.
Sat, Jul 20, 7:10 PM
historic_bruno added a reviewer for D1046: Give Message Box Confirmation Hotkey Binding: historic_bruno.
Sat, Jul 20, 7:10 PM
historic_bruno added inline comments to D1510: Update to Spidermonkey 45.0.2.
Sat, Jul 20, 9:22 AM
historic_bruno retitled D1263: Improve lobby UI at default 1024x768 window size from Player list ratings not more completely viewable on 1024x768 lobby to Improve lobby UI at default 1024x768 window size.
Sat, Jul 20, 8:28 AM

Fri, Jul 19

historic_bruno updated the summary of D1698: FCollada: Various compilation fixes for different compilers.
Fri, Jul 19, 6:38 PM
historic_bruno updated the summary of D1697: FCollada: Add missing includes in the test suite.
Fri, Jul 19, 6:38 PM
historic_bruno updated the summary of D1696: FCollada: Add gitignore and Update solution files.
Fri, Jul 19, 6:37 PM
historic_bruno added inline comments to D2089: Catch PSError MapReader and MapGenerator exceptions.
Fri, Jul 19, 4:08 PM
historic_bruno added a comment to D1246: Allow to lock teams in scenarios.
In D1246#53684, @elexis wrote:

I'm reluctant with this. The idea of scenario maps must have been at one point to let the map lock every setting.

Fri, Jul 19, 7:14 AM
historic_bruno committed rP22508: Makes wxWidgets 3.0 dependency explicit in the game build..
Makes wxWidgets 3.0 dependency explicit in the game build.
Fri, Jul 19, 6:52 AM
historic_bruno closed D2076: Make wxWidgets 3.0 build requirement more explicit.
Fri, Jul 19, 6:52 AM
historic_bruno accepted D2099: Fix Pathfinder Grid.h compiler warning.
Fri, Jul 19, 1:41 AM

Thu, Jul 18

historic_bruno committed rP22503: Removes deprecated 'register' storage class from mongoose. Refs #3068.
Removes deprecated 'register' storage class from mongoose. Refs #3068
Thu, Jul 18, 8:28 AM
historic_bruno updated the diff for D2076: Make wxWidgets 3.0 build requirement more explicit.

Rebased to latest SVN

Thu, Jul 18, 7:22 AM
historic_bruno committed rP22501: Update win32 wxWidgets README for VS 2015..
Update win32 wxWidgets README for VS 2015.
Thu, Jul 18, 6:18 AM
historic_bruno closed D2030: Update wxWidgets readme [VS2013 -> VS2015].
Thu, Jul 18, 6:18 AM
historic_bruno committed rP22500: Fixes some ambiguous calls of abs()..
Fixes some ambiguous calls of abs().
Thu, Jul 18, 12:39 AM
historic_bruno closed D2091: Fix ambiguous uses of abs [-Wabsolute-value] .
Thu, Jul 18, 12:39 AM

Wed, Jul 17

historic_bruno closed D2057: GnuTLS configure requires pkg-config, breaking macOS build.
Wed, Jul 17, 11:12 PM
historic_bruno accepted D2030: Update wxWidgets readme [VS2013 -> VS2015].
Wed, Jul 17, 7:04 PM
historic_bruno added a comment to D2030: Update wxWidgets readme [VS2013 -> VS2015].
In D2030#87141, @Itms wrote:

I used the latest one (probably vc12) with the compiler I wanted to build the game with. Recent versions of visual studio can open slightly older solutions without issue 🙂
Sorry, I should have seen this revision earlier.

Wed, Jul 17, 6:57 PM
historic_bruno requested changes to D2030: Update wxWidgets readme [VS2013 -> VS2015].
Wed, Jul 17, 5:16 PM
historic_bruno committed rP22494: Disables GnuTLS Native Language Support in build-osx-libs.sh, refs #5503.
Disables GnuTLS Native Language Support in build-osx-libs.sh, refs #5503
Wed, Jul 17, 4:52 PM
historic_bruno committed rP22493: Fixes silent download errors in build-osx-libs.sh. Fixes #5490..
Fixes silent download errors in build-osx-libs.sh. Fixes #5490.
Wed, Jul 17, 4:32 PM
historic_bruno committed rP22492: Cleans up build-osx-libs.sh whitespace. Fixes #5486..
Cleans up build-osx-libs.sh whitespace. Fixes #5486.
Wed, Jul 17, 4:20 PM
historic_bruno added a comment to D2091: Fix ambiguous uses of abs [-Wabsolute-value] .
In D2091#87068, @elexis wrote:

std::fabs, std::labs?

Wed, Jul 17, 3:53 PM
historic_bruno created D2091: Fix ambiguous uses of abs [-Wabsolute-value] .
Wed, Jul 17, 6:26 AM
historic_bruno added inline comments to D2057: GnuTLS configure requires pkg-config, breaking macOS build.
Wed, Jul 17, 6:02 AM
historic_bruno accepted D2084: Remove CMapGeneratorWorker struct AutoFree.
Wed, Jul 17, 12:56 AM
historic_bruno added inline comments to D2084: Remove CMapGeneratorWorker struct AutoFree.
Wed, Jul 17, 12:54 AM
historic_bruno requested changes to D2084: Remove CMapGeneratorWorker struct AutoFree.
Wed, Jul 17, 12:15 AM
historic_bruno added inline comments to D2084: Remove CMapGeneratorWorker struct AutoFree.
Wed, Jul 17, 12:15 AM

Tue, Jul 16

historic_bruno accepted D2084: Remove CMapGeneratorWorker struct AutoFree.
Tue, Jul 16, 11:49 PM
historic_bruno added a comment to D2084: Remove CMapGeneratorWorker struct AutoFree.
In D2084#86963, @elexis wrote:

WOuldn't it be better to make m_ScriptInterface an std::unique_ptr (and still delete)? That would be exception-safe, right?

You mean making it a pointer in the tests and passing a pointer? I don't see the need to make it a pointer, unless there are reasons the AutoFree must be there.

All I can think of are exceptions. What if an exception is thrown in CMapGeneratorWorker::Run()?

As far as I see there should by design not be any exceptions thrown in the MapGenerator thread.
If there is an error in mapgen stage, it is passed as progress = -1 to the MapReader in CMapReader::GenerateMap.
One could do some effort to pass over the exception string.

Tue, Jul 16, 11:43 PM
historic_bruno added a comment to D2030: Update wxWidgets readme [VS2013 -> VS2015].

Ah, thanks! :) That makes sense then.

Tue, Jul 16, 9:08 PM
historic_bruno added a comment to D2030: Update wxWidgets readme [VS2013 -> VS2015].

Why 3.0.4 in particular? I've built against 3.0.2 and it works (see also #2891, not sure which version the autobuilder currently uses -- it was 3.0.2 back then). We could simply say "the latest stable release", or something like that.

Tue, Jul 16, 8:58 PM
historic_bruno added a comment to D2084: Remove CMapGeneratorWorker struct AutoFree.

All I can think of are exceptions. What if an exception is thrown in CMapGeneratorWorker::Run()?

Tue, Jul 16, 8:36 PM
historic_bruno updated the Trac tickets for D2076: Make wxWidgets 3.0 build requirement more explicit.
Tue, Jul 16, 8:07 PM
historic_bruno added a comment to D1784: Fixed assert fails in Actor Editor.
In D1784#75860, @Stan wrote:

For Windows we officially dropped it when we committed #5098. For the rest of the platforms most of the ticket are about being compatible, but there is no clear decision.

What's about 2.9?

Tue, Jul 16, 8:02 PM · Windows Developers
historic_bruno added inline comments to D2076: Make wxWidgets 3.0 build requirement more explicit.
Tue, Jul 16, 7:23 PM
historic_bruno requested review of D2076: Make wxWidgets 3.0 build requirement more explicit.
Tue, Jul 16, 3:53 AM
historic_bruno updated the diff for D2076: Make wxWidgets 3.0 build requirement more explicit.
Tue, Jul 16, 3:53 AM
historic_bruno added a comment to D2076: Make wxWidgets 3.0 build requirement more explicit.

source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Player/Player.cpp has some code related to 2.8, I think it should be removed too.
source/tools/atlas/AtlasUI/ScenarioEditor/ScenarioEditor.cpp has some notes about 2.9, should be fixed or removed.

Tue, Jul 16, 3:49 AM
historic_bruno added a comment to D2076: Make wxWidgets 3.0 build requirement more explicit.

What's about Ubuntu 14.04? We still have such audience (judging by feedback statistics).

Tue, Jul 16, 2:49 AM
historic_bruno updated the diff for D2076: Make wxWidgets 3.0 build requirement more explicit.

Remove some wxWidgets 2.x checks.

Tue, Jul 16, 2:03 AM

Mon, Jul 15

historic_bruno added a comment to D2079: Adds snapping to edges for buildings.

Trac ticket: #3920
It also has an entry on https://trac.wildfiregames.com/wiki/GameplayFeatureStatus

Mon, Jul 15, 8:31 PM

Sun, Jul 14

historic_bruno added a comment to D2070: Linting: Remove controversial 'curly' eslint rules.

(about curly braces: I think this is one of the things where all current devs have sensible preferences/conventions, and for community contributors we can simply point them out during reviews. I realize that leaves uncertainty in the future, but as you say, there doesn't seem to be a "simple" rule. At least I never saw this being a problem in the codebase)

Sun, Jul 14, 4:51 PM
historic_bruno updated the diff for D2076: Make wxWidgets 3.0 build requirement more explicit.

Reverts accidental comment from testing

Sun, Jul 14, 4:30 PM
historic_bruno updated the test plan for D2076: Make wxWidgets 3.0 build requirement more explicit.
Sun, Jul 14, 4:08 PM
historic_bruno created D2076: Make wxWidgets 3.0 build requirement more explicit.
Sun, Jul 14, 4:07 PM
historic_bruno committed rP22468: Actually use variable added in r22467. Refs #5501..
Actually use variable added in r22467. Refs #5501.
Sun, Jul 14, 7:16 AM
historic_bruno committed rP22467: Fixes #5501 null pointer exception in AtlasUI on Windows..
Fixes #5501 null pointer exception in AtlasUI on Windows.
Sun, Jul 14, 7:03 AM
historic_bruno added a comment to D2003: Linting: Enable 'no-floating-decimal' rule in ESLint.

I see no problem with this, but today is my first encounter with this aspect of the build, so I'll need a better grasp before reviewing.

Sun, Jul 14, 12:22 AM

Sat, Jul 13

historic_bruno added a comment to D2068: Cleanup MapGenerator ScriptInterface.
In D2068#86242, @elexis wrote:

May I use the phrasing "VfsPath change accepted by historic bruno" in the commit message?

Sat, Jul 13, 9:56 PM
historic_bruno added a comment to D2068: Cleanup MapGenerator ScriptInterface.

I can give a little historical context here. Once upon a time VfsPath was:

typedef std::wstring VfsPath;
Sat, Jul 13, 8:17 PM
historic_bruno updated the Trac tickets for D2057: GnuTLS configure requires pkg-config, breaking macOS build.
Sat, Jul 13, 7:41 PM

Fri, Jul 12

historic_bruno added inline comments to D2037: [ATLAS] Adds a tool to pick water high by terrain click.
Fri, Jul 12, 10:07 PM
historic_bruno committed rP22457: Updates library LICENSE.txt for libsodium and macOS patches.
Updates library LICENSE.txt for libsodium and macOS patches
Fri, Jul 12, 5:25 PM
historic_bruno requested changes to D2019: [ATLASUI] Main Thread Checker: UI API called on a background thread: -[NSView initWithFrame:].
Fri, Jul 12, 12:49 AM
historic_bruno added inline comments to D2019: [ATLASUI] Main Thread Checker: UI API called on a background thread: -[NSView initWithFrame:].
Fri, Jul 12, 12:11 AM
historic_bruno added inline comments to D2019: [ATLASUI] Main Thread Checker: UI API called on a background thread: -[NSView initWithFrame:].
Fri, Jul 12, 12:03 AM

Thu, Jul 11

historic_bruno committed rP22455: Fixes GnuTLS build on macOS..
Fixes GnuTLS build on macOS.
Thu, Jul 11, 11:49 PM
historic_bruno updated the test plan for D2057: GnuTLS configure requires pkg-config, breaking macOS build.
Thu, Jul 11, 8:15 PM
historic_bruno accepted D2062: [ATLASUI] Build atlasUI inside xcode missing libpng, libjpeg.
Thu, Jul 11, 5:59 PM
historic_bruno added a reviewer for D2062: [ATLASUI] Build atlasUI inside xcode missing libpng, libjpeg: historic_bruno.
Thu, Jul 11, 5:42 PM
historic_bruno added a comment to D2057: GnuTLS configure requires pkg-config, breaking macOS build.

@historic_bruno I think this patch worked for me as I was able to build a24 without any errors. However, when I try to login to the multiplayer lobby it says "Resolving the server's hostname failed". Is that the expected result?

Thu, Jul 11, 3:56 PM
historic_bruno updated the diff for D2057: GnuTLS configure requires pkg-config, breaking macOS build.

While I'm here:
Add --with-pic to GMP configure flags, fixing ld warning reported in #5489.

Thu, Jul 11, 3:27 AM
historic_bruno updated the diff for D2057: GnuTLS configure requires pkg-config, breaking macOS build.

LIB_URL update was omitted from previous diff.

Thu, Jul 11, 2:17 AM

Wed, Jul 10

historic_bruno added a reviewer for D2019: [ATLASUI] Main Thread Checker: UI API called on a background thread: -[NSView initWithFrame:]: historic_bruno.
Wed, Jul 10, 9:07 PM
historic_bruno added a comment to D1483: Use Homebrew to fetch OSX libraries instead of compiling them all.

Also, requiring Homebrew to run a bundle (also an option to consider) breaks the Apple vision of apps as self-contained bundles. The 0A.D. bundle should rely only on what is inside it, and the standard macOS system libraries. That was always the design goal, and at least in the past, that was how it worked.

Wed, Jul 10, 8:16 PM
historic_bruno added a comment to D1483: Use Homebrew to fetch OSX libraries instead of compiling them all.

Another reason is that it allows building for other Apple platforms, including iOS. Even though we don't support that at all, I have tinkered with it in the past, and it helped substantially to have this infrastructure in place. Only a few differences needed between building for macOS and iOS.

Wed, Jul 10, 8:11 PM
historic_bruno added a comment to D1483: Use Homebrew to fetch OSX libraries instead of compiling them all.

So just to add onto this discussion, since myself and leper originally wrote this script.

Wed, Jul 10, 8:05 PM
historic_bruno updated the diff for D2057: GnuTLS configure requires pkg-config, breaking macOS build.

Restore --enable-fat for GMP, and add to nettle as well.

Wed, Jul 10, 5:38 PM
historic_bruno planned changes to D2057: GnuTLS configure requires pkg-config, breaking macOS build.
Wed, Jul 10, 4:32 PM
historic_bruno added a comment to D1772: Fix TLS Segfault on various mac versions.

Encountered this today while working on D2057. I mistakenly removed the flag, thinking it was only macOS "fat binaries" which are combined x86_64 and i386 archs.

Wed, Jul 10, 4:01 PM
historic_bruno updated the diff for D2057: GnuTLS configure requires pkg-config, breaking macOS build.

Diff with full context

Wed, Jul 10, 3:11 PM
historic_bruno added a comment to D2057: GnuTLS configure requires pkg-config, breaking macOS build.

For a look at what disabled TCP fast open means, see https://gitlab.com/gnutls/gnutls/blob/master/lib/system/fastopen.c

Wed, Jul 10, 3:02 PM
historic_bruno updated the diff for D2057: GnuTLS configure requires pkg-config, breaking macOS build.

Updates nettle to 3.5.1, gnutls to 3.6.8, and gloox to 1.0.22.
Fixes GnuTLS build by adding gmp to the LIBS var, otherwise it's a missing dependency in the configure script (they only add NETTLE_LIBS and HOGWEED_LIBS). NOTE: Upstream should include GMP_LIBS in the configure script.
GnuTLS 3.6.8 implements a new feature TCP Fast Open which requires a system function connectx, not available until OS X 10.11. Unfortunately GnuTLS doesn't currently support SDK-based builds, so the feature must either be enabled or disabled. I have chosen to disable it on macOS, as it's only an optional feature. We could certainly revisit an upstream patch to provide proper macOS SDK-based builds, or at least a build flag to disable TCPFO.

Wed, Jul 10, 2:59 PM

Tue, Jul 9

historic_bruno planned changes to D2057: GnuTLS configure requires pkg-config, breaking macOS build.
Tue, Jul 9, 9:06 PM
historic_bruno created D2057: GnuTLS configure requires pkg-config, breaking macOS build.
Tue, Jul 9, 8:42 PM