Page MenuHomeWildfire Games
Feed All Stories

Yesterday

phosit added inline comments to D4790: Use atomic as buffer index in CProfiler2::ThreadStorage.
Sun, Sep 25, 9:00 PM
Stan added inline comments to D4790: Use atomic as buffer index in CProfiler2::ThreadStorage.
Sun, Sep 25, 7:47 PM
phosit requested review of D4790: Use atomic as buffer index in CProfiler2::ThreadStorage.
Sun, Sep 25, 7:44 PM
asterix accepted D4789: Bump version to A27.

LGTM

Sun, Sep 25, 5:40 PM
phosit added a comment to D4770: Multiplayer saved games.

It does not work for me: as soon as i hit Save as a host of a MP game the game crashes. Same for the Load Game button.

Sun, Sep 25, 3:38 PM
phosit added a comment to D4664: Non-local condition_variable.

I'm not satisfied with the "selecting priority" inside PopTask. The predicate is not trivial and both mutexes are owned at the same time. Do you think this are problems? Do you have a solution?
My ideas (non of them is perfect and i omited m_Kill):

Sun, Sep 25, 11:36 AM
vladislavbelov accepted D4789: Bump version to A27.

LGTM.

Sun, Sep 25, 11:09 AM
Stan requested review of D4789: Bump version to A27.
Sun, Sep 25, 9:13 AM

Sat, Sep 24

phosit added inline comments to D3676: Removes explicit synchronizations from MapGenerator.
Sat, Sep 24, 4:18 PM
wowgetoffyourcellphone added a comment to D4788: [Gameplay] A new suite of unit specific upgrades.

Make sure to capitalize all words in genericName. :)

Sat, Sep 24, 3:41 PM
wowgetoffyourcellphone added a comment to D4271: [WIP] Civ backgrounds for minimap..

Should the minimap have its own sprite.xml file for clarity?

Sat, Sep 24, 4:26 AM

Fri, Sep 23

autobuild committed rP27104: [Windows] Automated build..
[Windows] Automated build.
Fri, Sep 23, 8:32 PM
Geniusupdates updated Geniusupdates.
Fri, Sep 23, 5:50 AM

Tue, Sep 20

Stan added a comment to D4669: Use _SC_NPROCESSORS_ONLN to get available CPUs.

Arch is using it

Tue, Sep 20, 10:46 AM

Mon, Sep 19

andy5995 added a comment to D2743: [WP] MesonBuild support.

Also there's some info in the meson FAQ about how to use wildcards

Mon, Sep 19, 5:51 PM
andy5995 added inline comments to D2743: [WP] MesonBuild support.
Mon, Sep 19, 5:19 PM
Stan abandoned D2877: [WIP] Libepoxy GL loader.

We merged the other GL loader.

Mon, Sep 19, 8:45 AM

Sun, Sep 18

real_tabasco_sauce added a comment to D4788: [Gameplay] A new suite of unit specific upgrades.

icon ideas:
level 1 have 'I' in the top right, level two have 'II' in the top right.

Sun, Sep 18, 10:04 PM
real_tabasco_sauce requested review of D4788: [Gameplay] A new suite of unit specific upgrades.
Sun, Sep 18, 9:47 PM

Fri, Sep 16

Stan resigned from D4758: Rearrange GC scheduling for reduced lag.
Fri, Sep 16, 10:33 AM
Stan removed a reviewer for D4758: Rearrange GC scheduling for reduced lag: Stan.

@vladislavbelov asked me to clarify more things before committing this, because it might lead to a 6 months Feature Freeze or a painful revert.
We need to make sure it doesn't cause more spikes in other cases.

Fri, Sep 16, 10:33 AM
Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.
In D4758#203957, @Stan wrote:

I the meantime can you keep testing it with different loads and replays to make sure there isn't something unstable ? :)

EG. The custom combat huge demo or a 4v4 with ais on big maps etc.

Fri, Sep 16, 7:40 AM
Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.

I the meantime can you keep testing it with different loads and replays to make sure there isn't something unstable ? :)

Fri, Sep 16, 7:38 AM

Thu, Sep 15

Stan accepted D4758: Rearrange GC scheduling for reduced lag.

Nah, this looks alright, will see about committing it after the release comes out.

Thu, Sep 15, 10:22 PM
Mercury added a comment to D4758: Rearrange GC scheduling for reduced lag.

No worries, do you need me to upload again?

Thu, Sep 15, 2:19 AM

Wed, Sep 14

Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Sorry about that, ZFS keeps failing these days, and the VM gets stuck.

Wed, Sep 14, 9:22 AM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Build was aborted.

Wed, Sep 14, 8:46 AM

Tue, Sep 13

Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Tue, Sep 13, 11:07 PM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Tue, Sep 13, 10:51 PM
Mercury added inline comments to D4758: Rearrange GC scheduling for reduced lag.
Tue, Sep 13, 10:46 PM
Stan removed a reviewer for D4698: Fix entvalidate.py: wraitii.
Tue, Sep 13, 10:40 PM
Stan accepted D4698: Fix entvalidate.py.

Looks good to go. Wonder if they should have a copyright header. According to https://trac.wildfiregames.com/browser/ps/trunk/source/tools/LICENSE.txt it's MIT.

Tue, Sep 13, 10:40 PM
Mercury updated the diff for D4758: Rearrange GC scheduling for reduced lag.

Added time units (seconds, milliseconds) to variable names.

Tue, Sep 13, 10:39 PM
baco updated the diff for D4698: Fix entvalidate.py.

Made Relese NG entity file an optional argument

Tue, Sep 13, 10:03 PM
baco added a comment to D4698: Fix entvalidate.py.
In D4698#203936, @Stan wrote:

Just realised I'm an idiot and you need a way to specify the location because you don't want to put the rng in the mod folder (since you're probably gonna zip it afterwards) and it won't be there on the CI either.

Tue, Sep 13, 2:15 PM
Stan added a comment to D4698: Fix entvalidate.py.

Just realised I'm an idiot and you need a way to specify the location because you don't want to put the rng in the mod folder (since you're probably gonna zip it afterwards) and it won't be there on the CI either.
Sorry, that's what happens when I do too much things at once.

Tue, Sep 13, 1:43 PM
baco updated the diff for D4698: Fix entvalidate.py.

Deleted the middle directory scripts in entity.rng's location. Didn't made it eligible, by argument, to avoid directory creation in case of not existence.

Tue, Sep 13, 1:40 PM
baco added a comment to D4698: Fix entvalidate.py.
In D4698#203928, @Stan wrote:

~~ Sadly I'm not sure I can set you as author. There seem to be a way but I dunno if trac and phab support it https://stackoverflow.com/questions/2107719/how-to-set-author-for-svn#2107898 ~~

EDIT: Seems it's only for files.

Tue, Sep 13, 1:29 PM
Stan added inline comments to D4698: Fix entvalidate.py.
Tue, Sep 13, 1:29 PM
baco added inline comments to D4698: Fix entvalidate.py.
Tue, Sep 13, 1:22 PM
Stan added a comment to D4698: Fix entvalidate.py.

Sadly I'm not sure I can set you as author. There seem to be a way but I dunno if trac and phab support it https://stackoverflow.com/questions/2107719/how-to-set-author-for-svn#2107898

Tue, Sep 13, 8:28 AM
autobuild committed rP27103: [Windows] Automated build..
[Windows] Automated build.
Tue, Sep 13, 6:41 AM
baco updated the diff for D4698: Fix entvalidate.py.

It's been a complete overhaul of the file, but it is working. Now it receives the modules' location and name as parameters.

Tue, Sep 13, 12:41 AM

Mon, Sep 12

vladislavbelov changed the visibility for D4716: Fixes water rendering on map borders.
Mon, Sep 12, 11:59 PM
vladislavbelov committed rP27102: Fixes water rendering on map borders..
Fixes water rendering on map borders.
Mon, Sep 12, 11:53 PM
vladislavbelov closed D4716: Fixes water rendering on map borders.
Mon, Sep 12, 11:53 PM
Stan committed rP27101: Update translators credit file..
Update translators credit file.
Mon, Sep 12, 10:08 PM
Stan committed rP27100: Fix translations script pipeline..
Fix translations script pipeline.
Mon, Sep 12, 1:35 PM
autobuild committed rP27099: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Mon, Sep 12, 1:01 PM
autobuild committed rP27098: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Mon, Sep 12, 11:41 AM
Stan committed rP27097: Update dockerfiles images to match jenkins.
Update dockerfiles images to match jenkins
Mon, Sep 12, 9:39 AM

Sun, Sep 11

baco updated the diff for D4698: Fix entvalidate.py.

Added a new diff with the flag -U3000 as suggested on IRC.

Sun, Sep 11, 8:58 PM
baco updated the diff for D4698: Fix entvalidate.py.
Sun, Sep 11, 8:36 PM
baco commandeered D4698: Fix entvalidate.py.
Sun, Sep 11, 8:35 PM
Stan committed rP27096: Update jenkinsfiles to match upstream..
Update jenkinsfiles to match upstream.
Sun, Sep 11, 7:28 PM
wowgetoffyourcellphone committed rP27095: [Alpha 26] Fix so that swordsman heroes can use the Testudo (if their civ….
[Alpha 26] Fix so that swordsman heroes can use the Testudo (if their civ…
Sun, Sep 11, 5:58 PM
Dunedan added a comment to rP27093: Remove code for the lobby bots from SVN.

As there haven't been any more feedback on this revision and we had various cases where people got confused which code is the current one, I went ahead and committed the changes now.

Sun, Sep 11, 3:26 PM
Dunedan committed rP27094: Remove code for the lobby bots from SVN.
Remove code for the lobby bots from SVN
Sun, Sep 11, 3:22 PM
Dunedan committed rP27093: Remove code for the lobby bots from SVN.
Remove code for the lobby bots from SVN
Sun, Sep 11, 3:15 PM
Dunedan closed D4155: Remove code for the lobby bots from SVN.
Sun, Sep 11, 3:15 PM
Stan accepted D4787: Fixes out of bounds on each match start in Profiler2.

Fix year and LGTM.

Sun, Sep 11, 1:14 PM
vladislavbelov added inline comments to D4787: Fixes out of bounds on each match start in Profiler2.
Sun, Sep 11, 12:14 PM
Stan added inline comments to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.
Sun, Sep 11, 11:34 AM
Stan added inline comments to D4787: Fixes out of bounds on each match start in Profiler2.
Sun, Sep 11, 11:32 AM
Vulcan added a comment to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.

Successful build - Chance fights ever on the side of the prudent.

Sun, Sep 11, 11:01 AM
Vulcan added a comment to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.

Successful build - Chance fights ever on the side of the prudent.

Sun, Sep 11, 11:00 AM
lyv updated the diff for D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.
  • Make config variable naming consistent
  • Check whether the passed in upgrade at least exists
Sun, Sep 11, 10:52 AM
lyv added inline comments to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.
Sun, Sep 11, 10:39 AM
vladislavbelov requested review of D4787: Fixes out of bounds on each match start in Profiler2.
Sun, Sep 11, 1:55 AM
vladislavbelov added a comment to rP18423: Revamp Profiler2 to make it more usable..

That commit leads to an out of bounds access on each match start.

Sun, Sep 11, 12:55 AM
vladislavbelov raised a concern with rP18423: Revamp Profiler2 to make it more usable..
Sun, Sep 11, 12:53 AM

Sat, Sep 10

vladislavbelov committed rP27092: Replaces -1 as stencil mask value in effect XML by a positive mask..
Replaces -1 as stencil mask value in effect XML by a positive mask.
Sat, Sep 10, 10:23 PM
vladislavbelov closed D4785: Replaces -1 as stencil mask value in effect XML by a positive mask.
Sat, Sep 10, 10:23 PM
Stan committed rP27091: Fix the check translation script failing..
Fix the check translation script failing.
Sat, Sep 10, 7:19 PM
Stan added inline comments to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.
Sat, Sep 10, 7:08 PM
Vulcan added a comment to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.

Successful build - Chance fights ever on the side of the prudent.

Sat, Sep 10, 6:45 PM
Vulcan added a comment to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.

Successful build - Chance fights ever on the side of the prudent.

Sat, Sep 10, 6:45 PM
lyv retitled D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers from Add `UpgradePlan`s to Petra and use it to upgrade sentry towers to Add UpgradePlan to Petra and use it to upgrade sentry towers.
Sat, Sep 10, 6:44 PM
lyv added inline comments to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.
Sat, Sep 10, 6:42 PM
lyv updated the diff for D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.
  • Minor lint changes
  • Set plan ID
  • Move damage priorities to config
Sat, Sep 10, 6:38 PM

Fri, Sep 9

Stan added a comment to D4786: A bit faster "state hash check".

Maybe try this flag https://github.com/7wells/0ad/blob/master/binaries/system/readme.txt#L75

Fri, Sep 9, 2:31 PM
phosit requested review of D4786: A bit faster "state hash check".
Fri, Sep 9, 2:12 PM
autobuild committed rP27090: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Sep 9, 1:39 PM
vladislavbelov requested review of D4785: Replaces -1 as stencil mask value in effect XML by a positive mask.
Fri, Sep 9, 11:28 AM
Vulcan added a comment to D4425: Use the threadpool for texture conversion.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Sep 9, 11:12 AM
Vulcan added a comment to D4425: Use the threadpool for texture conversion.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Sep 9, 11:11 AM
Vulcan added a comment to D4740: [WIP] - Allow to limit the structures a builder can construct..

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Sep 9, 11:11 AM
Vulcan added a comment to D4425: Use the threadpool for texture conversion.

Build was aborted.

Fri, Sep 9, 10:12 AM

Thu, Sep 8

phosit accepted D4779: Removes drawing via IDeviceCommandContext from CMinimap.
Thu, Sep 8, 8:00 PM
Vulcan added a comment to D4425: Use the threadpool for texture conversion.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 8, 3:24 PM
Vulcan added a comment to D4425: Use the threadpool for texture conversion.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 8, 3:22 PM
phosit updated the diff for D4425: Use the threadpool for texture conversion.

change parameter order of PushTask
add context

Thu, Sep 8, 3:16 PM
phosit added a comment to D4425: Use the threadpool for texture conversion.
In D4425#203777, @Stan wrote:

Can't you make it the responsibility of the receiver to destroy objects instead of adding the extra overhead of a unique ptr?

Thu, Sep 8, 2:34 PM
Vulcan added a comment to D4425: Use the threadpool for texture conversion.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 8, 2:11 PM
Vulcan added a comment to D4425: Use the threadpool for texture conversion.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 8, 2:09 PM
phosit updated the diff for D4425: Use the threadpool for texture conversion.

Revert to the one that worked

Thu, Sep 8, 2:04 PM
lyv added a comment to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.

Note to self/anyone else interested: One could also use this in the army manager to upgrade units as well. If the army composition is more melee, the persian champions could instead be switched to archer variants to balance it out and whatnot.

Thu, Sep 8, 1:52 PM
lyv added inline comments to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.
Thu, Sep 8, 1:34 PM
Stan added inline comments to D4782: Add UpgradePlan to Petra and use it to upgrade sentry towers.
Thu, Sep 8, 10:32 AM
Vulcan added a comment to D4740: [WIP] - Allow to limit the structures a builder can construct..

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 8, 8:38 AM