Page MenuHomeWildfire Games
Feed All Stories

Today

Stan added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Delenda est and hyrule have custom shaders though.

Fri, Dec 3, 11:33 AM
vladislavbelov added a comment to D4361: Removes AO multipliers and normalizes AO textures.
In D4361#185795, @Stan wrote:

Maybe we should have "ignored" or something instead. 0.0 looks like a normal value to me.

Fri, Dec 3, 10:02 AM
Stan added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Could have a warning too.

Fri, Dec 3, 9:48 AM
Stan added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Maybe we should have "ignored" or something instead. 0.0 looks like a normal value to me.

Fri, Dec 3, 9:47 AM
vladislavbelov added a comment to D4361: Removes AO multipliers and normalizes AO textures.
In D4361#185793, @Stan wrote:

Even then, any modder opening the file will be confused.

Fri, Dec 3, 9:44 AM
Stan added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Even then, any modder opening the file will be confused.

Fri, Dec 3, 9:31 AM
autobuild committed rP26028: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Dec 3, 9:15 AM
vladislavbelov added a comment to D4361: Removes AO multipliers and normalizes AO textures.
In D4361#185791, @Stan wrote:

Why do you set it to 0 instead of 1.0 even for materials with AO? It's confusing.

Fri, Dec 3, 9:08 AM
Stan added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Why do you set it to 0 instead of 1.0 even for materials with AO? It's confusing.

Fri, Dec 3, 8:32 AM
Freagarach added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Okay, thanks. :)

Fri, Dec 3, 8:11 AM
vladislavbelov added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Maybe an ignorant question, but why this patch?

Fri, Dec 3, 8:11 AM
ChinaAirline updated ChinaAirline.
Fri, Dec 3, 8:08 AM
Freagarach added a comment to D4361: Removes AO multipliers and normalizes AO textures.

Maybe an ignorant question, but why this patch?

Fri, Dec 3, 8:07 AM
vladislavbelov requested review of D4361: Removes AO multipliers and normalizes AO textures.
Fri, Dec 3, 7:51 AM
vladislavbelov created P259 Script to normalize AO textures.
Fri, Dec 3, 7:24 AM

Yesterday

Vulcan added a comment to D4354: Adds more flexible dependencies to options.

Successful build - Chance fights ever on the side of the prudent.

Thu, Dec 2, 8:27 PM
Vulcan added a comment to D4354: Adds more flexible dependencies to options.

Successful build - Chance fights ever on the side of the prudent.

Thu, Dec 2, 8:24 PM
vladislavbelov updated the diff for D4354: Adds more flexible dependencies to options.

Fixes linter.

Thu, Dec 2, 8:19 PM
Freagarach requested review of D4360: Put the formation-selection feature behind a config..
Thu, Dec 2, 6:48 PM
Stan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Freagarach is right, https://stackoverflow.com/questions/8044750/javascript-performance-difference-between-double-equals-and-triple-equals

Thu, Dec 2, 4:08 PM

Wed, Dec 1

Freagarach requested changes to D4356: Check for squaredRange being negative.

BuildingAI
But I'd rather have D3249.

Wed, Dec 1, 8:23 PM
Freagarach added a comment to D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].

You'll need to rebase this after number 1, so you can wait to implement these changes.

Wed, Dec 1, 8:04 PM
Freagarach accepted D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].
  • Code looks good, greps compleat.
  • Nice change: improves readability.
  • Tested some (~5) games, neither warnings/errors, nor strange behaviour.
Wed, Dec 1, 6:45 PM
Freagarach added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

We don't need enums, thats correct.
But they help when changing strings/values to make change only on one place.

=== checks also for variable type and therefore is slower than == how is this helpful here?
We assign to those variables only enums, do we need to care about the type?

According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness with == the values are converted before checking so that might actually be slower.

Wed, Dec 1, 6:25 PM
Silier added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

We don't need enums, thats correct.
But they help when changing strings/values to make change only on one place.

Wed, Dec 1, 5:56 PM
Freagarach added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

We don't _need_ it. :) Nor do we _need_ enums.
But it is nice to have when checking enums, IMHO.

Wed, Dec 1, 5:49 PM
Silier added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Why do we need strict checking? == is totally sufficient here.

Wed, Dec 1, 5:47 PM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 5:43 PM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 5:41 PM
Freagarach updated the diff for D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Some minor changes.

Wed, Dec 1, 5:35 PM
Stan added a comment to D4244: Forbids using more than 64 bones for GPU skinning.
Wed, Dec 1, 2:15 PM
Vulcan added a comment to D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 1:52 PM
Vulcan added a comment to D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 1:49 PM
vladislavbelov added a comment to D2440: Per-Unit Discrete LOD using actor quality levels.

@Stan @vladislavbelov do you know if anyone plans to work on this?

Wed, Dec 1, 1:45 PM
JCWasmx86 updated the diff for D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].
Wed, Dec 1, 1:43 PM
vladislavbelov added a comment to D3475: General improvements to 0ad.desktop.

Any decision regarding inclusion to master whether we agree and thus it is committable or disagree?

Wed, Dec 1, 1:42 PM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 1:31 PM
Vulcan added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Successful build - Chance fights ever on the side of the prudent.

Wed, Dec 1, 1:26 PM
JCWasmx86 updated the diff for D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Replaced the "=="/"!=" with "===" or "!==".

Wed, Dec 1, 1:19 PM
asterix added a comment to D2440: Per-Unit Discrete LOD using actor quality levels.

@Stan @vladislavbelov do you know if anyone plans to work on this?

Wed, Dec 1, 1:09 PM
asterix added a comment to D3475: General improvements to 0ad.desktop.

Any decision regarding inclusion to master whether we agree and thus it is committable or disagree?

Wed, Dec 1, 1:06 PM
Freagarach added a comment to D4334: [PetraAI] - Use enum-like variables instead of magic values. [1/n].

Use strict checks (===) for comparison with enums and we're good to go.

Wed, Dec 1, 8:21 AM
Freagarach added a comment to D4343: [PetraAI] - Use enum-like variables instead of magic values. [2/n].

I think after this pass (change == to ===) this is ready for commit.

Wed, Dec 1, 7:58 AM
autobuild committed rP26027: [Windows] Automated build..
[Windows] Automated build.
Wed, Dec 1, 6:41 AM

Tue, Nov 30

Stan added inline comments to D4359: Fix Alt Tab For SDL > 2.0.12.
Tue, Nov 30, 7:44 PM
Freagarach accepted rP26023: Drops custom utf16 string implementation (from rP684), uses C++11 one..

r26026 Fixes my reported issue.

Tue, Nov 30, 7:06 PM
vladislavbelov requested verification of rP26023: Drops custom utf16 string implementation (from rP684), uses C++11 one..
Tue, Nov 30, 7:04 PM
vladislavbelov committed rP26026: Fixes without PCH build after rP26023..
Fixes without PCH build after rP26023.
Tue, Nov 30, 7:04 PM
Freagarach added inline comments to D4359: Fix Alt Tab For SDL > 2.0.12.
Tue, Nov 30, 6:59 PM
Stan added inline comments to D4359: Fix Alt Tab For SDL > 2.0.12.
Tue, Nov 30, 6:58 PM
Freagarach added a comment to D4359: Fix Alt Tab For SDL > 2.0.12.

Works for me. (libsdl2-dev: 2.0.16)

Tue, Nov 30, 5:23 PM
Freagarach added a comment to rP26023: Drops custom utf16 string implementation (from rP684), uses C++11 one..

I suppose without PCH on Linux? Because on Windows it works.

Aye.

Tue, Nov 30, 4:30 PM
Stan requested review of D4359: Fix Alt Tab For SDL > 2.0.12.
Tue, Nov 30, 12:02 PM
vladislavbelov requested review of D4358: Reorganizes GL context creation in VideoMode.
Tue, Nov 30, 11:41 AM
Stan created P257 Fix for Windows 10 SDK.
Tue, Nov 30, 11:28 AM
Stan added a comment to rP26023: Drops custom utf16 string implementation (from rP684), uses C++11 one..

Was pulling <algorithm> from utf16string.h can you try adding it to that file @Freagarach?

Tue, Nov 30, 10:55 AM
vladislavbelov added a comment to rP26023: Drops custom utf16 string implementation (from rP684), uses C++11 one..
KeyName.cpp
../../../source/ps/KeyName.cpp: In function ‘SDL_Scancode FindScancode(const CStr8&)’:
../../../source/ps/KeyName.cpp:92:22: error: ‘find_if’ is not a member of ‘std’
   92 |                 std::find_if(scancodemap.begin(), scancodemap.end(), [&keyname](const std::pair<int, std::vector<CStr>>& names) {
      |                      ^~~~~~~
../../../source/ps/KeyName.cpp: In lambda function:
../../../source/ps/KeyName.cpp:93:37: error: ‘find_if’ is not a member of ‘std’
   93 |                         return std::find_if(names.second.begin(), names.second.end(), [&keyname](const CStr& t) {
      |                                     ^~~~~~~
make[1]: *** [engine.make:352: obj/engine_Release/KeyName.o] Error 1
make: *** [Makefile:117: engine] Error 2
Tue, Nov 30, 10:51 AM
Freagarach raised a concern with rP26023: Drops custom utf16 string implementation (from rP684), uses C++11 one..
KeyName.cpp
../../../source/ps/KeyName.cpp: In function ‘SDL_Scancode FindScancode(const CStr8&)’:
../../../source/ps/KeyName.cpp:92:22: error: ‘find_if’ is not a member of ‘std’
   92 |                 std::find_if(scancodemap.begin(), scancodemap.end(), [&keyname](const std::pair<int, std::vector<CStr>>& names) {
      |                      ^~~~~~~
../../../source/ps/KeyName.cpp: In lambda function:
../../../source/ps/KeyName.cpp:93:37: error: ‘find_if’ is not a member of ‘std’
   93 |                         return std::find_if(names.second.begin(), names.second.end(), [&keyname](const CStr& t) {
      |                                     ^~~~~~~
make[1]: *** [engine.make:352: obj/engine_Release/KeyName.o] Error 1
make: *** [Makefile:117: engine] Error 2
Tue, Nov 30, 10:46 AM
autobuild committed rP26025: [Windows] Automated build..
[Windows] Automated build.
Tue, Nov 30, 6:57 AM

Mon, Nov 29

vladislavbelov committed rP26024: Removes unused/not implemented hooks from AppHooks. Refs rP13724..
Removes unused/not implemented hooks from AppHooks. Refs rP13724.
Mon, Nov 29, 7:22 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Successful build - Chance fights ever on the side of the prudent.

Mon, Nov 29, 6:46 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Successful build - Chance fights ever on the side of the prudent.

Mon, Nov 29, 6:43 PM
Freagarach updated the diff for D4349: Fix infinite loop when queuing a gather order after garrison..

Don't query cmpTurretable twice.

Mon, Nov 29, 6:38 PM
Stan added inline comments to D4349: Fix infinite loop when queuing a gather order after garrison..
Mon, Nov 29, 6:09 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Successful build - Chance fights ever on the side of the prudent.

Mon, Nov 29, 6:07 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Successful build - Chance fights ever on the side of the prudent.

Mon, Nov 29, 6:01 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Build failure - The Moirai have given mortals hearts that can endure.

Mon, Nov 29, 5:59 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Build failure - The Moirai have given mortals hearts that can endure.

Mon, Nov 29, 5:56 PM
Freagarach updated the diff for D4349: Fix infinite loop when queuing a gather order after garrison..

Fix test.

Mon, Nov 29, 5:56 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Successful build - Chance fights ever on the side of the prudent.

Mon, Nov 29, 5:51 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Build failure - The Moirai have given mortals hearts that can endure.

Mon, Nov 29, 5:50 PM
Freagarach updated the diff for D4349: Fix infinite loop when queuing a gather order after garrison..

Inline IsTurret.

Mon, Nov 29, 5:45 PM
Vulcan added a comment to D4357: Fix Trainer/Researcher without entities/techs..

Successful build - Chance fights ever on the side of the prudent.

Mon, Nov 29, 5:43 PM
Freagarach added inline comments to D4349: Fix infinite loop when queuing a gather order after garrison..
Mon, Nov 29, 5:40 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Successful build - Chance fights ever on the side of the prudent.

Mon, Nov 29, 5:38 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Build failure - The Moirai have given mortals hearts that can endure.

Mon, Nov 29, 5:34 PM
Stan added inline comments to D4349: Fix infinite loop when queuing a gather order after garrison..
Mon, Nov 29, 5:33 PM
Freagarach updated the diff for D4349: Fix infinite loop when queuing a gather order after garrison..

Fix missing ).

Mon, Nov 29, 5:32 PM
Stan added a comment to D4108: Adds FreeType support to the engine.

@Langbart can you try again? :)

Mon, Nov 29, 5:31 PM
Vulcan added a comment to D4357: Fix Trainer/Researcher without entities/techs..

Successful build - Chance fights ever on the side of the prudent.

Mon, Nov 29, 5:30 PM
Freagarach added inline comments to D4349: Fix infinite loop when queuing a gather order after garrison..
Mon, Nov 29, 5:29 PM
Freagarach added a comment to D4108: Adds FreeType support to the engine.

Compiles fine and runs on Debian Sid ("freetype": "2.11.0" reported, as is installed).

Mon, Nov 29, 5:28 PM
Freagarach updated the diff for D4357: Fix Trainer/Researcher without entities/techs..

Add test.
Fix comment from @Stan.

Mon, Nov 29, 5:14 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Build failure - The Moirai have given mortals hearts that can endure.

Mon, Nov 29, 5:10 PM
Vulcan added a comment to D4349: Fix infinite loop when queuing a gather order after garrison..

Build failure - The Moirai have given mortals hearts that can endure.

Mon, Nov 29, 5:06 PM
Stan added inline comments to D4349: Fix infinite loop when queuing a gather order after garrison..
Mon, Nov 29, 5:05 PM
Freagarach updated the diff for D4349: Fix infinite loop when queuing a gather order after garrison..

Fix more properly.

Mon, Nov 29, 4:58 PM
Silier awarded rP26023: Drops custom utf16 string implementation (from rP684), uses C++11 one. a Love token.
Mon, Nov 29, 1:16 PM
vladislavbelov added a comment to D4223: Drop custom utf16 string implementation.
In D4223#185614, @sera wrote:

Go ahead

Thanks

Mon, Nov 29, 1:11 PM
vladislavbelov committed rP26023: Drops custom utf16 string implementation (from rP684), uses C++11 one..
Drops custom utf16 string implementation (from rP684), uses C++11 one.
Mon, Nov 29, 1:11 PM
vladislavbelov closed D4223: Drop custom utf16 string implementation.
Mon, Nov 29, 1:11 PM
sera added a comment to D4223: Drop custom utf16 string implementation.

Go ahead

Mon, Nov 29, 12:55 PM
Silier added a comment to rP25123: Technically seperate Turrets from GarrisonHolder..

Also performance is not the question since number of messages for turreted is just subset of original number of messages from garrisoned.
Only additional cost are extra variables but amount of data is not affected.

Mon, Nov 29, 12:49 PM
vladislavbelov added a comment to D4223: Drop custom utf16 string implementation.
In D4223#185612, @sera wrote:

"Ralph Sennhauser <ralph.sennhauser@gmail.com>", if nick is required "sera" is fine.

Thank you. We don't use email in the list, so it'll be: { "nick": "sera", "name": "Ralph Sennhauser" }.

Mon, Nov 29, 12:43 PM
Silier added a comment to rP25123: Technically seperate Turrets from GarrisonHolder..

Its not complete now.
If someone would want to use it, they would need to update proxy and other stuff in common api.

Mon, Nov 29, 12:31 PM
sera added a comment to D4223: Drop custom utf16 string implementation.

"Ralph Sennhauser <ralph.sennhauser@gmail.com>", if nick is required "sera" is fine.

Mon, Nov 29, 11:46 AM
vladislavbelov added a comment to D4223: Drop custom utf16 string implementation.

Whom I should mention in credits (programming.json)?

Mon, Nov 29, 9:30 AM
autobuild committed rP26022: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Mon, Nov 29, 9:17 AM

Sun, Nov 28

Vulcan added a comment to D4108: Adds FreeType support to the engine.

Successful build - Chance fights ever on the side of the prudent.

Sun, Nov 28, 11:31 PM
Vulcan added a comment to D4108: Adds FreeType support to the engine.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Nov 28, 11:25 PM