Can you tell me which is which? :D

This indeed solves the oversharp problem of the terrain texture previews. Although I suppose it's highly dependant on texture resolution but is definitely is an improvement

Looks way better, i vote commit.

Also D4009 would be pretty great to have along this patch if @Langbart finds time/motivation for it. Because then users can change lobby colors / settings from within the lobby, too. And #6418 is kind of an issue too, with or without the patch (idk c++ so i can't)

All of those issues stem from poor civ designs, honestly. This one diff can't address all of that.

So the archery range is a building where Spartans, Mauryas and Romans can train exactly 1 unit.

Read more into it, I think:

• the selectable split is worthwhile
• Only models have props and adding that logic to ModelAbstract slows other implementations down, which is bad. Instead, a CCompositeObject that's prop-aware should probably exist, inherited by CModel. This would clean the interface there a bit.
• The main characteristic of CModelAbstract is that it can have a parent & can be casted to its subtype. These two behaviour can perhaps again be split.

Is ele/walrus included in fauna? If so this would impact luring. I think that’s a nice little wrinkle to normal gameplay (but not perfect). I wouldn’t be devastated if it disappeared, though

I'm generally in favor, animals should be outposts, but I feel like the aggressive need a bigger vision range to attack more "naturally". Something like 30?

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

working version of the mixins

@wowgetoffyourcellphone

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Rebase. I believe this diff still makes a lot of sense, need to dig a little deeper in the summary questions.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

just to save some WIP.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Run the AI at turn's end. I had accidentally ran it after paths start computing which is obviously buggy since the state musn't change.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

@Silier I don't have a strong opinion about it. It can now be explained in the new lobby colors menu, if it stays. Though it seems like my current explanation for it is wrong (options.json L639), and that still requires some steps before the user sees that. What do you prefer yourself?

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

while on the topic, it could be considered to drop waiting colour
#4752

remove debug code.

Fix the diff.

Fix the diff.

Successful build - Chance fights ever on the side of the prudent.

Did you thread some stuff eventually?

More number tweaking. I'm rather happy with how this currently looks & feels.
This splits the new 'spread' factor in a static & a moving version, so that moving units push farther but less strongly so. Helps with the movement in general I think.

@Freagarach will you commit this?

In D4438#189834, @asterix wrote:

You mean today

I certainly don't mean today, since I'm AFK the rest of the day. :)

In D4438#189832, @Freagarach wrote:

(I'll aim to commit this this week unless objected.)

(I'll aim to commit this this week unless objected.)

(I don't want to change anything that might be functional with this move. xD)

I like this idea too, hopefully we can get fattening like in aoe3.

Looks like this has broad appeal. Anyone wish to Accept Revision?

In D4385#189800, @asterix wrote:

you can also ask users/players on forums for more feedback and testing

you can also ask users/players on forums for more feedback and testing

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

• Reduced max characters for a game name to 100 from 256.
• Unrated players are not 1200 rating by default anymore but 0, and they are not included into calculating the avg. rating of the game (g_DefaultLobbyRating doesn't affect the actual rating afaik?).
• Mods like "custom rating" caused wrong avg gamerating calculation. Fixed while keeping mods like that compatible.
• Games in gamelist that only have unrated players will not show the avg rating.
• Fix for playername tooltip in gamedetails in case of unknown civ.
• Appended buddysymbol to playernames in chat if buddy.
• Made chat messages text lightgray.
• Users can customize the symbol of status and buddies to a letter/number/symbol of their choosing in the main menu -> networking / lobby.
• Users can customize the colors of the following elements in the main menu -> lobby colors:

In D4444#189779, @Langbart wrote:

In D4444#189777, @asterix wrote:

@Langbart @Freagarach can you test this?

its wip

In D4444#189777, @asterix wrote:

@Langbart @Freagarach can you test this?

@Langbart @Freagarach can you test this?

This may have sped up the loading, but now the previews are very aliased and difficult to use.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Ran the template-updating script.

Think that makes sense.

Fixes the issue.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Reduce scope-creep a bit. (Don't call ResearchTechnology on replacements.)

In rP26215#55398, @wraitii wrote:

Only seems to happen with this combination of settings.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Perform actions in the Finish function.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

style update

In D4294#189672, @Freagarach wrote:

If we look at the UnitAI function, it will always at least return [], taking the zeroth index of that results in undefined; that is what cmpFormationUnitAI.GetTargetPositions()[0] returns.

my bad, I thought it would default to
https://github.com/0ad/0ad/blob/e27eb2200ae9ad75e775fed9832b26ff646547b9/binaries/data/mods/public/simulation/components/UnitAI.js#L5264

Should we have more tests in test_formation.js?

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.