Page MenuHomeWildfire Games
Feed All Stories

Today

Vulcan added a comment to D1346: List multiselection.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 10:26 PM
Harbormaster failed remote builds in B9487: Diff 9872 for D1346: List multiselection!
Thu, Sep 19, 10:24 PM
Vulcan added a comment to D1346: List multiselection.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 10:24 PM
Angen updated the diff for D1346: List multiselection.

something is wrong with olistsingle, olistmultiple

Thu, Sep 19, 10:22 PM
Vulcan added a comment to D2207: Adds a function to pick entities with obstructions on screen.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 9:52 PM
Harbormaster failed remote builds in B9486: Diff 9871 for D2207: Adds a function to pick entities with obstructions on screen!
Thu, Sep 19, 9:52 PM
Vulcan added a comment to D2207: Adds a function to pick entities with obstructions on screen.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 9:52 PM
vladislavbelov updated the diff for D2207: Adds a function to pick entities with obstructions on screen.
Thu, Sep 19, 9:48 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 9:40 PM
Freagarach added inline comments to D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 9:23 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 9:22 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 9:17 PM
Harbormaster failed remote builds in B9485: Diff 9870 for D2305: more gui/manual/intro.txt improvements!
Thu, Sep 19, 9:17 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 9:17 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 9:16 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 9:16 PM
Freagarach added inline comments to D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 9:02 PM
Vulcan added a comment to D2307: improve default.cfg comments.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 9:02 PM
Harbormaster failed remote builds in B9484: Diff 9869 for D2307: improve default.cfg comments!
Thu, Sep 19, 9:02 PM
Vulcan added a comment to D2307: improve default.cfg comments.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 9:01 PM
Nescio created D2307: improve default.cfg comments.
Thu, Sep 19, 9:00 PM
vladislavbelov added inline comments to D1763: Removes duplication of Clamp function.
Thu, Sep 19, 8:53 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

The changes in this diff arent so worthy for concern if it wasnt a pattern to ignore default.cfg that had led to many mistakes before that would have been found if carefully compared and always cosidered.

Isn't it actually more of a problem that people change keys in the default.cfg file but forget to update the intro.txt file?

Thu, Sep 19, 8:39 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 8:36 PM
elexis added a comment to D2305: more gui/manual/intro.txt improvements.
Why describe different behavior for the same hotkey in different places?

Well I described the problem already multiple times. Some sentence mentions that the page is "shown", other places mention that the page is "toggled". I didn't know that the civ dialog should be able to toggle and even committed a bug changing the behavior that way without noticing (D2273), and default.cfg still says

structree = "Alt+Shift+T" ; Show structure tree
civinfo = "Alt+Shift+H" ; Show civilization info

while you propose to change it in Intro.txt to:

Alt + Shift + T – Toggle the “Structure Tree” window
Alt + Shift + H – Toggle the “Civilizations” (“History”) window

Thu, Sep 19, 8:32 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 8:27 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 8:26 PM
Harbormaster failed remote builds in B9482: Diff 9867 for D2305: more gui/manual/intro.txt improvements!
Thu, Sep 19, 8:25 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 8:25 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 8:25 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

By the way, shouldn't there be a hotkey to open the Manual?

Thu, Sep 19, 8:20 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

Why change anticlockwise to counterclockwise in one file but not in the other?
There actually was no argument provided why it was right to change the string in D1744, but I suppose it's because the word is more common, regardless whether you're a developer or player.

The reason is “anticlockwise” is English and “counterclockwise” is American. Spelling and vocabulary differences matter for translations, but not really for comments in code.

Why changing building to structure in one file but not the other?

Well, I suppose I could change that and similar things in the default.cfg too, but I still think it would be better to do that in a separate patch.

Why describe different behavior for the same hotkey in different places?

?

Thu, Sep 19, 8:14 PM
elexis added a comment to D2305: more gui/manual/intro.txt improvements.

Why change anticlockwise to counterclockwise in one file but not in the other?
There actually was no argument provided why it was right to change the string in D1744, but I suppose it's because the word is more common, regardless whether you're a developer or player.
It was an exact copy of the same sentence, so I don't see why one of the files would just not be updated when we already can identify the location quickly inside the known file.
Why changing building to structure in one file but not the other?
Why describe different behavior for the same hotkey in different places?
The argument at least applies to all of the sentences changed in this diff.

Thu, Sep 19, 7:48 PM
Vulcan added a comment to D2306: remove "Goods" from trade window stings.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 7:35 PM
Vulcan added a comment to D2306: remove "Goods" from trade window stings.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 7:35 PM
Harbormaster failed remote builds in B9481: Diff 9866 for D2306: remove "Goods" from trade window stings!
Thu, Sep 19, 7:35 PM
Nescio created D2306: remove "Goods" from trade window stings.
Thu, Sep 19, 7:34 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 7:21 PM
Harbormaster failed remote builds in B9480: Diff 9865 for D2305: more gui/manual/intro.txt improvements!
Thu, Sep 19, 7:21 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 7:21 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
  • put window names inside quotation marks
Thu, Sep 19, 7:20 PM
Harbormaster failed remote builds in B9479: Diff 9864 for D2305: more gui/manual/intro.txt improvements!
Thu, Sep 19, 7:14 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 7:14 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 7:14 PM
Vulcan added a comment to D1346: List multiselection.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 7:13 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

One example, default.cfg has:

screenshot = F2                          ; Take PNG screenshot
bigscreenshot = "Shift+F2"               ; Take large BMP screenshot

and intro.txt has:

F2 – Take screenshot (in .png format, location is displayed in the top left of the GUI after the file has been saved, and can also be seen in the console/logs if you miss it there)
Shift + F2 – Take huge screenshot (6400×4800 pixels, in .bmp format, location is displayed in the top left of the GUI after the file has been saved, and can also be seen in the console/logs if you miss it there)

In my honest opinion neither replacing the concise former with the verbose former nor vice versa would be an improvement.

Thu, Sep 19, 7:13 PM
Harbormaster failed remote builds in B9478: Diff 9863 for D1346: List multiselection!
Thu, Sep 19, 7:12 PM
Vulcan added a comment to D1346: List multiselection.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 7:12 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 7:11 PM
Angen planned changes to D1346: List multiselection.
Thu, Sep 19, 7:11 PM
Angen updated the diff for D1346: List multiselection.

Single, Multiple class design
Not synchronised with js
OList is Single for now

Thu, Sep 19, 7:10 PM
elexis requested changes to D2305: more gui/manual/intro.txt improvements.
In D2305#96247, @Nescio wrote:

The same changes should be applied to default.cfg in the same patch I suppose?

  • it includes many other settings not in the manual
  • it doesn't list many of the manual entries (esp. those that involve clicking or specify multiple cases)
  • completely different order
  • different format ("code = key ; comment" instead of "key: function")

These points are irrelevant to the argument that the sentences are the exact same in both places, targetted at the same reader, expressing the same information, the patch proposing to correct or improve that information based on an argument that applies to the instances of the sentence alike; fixing one instance of the sentences because its better but then leaving the other copies of the sentences with the less correct or less accurate information.

Thu, Sep 19, 6:51 PM
Nescio added inline comments to D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 6:36 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 6:31 PM
Harbormaster failed remote builds in B9475: Diff 9860 for D2305: more gui/manual/intro.txt improvements!
Thu, Sep 19, 6:30 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 6:30 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 6:29 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

That was the part that I was wondering about in D2273.

Yes, I saw your post there today, which prompted me to change it again in this patch.

Thu, Sep 19, 6:08 PM
Nescio added a comment to D2305: more gui/manual/intro.txt improvements.

The same changes should be applied to default.cfg in the same patch I suppose?

Actually I had a look at the binaries/data/config/default.cfg file, but quickly noticed it's too different from the gui/manual/intro.txt file:

  • it includes many other settings not in the manual
  • it doesn't list many of the manual entries (esp. those that involve clicking or specify multiple cases)
  • completely different order
  • different format ("code = key ; comment" instead of "key: function")
  • file is for developers, does not really contain user-facing text strings
  • already out of sync prior to D1719

Taking everything together, I concluded it's too much work and not really necessarily a good idea to update the default.cfg to match the intro.txt file.

Thu, Sep 19, 5:57 PM
elexis added a comment to D2305: more gui/manual/intro.txt improvements.

The same changes should be applied to default.cfg in the same patch I suppose?

Thu, Sep 19, 5:25 PM
elexis added a comment to rP22060: manual/intro.txt corrections.

intro.txt, default.cfg and HotKeys should be kept in sync

Thu, Sep 19, 5:24 PM
Freagarach added inline comments to D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 5:15 PM
Angen accepted D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

Builds, tests passed, jenkins tests are ok, feature looks good, I do not see more problems in code

Thu, Sep 19, 5:06 PM
Freagarach added inline comments to D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 5:03 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 2:58 PM
Harbormaster failed remote builds in B9474: Diff 9859 for D2305: more gui/manual/intro.txt improvements!
Thu, Sep 19, 2:58 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 2:58 PM
Nescio updated the diff for D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 2:57 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 2:57 PM
Angen added a comment to D2304: Delete GUI.h umbrella include.

builds in debug and without pch release

Thu, Sep 19, 2:56 PM
Harbormaster failed remote builds in B9473: Diff 9858 for D2305: more gui/manual/intro.txt improvements!
Thu, Sep 19, 2:55 PM
Vulcan added a comment to D2305: more gui/manual/intro.txt improvements.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 2:55 PM
Nescio created D2305: more gui/manual/intro.txt improvements.
Thu, Sep 19, 2:53 PM
Vulcan added a comment to D825: Atlas: Allow map to recenter during resize.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 2:52 PM
elexis added a comment to D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues..
In D2295#96153, @elexis wrote:

Moving hotkey.js hotkey.xml into a new hotkey folder would allow future GUI test pages to be distinguished, like we have in public/gui/ and mod/gui/. (Current directory contents gui_page.rng gui.rng hotkey.js hotkey.xml page_hotkey.xml)

Ah, I think I understand why - you mean that we can have different schemas then, correct?

Thu, Sep 19, 2:37 PM
Vulcan added a comment to D825: Atlas: Allow map to recenter during resize.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 2:34 PM
Stan updated the diff for D825: Atlas: Allow map to recenter during resize.
  • Add missing wxUnused(evt) to fix the warning reported by @Angen
  • Add a missing include to fix "There is an unknown macro here somewhere. Configuration is required. If BEGIN_EVENT_TABLE is a macro then please configure it." from CPPCHECK
Thu, Sep 19, 2:30 PM
Vulcan added a comment to D825: Atlas: Allow map to recenter during resize.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 2:07 PM
Angen added a comment to D825: Atlas: Allow map to recenter during resize.

From Debug build

Thu, Sep 19, 1:57 PM
Vulcan added a comment to D825: Atlas: Allow map to recenter during resize.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 1:46 PM
Vulcan added a comment to D825: Atlas: Allow map to recenter during resize.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 1:25 PM
Vulcan added a comment to D825: Atlas: Allow map to recenter during resize.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 1:14 PM
Stan updated the diff for D825: Atlas: Allow map to recenter during resize.

Fix broken indent on brace.

Thu, Sep 19, 1:10 PM
Harbormaster failed remote builds in B9467: Diff 9852 for D825: Atlas: Allow map to recenter during resize!
Thu, Sep 19, 1:07 PM
Vulcan added a comment to D825: Atlas: Allow map to recenter during resize.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Sep 19, 1:07 PM
Stan updated the diff for D825: Atlas: Allow map to recenter during resize.

Add missing final newlines.

Thu, Sep 19, 1:05 PM
Vulcan added a comment to D825: Atlas: Allow map to recenter during resize.

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 1:05 PM
Stan updated the diff for D825: Atlas: Allow map to recenter during resize.

Rebase + Context

Thu, Sep 19, 1:01 PM
Stan added a comment to D2304: Delete GUI.h umbrella include.

Can any of this includes be replaced by a forward include ?

Thu, Sep 19, 11:54 AM
Stan added inline comments to rP22767: Add a system component to handle stat modifiers, make technologies and auras….
Thu, Sep 19, 11:50 AM
Angen added a comment to D2304: Delete GUI.h umbrella include.

I see two cases when to add header to precompiled.

  1. It is included in a lot of files ( what means more than 15 with small files)
  2. It is big file in terms of code and other includes and is used more than 5 times.
Thu, Sep 19, 11:45 AM
vladislavbelov added a comment to D2304: Delete GUI.h umbrella include.

The patch looks good to me. Though I didn't test it.

Thu, Sep 19, 9:22 AM
Vulcan added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 9:04 AM
Vulcan added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 9:02 AM
Freagarach updated the diff for D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

Rebased.

Thu, Sep 19, 9:00 AM
wraitii added a comment to D2295: Improve js glue code in D1839/rP22909 (hotkey state fix) and deal with rebase issues..
In D2295#96153, @elexis wrote:

Sorry that I was too lazy to review the original patch, one needs to know the circumstances of the hotkey code which takes some time to get back into again.

TBH that's fine. Your time, like mine, is limited. You'll never have the time to really look at everything in advance, but if you look at what gets committed that optimises your time and the code still gets to where it needs to be.
Indeed this patch was fairly tricky, I too had to dive deep again before committing because I'd forgotten why it worked.

Thu, Sep 19, 8:51 AM
Vulcan added a comment to D2281: [WIP] - Status Effects v2 - More cleanup, allow modifiers..

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 8:36 AM
Vulcan added a comment to D2281: [WIP] - Status Effects v2 - More cleanup, allow modifiers..

Successful build - Chance fights ever on the side of the prudent.

Thu, Sep 19, 8:33 AM
Freagarach updated the diff for D2281: [WIP] - Status Effects v2 - More cleanup, allow modifiers..

INVALID_ENTITY, INVALID_PLAYER.

Thu, Sep 19, 8:31 AM
autobuild committed rP22932: [Windows] Automated build..
[Windows] Automated build.
Thu, Sep 19, 7:28 AM