Page MenuHomeWildfire Games
Feed All Stories

Today

Stan added members for Contributors: defc0n, Baelish.
Fri, Feb 23, 8:37 AM
Stan added a reviewer for D5247: Error 6605: marder.
Fri, Feb 23, 8:36 AM
Feldfeld added a comment to D5247: Error 6605.

It is good if the base placer is more flexible.
That said, in my opinion, it should not be expected of every random map to support the most extreme settings. So if an hypothetical random map that typically has 75% its total area impassable is generated in 4v4 tiny and fails to place some features... It's fine in my opinion.
What should be done imo is that in the game settings screen, if the configuration is deemed too extreme, then a warning should appear (I'm not referring to the console but something integrated to the game settings UI) but the user should be allowed to launch the game anyway. Then if the base placer fails to place some features, it should not show an error, at best a warning (possibly more generic, appearing once, saying not everything has been placed).

Fri, Feb 23, 6:57 AM
Baelish added a comment to D5247: Error 6605.
In D5247#223294, @sera wrote:

Thanks for the rational, tho the idea was to update the summary at the top of this web page. The summary is what the commit message should be based on.

Fri, Feb 23, 1:16 AM

Yesterday

sera added a comment to D5247: Error 6605.

Thanks for the rational, tho the idea was to update the summary at the top of this web page. The summary is what the commit message should be based on.

Thu, Feb 22, 11:22 PM
Baelish updated the diff for D5247: Error 6605.

respect coding convention

Thu, Feb 22, 10:19 PM
Baelish updated the diff for D5247: Error 6605.

The basic idea for animals, berries and mines is to map the entire area surrounding the base in polar coordinates. Integer rages are taken between a minimum and a maximum radius (integers because greater precision is useless and increases the number of points to be calculated, making it slower) and an angle between 0 and 360 (in the code is in radiant) with an interval of 1 degree. In this way we will have 360 times n non-random attempts and we will be certain of finding a place in any situation. The program places the resource as soon as it finds space: for animals it starts from the smaller radius 5 (up to 12), for berries and mines from the larger one 12 (up to 7) and then scales up. This choice was made to minimize the number of attempts and reduce calculations: in the external radius it is more likely to have space, while in the internal one there is no difficulty in placing the animals, which take up less space.

Thu, Feb 22, 7:15 PM
sera added a comment to D5247: Error 6605.

I did not remove old parts, so i took them as comments

Thu, Feb 22, 6:37 PM
Baelish requested review of D5247: Error 6605.
Thu, Feb 22, 5:41 PM
sera added inline comments to D5240: Atlas Actor Viewer Toggle 3d.
Thu, Feb 22, 10:32 AM
luciasmith561 updated luciasmith561.
Thu, Feb 22, 10:01 AM
Vulcan added a comment to D5240: Atlas Actor Viewer Toggle 3d.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Feb 22, 8:50 AM
Vulcan added a comment to D5240: Atlas Actor Viewer Toggle 3d.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Feb 22, 8:06 AM
Vulcan added a comment to D5240: Atlas Actor Viewer Toggle 3d.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Feb 22, 8:02 AM
Boston_Brooks updated the diff for D5240: Atlas Actor Viewer Toggle 3d.

ScenarioEditor::ProjectionType
no longer "mirrors"
CCamera::ProjectionType.
There are no longer any changes to Camera.h
A switch statement is used to convert enum to int to enum.

Thu, Feb 22, 8:00 AM
providentbotanico updated providentbotanico.
Thu, Feb 22, 4:20 AM

Wed, Feb 21

Vulcan added a comment to D5220: Allow to use a generator as MapGenerator.

Successful build - Chance fights ever on the side of the prudent.

Wed, Feb 21, 10:30 PM
Vulcan added a comment to D5220: Allow to use a generator as MapGenerator.

Successful build - Chance fights ever on the side of the prudent.

Wed, Feb 21, 8:18 PM
phosit updated the diff for D5220: Allow to use a generator as MapGenerator.

Use an Error.
Make it less branchy.
Move RunGenerator to ScriptFunction.
Prevent the "printing" from rmlib.

Wed, Feb 21, 8:13 PM
Vulcan added a comment to D5239: Use std::function instead of inhereting from CNetFileReceiveTask.

Successful build - Chance fights ever on the side of the prudent.

Wed, Feb 21, 3:21 PM
Vulcan added a comment to D5239: Use std::function instead of inhereting from CNetFileReceiveTask.

Successful build - Chance fights ever on the side of the prudent.

Wed, Feb 21, 1:58 PM
Stan added inline comments to D5239: Use std::function instead of inhereting from CNetFileReceiveTask.
Wed, Feb 21, 1:56 PM
phosit updated the diff for D5239: Use std::function instead of inhereting from CNetFileReceiveTask.

Add a test.
Use KiB more and include it's header.

Wed, Feb 21, 1:55 PM
phosit added inline comments to D5239: Use std::function instead of inhereting from CNetFileReceiveTask.
Wed, Feb 21, 1:49 PM
Vulcan added a comment to D5236: Remove the StateSet from FSM.

Successful build - Chance fights ever on the side of the prudent.

Wed, Feb 21, 12:04 PM
Vulcan added a comment to D5236: Remove the StateSet from FSM.

Successful build - Chance fights ever on the side of the prudent.

Wed, Feb 21, 10:54 AM
phosit updated the diff for D5236: Remove the StateSet from FSM.

Copyright year in NetServer.cpp

Wed, Feb 21, 10:51 AM

Tue, Feb 20

Vulcan added a comment to D5236: Remove the StateSet from FSM.

Successful build - Chance fights ever on the side of the prudent.

Tue, Feb 20, 9:28 PM
Vulcan added a comment to D5236: Remove the StateSet from FSM.

Successful build - Chance fights ever on the side of the prudent.

Tue, Feb 20, 8:07 PM
phosit updated the diff for D5236: Remove the StateSet from FSM.
Tue, Feb 20, 8:02 PM
marder added a comment to D5220: Allow to use a generator as MapGenerator.

@marder Should TERRAIN_TILE_SIZE and MAP_BORDER_WIDTH also be passed as an argument to the generator?

Tue, Feb 20, 7:30 PM
Vulcan added a comment to D5236: Remove the StateSet from FSM.

Build failure - The Moirai have given mortals hearts that can endure.

Tue, Feb 20, 7:15 PM
Vulcan added a comment to D5236: Remove the StateSet from FSM.

Build failure - The Moirai have given mortals hearts that can endure.

Tue, Feb 20, 7:09 PM
phosit updated the diff for D5236: Remove the StateSet from FSM.

Include set in NetServer.cpp

Tue, Feb 20, 7:08 PM
phosit added a comment to D5220: Allow to use a generator as MapGenerator.

@marder Should TERRAIN_TILE_SIZE and MAP_BORDER_WIDTH also be passed as an argument to the generator?

Tue, Feb 20, 6:50 PM
phosit added a comment to D5240: Atlas Actor Viewer Toggle 3d.

Is ScenarioEditor::ProjectionType::CUSTOM even used?

Tue, Feb 20, 5:48 PM
Stan added a comment to D5244: Adds a hack to detect missing SPIR-V mod for SVN.

So what happens here exactly when it cannot find the shader file?

Tue, Feb 20, 7:55 AM
Boston_Brooks added a comment to D5240: Atlas Actor Viewer Toggle 3d.

"Mirroring" a type (union) is bad. I don't have a better solution though.

Tue, Feb 20, 1:46 AM

Mon, Feb 19

phosit added a comment to D5246: WIP Refactor playerPlacement functions (another approach).

(but I didn't liked the idea to create another global object for this).

Mon, Feb 19, 8:34 PM
marder added a comment to D5246: WIP Refactor playerPlacement functions (another approach).

As option C we can just stick to individual functions that return an object of class PlayerPlacement, instead of methods.

Mon, Feb 19, 7:37 PM
marder added a comment to D5246: WIP Refactor playerPlacement functions (another approach).

I don't like this interface:
If one wants a PlayerPlacement one would have to call two functions.
That's a two step initialization. (Which is bad IMO)

Mon, Feb 19, 7:34 PM
phosit added a comment to D5240: Atlas Actor Viewer Toggle 3d.

"Mirroring" a type (union) is bad. I don't have a better solution though.

Mon, Feb 19, 7:07 PM
phosit added a comment to D5246: WIP Refactor playerPlacement functions (another approach).

I don't like this interface:
If one wants a PlayerPlacement one would have to call two functions.
That's a two step initialization. (Which is bad IMO)

Mon, Feb 19, 6:32 PM
Stan added a comment to D5246: WIP Refactor playerPlacement functions (another approach).

A better solution indeed would be to profile :)

Mon, Feb 19, 2:11 PM
sera added inline comments to D5246: WIP Refactor playerPlacement functions (another approach).
Mon, Feb 19, 1:34 PM
marder updated the diff for D5246: WIP Refactor playerPlacement functions (another approach).

unrelated to the class / prototype discussion, just a quick update to make it somewhat functional.
At least mainland generates now.

Mon, Feb 19, 1:27 PM
sera added a comment to D5246: WIP Refactor playerPlacement functions (another approach).

at least from a simple test (just object creation and setting a value) the performance looks equal. Not sure what happens in complex scenarios tho.

Mon, Feb 19, 1:05 PM
Stan added a comment to D5246: WIP Refactor playerPlacement functions (another approach).

Found it. https://irclogs.wildfiregames.com/%230ad-dev/2020-07-29-QuakeNet-%230ad-dev.log

Mon, Feb 19, 12:37 PM
marder added a comment to D5246: WIP Refactor playerPlacement functions (another approach).

at least from a simple test (just object creation and setting a value) the performance looks equal. Not sure what happens in complex scenarios tho.

Mon, Feb 19, 9:25 AM
autobuild committed rP28037: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Mon, Feb 19, 9:20 AM
marder added a comment to D5246: WIP Refactor playerPlacement functions (another approach).

The only thing I could find on phab was this:
https://code.wildfiregames.com/D4021#173216

Mon, Feb 19, 7:57 AM
Stan updated subscribers of D5246: WIP Refactor playerPlacement functions (another approach).
Mon, Feb 19, 1:23 AM

Sun, Feb 18

sera added inline comments to D5246: WIP Refactor playerPlacement functions (another approach).
Sun, Feb 18, 10:10 PM
marder added inline comments to D5246: WIP Refactor playerPlacement functions (another approach).
Sun, Feb 18, 10:00 PM
marder retitled D5246: WIP Refactor playerPlacement functions (another approach) from WIP Refactor playerPlacement functions (another apporach) to WIP Refactor playerPlacement functions (another approach).
Sun, Feb 18, 9:53 PM
sera added inline comments to D5246: WIP Refactor playerPlacement functions (another approach).
Sun, Feb 18, 9:29 PM
marder added a comment to D5198: Refactor playerPlacement functions.

I did some experiments with a class based approach here: D5246

Sun, Feb 18, 8:52 PM
marder requested review of D5246: WIP Refactor playerPlacement functions (another approach).
Sun, Feb 18, 8:48 PM
Vulcan added a comment to D5245: [Fix] Try to fix OOS with roman Onager.

Successful build - Chance fights ever on the side of the prudent.

Sun, Feb 18, 6:51 PM
Vulcan added a comment to D5245: [Fix] Try to fix OOS with roman Onager.

Successful build - Chance fights ever on the side of the prudent.

Sun, Feb 18, 6:24 PM
real_tabasco_sauce updated the diff for D5245: [Fix] Try to fix OOS with roman Onager.

remove inaccurate tooltip

Sun, Feb 18, 6:22 PM
real_tabasco_sauce requested review of D5245: [Fix] Try to fix OOS with roman Onager.
Sun, Feb 18, 5:57 PM
vladislavbelov added a comment to D5242: Deprecates OpenGL ARB backend.
In D5242#223156, @sera wrote:

You could render in a different window and copy back the frame as well as forward the events. Worth it? Probably not.

Also might be a performance loss.

Sun, Feb 18, 5:16 PM
vladislavbelov added a comment to D5244: Adds a hack to detect missing SPIR-V mod for SVN.
In D5244#223158, @sera wrote:

I suggest to add a shaders not found error message and maybe give a hint as for the possible cause and solution, otherwise LGTM apart from the obvious linter warning.

Sun, Feb 18, 5:11 PM
sera added a comment to D5244: Adds a hack to detect missing SPIR-V mod for SVN.

I suggest to add a shaders not found error message and maybe give a hint as for the possible cause and solution, otherwise LGTM apart from the obvious linter warning.

Sun, Feb 18, 4:54 PM
sera added a comment to D5242: Deprecates OpenGL ARB backend.
In D5242#223121, @sera wrote:

About atlas, wx itself uses gl but that doesn't mean you can't use vulkan for the viewport, anyway mostly a non issue and certainly low prio.

Vulkan can't access the viewport without interacting with wx.

Sun, Feb 18, 4:51 PM
Vulcan added a comment to D5244: Adds a hack to detect missing SPIR-V mod for SVN.

Successful build - Chance fights ever on the side of the prudent.

Sun, Feb 18, 4:17 PM
vladislavbelov requested review of D5244: Adds a hack to detect missing SPIR-V mod for SVN.
Sun, Feb 18, 4:17 PM
marder requested review of D5243: [Experimental] improve atlas biome fallback.
Sun, Feb 18, 3:06 PM

Sat, Feb 17

marder added a comment to D5229: [Gameplay] Skirmish Maps | An updated Sporades Islands map more suitable for 1v1 play.

if you want me to test this you need to send me the pmp file.

Sat, Feb 17, 6:15 PM
vladislavbelov added a comment to D5242: Deprecates OpenGL ARB backend.
In D5242#223121, @sera wrote:

About atlas, wx itself uses gl but that doesn't mean you can't use vulkan for the viewport, anyway mostly a non issue and certainly low prio.

Vulkan can't access the viewport without interacting with wx.

Sat, Feb 17, 3:34 PM
Stan added a comment to D5242: Deprecates OpenGL ARB backend.

The issue is that so far we don't have a reliable way to detect Vulkan support, as the detection itself can crash the game on some AMD GPUs. :)

Sat, Feb 17, 2:51 PM
sera added a comment to D5242: Deprecates OpenGL ARB backend.

If selecting vulkan can break the game then it shouldn't be exposed in the gui in the first place, even less be recommended. At least as long as reinstalling can't fix the issue. So before a release this needs to be addressed anyway.

Sat, Feb 17, 1:56 PM
Stan added a comment to D5242: Deprecates OpenGL ARB backend.

That's my point. We don't have graceful stuff here and as long as it's not 60% stable we can't force users to use it :)

Sat, Feb 17, 1:25 PM
sera added a comment to D5242: Deprecates OpenGL ARB backend.

Vulkan being _highly recommended_ but not the default is a contradiction, the note about drivers could be read as don't try unless you are sure it works because you will lock yourself out if not. Graceful degradation from vulkan to gl if something goes wrong is a must have.

Sat, Feb 17, 12:44 PM
marder closed D5214: rmgen: var -> let -> const.
Sat, Feb 17, 12:24 PM
marder committed rP28036: rmgen: var -> let -> const.
rmgen: var -> let -> const
Sat, Feb 17, 12:14 PM
Vulcan added a comment to D5214: rmgen: var -> let -> const.

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 17, 11:38 AM
Vulcan added a comment to D5214: rmgen: var -> let -> const.

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 17, 11:24 AM
marder updated the diff for D5214: rmgen: var -> let -> const.

no changes - just re-trigger the CI

Sat, Feb 17, 11:18 AM
Vulcan added a comment to D5240: Atlas Actor Viewer Toggle 3d.

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 17, 9:03 AM
Stan updated subscribers of D5242: Deprecates OpenGL ARB backend.

Maybe. Although errors do that, CTDs not really. The last five times I ran SVN it crashed because of Vulkan + Mod combo so I eventually gave up and went back to GL. Also worth noting Atlas doesn't support Vulkan and I guess @trompetin17 will not finish his patch to get rid of Atlas any time soon.

Sat, Feb 17, 8:44 AM
Vulcan added a comment to D5240: Atlas Actor Viewer Toggle 3d.

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 17, 8:15 AM
Vulcan added a comment to D5240: Atlas Actor Viewer Toggle 3d.

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 17, 8:06 AM
Vulcan added a comment to D5240: Atlas Actor Viewer Toggle 3d.

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 17, 7:35 AM
Vulcan added a comment to D5240: Atlas Actor Viewer Toggle 3d.

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 17, 7:23 AM
sera added a comment to D5242: Deprecates OpenGL ARB backend.
In D5242#223095, @Stan wrote:

Which is really a pain

Sat, Feb 17, 7:19 AM
Vulcan added a comment to D5240: Atlas Actor Viewer Toggle 3d.

Successful build - Chance fights ever on the side of the prudent.

Sat, Feb 17, 7:16 AM
Boston_Brooks updated the diff for D5240: Atlas Actor Viewer Toggle 3d.

There was a line in AtlasViewActor::Render()
that I had commented out because it interfering with my code.
I felt that this was bad form.
I have updated that line with an if/else statement
To provide the functionality that I needed

Sat, Feb 17, 7:11 AM
Boston_Brooks updated the diff for D5240: Atlas Actor Viewer Toggle 3d.

I modified the formatting of the code to match the coding conventions

Sat, Feb 17, 7:00 AM
autobuild committed rP28035: [Windows] Automated build..
[Windows] Automated build.
Sat, Feb 17, 6:07 AM
Stan added a comment to D5242: Deprecates OpenGL ARB backend.

@sera if you do that you can't run the dev build without building shaders first... Which is really a pain

Sat, Feb 17, 3:51 AM

Fri, Feb 16

sera added a comment to D5242: Deprecates OpenGL ARB backend.

Well, I'd say gl is supposed to be labeled legacy. So I'd use stronger language and move vulkan to the top of the list and make it default in default.cfg

Fri, Feb 16, 10:45 PM
vladislavbelov requested review of D5242: Deprecates OpenGL ARB backend.
Fri, Feb 16, 8:12 PM
phosit updated the summary of D5220: Allow to use a generator as MapGenerator.
Fri, Feb 16, 8:02 PM
vladislavbelov committed rP28034: Accounts maxAnisotropy for Vulkan samplers..
Accounts maxAnisotropy for Vulkan samplers.
Fri, Feb 16, 7:46 PM
phosit committed rP28033: More generic hash function for FSM.
More generic hash function for FSM
Fri, Feb 16, 6:32 PM
phosit closed D5237: More generic hash function for FSM.
Fri, Feb 16, 6:32 PM
autobuild committed rP28032: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Feb 16, 9:42 AM

Thu, Feb 15

Stan updated subscribers of D5240: Atlas Actor Viewer Toggle 3d.

If you haven't already, I would read this wiki page https://trac.wildfiregames.com/wiki/Coding_Conventions This will save some time for the review by @vladislavbelov Unfortunately we don't have Clang format or an equivalent, so we have to enforce the coding style manually. Obvious things I see from a quick glance are braces that aren't on new lines, nested ifs instead of early returns etc.

Thu, Feb 15, 12:16 PM