Page MenuHomeWildfire Games
Feed All Stories

Today

elexis added a comment to D2090: glooxwrapper: Remove unused private 'm_Owned' in Jingle::Session::Jingle.

Sorry I was wrong - I thought the missing Session destructor fixed it, but the Jingle class also needs one. Too much nesting!

Fri, Aug 23, 1:31 PM
vladislavbelov added inline comments to rP22744: Use variadic template for RecurseObject from rP31 and move it from GUIutil to….
Fri, Aug 23, 1:05 PM
elexis updated the summary of D2215: Delete copy-assignment GUIUtil GetSetting variant.
Fri, Aug 23, 11:44 AM
wraitii added a comment to D1670: Singleton g_Game and g_SoundManager.
In D1670#92067, @elexis wrote:

It doesnt change semantics, does it? Only syntax.

Mh, yes.

Fri, Aug 23, 11:12 AM
elexis retitled D1670: Singleton g_Game and g_SoundManager from Remove references to globals to Singleton g_Game and g_SoundManager.
Fri, Aug 23, 11:02 AM
elexis added a comment to D1670: Singleton g_Game and g_SoundManager.

I don't believe this change is worth committing as it stands, as Vlad said this only changes semantics (arguably making them worse since the new code is longer).

It doesnt change semantics, does it? Only syntax.

Fri, Aug 23, 10:47 AM
wraitii requested changes to D1670: Singleton g_Game and g_SoundManager.

I don't believe this change is worth committing as it stands, as Vlad said this only changes semantics (arguably making them worse since the new code is longer).
It's ever so slightly annoying for svn-blame to change so many lines, and to me the cost vs win calculation is negative here.

Fri, Aug 23, 9:49 AM
wraitii requested changes to D2064: Move "PlayersToDamage" from calling functions to to "CauseSplashDamage" and replace it with FF..

This needs a new rebase.

Fri, Aug 23, 9:40 AM
autobuild committed rP22763: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Aug 23, 9:27 AM
wraitii accepted D2115: Improve support of classes of bonuses..

Thanks for the split, much easier to be confident that we aren't introducing weird bugs now :)

Fri, Aug 23, 9:25 AM
wraitii requested changes to D2138: Tooltips for D2092/rP22754..

Thanks for taking a jab at this :)

Fri, Aug 23, 9:23 AM
Freagarach updated the summary of D2138: Tooltips for D2092/rP22754..
Fri, Aug 23, 7:50 AM
Freagarach added a comment to D2138: Tooltips for D2092/rP22754..

Yeah, sorry about the confusion. The tooltips are not working as supposed to be, hence broken. But for now they're not ;)
I'll update the name of the patch.

Fri, Aug 23, 7:47 AM
wraitii added a comment to D2138: Tooltips for D2092/rP22754..
In D2138#92011, @elexis wrote:

This patch fixes the tooltips after D2092/rP22754.

Fixes the tooltips? Did that commit break them?

Fri, Aug 23, 7:45 AM
autobuild committed rP22762: [Windows] Automated build..
[Windows] Automated build.
Fri, Aug 23, 7:26 AM
Vulcan added a comment to D2215: Delete copy-assignment GUIUtil GetSetting variant.

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 23, 6:06 AM
elexis created D2215: Delete copy-assignment GUIUtil GetSetting variant.
Fri, Aug 23, 5:57 AM
elexis removed 1 auditor(s) for rP22695: Remove IsBoolTrue helper function from rP7289.: vladislavbelov.
Fri, Aug 23, 5:48 AM
elexis added a comment to rP22758: Fix missing actual boolean check in the commit removing the odd way to check….

Uses GetSetting variant from rP22693.

Fri, Aug 23, 5:48 AM
elexis added a comment to rP22756: Introduce IGUIObject::PlaySound to unify 19 copies of the UI sound play….

Uses GetSetting variant from rP22693.

Fri, Aug 23, 5:48 AM
elexis added a comment to rP22761: Remove hardcoded C++ fallback font from rP1074 and according TODO from rP1085….

Uses GetSetting variant from rP22693.

Fri, Aug 23, 5:47 AM
elexis committed rP22761: Remove hardcoded C++ fallback font from rP1074 and according TODO from rP1085….
Remove hardcoded C++ fallback font from rP1074 and according TODO from rP1085…
Fri, Aug 23, 5:28 AM
elexis closed D2214: Delete broken fallback font for broken fonts.
Fri, Aug 23, 5:28 AM
elexis added a comment to D2214: Delete broken fallback font for broken fonts.

Revision history:

Fri, Aug 23, 5:17 AM
Alexandermb committed rP22760: Update elephantry_r of the following factions:.
Update elephantry_r of the following factions:
Fri, Aug 23, 5:07 AM
Vulcan added a comment to D2214: Delete broken fallback font for broken fonts.

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 23, 5:04 AM
Alexandermb committed rP22759: Fix the warning of fishermans unrecognized skeleton..
Fix the warning of fishermans unrecognized skeleton.
Fri, Aug 23, 4:51 AM
elexis created D2214: Delete broken fallback font for broken fonts.
Fri, Aug 23, 4:41 AM
Harbormaster failed to build B9019: rP22758: Fix missing actual boolean check in the commit removing the odd way to check… for rP22758: Fix missing actual boolean check in the commit removing the odd way to check…!
Fri, Aug 23, 2:45 AM
elexis requested verification of rP22695: Remove IsBoolTrue helper function from rP7289..

Thanks for the notification and bisect!

Fri, Aug 23, 2:42 AM
elexis committed rP22758: Fix missing actual boolean check in the commit removing the odd way to check….
Fix missing actual boolean check in the commit removing the odd way to check…
Fri, Aug 23, 2:42 AM
vladislavbelov raised a concern with rP22695: Remove IsBoolTrue helper function from rP7289..

The commit broke button hover (in session) and minimap camera dragging (at least on Windows). As far as I see, we shouldn't reset states for visible objects.

Fri, Aug 23, 2:02 AM
Harbormaster failed to build B9018: rP22757: Mark some GUI functions as const, including the boolean ones from rP22744. for rP22757: Mark some GUI functions as const, including the boolean ones from rP22744.!
Fri, Aug 23, 1:54 AM
elexis committed rP22757: Mark some GUI functions as const, including the boolean ones from rP22744..
Mark some GUI functions as const, including the boolean ones from rP22744.
Fri, Aug 23, 1:51 AM
elexis added inline comments to rP22744: Use variadic template for RecurseObject from rP31 and move it from GUIutil to….
Fri, Aug 23, 12:46 AM
Harbormaster failed to build B9017: rP22756: Introduce IGUIObject::PlaySound to unify 19 copies of the UI sound play… for rP22756: Introduce IGUIObject::PlaySound to unify 19 copies of the UI sound play…!
Fri, Aug 23, 12:37 AM
elexis committed rP22756: Introduce IGUIObject::PlaySound to unify 19 copies of the UI sound play….
Introduce IGUIObject::PlaySound to unify 19 copies of the UI sound play…
Fri, Aug 23, 12:34 AM
elexis closed D2209: Unify 19 copies of IGUIObject::PlaySound and stop copying the according CStrW.
Fri, Aug 23, 12:34 AM
elexis updated the summary of D2209: Unify 19 copies of IGUIObject::PlaySound and stop copying the according CStrW.
Fri, Aug 23, 12:15 AM
elexis added a comment to rP13521: Adds UI sounds for buttons, dropdowns, lists, and checkboxes, fixes #948.

Comment about the duplication.

Fri, Aug 23, 12:07 AM

Yesterday

Harbormaster failed remote builds in B9016: Diff 9452 for D2213: Delete CSimulation2 m_MapSettings and redundant getters!
Thu, Aug 22, 11:50 PM
Vulcan added a comment to D2213: Delete CSimulation2 m_MapSettings and redundant getters.

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Aug 22, 11:50 PM
elexis created D2213: Delete CSimulation2 m_MapSettings and redundant getters.
Thu, Aug 22, 11:48 PM
elexis added a comment to D2138: Tooltips for D2092/rP22754..

This patch fixes the tooltips after D2092/rP22754.

Fixes the tooltips? Did that commit break them?

Thu, Aug 22, 11:26 PM
Vulcan added a comment to D2138: Tooltips for D2092/rP22754..

Successful build - Chance fights ever on the side of the prudent.

Thu, Aug 22, 11:25 PM
Freagarach added a reviewer for D2182: [WIP] - Support training of groups of units.: Restricted Owners Package.
Thu, Aug 22, 11:22 PM
Freagarach updated the diff for D2138: Tooltips for D2092/rP22754..

Rebased.

Thu, Aug 22, 11:21 PM
Harbormaster failed to build B9013: rP22755: Cleanup Camera and CGameView, removes a not needed method and refactors classes. for rP22755: Cleanup Camera and CGameView, removes a not needed method and refactors classes.!
Thu, Aug 22, 10:53 PM
vladislavbelov committed rP22755: Cleanup Camera and CGameView, removes a not needed method and refactors classes..
Cleanup Camera and CGameView, removes a not needed method and refactors classes.
Thu, Aug 22, 10:50 PM
vladislavbelov closed D2195: Cleanup Camera and CGameView.
Thu, Aug 22, 10:50 PM
Harbormaster failed remote builds in B9012: Diff 9448 for D2182: [WIP] - Support training of groups of units.!
Thu, Aug 22, 10:12 PM
Vulcan added a comment to D2182: [WIP] - Support training of groups of units..

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Aug 22, 10:12 PM
Freagarach changed the visibility for D2182: [WIP] - Support training of groups of units..
Thu, Aug 22, 10:12 PM
Freagarach updated the diff for D2182: [WIP] - Support training of groups of units..
  • Reverted cost calculation.
  • Finish the spawning
    • Ugly but working. Feedback appreciated!
Thu, Aug 22, 10:12 PM
irishninja awarded D2197: Add support for recording replay metadata when in nonvisual mode a Like token.
Thu, Aug 22, 9:29 PM
Vulcan added a comment to D2212: Show system_info.txt path in terminal when it's written.

Successful build - Chance fights ever on the side of the prudent.

Thu, Aug 22, 8:22 PM
Freagarach added a comment to D2081: Add status effects support to splash, melee and death damage..

Done in D2092. Thanks for the patch which gave me the idea for that one :)

You're welcome!
B.t.w. I have already a patch for the new tooltips but it ought to be updated.

Thu, Aug 22, 8:18 PM
elexis created D2212: Show system_info.txt path in terminal when it's written.
Thu, Aug 22, 8:16 PM
wraitii abandoned D2081: Add status effects support to splash, melee and death damage..

Done in D2092. Thanks for the patch which gave me the idea for that one :)

Thu, Aug 22, 8:13 PM
wraitii added a comment to D368: Gameplay Scripting: Entity and Actor coding for Secondary Attacks.

@bb: I've committed rP22754, making "Damage" and "Capture" not based on the attack names, allowing you to drop that from this diff.
I think you'll find my final decision OK with regards to how templates get written.
If not, feel free to discuss this by PM or on a forum thread or through the audit feature or something.

Thu, Aug 22, 8:10 PM
wraitii committed rP22754: Generalise Attack effects. All attacks, including death damage and splash, can….
Generalise Attack effects. All attacks, including death damage and splash, can…
Thu, Aug 22, 8:00 PM
wraitii closed D2092: Generalise Attack effects - any attack can do damage, capture, inflict status effects, including splash. Also damage bonuses..
Thu, Aug 22, 8:00 PM
Freagarach added a comment to D2092: Generalise Attack effects - any attack can do damage, capture, inflict status effects, including splash. Also damage bonuses..

I don't have a clean working copy, so I can't test soon.

Thu, Aug 22, 7:32 PM
elexis added a comment to D2197: Add support for recording replay metadata when in nonvisual mode.

So the important part is this, this way the ugly monster condition that copies the CGame constructor argument logic doesn't have to be replicated, kept in sync, and then bugfixes multiple times without ever becoming evidently correct, unless doing it this way:

Index: source/ps/Game.cpp
===================================================================
--- source/ps/Game.cpp	(revision 22752)
+++ source/ps/Game.cpp	(working copy)
@@ -100,10 +100,13 @@ CGame::~CGame()
 {
 	// Again, the in-game call tree is going to be different to the main menu one.
 	if (CProfileManager::IsInitialised())
 		g_Profiler.StructuralReset();
Thu, Aug 22, 7:28 PM
wraitii committed rP22753: Make Promotion.js use the common Transform helper, add resource gatherer and….
Make Promotion.js use the common Transform helper, add resource gatherer and…
Thu, Aug 22, 7:26 PM
wraitii closed D2026: Make Promotion.js use the common Transform helper.
Thu, Aug 22, 7:26 PM
Vulcan added a comment to D2092: Generalise Attack effects - any attack can do damage, capture, inflict status effects, including splash. Also damage bonuses..

Successful build - Chance fights ever on the side of the prudent.

Thu, Aug 22, 7:21 PM
wraitii added inline comments to D2026: Make Promotion.js use the common Transform helper.
Thu, Aug 22, 7:20 PM
wraitii updated the diff for D2092: Generalise Attack effects - any attack can do damage, capture, inflict status effects, including splash. Also damage bonuses..

Also address Stan's comments.

Thu, Aug 22, 7:17 PM
wraitii added inline comments to D2092: Generalise Attack effects - any attack can do damage, capture, inflict status effects, including splash. Also damage bonuses..
Thu, Aug 22, 7:17 PM
Vulcan added a comment to D2092: Generalise Attack effects - any attack can do damage, capture, inflict status effects, including splash. Also damage bonuses..

Successful build - Chance fights ever on the side of the prudent.

Thu, Aug 22, 7:14 PM
elexis added a comment to D2211: Clean CGame constructor arguments.

Notice that there are 36 occurrences of CRenderer::IsInitialised() after this patch (and 30 before), so it's not a new thing to test for this at all.
It just shows that we made up some random concepts in our mind ("visual mode") that doesn't really exist as something different from "renderering enabled".

Thu, Aug 22, 7:10 PM
wraitii updated the diff for D2092: Generalise Attack effects - any attack can do damage, capture, inflict status effects, including splash. Also damage bonuses..

Allow calling an arbitrary method per damage type. This means we can give and remove status effects neatly, or have attacks that actually heal, or anything really.

Thu, Aug 22, 7:08 PM
elexis updated the summary of D2211: Clean CGame constructor arguments.
Thu, Aug 22, 5:33 PM
elexis added inline comments to rP19645: Add a -autostart-nonvisual option. Patch by sacha_vrand. Fixes #4577..
Thu, Aug 22, 5:32 PM
elexis added a comment to rP17689: Don't create replays without commands in case of running non-visual replay or….

Fixed rP16727, the commit is a good example why default arguments should be avoided. The commit added the default argument because the other argument was a default one too, from rP7653.

Thu, Aug 22, 5:29 PM
elexis added inline comments to rP18613: Always save the replay metadata (summary screen info) when ending the….
Thu, Aug 22, 5:16 PM
Vulcan added a comment to D2211: Clean CGame constructor arguments.

Successful build - Chance fights ever on the side of the prudent.

Thu, Aug 22, 5:15 PM
Alexandermb committed rP22752: Replace the horse rein with a less basic version.
Replace the horse rein with a less basic version
Thu, Aug 22, 5:11 PM
Alexandermb committed rP22751: Adjust some helmets following the latest changes on human bodie armature..
Adjust some helmets following the latest changes on human bodie armature.
Thu, Aug 22, 5:06 PM
Alexandermb committed rP22750: Adjust archers right hand position and rotation according to the discussion in….
Adjust archers right hand position and rotation according to the discussion in…
Thu, Aug 22, 5:05 PM
elexis updated the diff for D2211: Clean CGame constructor arguments.

Use Singleton method CRenderer::IsInitialised() instead of adding a Renderer boolean getter and doing something that crashes everything immediately all the time.

Thu, Aug 22, 5:04 PM
elexis added inline comments to rP22432: Adds a possibility to disable saving of replay in autostart mode..
Thu, Aug 22, 5:02 PM
Vulcan added a comment to D2211: Clean CGame constructor arguments.

Successful build - Chance fights ever on the side of the prudent.

Thu, Aug 22, 4:47 PM
elexis added inline comments to D2211: Clean CGame constructor arguments.
Thu, Aug 22, 4:37 PM
elexis updated the diff for D2211: Clean CGame constructor arguments.

Test whether the renderer is open instead of passing this information around under different names.

Thu, Aug 22, 4:32 PM
elexis added a comment to D2211: Clean CGame constructor arguments.

I don't mind much what our personal opinions are, it matters what the effect on future readers is that have never seen or met us.
So we need to stop arguing with saying "I like X", since it hides the argument.
A disadvantage of enum flags is that they define a new data structure and that they require parsing that is sometimes done uglily using switch and even loops.
But in this case those are only two booleans, two bits, so it should be possible to get away with one arg & const each and it provides a readable name.
So I'm afraid the flags are preferable in this single instance even if you had the opposite opinion or if flags are worse in other cases.

Thu, Aug 22, 4:30 PM
Vulcan added a comment to D2211: Clean CGame constructor arguments.

Successful build - Chance fights ever on the side of the prudent.

Thu, Aug 22, 3:55 PM
wraitii added a comment to D2211: Clean CGame constructor arguments.

I would prefer using enum-flags to make these parameters more readable then.

Thu, Aug 22, 3:54 PM
elexis created D2211: Clean CGame constructor arguments.
Thu, Aug 22, 3:43 PM
vladislavbelov added inline comments to D2197: Add support for recording replay metadata when in nonvisual mode.
Thu, Aug 22, 1:23 PM
elexis commandeered D2197: Add support for recording replay metadata when in nonvisual mode.
Thu, Aug 22, 12:58 PM
vladislavbelov added inline comments to D2197: Add support for recording replay metadata when in nonvisual mode.
Thu, Aug 22, 12:49 PM
elexis added a comment to D2197: Add support for recording replay metadata when in nonvisual mode.

I will be updating the diff with the most recent fixes.

It seems you didn't see the inline comments and the patch?
JSI_Simulation::GetInitAttributes is out of place in ComponentManager, and furthermore it can be deleted :-)

Thu, Aug 22, 12:26 PM
Freagarach updated subscribers of D2182: [WIP] - Support training of groups of units..
Thu, Aug 22, 9:35 AM
Freagarach updated the diff for D2182: [WIP] - Support training of groups of units..

Made stuff useful for training optional, so that the cost can also be calculated based on the individual entites to spawn. I think however that that is not viable, since one can deduce from the amount of resources subtracted which entities are to spawn. So I guess I'll have to revert this change when I find the time again to make Cost obligatory again.

Thu, Aug 22, 9:34 AM
wraitii added a comment to D2207: Adds a function to pick entities with obstructions on screen.

On the whole, I think this is a minor feature that's useful for performance reasons, and we shouldn't worry too much about future-proofing these kind of things, which are easy to change, and generally used in specific use-cases (see also the shore-dock code thingy).

Thu, Aug 22, 8:40 AM
wraitii accepted D2195: Cleanup Camera and CGameView.

@wraitii any thoughts about updated patch? Is it acceptable?

Thu, Aug 22, 8:22 AM
irishninja updated the diff for D2197: Add support for recording replay metadata when in nonvisual mode.

Cleaned up the updates to the SaveReplayMetadata function (mentioned in the prior reviews). I also made the argument for the fn const since it is read-only.

Thu, Aug 22, 7:51 AM
irishninja added a comment to D2197: Add support for recording replay metadata when in nonvisual mode.

I will be updating the diff with the most recent fixes. Dumb question: when I update the diff, does it add the changes to the existing diff or overwrite it with the most recent diff? I usually use git and GitHub and am still getting used to Phabricator...

Thu, Aug 22, 7:49 AM