Page MenuHomeWildfire Games
Feed All Stories

Today

lyv added inline comments to D4758: Rearrange GC scheduling for reduced lag.
Mon, Aug 15, 11:08 AM
Stan added a comment to D2772: Prevent Upgrading units from moving.

Maybe I could just set unit to uncontrollable @Freagarach ? Since 1960 got merged.

Mon, Aug 15, 10:10 AM
marder added a comment to rP27052: [Maps] Fix Jebel barkal after rP26955.

Ah I messed that sentence up in all ways possible.
Should be: since only infantry can garrison in barracks now.

Mon, Aug 15, 10:06 AM
autobuild committed rP27057: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Mon, Aug 15, 9:23 AM
wowgetoffyourcellphone added a comment to rP27052: [Maps] Fix Jebel barkal after rP26955.

*cavalry

Mon, Aug 15, 2:45 AM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Mon, Aug 15, 2:12 AM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Mon, Aug 15, 2:12 AM
Mercury added a comment to D4758: Rearrange GC scheduling for reduced lag.

Since the patch is about timing i don't see how to test it without introducing a race condition.

Mon, Aug 15, 2:03 AM
Mercury updated the diff for D4758: Rearrange GC scheduling for reduced lag.

uint32_t changed to u32

Mon, Aug 15, 2:01 AM

Yesterday

Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Sun, Aug 14, 11:31 PM
Stan added inline comments to D4758: Rearrange GC scheduling for reduced lag.
Sun, Aug 14, 11:17 PM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Sun, Aug 14, 11:11 PM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Sun, Aug 14, 11:10 PM
Mercury added inline comments to D4758: Rearrange GC scheduling for reduced lag.
Sun, Aug 14, 11:00 PM
Mercury updated the diff for D4758: Rearrange GC scheduling for reduced lag.

Add some includes, use timer_Time.

Sun, Aug 14, 10:59 PM
phosit added a comment to D4761: remove cassert.

I don't think the condition is useful without context. But i'm ok if i should leave it that way.

Sun, Aug 14, 10:38 PM
vladislavbelov added a comment to D4761: remove cassert.

it does compile on all os. Ther might be some in architecture specivic code but a grep yields nothing.

Sun, Aug 14, 10:21 PM
phosit added a comment to D4761: remove cassert.

Have you checked MSVC output in case of an error?

Sun, Aug 14, 10:09 PM
Mercury updated the summary of D4760: Reduce simulation turns per second from 5 to 4.
Sun, Aug 14, 9:08 PM
Mercury added a comment to D4760: Reduce simulation turns per second from 5 to 4.

Reduce simulation thread load by ~10% (maybe a bit less, can't think of a way to test) and network traffic by 10-18%, depending on player APM. 500ms indeed sounds like too much. But 200 might have been an over-correction. The difference from 2 turns per second to 5 turns per second is ~1/3 second, but the difference between 5 and 4 is 1/20 second. I think this is small enough to not make a big difference.

Sun, Aug 14, 9:07 PM
Mercury updated the summary of D4760: Reduce simulation turns per second from 5 to 4.
Sun, Aug 14, 8:35 PM
Stan committed rP27056: Fix previous commit. .
Fix previous commit.
Sun, Aug 14, 8:23 PM
Harbormaster failed to build B20760: rP27055: Fix mod installation in non latin folders. Use OSString for consistency. for rP27055: Fix mod installation in non latin folders. Use OSString for consistency. !
Sun, Aug 14, 7:56 PM
Stan committed rP27055: Fix mod installation in non latin folders. Use OSString for consistency. .
Fix mod installation in non latin folders. Use OSString for consistency.
Sun, Aug 14, 7:55 PM
Stan committed rP27054: Fix replay cache creation in non latin folders..
Fix replay cache creation in non latin folders.
Sun, Aug 14, 7:24 PM
Stan closed D4763: Fix broken rename and copy on Windows..
Sun, Aug 14, 7:24 PM
marder added a comment to D4762: [gui] remove the 'trained by' and 'builds' string from the extended tooltip.

Another question is if this should also remove these functions itself as well, to not stack dead code

Sun, Aug 14, 7:14 PM
Stan requested review of D4763: Fix broken rename and copy on Windows..
Sun, Aug 14, 7:13 PM
Stan added a comment to D4762: [gui] remove the 'trained by' and 'builds' string from the extended tooltip.

Gotta check what this do to translations.

Sun, Aug 14, 7:00 PM
marder requested review of D4762: [gui] remove the 'trained by' and 'builds' string from the extended tooltip.
Sun, Aug 14, 6:39 PM
Stan committed rP27053: Fix an edge case when you would delete the last savegame and thus, the metadata….
Fix an edge case when you would delete the last savegame and thus, the metadata…
Sun, Aug 14, 5:11 PM
marder committed rP27052: [Maps] Fix Jebel barkal after rP26955.
[Maps] Fix Jebel barkal after rP26955
Sun, Aug 14, 5:06 PM
vladislavbelov added a comment to D4761: remove cassert.

Have you checked MSVC output in case of an error?

Sun, Aug 14, 3:58 PM
phosit requested review of D4761: remove cassert.
Sun, Aug 14, 3:51 PM
Silier updated Silier.
Sun, Aug 14, 3:37 PM
Silier added a comment to D4743: Ignore broken symlinks.

I suggest to add some information explaining user what's wrong, they won't understand what it means

Sun, Aug 14, 3:35 PM
Stan updated the summary of D4760: Reduce simulation turns per second from 5 to 4.
Sun, Aug 14, 12:40 PM
Stan committed rP27051: Fix Athenian Gymnasion counting as a City Phase building, when it's actually a….
Fix Athenian Gymnasion counting as a City Phase building, when it's actually a…
Sun, Aug 14, 12:38 PM
Stan committed rP27050: Recenter Han emblem logo slightly and fix the name..
Recenter Han emblem logo slightly and fix the name.
Sun, Aug 14, 12:31 PM
Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.

If SM allows to get a size of currently allocated memory it should be easy to write a unit test. We already have some unit tests for ScriptInterface.

Sun, Aug 14, 11:58 AM
Stan added a comment to D4760: Reduce simulation turns per second from 5 to 4.

Mmh I'm not sure this is a good idea. What are the advantages?
See rP25001 and #3752

Sun, Aug 14, 10:53 AM
Mercury requested review of D4760: Reduce simulation turns per second from 5 to 4.
Sun, Aug 14, 4:25 AM

Sat, Aug 13

Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Sat, Aug 13, 10:11 PM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Sat, Aug 13, 10:07 PM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Build failure - The Moirai have given mortals hearts that can endure.

Sat, Aug 13, 10:01 PM
Mercury updated the diff for D4758: Rearrange GC scheduling for reduced lag.

Changed type of gcPressure to double, changed type of gcBytes and gcMaxBytes to uint32_t, as well as m_HeapGrowthBytesGCTrigger and m_LastGCBytes. Added some const. Edited some comments.

Sat, Aug 13, 10:00 PM
Mercury added a comment to D4758: Rearrange GC scheduling for reduced lag.

Slice runs fewer times because it's time budget is typically higher. The total amount of RAM consumed should remain the same.

Sat, Aug 13, 9:39 PM
phosit added a comment to D4743: Ignore broken symlinks.

Acording to https://trac.wildfiregames.com/wiki/Coding_Conventions#Errorreporting we should not use LOGWARNING:
"only use things defined in source/lib/"

Sat, Aug 13, 7:05 PM
phosit abandoned D4759: UTF-8 as execution caracter set.

It is already UTF-8‽ So it should be possible to replace wchar_t by char in most places.

Sat, Aug 13, 2:26 PM
Stan added a comment to D4759: UTF-8 as execution caracter set.

Might want to check premake :)

Sat, Aug 13, 2:04 PM
phosit requested review of D4759: UTF-8 as execution caracter set.
Sat, Aug 13, 1:56 PM
vladislavbelov committed rP27049: Adds explicit z value for main menu buttons to workaround low resolutions to be….
Adds explicit z value for main menu buttons to workaround low resolutions to be…
Sat, Aug 13, 1:22 PM
vladislavbelov closed D4757: Workaround main menu buttons to be able to exit for low resolutions.
Sat, Aug 13, 1:22 PM
Stan added a reviewer for D4758: Rearrange GC scheduling for reduced lag: Restricted Owners Package.
Sat, Aug 13, 1:01 PM
Stan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Hey, thanks for another very promising patch. Is there a way you could add some tests for it?

Sat, Aug 13, 1:00 PM
phosit added a comment to D4758: Rearrange GC scheduling for reduced lag.

Realy nice improvement... and less controversal than the allocator.

Sat, Aug 13, 12:04 PM
marder committed rP27048: Add in rP27046 removed Han swordsman templates back in under a different name.
Add in rP27046 removed Han swordsman templates back in under a different name
Sat, Aug 13, 11:20 AM
marder awarded D4758: Rearrange GC scheduling for reduced lag a Party Time token.
Sat, Aug 13, 11:01 AM
Mercury added a reviewer for D4758: Rearrange GC scheduling for reduced lag: Stan.
Sat, Aug 13, 8:38 AM
Mercury updated the summary of D4758: Rearrange GC scheduling for reduced lag.
Sat, Aug 13, 7:33 AM
Mercury updated the summary of D4758: Rearrange GC scheduling for reduced lag.
Sat, Aug 13, 7:23 AM
Mercury updated the summary of D4758: Rearrange GC scheduling for reduced lag.
Sat, Aug 13, 7:20 AM
Mercury updated the summary of D4758: Rearrange GC scheduling for reduced lag.
Sat, Aug 13, 7:17 AM
Mercury updated the summary of D4758: Rearrange GC scheduling for reduced lag.
Sat, Aug 13, 7:12 AM
Mercury updated the summary of D4758: Rearrange GC scheduling for reduced lag.
Sat, Aug 13, 7:12 AM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Sat, Aug 13, 7:05 AM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Sat, Aug 13, 7:03 AM
Mercury updated the diff for D4758: Rearrange GC scheduling for reduced lag.

replaced the constant 200 with the variable turnLength in Simulation2.cpp. Edited comment.

Sat, Aug 13, 6:55 AM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Sat, Aug 13, 6:38 AM
Mercury updated the summary of D4758: Rearrange GC scheduling for reduced lag.
Sat, Aug 13, 6:37 AM
Mercury retitled D4758: Rearrange GC scheduling for reduced lag from Rearrange GC scheduling for reduced latency to Rearrange GC scheduling for reduced lag.
Sat, Aug 13, 6:36 AM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Sat, Aug 13, 6:34 AM
Mercury updated the summary of D4758: Rearrange GC scheduling for reduced lag.
Sat, Aug 13, 6:31 AM
Mercury updated the summary of D4758: Rearrange GC scheduling for reduced lag.
Sat, Aug 13, 6:28 AM
Mercury updated the diff for D4758: Rearrange GC scheduling for reduced lag.

Space after if.

Sat, Aug 13, 6:23 AM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Sat, Aug 13, 4:51 AM
Vulcan added a comment to D4758: Rearrange GC scheduling for reduced lag.

Successful build - Chance fights ever on the side of the prudent.

Sat, Aug 13, 4:49 AM
Mercury updated the diff for D4758: Rearrange GC scheduling for reduced lag.

Copyright year, trailing white space, comment format.

Sat, Aug 13, 4:39 AM
Mercury requested review of D4758: Rearrange GC scheduling for reduced lag.
Sat, Aug 13, 4:10 AM
wowgetoffyourcellphone accepted D4754: [Gameplay] - Small nerf to CS crossbows.
Sat, Aug 13, 12:07 AM
wowgetoffyourcellphone awarded D4754: [Gameplay] - Small nerf to CS crossbows a Dat Boi token.
Sat, Aug 13, 12:06 AM

Fri, Aug 12

autobuild committed rP27047: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Aug 12, 9:13 AM
Vulcan added a comment to D4718: Allocator and generator for component data..

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 12, 8:12 AM
Vulcan added a comment to D4718: Allocator and generator for component data..

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 12, 7:49 AM
Vulcan added a comment to D4718: Allocator and generator for component data..

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 12, 7:40 AM
Mercury added inline comments to D4718: Allocator and generator for component data..
Fri, Aug 12, 7:21 AM
Mercury updated the diff for D4718: Allocator and generator for component data..

Use range based loop in graphics/mapWriter.cpp

Fri, Aug 12, 7:21 AM

Thu, Aug 11

marder committed rP27046: [Gameplay] Enable other civ's to train champions in Han barracks and stables.
[Gameplay] Enable other civ's to train champions in Han barracks and stables
Thu, Aug 11, 10:31 PM
marder accepted D4757: Workaround main menu buttons to be able to exit for low resolutions.

better than the current situation.
Everything seem to work.

Thu, Aug 11, 8:13 PM
Stan accepted D4757: Workaround main menu buttons to be able to exit for low resolutions.

LGTM.

Thu, Aug 11, 8:11 PM
Stan committed rP27045: Fix mipmap issue with the camel rein. Use a very light texture as most details….
Fix mipmap issue with the camel rein. Use a very light texture as most details…
Thu, Aug 11, 7:47 PM
vladislavbelov requested review of D4757: Workaround main menu buttons to be able to exit for low resolutions.
Thu, Aug 11, 7:44 PM
Stan published D4756: Minor fixes for NSIS - Windows distribution script for review.
Thu, Aug 11, 7:26 PM
autobuild committed rP27044: [Windows] Automated build..
[Windows] Automated build.
Thu, Aug 11, 7:07 AM
Freagarach requested verification of rP26015: Some fixes after the ProductionQueue split..
Thu, Aug 11, 6:40 AM
billierios updated billierios.
Thu, Aug 11, 6:36 AM
marder committed rP27043: [Gameplay] Make fences capturable.
[Gameplay] Make fences capturable
Thu, Aug 11, 12:16 AM

Wed, Aug 10

marder committed rP27042: [Fix] Patch globalscripts technology template helper after rP26015 and the….
[Fix] Patch globalscripts technology template helper after rP26015 and the…
Wed, Aug 10, 11:49 PM
marder closed D4755: Patch globalscripts.js to fix wrong tooltips.
Wed, Aug 10, 11:49 PM
Vulcan added a comment to D4755: Patch globalscripts.js to fix wrong tooltips.

Successful build - Chance fights ever on the side of the prudent.

Wed, Aug 10, 11:20 PM