Translation of label and description will not have effect on other mods. I dont think it is worth the call to translate.

In D3216#170616, @Stan wrote:

Just creating a folder and dumping the zip in it. That's in most instructions other than the pyromod way.

I'm still confused :P . This worked before and it will still work. It's just sub-optimal at the moment.
Incidentally I think I probably should write the JSON when it's encountered in the archive but not the mod, to fix the inconsistency.

If you move the Athenian Marine to the barracks or gymnasium, then I suggest you rename the unit back to its original name from years ago: Athenian Ekdromos. Full circle.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Use getReadableHotkeyName() in HotKey Picker.
Fix lint warnings

In D3216#170613, @wraitii wrote:

In D3216#170610, @Stan wrote:

We might want to add that to the A24 to A25 page for I remember seeing instructions that would not work

I'm not sure what you mean? That what would not work?

In D3216#170610, @Stan wrote:

We might want to add that to the A24 to A25 page for I remember seeing instructions that would not work

We might want to add that to the A24 to A25 page for I remember seeing instructions that would not work

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Update. This is retro-compatible by opening the archive if the mod.json cannot be found, which makes more sense.

It's fine, it's a bug in blender.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Also rebase the tests :p

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Rebased properly.

K I'm actually changing my mind : I think it'll be easier to maintain an IPV6-compatible fork of Enet and reuse it everywhere than maintain our own socket compatibility layer (the job is mostly the same anyways).

TEST PLAN
Test it

Another user will try to implement it, I will not work on this one anymore.
see D3958 - Add an extra button for seeing the summary page when quitting a session (13/May/21).

Is intended for those who don't overite the parent setting, which means is intended.

This also affects all trees in simulation/templates/gaia/fruit. Is intended?
Refs: rP25259

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Aight, so as it turns out winsock2 is a bit of a pain.

Build failure - The Moirai have given mortals hearts that can endure.

Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

I'm a firm "don't care" here, so do whatever you want from my end :)

Rebased.

Rebased.

Successful build - Chance fights ever on the side of the prudent.

In D3886#170491, @bb wrote:

Please redo your math. If you do 0.9^x you are making everything more easy, more performant and you get 0=undefined= immume, so no damage being dealt. Makes total sense to me. Just have to rename stuff and work out the gui.

Right, assuming '1' means '100% resistance'. But then you get the awkwardness that there is no '0' value, and adding 1 at lower armour levels will have a greater absolute effect than at lower effects, which is the nice property that led us to exponential armour in the first place.

In D3886#170470, @wraitii wrote:

which is that undefined values can be assumed to mean invulnerable.

Then all falsy values should mean that, and build a paradigm around that. The 1/x proposal might be not ideal, but consider e^(-x) (or if you are looking at the code one might consider 0.9^x)

Look, a system in which a resistance of '0' means 'infinite' and '9999' means 'none' is dumb, there's no way around that.

Please redo your math. If you do 0.9^x you are making everything more easy, more performant and you get 0=undefined= immume, so no damage being dealt. Makes total sense to me. Just have to rename stuff and work out the gui.

In D3898#170465, @wraitii wrote:

I noticed in A23 outposts actually had 80 vision by default, increasing to 120 with the pidgeon tech. It's D2933 that made it 100.

This gives them 100 base vision, and the pidgeon tech gives them 150. That's a _lot_ of range, but I agree that it should outrange units, and units have around 80 vision, so...

I didn't add a garrison-related tech because nothing works well with turrets. The only point of garrisoning is that you can attack.
I'm wondering if outposts shouldn't be made un-garrisonable and have an actor inside anyways now.

I'm wary that the new LOS values might be a bit too high. Perhaps unit should lose 10 vision, and outposts be 90-135 ?

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

In D3886#170483, @Freagarach wrote:

"undefined means unable to do x", seems like something we use throughout the sim. E.g. if you don't have a value for gathering wood you can't. If you don't have the wood resource supply, it cannot be gathered from you. In that respect undefined == immune sounds good.

Well, except that a gather rate of 0 also means "can't gather wood", so that can also be used to say that "0 resistance" should be infinite resistance.

"undefined means unable to do x", seems like something we use throughout the sim. E.g. if you don't have a value for gathering wood you can't. If you don't have the wood resource supply, it cannot be gathered from you. In that respect undefined == immune sounds good.

Gonna have to rebase this tomorrow

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

In D3886#170469, @bb wrote:

Not all usecases will iterate this particular object. One might iterate an attackers attack object instead, and turn into trouble. In fact this is exactly what we do in current SVN.

Mh, you're right, I should change that actually.

In D3886#170442, @wraitii wrote:

In D3886#170423, @bb wrote:

Having two falsy values (undefined and 0) meaning opposite things is highly unwanted and must be avoided: Checking for !resistanceType is likely to happen one day and is totally ill-defined.

Point taken, but I don't think what you're describing is quite right, because it's not 'undefined', it's _actually_ undefined, as in the key in the resistance object doesn't exist. Which means, crucially, that iterating the resistance will work as you'd expect out of the box instead of requiring special handling (as in D2044 for example).

Not all usecases will iterate this particular object. One might iterate an attackers attack object instead, and turn into trouble. In fact this is exactly what we do in current SVN,. So this revision is turning an iteration which does exactly what is being expected, into one which has likely breakage.
If you wish all damagetypes in each resistance instance (first consider performance), then fill up the missing entries from the damagtypes globalscript.

Further, and as you can see, this only changes a single file, so I think the risk is limited, and we have tests now, so the risk is further limited.

Not an argument. Anyone working with the code might come to a conclusion that we need to do some checks in another file. Also within one file the risk is huge.

Overall I'm not too concerned

Problematic.

Edit: also, you would lose the whole point of the diff

Well, that could be a conclusion.

I noticed in A23 outposts actually had 80 vision by default, increasing to 120 with the pidgeon tech. It's D2933 that made it 100.

Build failure - The Moirai have given mortals hearts that can endure.

Unassigned hotkey -> Gray

Build failure - The Moirai have given mortals hearts that can endure.

Update. Should go green.

How about grey for a color? After all it's disabled.

In D3886#170423, @bb wrote:

Having two falsy values (undefined and 0) meaning opposite things is highly unwanted and must be avoided: Checking for !resistanceType is likely to happen one day and is totally ill-defined.

Point taken, but I don't think what you're describing is quite right, because it's not 'undefined', it's _actually_ undefined, as in the key in the resistance object doesn't exist. Which means, crucially, that iterating the resistance will work as you'd expect out of the box instead of requiring special handling (as in D2044 for example).