Page MenuHomeWildfire Games
Feed All Stories

Today

Harbormaster failed to build B9855: rP23087: Refactor session lobby bot client code to use object orientation, refs #5387. for rP23087: Refactor session lobby bot client code to use object orientation, refs #5387.!
Mon, Oct 21, 5:16 PM
elexis committed rP23087: Refactor session lobby bot client code to use object orientation, refs #5387..
Refactor session lobby bot client code to use object orientation, refs #5387.
Mon, Oct 21, 5:01 PM
elexis closed D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.
Mon, Oct 21, 5:01 PM
elexis added a comment to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Verification of the patch:

Mon, Oct 21, 4:55 PM
Stan added inline comments to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.
Mon, Oct 21, 4:41 PM
elexis updated the Trac tickets for D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.
Mon, Oct 21, 4:28 PM
elexis added inline comments to rP14752: Reformat the database to accept the additional summary counters as well as….
Mon, Oct 21, 3:20 PM
Harbormaster failed to build B9854: rP23086: Remove hardcoding and quadruplication of the StatisticsTracker unit and… for rP23086: Remove hardcoding and quadruplication of the StatisticsTracker unit and…!
Mon, Oct 21, 11:12 AM
elexis committed rP23086: Remove hardcoding and quadruplication of the StatisticsTracker unit and….
Remove hardcoding and quadruplication of the StatisticsTracker unit and…
Mon, Oct 21, 10:48 AM
elexis closed D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Mon, Oct 21, 10:48 AM
elexis added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

For rP14703 there was also the debate whether to unify buildings and structures. Not now.

Mon, Oct 21, 10:35 AM
elexis added inline comments to rP21250: Small StatisticsTracker test.
Mon, Oct 21, 10:28 AM
elexis added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

After this patch, the following Identity classes remain:

Mon, Oct 21, 10:07 AM
elexis added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

For default serialization:
Serialization of these properties could be left out, but since there is only one of these per components per player, it has no significant performance or memory footprint impact. Implementing a custom serialization function that copies all owned properties except these two means that the reader will have to read through the entire component code in order to determine / verify whether the list is complete.

Mon, Oct 21, 9:36 AM
Harbormaster failed to build B9853: rP23085: New Elm trees. for rP23085: New Elm trees.!
Mon, Oct 21, 9:04 AM
Stan committed rP23085: New Elm trees..
New Elm trees.
Mon, Oct 21, 8:37 AM
Angen awarded D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes a Love token.
Mon, Oct 21, 8:13 AM

Yesterday

Harbormaster failed to build B9852: rP23084: New lavender actors. for rP23084: New lavender actors. !
Sun, Oct 20, 10:58 PM
Stan committed rP23084: New lavender actors. .
New lavender actors.
Sun, Oct 20, 10:53 PM
Vulcan added a comment to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 7:50 PM
Harbormaster failed remote builds in B9851: Diff 10188 for D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding!
Sun, Oct 20, 7:49 PM
Vulcan added a comment to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Oct 20, 7:49 PM
elexis updated the diff for D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Remove ceasefire and thus Time.js and extendedSimState argument for InsertValues.

Sun, Oct 20, 7:49 PM
elexis added inline comments to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Sun, Oct 20, 7:46 PM
Vulcan added a comment to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 7:42 PM
Freagarach added inline comments to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Sun, Oct 20, 7:41 PM
Vulcan added a comment to D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Oct 20, 7:41 PM
Harbormaster failed remote builds in B9850: Diff 10187 for D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding!
Sun, Oct 20, 7:41 PM
elexis created D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.
Sun, Oct 20, 7:41 PM
elexis added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Mostly wondering whether there would be a reason to deem this patch bad, trying to identify a reason why this should not be in the templates but should be in the code.
I fail to find such a reason and it's actually bad to hardcode values in the code. Perhaps one could argue that while the purpose of templates is store values for components, the superseding purpose of templates is to remain moddable while these values are not freely moddable, because the summary screen and lobby bot require some of these values to be present. But I would counter to that that the JS arrays and objects in the summary screen code also look quite modifiable, both in the StatisticsTracker and reportGame in session.js and equally appear like a manual selection of nice classes like here in the template.
So if someone was to hold that point, consequentially the summary screen would have to be changed to work without hardcoded classes, without making any expectations as to what is in the playerState. Then this patch is still correct and not adding a regression, but its the summary screen hardcoding that would be broken. Hence must commit, no?

Sun, Oct 20, 7:29 PM
Freagarach added inline comments to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Sun, Oct 20, 7:17 PM
elexis added inline comments to rP14703: Better summary screen. Fixes #686. Patch by Bajter and Kabzerek.
Sun, Oct 20, 7:05 PM
Vulcan added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 5:55 PM
elexis added inline comments to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Sun, Oct 20, 5:53 PM
Vulcan added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 5:52 PM
elexis updated the diff for D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Fix tests.

Sun, Oct 20, 5:51 PM
Harbormaster failed remote builds in B9848: Diff 10185 for D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes!
Sun, Oct 20, 5:36 PM
Vulcan added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Oct 20, 5:36 PM
Vulcan added a comment to D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.

Build failure - The Moirai have given mortals hearts that can endure.

Sun, Oct 20, 5:36 PM
elexis created D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.
Sun, Oct 20, 5:35 PM
elexis added a comment to rP22984: Enable workshops for all civilisations..

From a23b lobby 2019-09-25:

(08:11:09 PM) faction02: elexis someone should check the codes changes made for the sieges workshops
(08:11:23 PM) faction02: kushites can upgrade bolts now...
(08:11:47 PM) ValihrAnt: i was so happy that the workshop let kush get techs for towers that i didnt even notice that xd

Sun, Oct 20, 5:11 PM
elexis added inline comments to rP14703: Better summary screen. Fixes #686. Patch by Bajter and Kabzerek.
Sun, Oct 20, 4:44 PM
elexis added inline comments to rP14752: Reformat the database to accept the additional summary counters as well as….
Sun, Oct 20, 4:41 PM
elexis added inline comments to rP14098: Multiplayer lobby based on the XmPP protocol. Special thanks to Philip….
Sun, Oct 20, 4:36 PM
elexis added inline comments to rP18395: Capture statistics summary. Patch by maveric and Imarok, fixes #3216..
Sun, Oct 20, 4:21 PM
elexis added inline comments to rP16624: Add optional ceasefire time to the game. Patch by elexis. Fixes #2749.
Sun, Oct 20, 4:20 PM
elexis added a comment to D1613: Improve the plural translation of the "<players> have won" string.

From http://irclogs.wildfiregames.com/2019-10/2019-10-20-QuakeNet-%230ad-dev.log:

(03:28:37 PM) elexis: gallaecio: perhaps we can just remove the "and"?
(03:29:03 PM) elexis: the provided arguments only seem to work for english and similar languages
(03:29:17 PM) elexis: v1, v2, ..., v(n-1) and v(n)
(03:29:46 PM) elexis: but some language might want to do
(03:29:46 PM) elexis: v1 something v2 somethingelse ..., v(n-1) somethingelsetoo v(n)
(03:30:06 PM) elexis: so why not just pass a list of players in any case
(03:33:12 PM) gallaecio: That would work form me. I’ll update the patch next week.
(03:33:31 PM) elexis: bb: that would work for you too? ^
(03:42:26 PM) bb: That could work
Sun, Oct 20, 4:17 PM
elexis added inline comments to rP19584: Fix economy and military score.
Sun, Oct 20, 3:53 PM
elexis added inline comments to rP19584: Fix economy and military score.
Sun, Oct 20, 3:31 PM
elexis added a comment to rP20543: Count Trained Cattle as resource and not as unit. Also only count the net….

Also as pointed out by causative, calculateEconomyScore should at least get a comment that it takes the vegetarianFood into account twice.

Sun, Oct 20, 3:17 PM
elexis updated the summary of D1052: Count Trained Cattle as resource and not as unit (And another cattle fix).
Sun, Oct 20, 3:14 PM
elexis raised a concern with rP20543: Count Trained Cattle as resource and not as unit. Also only count the net….

See inline comment.

Sun, Oct 20, 3:03 PM
Freagarach added inline comments to rP23082: list heroes after champions and correct some structure tooltips.
Sun, Oct 20, 2:52 PM
Polakrity added inline comments to rP23082: list heroes after champions and correct some structure tooltips.
Sun, Oct 20, 2:34 PM
Freagarach added inline comments to rP23082: list heroes after champions and correct some structure tooltips.
Sun, Oct 20, 2:01 PM
Polakrity added inline comments to rP23082: list heroes after champions and correct some structure tooltips.
Sun, Oct 20, 1:53 PM
Gallaecio added a comment to D1674: Check translations for sprintf errors.

Should we get this script merged, to make it easier to use it next time?

Sun, Oct 20, 1:50 PM
Gallaecio added a comment to D2226: Use standarized phrasing and terminology for the Patriot aura description.

I’ve just posted https://wildfiregames.com/forum/index.php?/topic/27150-wording-attack-repeat-time-vs-attack-time-vs-time-between-attacks-vs-attack-speed/ to discuss this, and CC’d people both from here and from https://trac.wildfiregames.com/ticket/3600

Sun, Oct 20, 1:41 PM
Harbormaster failed to build B9847: rP23083: Rephrase the tooltip of Reload Cache to avoid confusion for rP23083: Rephrase the tooltip of Reload Cache to avoid confusion!
Sun, Oct 20, 1:35 PM
Vulcan added a comment to D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 1:29 PM
Vulcan added a comment to D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 1:26 PM
Vulcan added a comment to D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 1:23 PM
Vulcan added a comment to D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

Successful build - Chance fights ever on the side of the prudent.

Sun, Oct 20, 1:22 PM
Gallaecio committed rP23083: Rephrase the tooltip of Reload Cache to avoid confusion.
Rephrase the tooltip of Reload Cache to avoid confusion
Sun, Oct 20, 1:21 PM
Gallaecio closed D2294: Rephrase the tooltip of Reload Cache to avoid confusion.
Sun, Oct 20, 1:21 PM
Gallaecio retitled D2294: Rephrase the tooltip of Reload Cache to avoid confusion from [WIP] Rephrase the tooltip of Reload Cache to avoid confusion to Rephrase the tooltip of Reload Cache to avoid confusion.
Sun, Oct 20, 1:20 PM
Gallaecio updated the diff for D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

Restore the previous tooltip wording

Sun, Oct 20, 1:19 PM
Gallaecio updated the diff for D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

Reload → Rebuild

Sun, Oct 20, 1:18 PM
elexis added a comment to D2306: remove "Goods" from trade window stings.

(Also notice that the code still uses the wording goods:)

Trader.js:	this.goods = {
Trader.js:		this.goods.amount = this.CalculateGain(this.markets[0], this.markets[1]);
Trader.js:	// Drop carried goods if markets were changed
Trader.js:	this.goods.amount = null;
Trader.js:		cmpPlayer.AddResource(this.goods.type, gain);
Trader.js:	this.AddResources(this.entity, this.goods.amount.traderGain);
Trader.js:	if (this.goods.amount.market1Gain)
Trader.js:		this.AddResources(currentMarket, this.goods.amount.market1Gain);
Trader.js:	if (this.goods.amount.market2Gain)
Trader.js:		this.AddResources(nextMarket, this.goods.amount.market2Gain);
Trader.js:		this.goods.amount = null;
Trader.js:	if (this.goods.amount && this.goods.amount.traderGain)
Trader.js:	this.goods.type = cmpPlayer.GetNextTradingGoods();
Trader.js:	this.goods.amount = this.CalculateGain(currentMarket, nextMarket);
Trader.js:	this.goods.origin = currentMarket;
Trader.js:Trader.prototype.GetGoods = function()
Trader.js:	return this.goods;
Trader.js:	this.goods.amount = null;
Trader.js:		this.goods.amount = this.CalculateGain(this.markets[0], this.markets[1]);
UnitAI.js:	let amount = cmpTrader.GetGoods().amount;
Player.js:	this.tradingGoods = []; // goods for next trade-route and its proba in % (the sum of probas must be 100)
Player.js:	// Trading goods probability in steps of 5
Player.js:		this.tradingGoods.push({
Player.js:			"goods": resTradeCodes[i],
Player.js:Player.prototype.GetNextTradingGoods = function()
Player.js:	var last = this.tradingGoods.length - 1;
Player.js:		sumProba += this.tradingGoods[i].proba;
Player.js:			return this.tradingGoods[i].goods;
Player.js:	return this.tradingGoods[last].goods;
Player.js:Player.prototype.GetTradingGoods = function()
Player.js:	var tradingGoods = {};
Player.js:	for (let resource of this.tradingGoods)
Player.js:		tradingGoods[resource.goods] = resource.proba;
Player.js:	return tradingGoods;
Player.js:Player.prototype.SetTradingGoods = function(tradingGoods)
Player.js:	for (let resource in tradingGoods)
Player.js:		if (resTradeCodes.indexOf(resource) == -1 || tradingGoods[resource] < 0)
Player.js:			error("Invalid trading goods: " + uneval(tradingGoods));
Player.js:		sumProba += tradingGoods[resource];
Player.js:		error("Invalid trading goods probability: " + uneval(sumProba));
Player.js:	this.tradingGoods = [];
Player.js:	for (let resource in tradingGoods)
Player.js:		this.tradingGoods.push({
Player.js:			"goods": resource,
Player.js:			"proba": tradingGoods[resource]
Looter.js:		cmpTrader && cmpTrader.GetGoods()
GuiInterface.js:			"goods": cmpTrader.GetGoods()
GuiInterface.js:			result.gain = cmpEntityTrader.GetGoods().amount;
GuiInterface.js:			"gain": cmpEntityTrader.GetGoods().amount,
GuiInterface.js:GuiInterface.prototype.GetTradingGoods = function(player)
GuiInterface.js:	return QueryPlayerIDInterface(player).GetTradingGoods();
GuiInterface.js:	"GetTradingGoods": 1,
Sun, Oct 20, 1:14 PM
elexis added a comment to D2306: remove "Goods" from trade window stings.

The XML file was moved to session/trade/ and the barter and trade panel of the dialog were moved to individual files in rP23072. The values didn't change if Im not mistaken.

Sun, Oct 20, 1:12 PM
Gallaecio added inline comments to D2306: remove "Goods" from trade window stings.
Sun, Oct 20, 1:11 PM
Gallaecio accepted D2306: remove "Goods" from trade window stings.

I’m not against the use of ‘goods’ in the context of trade, where it’s the right word to refer to “tradeable resources”, but since in 0 A.D. all resources are tradeable, I’m OK with the change.

Sun, Oct 20, 1:09 PM
Harbormaster failed to build B9844: rP23082: list heroes after champions and correct some structure tooltips for rP23082: list heroes after champions and correct some structure tooltips!
Sun, Oct 20, 1:04 PM
Gallaecio added a comment to D2312: Single Player → single-player.

Single-player is proper English, single player and singleplayer are less correct.

Sun, Oct 20, 1:04 PM
Gallaecio committed rP23082: list heroes after champions and correct some structure tooltips.
list heroes after champions and correct some structure tooltips
Sun, Oct 20, 12:57 PM
Gallaecio closed D2324: list heroes after champions and correct some structure tooltips.
Sun, Oct 20, 12:57 PM
Gallaecio accepted D2324: list heroes after champions and correct some structure tooltips.
Sun, Oct 20, 12:56 PM

Sat, Oct 19

Vulcan added a comment to D2382: [WIP] - Building Sockets..

Successful build - Chance fights ever on the side of the prudent.

Sat, Oct 19, 11:30 PM
Vulcan added a comment to D2382: [WIP] - Building Sockets..

Successful build - Chance fights ever on the side of the prudent.

Sat, Oct 19, 11:18 PM
Freagarach added inline comments to D2382: [WIP] - Building Sockets..
Sat, Oct 19, 11:16 PM
Freagarach updated the diff for D2382: [WIP] - Building Sockets..
  • Renamed Settlement.js.
  • Every terrain as long as a socket exists (sockets not yet implemented).
  • cmpObstruction.CheckSocketPlacement(SlotTemplate). <- Not used yet.
Sat, Oct 19, 11:15 PM
Freagarach updated the test plan for D2370: Let splash radius be affected by techs..
Sat, Oct 19, 6:06 PM
Freagarach added a comment to D2382: [WIP] - Building Sockets..

I compleately overlooked Settlement.js,,,
A socket building only should check for the socket to exist and whether it is obstructed, not the type of terrain, IMHO.
Furthermore it should have a special check in BuildRestrictions.js, similar to the shore-check, whether the location is within a socket (cmpObstruction.CheckSlotPlacement(SlotTemplate)?).
Snapping should be indeed introduced and can (partly?) be reused from the wall snapping.

Sat, Oct 19, 10:58 AM
Harbormaster failed to build B9842: rP23081: Rewrite developer overlay to use class syntax, one class per checkbox, a class… for rP23081: Rewrite developer overlay to use class syntax, one class per checkbox, a class…!
Sat, Oct 19, 2:33 AM
elexis committed rP23081: Rewrite developer overlay to use class syntax, one class per checkbox, a class….
Rewrite developer overlay to use class syntax, one class per checkbox, a class…
Sat, Oct 19, 2:27 AM
elexis closed D2383: Rewrite DeveloperOverlay and TimeWarp to use class syntax and split classes.
Sat, Oct 19, 2:27 AM
elexis updated the summary of D2383: Rewrite DeveloperOverlay and TimeWarp to use class syntax and split classes.
Sat, Oct 19, 2:09 AM
elexis updated the summary of D2383: Rewrite DeveloperOverlay and TimeWarp to use class syntax and split classes.
Sat, Oct 19, 1:58 AM
elexis added a comment to D2383: Rewrite DeveloperOverlay and TimeWarp to use class syntax and split classes.

For the Set vs Array difference, iteration performance is what matters most.

Sat, Oct 19, 1:52 AM
Vulcan added a comment to D2383: Rewrite DeveloperOverlay and TimeWarp to use class syntax and split classes.

Successful build - Chance fights ever on the side of the prudent.

Sat, Oct 19, 1:36 AM
Harbormaster failed remote builds in B9841: Diff 10178 for D2383: Rewrite DeveloperOverlay and TimeWarp to use class syntax and split classes!
Sat, Oct 19, 1:33 AM
Vulcan added a comment to D2383: Rewrite DeveloperOverlay and TimeWarp to use class syntax and split classes.

Build failure - The Moirai have given mortals hearts that can endure.

Sat, Oct 19, 1:33 AM
elexis created D2383: Rewrite DeveloperOverlay and TimeWarp to use class syntax and split classes.
Sat, Oct 19, 1:33 AM
elexis added a comment to F1100948: r23063 replay, at min 34, go2die lost 25 naked fanatics due to pathfinding problems at a narrow passage.

Ticket at #5624

Sat, Oct 19, 1:27 AM
Stan added a comment to D2382: [WIP] - Building Sockets..

The Settlement.js class should be updated/deleted/renamed :)

Sat, Oct 19, 1:19 AM

Fri, Oct 18

Vulcan added a comment to D2382: [WIP] - Building Sockets..

Successful build - Chance fights ever on the side of the prudent.

Fri, Oct 18, 11:00 PM
Vulcan added a comment to D2382: [WIP] - Building Sockets..

Successful build - Chance fights ever on the side of the prudent.

Fri, Oct 18, 10:51 PM
Freagarach created D2382: [WIP] - Building Sockets..
Fri, Oct 18, 10:48 PM
Krinkle updated Krinkle.
Fri, Oct 18, 9:56 PM
Stan added inline comments to D2379: Give the GarrisonHolder component the power to set garrisoned on an entity with UnitAI, instead of leaving it to UnitAI..
Fri, Oct 18, 7:45 PM