Page MenuHomeWildfire Games
Feed All Stories

Today

Stan added inline comments to rP22196: Correctly handle receiving 0 damage as not receiving any damage..
Sat, Apr 20, 12:06 AM

Yesterday

wraitii added a comment to rP22197: Change Run Speed into a Run multiplier..

but I don't really see the point (in terms of C++ code vs template cleanliness).

(I can't imagine that it would leave the C++ code in an uglier state)

Fri, Apr 19, 10:23 PM
wraitii planned changes to D1830: Const-correct the hierarchical pathfinder (D53 outtake).
Fri, Apr 19, 10:21 PM
wraitii added a comment to D1830: Const-correct the hierarchical pathfinder (D53 outtake).

Yup, and I think I've actually messed it up but I'll check with an upstream diff.

Fri, Apr 19, 10:21 PM
wraitii added inline comments to D53: D13 prerequisite 8: Upgrade the hierarchical pathfinder.
Fri, Apr 19, 10:20 PM
elexis added a comment to rP22197: Change Run Speed into a Run multiplier..

make the run multiplier optional and handle that specifically

That's what I was wondering about - whether there was a limit check in place before somewhere, I didn't find one from a quick look.

Fri, Apr 19, 10:19 PM
elexis added a comment to D1830: Const-correct the hierarchical pathfinder (D53 outtake).

const-correct

(I guess the previous code was not incorrect, but adding the const adds benefits)

Fri, Apr 19, 9:20 PM
wraitii added a comment to rP22197: Change Run Speed into a Run multiplier..

Formations have a 100 run multiplier which effectively sets their maximal walking speed at 100

https://code.wildfiregames.com/D438?id=7178#inline-34668

Sounds hackish

Indeed, why is that run multiplier 100 and not left undefined, or to be defined by the specific formations?

Fri, Apr 19, 9:16 PM
elexis updated subscribers of rP22196: Correctly handle receiving 0 damage as not receiving any damage..
Fri, Apr 19, 9:13 PM
elexis added a comment to rP22197: Change Run Speed into a Run multiplier..

Formations have a 100 run multiplier which effectively sets their maximal walking speed at 100

https://code.wildfiregames.com/D438?id=7178#inline-34668

Sounds hackish

Indeed, why is that run multiplier 100 and not left undefined, or to be defined by the specific formations?

Fri, Apr 19, 9:10 PM
wraitii added inline comments to rP22196: Correctly handle receiving 0 damage as not receiving any damage..
Fri, Apr 19, 9:02 PM
elexis added a comment to rP22196: Correctly handle receiving 0 damage as not receiving any damage..

Very informative description by Angen that was used in the commit message, thanks for writing and chosing that.
(I hope you have examined possible edge cases)

Fri, Apr 19, 8:17 PM
wraitii added a child revision for D1830: Const-correct the hierarchical pathfinder (D53 outtake): D1832: Hierarchical pathfinder: fix an issue with regions and some touch-ups (D53 outtake).
Fri, Apr 19, 6:56 PM
wraitii added a parent revision for D1832: Hierarchical pathfinder: fix an issue with regions and some touch-ups (D53 outtake): D1830: Const-correct the hierarchical pathfinder (D53 outtake).
Fri, Apr 19, 6:56 PM
wraitii added inline comments to D1832: Hierarchical pathfinder: fix an issue with regions and some touch-ups (D53 outtake).
Fri, Apr 19, 6:51 PM
Harbormaster failed remote builds in B7216: Diff 7776 for D1832: Hierarchical pathfinder: fix an issue with regions and some touch-ups (D53 outtake)!
Fri, Apr 19, 6:51 PM
Vulcan added a comment to D1832: Hierarchical pathfinder: fix an issue with regions and some touch-ups (D53 outtake).

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Apr 19, 6:50 PM
wraitii created D1832: Hierarchical pathfinder: fix an issue with regions and some touch-ups (D53 outtake).
Fri, Apr 19, 6:50 PM
Stan added a comment to D665: Make ship pickup nicer.

@wraitii This year maybe ? ;)

Fri, Apr 19, 6:14 PM
Stan added a comment to D1764: Dynamically sizes the dataCounter overlay.

Binary files should be removed from the diff :)

Fri, Apr 19, 6:07 PM
Vulcan added a comment to D1831: Some more pathfinder tests (D53 outtake).

Successful build - Chance fights ever on the side of the prudent.

Fri, Apr 19, 6:04 PM
Stan edited reviewers for D1670: Remove references to globals, added: Restricted Owners Package; removed: causative.
Fri, Apr 19, 6:03 PM
Stan requested changes to D1670: Remove references to globals.

Needs to be rebased.

Fri, Apr 19, 6:02 PM
wraitii created D1831: Some more pathfinder tests (D53 outtake).
Fri, Apr 19, 6:01 PM
Vulcan added a comment to D1830: Const-correct the hierarchical pathfinder (D53 outtake).

Successful build - Chance fights ever on the side of the prudent.

Fri, Apr 19, 5:58 PM
Vulcan added a comment to D1829: Make Pathgoal::NavcellContainsSquare use only the top/left edge of the square (D53 outtake).

Successful build - Chance fights ever on the side of the prudent.

Fri, Apr 19, 5:55 PM
wraitii created D1830: Const-correct the hierarchical pathfinder (D53 outtake).
Fri, Apr 19, 5:55 PM
wraitii updated the summary of D1829: Make Pathgoal::NavcellContainsSquare use only the top/left edge of the square (D53 outtake).
Fri, Apr 19, 5:52 PM
wraitii created D1829: Make Pathgoal::NavcellContainsSquare use only the top/left edge of the square (D53 outtake).
Fri, Apr 19, 5:51 PM
Stan added inline comments to D1491: Const-Correct the long range pathfinder.
Fri, Apr 19, 2:54 PM
Stan added a comment to D359: Water shader improvements: fix some of the redness, fix edge-of-map showing up, improve entity-under-water, slight improvement to reflection edges..

Might want to commit the whitespace changes separately :)

Fri, Apr 19, 1:23 PM
Vulcan added a comment to D359: Water shader improvements: fix some of the redness, fix edge-of-map showing up, improve entity-under-water, slight improvement to reflection edges..

Successful build - Chance fights ever on the side of the prudent.

Fri, Apr 19, 12:53 PM
wraitii updated the diff for D359: Water shader improvements: fix some of the redness, fix edge-of-map showing up, improve entity-under-water, slight improvement to reflection edges..

Fix all whitespace I've regex-ed in water_high.fs, address vlad's comments.

Fri, Apr 19, 12:47 PM
wraitii accepted D1333: Precompiled update.

Measured by time, after a make clean, running make pyrogenesis -o2 -j3

Fri, Apr 19, 12:27 PM
wraitii committed rP22197: Change Run Speed into a Run multiplier..
Change Run Speed into a Run multiplier.
Fri, Apr 19, 12:05 PM
wraitii closed D438: Change Run Speed into a Run multiplier.
Fri, Apr 19, 12:05 PM
Vulcan added a comment to D1482: Target build version explicitly for Xcode.

Successful build - Chance fights ever on the side of the prudent.

Fri, Apr 19, 12:02 PM
Vulcan added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

Successful build - Chance fights ever on the side of the prudent.

Fri, Apr 19, 11:56 AM
Vulcan added a comment to D1828: Health.js cleanup: add tests, add an "IsInjured" function, use GetHitpoints everywhere.

Successful build - Chance fights ever on the side of the prudent.

Fri, Apr 19, 11:50 AM
wraitii updated the diff for D1482: Target build version explicitly for Xcode.

Do not change minimal OSX version

Fri, Apr 19, 11:46 AM
wraitii updated the diff for D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

const-correct, @Itms I'm putting this up for you to accept it.

Fri, Apr 19, 11:37 AM
wraitii created D1828: Health.js cleanup: add tests, add an "IsInjured" function, use GetHitpoints everywhere.
Fri, Apr 19, 11:17 AM
wraitii committed rP22196: Correctly handle receiving 0 damage as not receiving any damage..
Correctly handle receiving 0 damage as not receiving any damage.
Fri, Apr 19, 11:13 AM
wraitii closed D1769: Do not mark unit as injured when receives 0 damage.
Fri, Apr 19, 11:13 AM
autobuild committed rP22195: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Apr 19, 9:59 AM
LordGood committed rP22194: cattails fix.
cattails fix
Fri, Apr 19, 12:19 AM

Thu, Apr 18

Stan committed rP22193: Remove useless files that contained placeholder objects (boxes).
Remove useless files that contained placeholder objects (boxes)
Thu, Apr 18, 6:05 PM
Vulcan added a comment to D1584: Seed random sounds.

Successful build - Chance fights ever on the side of the prudent.

Thu, Apr 18, 2:06 PM
Stan updated the diff for D1584: Seed random sounds.
  • Initialize private member before using it.
Thu, Apr 18, 2:05 PM
Itms added a member for Contributors: happyconcepts.
Thu, Apr 18, 11:35 AM
Itms committed rDDfd7e49d4e5a3: Corrected Mauryans* into Mauryas. (authored by Itms).
Corrected Mauryans* into Mauryas.
Thu, Apr 18, 11:10 AM

Wed, Apr 17

Stan added inline comments to D1763: Removes duplication of Clamp function.
Wed, Apr 17, 6:50 PM
Stan added a comment to D1584: Seed random sounds.

@vladislavbelov Can you recheck that everything is fine so I can commit it ?

Wed, Apr 17, 6:47 PM
Vulcan added a comment to D1584: Seed random sounds.

Successful build - Chance fights ever on the side of the prudent.

Wed, Apr 17, 6:43 PM
Stan updated the diff for D1584: Seed random sounds.
  • Fix incorrect function call
  • Remove deleted whitespace
Wed, Apr 17, 6:41 PM
Harbormaster failed remote builds in B7200: Diff 7762 for D1584: Seed random sounds!
Wed, Apr 17, 6:38 PM
Vulcan added a comment to D1584: Seed random sounds.

Build failure - The Moirai have given mortals hearts that can endure.

Wed, Apr 17, 6:38 PM
Stan updated the diff for D1584: Seed random sounds.
  • Use the fast random function
  • Make function and variables members of the SoundGroup.cpp class.
  • Make them non static as it doesn't matter as they are constantly overridden.
Wed, Apr 17, 6:36 PM
Stan added a comment to D1584: Seed random sounds.
cl.exe file.cpp /fp:precise
file.cpp
Microsoft (R) Incremental Linker Version 14.00.24245.0
Copyright (C) Microsoft Corporation.  All rights reserved.
Wed, Apr 17, 6:13 PM
Angen added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Wed, Apr 17, 3:37 PM
Vulcan added a comment to D1790: Separate stable from barracks.

Successful build - Chance fights ever on the side of the prudent.

Wed, Apr 17, 10:54 AM
Nescio updated the diff for D1790: Separate stable from barracks.
Wed, Apr 17, 10:53 AM
wraitii added a comment to D1584: Seed random sounds.

I mean if we don't really care about actual randomness (which it seems we don't), maybe something from there: https://stackoverflow.com/questions/1640258/need-a-fast-random-generator-for-c
Like this should be super-fast and should be enough:

Wed, Apr 17, 10:43 AM
Stan added a comment to D1769: Do not mark unit as injured when receives 0 damage.

That works however I'm not sure what are the bounds of the generated number. I tried to divide it by std::limits<int>::max() but I only get 10^-6 numbers.

Wed, Apr 17, 10:29 AM
wraitii added a comment to D1769: Do not mark unit as injured when receives 0 damage.
Wed, Apr 17, 9:48 AM
Stan added a comment to D1584: Seed random sounds.

@wraitii Any idea on what could be faster than a MT19973 ? srand() would have been perfect but we cannot use it.

Wed, Apr 17, 9:40 AM
Stan added a comment to D1769: Do not mark unit as injured when receives 0 damage.

Can you fix the JSDOC comment ? :)

Wed, Apr 17, 9:39 AM

Tue, Apr 16

happyconcepts updated the diff for D1803: Communicate field diminishing returns to the player.

as discussed on phab

Tue, Apr 16, 11:29 PM
bb added inline comments to rP20939: Garrisoned units are lost after an upgrade towards a non garrison holder.
Tue, Apr 16, 11:16 PM
bb accepted rP20393: Move out of world promoted, packed and upgraded entity as they are not….

concern fixed by rP20939

Tue, Apr 16, 11:16 PM
Angen awarded rP22192: Add missing parenthesis in the Petra diplomacyManager. Else the requested… a Like token.
Tue, Apr 16, 7:41 PM
Vulcan added a comment to D1769: Do not mark unit as injured when receives 0 damage.

Successful build - Chance fights ever on the side of the prudent.

Tue, Apr 16, 7:37 PM
Angen updated the diff for D1769: Do not mark unit as injured when receives 0 damage.

move comment to better place

Tue, Apr 16, 7:34 PM
smiley added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Tue, Apr 16, 6:47 PM
Stan committed rP22192: Add missing parenthesis in the Petra diplomacyManager. Else the requested….
Add missing parenthesis in the Petra diplomacyManager. Else the requested…
Tue, Apr 16, 6:40 PM
Stan closed D1826: Fix missing parenthesis in the AI.
Tue, Apr 16, 6:40 PM
Stan added inline comments to rP22023: Always leave/reenter the top-most FSM state when SetNextState is called with….
Tue, Apr 16, 6:36 PM
bb accepted D1826: Fix missing parenthesis in the AI.
Tue, Apr 16, 6:14 PM
Vulcan added a comment to D1826: Fix missing parenthesis in the AI.

Successful build - Chance fights ever on the side of the prudent.

Tue, Apr 16, 5:54 PM
Stan created D1826: Fix missing parenthesis in the AI.
Tue, Apr 16, 5:52 PM
wraitii added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Tue, Apr 16, 5:39 PM
smiley added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Tue, Apr 16, 5:19 PM
wraitii added inline comments to D1737: Slight cleanup of fogging OnDestroy and some comments.
Tue, Apr 16, 5:02 PM
Itms added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

This new method should be const. But apart from that this looks good to me.

Tue, Apr 16, 4:38 PM
Stan added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

@Itms @vladislavbelov Any other comments ?

Tue, Apr 16, 3:46 PM
bb added inline comments to D1737: Slight cleanup of fogging OnDestroy and some comments.
Tue, Apr 16, 2:06 PM
wraitii added a comment to D1739: Replace EntityMap, std::map, std::unordered_map and boost::unordered_map with an upgraded container.
In D1739#75035, @Stan wrote:

This really needs to be used for components before I decide if it's worth merging, but as it changes hashes it's kind of annoying. I'll probably have to do some fancy tests at some point.

When you committed last time it wasn't ?

Tue, Apr 16, 1:43 PM
Stan added a reviewer for D1803: Communicate field diminishing returns to the player: Gallaecio.
In D1803#74329, @bb wrote:

changing vegetables to grain wouldn't work since f.e. the Chinese mod has rise fields instead. One could consider "crops" though.

The string but at reduced efficiency doesn't specify when the efficiency is reduced, so it doesn't help explaining what is going on. Maybe Harvest crops for food. Up to 5 units can gather, but each subsequent gatherer reduces the efficiency per worker.

Tue, Apr 16, 10:26 AM
Stan added a comment to D1739: Replace EntityMap, std::map, std::unordered_map and boost::unordered_map with an upgraded container.

This really needs to be used for components before I decide if it's worth merging, but as it changes hashes it's kind of annoying. I'll probably have to do some fancy tests at some point.

Tue, Apr 16, 10:23 AM
wraitii added a comment to D1739: Replace EntityMap, std::map, std::unordered_map and boost::unordered_map with an upgraded container.

This really needs to be used for components before I decide if it's worth merging, but as it changes hashes it's kind of annoying. I'll probably have to do some fancy tests at some point.

Tue, Apr 16, 9:43 AM
Nescio added a comment to D1803: Communicate field diminishing returns to the player.

Just update the diff, taking into account the suggestions raised in this discussion, then people can request further changes, or accept and commit this patch. The idea is to do things properly rather than quickly.

Tue, Apr 16, 9:34 AM
Nescio added a comment to D1815: match unit classes with templates.

(wasn't there some earlier revision where it was discussed?)

Yes, D1036.

Tue, Apr 16, 9:30 AM
Stan added a comment to D1739: Replace EntityMap, std::map, std::unordered_map and boost::unordered_map with an upgraded container.

Any news on this ?

Tue, Apr 16, 9:17 AM
Nescio added inline comments to D1791: Separate range from barracks.
Tue, Apr 16, 9:07 AM

Mon, Apr 15

bb committed rP22191: align the footprint an obstruction size with the model size for the kush range.
align the footprint an obstruction size with the model size for the kush range
Mon, Apr 15, 11:46 PM
bb committed rP22190: unparent the range from the barracks, and reduce the duplication in the civs'….
unparent the range from the barracks, and reduce the duplication in the civs'…
Mon, Apr 15, 11:40 PM
bb closed D1791: Separate range from barracks.
Mon, Apr 15, 11:40 PM
bb accepted D1791: Separate range from barracks.

Cav got removed from ranges (which makes sense)

Mon, Apr 15, 11:35 PM
Stan added inline comments to D1769: Do not mark unit as injured when receives 0 damage.
Mon, Apr 15, 11:05 PM
happyconcepts added a comment to D1803: Communicate field diminishing returns to the player.

Thanks for the feedback guys, appreciated.

Mon, Apr 15, 10:53 PM