Page MenuHomeWildfire Games
Feed All Stories

Today

wraitii added a comment to D2808: Allow resistance to StatusEffects..

I really fail to see how you want to find a typo in a name automically.

There's automatically and then there's "easily". We could detect close-names (such as capitalized/uncapitalized versions of the same string) quite easily with a script, and likewise typos aren't too complicated. Simply outputting all "known" status effect node-names would make it obvious if there are duplicates, and that's not extremely difficult to do.

Mon, Sep 28, 1:29 PM
bb abandoned D2767: Stop dodging arrows by spamclicking or patrol: Lower speed at short distances.

This patch has maximal gameplay impact and minimal fixed compared to D2837, D2913 and D3021

Mon, Sep 28, 12:22 PM
bb added a comment to D3021: Stop dodging arrows by spamclicking or patrol: Acceleration.

Also chasing is beyond broken

I actually find it a tad easier to hunt now, since the hunt does not speed away ^^

Have you tried attacking an infantry unit which is walking away with melee cav?

Mon, Sep 28, 12:09 PM
bb added a comment to D2808: Allow resistance to StatusEffects..

I somewhat disagree with @bb -> we have people looking at our templates quite closely,

Currently maybe, but we can't know if that is sustainable.

and we're supposed to test things,

I really fail to see how you want to find a typo in a name automically. It is more that plausible that the codes defer by 1 character and such and not all templates need to define everything.

and it's really just not that hard to make sure there are no typos.

It actually is, since the codes can be almost identical (1 character difference is enough, say a Cap vs lower case), so getting it from the template will be hard. And ingame one would need to look extremely closely too see if the resistance is applied (see the hero garrison aura not being applied for a long time, before we found out).

Forcing template writers to make JSON files isn't an improvement to me.

We already do for Auras and technologies.

Mon, Sep 28, 12:05 PM
autobuild committed rP24074: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Mon, Sep 28, 9:59 AM
wraitii added a comment to D2808: Allow resistance to StatusEffects..

That is also the case for damage types, right?

Mon, Sep 28, 9:05 AM
Freagarach added a comment to D2808: Allow resistance to StatusEffects..

That is also the case for damage types, right?
If you would require SE to have JSONs the templates could be simplified as well (no need for the translatable names in there I guess?).

Mon, Sep 28, 8:36 AM
Freagarach added a comment to D3021: Stop dodging arrows by spamclicking or patrol: Acceleration.

Also chasing is beyond broken

I actually find it a tad easier to hunt now, since the hunt does not speed away ^^

Mon, Sep 28, 8:27 AM
Freagarach added inline comments to D3020: Allow to set texture quality in config.
Mon, Sep 28, 7:52 AM
autobuild committed rP24073: [Windows] Automated build..
[Windows] Automated build.
Mon, Sep 28, 7:43 AM

Yesterday

bb added a comment to D2808: Allow resistance to StatusEffects..

What gives me a bit of a stomachache is the fact the codes of the statuseffects can be completely arbitrary, but still need to match for resistances to apply. 1 typo in the resistance and the resistance will silently not work. Imho all statusEffects should have an json and give a big fat error otherwise.

Sun, Sep 27, 11:51 PM
bb added a comment to D1613: Improve the plural translation of the "<players> have won" string.

Not really satisfied with this solution, since we now try to fix translations ourselfs for some specifc cases (n=1, n=2, n>2). That does no allow the full generality:

(03:29:46 PM) elexis: v1 something v2 somethingelse ..., v(n-1) somethingelsetoo v(n)

Also as the Gnu getText documentation says The consequence of this is that application writers should not try to solve the problem in their code.

Sun, Sep 27, 10:03 PM
Angen added a comment to D2423: Do not use GPUSkinning without glsl [Crash fix].

so you suggest to add variable to keep track if gpu skinning was disabled or to write custom getter for gpuskinning and disable it silently?

Sun, Sep 27, 9:39 PM
Stan added inline comments to D2423: Do not use GPUSkinning without glsl [Crash fix].
Sun, Sep 27, 8:25 PM
vladislavbelov added inline comments to D2423: Do not use GPUSkinning without glsl [Crash fix].
Sun, Sep 27, 8:18 PM
Stan added inline comments to D2423: Do not use GPUSkinning without glsl [Crash fix].
Sun, Sep 27, 8:14 PM
vladislavbelov added inline comments to D2423: Do not use GPUSkinning without glsl [Crash fix].
Sun, Sep 27, 8:09 PM
Stan added inline comments to D2423: Do not use GPUSkinning without glsl [Crash fix].
Sun, Sep 27, 7:58 PM
vladislavbelov added inline comments to D2423: Do not use GPUSkinning without glsl [Crash fix].
Sun, Sep 27, 7:05 PM
Vulcan added a comment to D2423: Do not use GPUSkinning without glsl [Crash fix].

Successful build - Chance fights ever on the side of the prudent.

Sun, Sep 27, 6:52 PM
Angen updated the diff for D2423: Do not use GPUSkinning without glsl [Crash fix].

fix check

Sun, Sep 27, 6:47 PM
Angen added inline comments to D2423: Do not use GPUSkinning without glsl [Crash fix].
Sun, Sep 27, 6:45 PM
Stan added inline comments to D2423: Do not use GPUSkinning without glsl [Crash fix].
Sun, Sep 27, 5:45 PM
Vulcan added a comment to D2423: Do not use GPUSkinning without glsl [Crash fix].

Successful build - Chance fights ever on the side of the prudent.

Sun, Sep 27, 4:35 PM
Angen updated the diff for D2423: Do not use GPUSkinning without glsl [Crash fix].

disable gpuskinning if glsl is disabled

Sun, Sep 27, 4:28 PM
Vulcan added a comment to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

Successful build - Chance fights ever on the side of the prudent.

Sun, Sep 27, 3:31 PM
bb added inline comments to D3021: Stop dodging arrows by spamclicking or patrol: Acceleration.
Sun, Sep 27, 3:26 PM
bb updated the diff for D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

fix test

Sun, Sep 27, 3:25 PM
Angen committed rP24072: Refactor UpdateMessageSubscriptions in CCmpRangeOverlayRenderer.
Refactor UpdateMessageSubscriptions in CCmpRangeOverlayRenderer
Sun, Sep 27, 3:12 PM
Angen closed D3009: Refactor UpdateMessageSubscriptions in CCmpRangeOverlayRenderer.
Sun, Sep 27, 3:12 PM
Angen added inline comments to D3020: Allow to set texture quality in config.
Sun, Sep 27, 3:06 PM
Angen added a comment to D2759: Update range queries to account for entity size.

Issue with parabolic query:

Sun, Sep 27, 2:52 PM
Stan added inline comments to D3020: Allow to set texture quality in config.
Sun, Sep 27, 2:48 PM
Angen added inline comments to D3020: Allow to set texture quality in config.
Sun, Sep 27, 2:21 PM
bb requested review of D3021: Stop dodging arrows by spamclicking or patrol: Acceleration.
Sun, Sep 27, 12:58 AM
bb updated the test plan for D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.
Sun, Sep 27, 12:44 AM
bb updated the test plan for D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.
Sun, Sep 27, 12:44 AM

Sat, Sep 26

bb accepted D2809: Don't detect audio card when audio is disabled.

don't forget to revert the config2 change

Sat, Sep 26, 9:26 PM
Vulcan added a comment to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

Build failure - The Moirai have given mortals hearts that can endure.

Sat, Sep 26, 9:05 PM
Vulcan added a comment to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

Build failure - The Moirai have given mortals hearts that can endure.

Sat, Sep 26, 9:04 PM
Vulcan added a comment to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

Build failure - The Moirai have given mortals hearts that can endure.

Sat, Sep 26, 9:02 PM
Vulcan added a comment to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

Build failure - The Moirai have given mortals hearts that can endure.

Sat, Sep 26, 8:54 PM
Stan requested review of D3020: Allow to set texture quality in config.
Sat, Sep 26, 8:51 PM
Vulcan added a comment to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

Build failure - The Moirai have given mortals hearts that can endure.

Sat, Sep 26, 8:47 PM
Vulcan added a comment to D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

Build failure - The Moirai have given mortals hearts that can endure.

Sat, Sep 26, 8:29 PM
Vulcan added a comment to D2809: Don't detect audio card when audio is disabled.

Successful build - Chance fights ever on the side of the prudent.

Sat, Sep 26, 8:24 PM
bb updated the diff for D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

Don't apply patches on patches bb, or at least work on 1 thing at the same time...

Sat, Sep 26, 8:14 PM
Stan added a comment to D3019: [art/actors] delete duplicate foundations.

Ideally there would be one rubble and one foundation per building but it's just too much work

Sat, Sep 26, 8:13 PM
bb updated the diff for D2837: Stop dodging arrows by spamclicking or patrol: Waste time turning.

Reuse the cmpPosition's turnRate, let formations really turn.

Sat, Sep 26, 8:10 PM
Vulcan added a comment to D2809: Don't detect audio card when audio is disabled.

Successful build - Chance fights ever on the side of the prudent.

Sat, Sep 26, 7:11 PM
Stan updated the diff for D2809: Don't detect audio card when audio is disabled.

Don't include useless headers instead

Sat, Sep 26, 7:00 PM
Vulcan added a comment to D2809: Don't detect audio card when audio is disabled.

Successful build - Chance fights ever on the side of the prudent.

Sat, Sep 26, 6:55 PM
bb added inline comments to D2809: Don't detect audio card when audio is disabled.
Sat, Sep 26, 6:53 PM
Stan updated the diff for D2809: Don't detect audio card when audio is disabled.

Remove newlines

Sat, Sep 26, 6:47 PM
Stan updated the diff for D2809: Don't detect audio card when audio is disabled.

Fix build when passing --without-audio

Sat, Sep 26, 6:40 PM
Nescio added a comment to D3019: [art/actors] delete duplicate foundations.

Line 63 is indeed different in the three 3x3 foundations.
And found them in Atlas:


There are not that many, though.
Also, not all walls are equally tall or thick, so perhaps a few more *_tower* and *_wall* versions ought to be created?

Sat, Sep 26, 2:44 PM
Angen updated the diff for D2652: Do not allow upgrading when entity is producing and vice versa..

actually use sort 2n -> n*logn
fix some comments

Sat, Sep 26, 2:26 PM
Stan added a comment to D3019: [art/actors] delete duplicate foundations.

Scaffoldings not the ground thing.

Sat, Sep 26, 2:20 PM
Nescio added a comment to D3019: [art/actors] delete duplicate foundations.

IIRC scaffolds are different for the wall foundations.

Are they? The actors looked the same in Atlas.

Sat, Sep 26, 2:17 PM
Stan added a comment to D3019: [art/actors] delete duplicate foundations.

IIRC scaffolds are different for the wall foundations.

Sat, Sep 26, 2:05 PM
Nescio requested review of D3019: [art/actors] delete duplicate foundations.
Sat, Sep 26, 2:03 PM
Stan added inline comments to D2809: Don't detect audio card when audio is disabled.
Sat, Sep 26, 12:42 PM
Vulcan added a comment to D2809: Don't detect audio card when audio is disabled.

Successful build - Chance fights ever on the side of the prudent.

Sat, Sep 26, 12:35 PM
Nescio removed a reviewer for D3018: nuba → noba: Angen.
Sat, Sep 26, 12:29 PM
Nescio requested review of D3018: nuba → noba.
Sat, Sep 26, 12:20 PM
Stan updated the diff for D2809: Don't detect audio card when audio is disabled.

Fix dumb race condition

Sat, Sep 26, 12:20 PM
Angen added a comment to D3005: Range safe buildingAI.

One could take look into performQuery function in parabolic range branch and see this checks looks like redundant
https://code.wildfiregames.com/source/0ad/browse/ps/trunk/source/simulation2/components/CCmpRangeManager.cpp$1210

Sat, Sep 26, 11:41 AM
bb updated the diff for D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

No sickle

Sat, Sep 26, 11:37 AM
bb added a comment to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

Different context == different translation

Good to know! I assume that also applies to no context? By the way, could you also add context to the <GenericName> of those templates, to allow consistency with <AttackName>?

no context != some context, also usually strings without context ought to be translated with a translate call, not a translateWithContext call. And those are pulled from a different part of the dictionary (the without context part).
In theory we can add context in a similar way for any template node (including GenericName). The GenericName translation code flow is however slightly different than we have for AttackName, so it isn't completely straightforward. In any case this should be the subject of another revision.

Sat, Sep 26, 11:36 AM
Vulcan added a comment to D3016: clean up structure templates build restriction categories, sounds etc.

Successful build - Chance fights ever on the side of the prudent.

Sat, Sep 26, 11:28 AM
Nescio added a comment to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

Different context == different translation

Good to know! I assume that also applies to no context? By the way, could you also add context to the <GenericName> of those templates, to allow consistency with <AttackName>?

You are right, also founda new type: kush_champ_amum has a Sickle. Also some heroes. 9 Singles on 51 swords now
EDIT: somehow feel Sickle is the wrong word, but can't find the correct one...

It's a khopesh, which is not a sickle-sword (i.e. pointing forward and sharp on the inside of the curve), but an axe-sword (i.e. pointing backwards and sharp on the outside of the curve). It's probably better to stick with ‘single-edged sword’, though.

Sat, Sep 26, 11:24 AM
Nescio planned changes to D2725: [art/actors] move foundations into a new folder.

outdated

Sat, Sep 26, 11:23 AM
Nescio planned changes to D3000: [work in progress] clean up and improve consistency in structure templates.

This patch should move actor-related nodes (footprint, obstruction, rubble, foundation actor) from the generic template_structure_* to the specific structures/* templates. Everything else ought to be split off.

Sat, Sep 26, 11:23 AM
Nescio updated the diff for D3016: clean up structure templates build restriction categories, sounds etc.
  • remove unnecessary campaign_city_* <Attack> lines
Sat, Sep 26, 11:23 AM
Stan updated subscribers of rP23926: Fix issues relating to SDL and wxWidgets interaction in Atlas..

Could be the --macosx-version-min=10.9 flag cc @Itms

Sat, Sep 26, 11:21 AM
Angen raised a concern with rP23926: Fix issues relating to SDL and wxWidgets interaction in Atlas..

Mac-OS build is failing since this commit, see jenkins logs
../../../source/lib/sysdep/os/osx/osx_atlas.mm:49:2: error: type arguments cannot be applied to non-parameterized class 'NSDictionary'

Sat, Sep 26, 11:15 AM
Stan requested review of D3017: macOs warning fix.
Sat, Sep 26, 10:56 AM
Vulcan added a comment to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

Successful build - Chance fights ever on the side of the prudent.

Sat, Sep 26, 12:26 AM
bb updated the diff for D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.
Sat, Sep 26, 12:10 AM
bb added a comment to D2995: Properly internationalize attack names/Generlize to arbitrary names in the GUI.

Below the translation field, there is a "more info" box displayed. The third item says "Context", the context string added here will be displayed there.

If I understand correctly, strings are translated on transifex, not occurrences, i.e. if a particular string is translated, all occurrences that are exactly the same have the same translation, which is typically fine for full sentences or longer texts. Although context is displayed on transifex, it's essentially meta-data, and since it does not alter the string, I fear both "Sword" (with double-edged context) and "Sword" (with single-edged context) will have the same translation. That said, I don't know the inner workings of transifex and I didn't test for this particular case

A very valid question, but transifex is slightly smarter:

  1. It translates strings per module (see the grouping of strings in transifex). This ofcourse does not help in this case, since all strings will be in Sim. Templates.
  2. Transifex cares about the context. Strings with different context will appear as different items in the list (e.g look at the "Range:" string in Misc. GUI, one without context, one with "aura" context). Also as you can see in the code the context is passed to the translate call (translateWithContext(context, string) and that will choose the translation of the tuple (context, string) so context should help us in this case!!.

And then it is replaced by the correct term, when wanted. If I counted correctly there are 20 different sword wielding units, of which 4 use a single-edged one. I believe avoiding duplication legitimizes settting the double-edged variant in the parent.

Did you check champions too? Those usually don't have swordsman in their file name. Anyway, if single-edged blades are indeed a small minority, I agree it's better to set Sword in the generic template parent and a different string in the relevant children. Perhaps ‘Saber’? It's a bit anachronistic, but probably clearer than e.g. ‘Backsword’.

You are right, also founda new type: kush_champ_amum has a Sickle. Also some heroes. 9 Singles on 51 doubles now

Sat, Sep 26, 12:10 AM
bb accepted rP23072: Refactor trade dialog and barter panel buttons to use object orientation, refs….

Fixed by rP24071

Sat, Sep 26, 12:07 AM

Fri, Sep 25

Harbormaster failed to build B13243: rP24071: Show correct trade info for observers for rP24071: Show correct trade info for observers!
Fri, Sep 25, 11:37 PM
bb committed rP24071: Show correct trade info for observers.
Show correct trade info for observers
Fri, Sep 25, 11:35 PM
bb closed D3014: Show correct trade info for observers.
Fri, Sep 25, 11:35 PM
bb added a comment to D2809: Don't detect audio card when audio is disabled.

More compile errors:

/usr/bin/ld: ../../../binaries/system/liblowlevel.a(snd.o): in function `snd_detect()':
/home/Bouke/0ad/SVNcom/0ad/build/workspaces/gcc/../../../source/lib/snd.cpp:48: undefined reference to `alcIsExtensionPresent'
/usr/bin/ld: /home/Bouke/0ad/SVNcom/0ad/build/workspaces/gcc/../../../source/lib/snd.cpp:65: undefined reference to `alGetString'
/usr/bin/ld: /home/Bouke/0ad/SVNcom/0ad/build/workspaces/gcc/../../../source/lib/snd.cpp:50: undefined reference to `alcIsExtensionPresent'
/usr/bin/ld: /home/Bouke/0ad/SVNcom/0ad/build/workspaces/gcc/../../../source/lib/snd.cpp:53: undefined reference to `alcGetString'
/usr/bin/ld: /home/Bouke/0ad/SVNcom/0ad/build/workspaces/gcc/../../../source/lib/snd.cpp:51: undefined reference to `alcGetString'
collect2: error: ld returned 1 exit status
make[1]: *** [pyrogenesis.make:81: ../../../binaries/system/pyrogenesis] Error 1
make: *** [Makefile:71: pyrogenesis] Error 2

Those look like the openAL functions used in snd_detect(). Looks like this patch is not only correct, but also necessairy by the looks of these errors. To solve the errors probably snd.h function shouldn't be compiled.

Fri, Sep 25, 11:29 PM
bb added a comment to D2733: CivStructure class for civ-specific structures.

Ahh okay, thanks, needs @s0600204 then...

Fri, Sep 25, 11:09 PM
Nescio added a comment to D2733: CivStructure class for civ-specific structures.

What would be the use case of this class?

https://code.wildfiregames.com/D2720#115075

Fri, Sep 25, 6:33 PM
Vulcan added a comment to D2809: Don't detect audio card when audio is disabled.

Successful build - Chance fights ever on the side of the prudent.

Fri, Sep 25, 6:14 PM
Vulcan added a comment to D2809: Don't detect audio card when audio is disabled.

Successful build - Chance fights ever on the side of the prudent.

Fri, Sep 25, 5:58 PM
Stan updated the diff for D2809: Don't detect audio card when audio is disabled.

Remove useless change

Fri, Sep 25, 5:44 PM
Stan updated the diff for D2809: Don't detect audio card when audio is disabled.

Merge snd block, update message, fix compilation, (Config 2 change is just for the CI)

Fri, Sep 25, 5:43 PM
bb added a comment to D2733: CivStructure class for civ-specific structures.

One obstruction for adding this considering the maintainability.

Fri, Sep 25, 5:41 PM
bb added a comment to D2809: Don't detect audio card when audio is disabled.

updating workspace --without-audio gives

../../../source/soundmanager/scripting/SoundGroup.cpp: In member function ‘void CSoundGroup::SetDefaultValues()’:
../../../source/soundmanager/scripting/SoundGroup.cpp:75:2: error: ‘m_Seed’ was not declared in this scope
   75 |  m_Seed = 0;
      |  ^~~~~~
Fri, Sep 25, 5:17 PM
Freagarach planned changes to D2525: Define auto-gather/-build ranges in template..

Very good points :) What about just using the vision range?
Gather a tree there, is the tree gone, _look_ for another tree.

Fri, Sep 25, 5:00 PM
bb updated subscribers of D2525: Define auto-gather/-build ranges in template..

On the caching: since we already listen to the modifactionUpdate messages adding the cache does not lower much performance. It gains very little performance in execution. But lowers the performance of (de)serialisation and makes the OOS logs unnecessarily larger.

Fri, Sep 25, 4:38 PM
Freagarach accepted D3014: Show correct trade info for observers.

Observers can now see the "proper" trading ratios, albeit they lag a bit behind in MP.

Fri, Sep 25, 3:15 PM
bb updated the diff for D3014: Show correct trade info for observers.

comments

Fri, Sep 25, 3:07 PM
bb added inline comments to D3014: Show correct trade info for observers.
Fri, Sep 25, 3:06 PM
Freagarach added a comment to D3014: Show correct trade info for observers.

Proper fixing indeed out of scope especially since more functions/buttons are probably affected.

Fri, Sep 25, 2:50 PM
Nescio updated the diff for D2993: [gameplay] add visible garrison points to rome siege wall tower.
  • updated because of D3016
Fri, Sep 25, 1:15 PM