Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Removed the AVX and FMA version, as we don't be able, to change instructions by runtime. Furthermore the AVX instructions aren't faster than SSE here.

Successful build - Chance fights ever on the side of the prudent.

Also dates.

Successful build - Chance fights ever on the side of the prudent.

In D2752#123195, @trompetin17 wrote:

@wraitii with your patch when start atlas I see a black window in the right hand, is this for "RendererIncrementalLoad"?

I don't understand what you mean.

Make this two patches, I meant. One enabling default formations and one allowing commands to disband a formation.

In D2764#123192, @wraitii wrote:

Because I think so? Formations are by nature combat-related, gathering isn't.
It's only strange because it breaks your current expectation imo. The entities, when gathering, aren't in formation, so it makes sense that they end up in the default formation. If you were to wait a sufficient time in the "gathering" stance, it wouldn't look odd because you'd have forgotten they were in 'line' formation.

Well, formations are also kind of gathering related. When a group of people goes woodchopping, they stay as a group until they arrive. But it might just be me reluctant to change here ^^' If the players don't complain, why should I ;)

In D2764#123191, @Freagarach wrote:

Why doesn't it make much sense to be able to gather when tasked in a formation?

Because I think so? Formations are by nature combat-related, gathering isn't.

Why doesn't it make much sense to be able to gather when tasked in a formation? If I order a group of entities into a "line" formation (while the default is "box") subsequently order the group to gather and then move the group to somewhere else again, previously the entities would just have the chosen "line" formation. Now they fall back to the default ("box") formation. IMHO, that is strange ^^'

If intervening in the following replay and selecting the 40 spearmen and 2 archers when tasked to drop off their resources at around 2:20 the FPS drop hugely for me. (Why not all entities are tasked on this while they were on r23810 (with which this replay is made) is kind of a mystery to me.)

I have rewrite the patch, so it uses only SSE. That I have used for the profiling. I will upload it later this day.

I tested the build flags, SSE seems to be the only flag with an positiv impact. AVX2 makes everything worse. I also made some profiling.
Current version:

Successful build - Chance fights ever on the side of the prudent.

Scale depending on affected range.

It will become useful when we garrison melee units on towered elephants.

Successful build - Chance fights ever on the side of the prudent.

Add capture tooltip.

• Tested in game, interval applied appropriately.
• Code looks good.
• Common use cases tested.

Successful build - Chance fights ever on the side of the prudent.

Notice the duplication of the capture bar part in PanelEntity.js and selection_details.js.

Successful build - Chance fights ever on the side of the prudent.

Fix inlines

From my discussions with Optimus Shepard, the fact that it is using FMA3 is problematic, because it literraly prevents anyone with less an Intel IX-4000 era CPU and FX6000 to play the game. We don't gather stats about those, so we do not actually know how many of our users have such CPUs.
From the 7th percent improvement reported by Optimus Shepard 30% of that is due to the usage of FMA3.

Would be nice to:

• Understand why compilers can't vectorise these themselves (is it just a build-flag issue?)
• Get some actual profiling in, ideally some Profiler 2 graphs of MP replays.

Successful build - Chance fights ever on the side of the prudent.

Add comment inline cmpTimer, apparently JavaScript allows this, and EsLint does not complain

Successful build - Chance fights ever on the side of the prudent.

More tests

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Remove variable

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Don't set interval depending on resource

Build failure - The Moirai have given mortals hearts that can endure.

Try again

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Forgot to register the global again

Build failure - The Moirai have given mortals hearts that can endure.

Fix tests, add test

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Build failure - The Moirai have given mortals hearts that can endure.

Inlines.

If it is historically wrong, then I don't think it should be maintained.

I am willing to accept this patch, in general it is very good. However starting with a healer with advance rank would be very powerful if used wel, rank 1 must be better.

Putting "Cost/BuildTime" on the "Rank Techs" seems to make more sense, besides being easier for future changes. Virtually no changes to gameplay.

New values look good to me now.

Correct identation pointed by @Nescio

Change cost to 500 food 200 metal suggested by @Nescio.
decrease penalty 10% to 5%.

Correct loot (2) pointed by @Nescio

In D2816#123071, @Nescio wrote:

Infantry with 30w 20m can be a problem early game for rome/iber.

So swordsmen costing 30 wood + 20 metal is problematic, but slingers costing 20 wood + 30 stone is not?

What about remove 10% training time and 500f0200m?

As for this patch, I agree limiting it to champions makes sense, the current modifications are fine and don't need changing, but the cost of 500 food + 500 metal is too much and needs to be lowered. I just happen to have a minor preference for 500 food + 200 metal over 300 food + 300 metal, which feels cheaper than the 600 metal proposed in D2867. Anyway, it's not terribly important.
Other opinions are most certainly welcome.

If 10% attack is same to +1 armor, what about 30% health and 500f/200m?

Yes, +1 armour level, +10% health, and +10% attack damage, whilst not identical, are broadly equivalent. As pointed out before, +25% health already is a lot, raising it to +30% seems excessive.
However, not all resources are equally valuable. Metal especially can become problematic in the late game, whereas food is basically unlimited. Moreover, getting smaller amounts of different resources is easier than a lot of just one. One should not only look at the resource total, but also at the individual numbers. There are no hard and fast rules, though.

Infantry with 30w 20m can be a problem early game for rome/iber.

So swordsmen costing 30 wood + 20 metal is problematic, but slingers costing 20 wood + 30 stone is not?

Successful build - Chance fights ever on the side of the prudent.

The patch is correct and complete, the changes make sense, the reason behind it is valid, and it improves consistency and maintainability.

• champions 20, 27, 36, per @borg-

This looks really nice at first sight. I'm keeping forward on the SM upgrade work and I'll let you know if I prefer get this in before or after a specific version.

@Nescio seems correct?