Page MenuHomeWildfire Games
Feed All Stories

Today

elexis added a comment to rP22346: Allow techs to affect unit counters stats..
In rP22346#34395, @Stan wrote:

Well obviously we can, since this isn't the only change you requested :)

Tue, Jun 25, 4:28 PM
Stan added a comment to rP22346: Allow techs to affect unit counters stats..
In rP22346#34393, @Stan wrote:

Shall I make another diff then ?

We can't know that without knowing the answer to the question when the TODO case can be triggered.

Tue, Jun 25, 4:19 PM
Stan added a comment to D1932: Update to premake Alpha 14.

It would seem they added support for Microsoft Visual Studio 2019.
As of today, still haven't updated the CHANGES.txt file.

Tue, Jun 25, 4:18 PM
Stan added inline comments to D1935: Anatolian → Lydian; correct Persian specific names.
Tue, Jun 25, 4:14 PM
elexis added a comment to rP22346: Allow techs to affect unit counters stats..
In rP22346#34393, @Stan wrote:

Shall I make another diff then ?

Tue, Jun 25, 4:09 PM
Stan added a comment to rP22346: Allow techs to affect unit counters stats..

Shall I make another diff then ?

Tue, Jun 25, 4:04 PM
elexis added a comment to rP22346: Allow techs to affect unit counters stats..

The Petra hardcounters implementation seems to come from rP13225.
There is also a countersClasses, but I guess that is not affected qualitatively, unless that // TODO: refine using the multiplier is implemented, in which case the ApplyValueModifications part would be done too if it is done here.
You cited the function that does apply the ValueModifications, I would add the function comment in the two lines above just for clarity:

helper function to return a template value, optionally adjusting for tech.
TODO: there's no support for "_string" values here.

Both come from rP14588. The commit message says Still need to fix the entity.js file to handle properly some things as this uses raw templates values..
So if the function does what the comments claim to do, then the function would be functional if and only if the ._string format never occurs for the passed data in this place, is that actually the case?

Tue, Jun 25, 3:55 PM
Angen added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

Bug n 1.
Run game with postprocessing on in fullscreen, alt tab and go back (solved by D1212)
Bug n 2.
Postprocessing on in fullscreen, alt tab while loading match, return back after match started ( original solution https://code.wildfiregames.com/D1495?id=7570) commited version (this)

Tue, Jun 25, 3:21 PM
elexis added inline comments to rP21847: Rewrite the prelobby pages and add the Terms of Service, Terms of Use and the….
Tue, Jun 25, 3:06 PM
wraitii added 1 auditor(s) for rP21026: Cleanup TileClass prototype and use vector arguments for countInRadius…: wraitii.

(to not forget)

Tue, Jun 25, 2:41 PM
wraitii raised a concern with rP21847: Rewrite the prelobby pages and add the Terms of Service, Terms of Use and the….

Concern:

  • this reverted rP20053 by accident, and we should again disable the login/registration button when clicking on them to prevent acting twice, which crashes.

See inline for where I think we need to fix this.

Tue, Jun 25, 2:37 PM
wraitii added a comment to D1914: Don't clear pathnames in vfs::GetPathnames so it can be called several times..

I don't think there is much value in having both functions, but renaming to AppendPathnames makes sense.

Tue, Jun 25, 9:36 AM
Stan updated subscribers of rP22397: #5445.

Usually one can write Fixes #5445 to automatically close tickets.
@Itms, we now need a AtlasUI autobuild for windows, not sure that's automatic yet.

Tue, Jun 25, 8:56 AM
Stan added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

Sorry, should have been more specific.

Tue, Jun 25, 8:52 AM
Stan added a comment to rP22386: 3 New temperate maps by BigTiger..

Yeah I was waiting for something like D2009 which I would have done myself if someone hadn't come to the rescue. Will add the keyword soon.

Tue, Jun 25, 8:50 AM
Stan added a comment to rP22323: Further cleanup of MikkTSpace.

Pass pointers instead of arrays

How are arrays passed?

Tue, Jun 25, 8:49 AM
trompetin17 closed D2009: Add a "new" checkbox to the map settings tab.
Tue, Jun 25, 7:12 AM · Restricted Project, macOS Developers
trompetin17 committed rP22397: #5445.
#5445
Tue, Jun 25, 7:05 AM
elexis added a comment to rP22341: Fixes black water glitches for certain wind angles with the approximate….

Fix for rP15576.

Tue, Jun 25, 6:27 AM
Vulcan added a comment to D2009: Add a "new" checkbox to the map settings tab.

Successful build - Chance fights ever on the side of the prudent.

Tue, Jun 25, 6:17 AM · Restricted Project, macOS Developers
elexis accepted D2009: Add a "new" checkbox to the map settings tab.
Tue, Jun 25, 6:16 AM · Restricted Project, macOS Developers
trompetin17 updated the diff for D2009: Add a "new" checkbox to the map settings tab.

Fixed Typo

Tue, Jun 25, 6:15 AM · Restricted Project, macOS Developers
Vulcan added a comment to D2009: Add a "new" checkbox to the map settings tab.

Successful build - Chance fights ever on the side of the prudent.

Tue, Jun 25, 6:15 AM · Restricted Project, macOS Developers
trompetin17 updated the diff for D2009: Add a "new" checkbox to the map settings tab.

Change VIsual Setting

Tue, Jun 25, 6:13 AM · Restricted Project, macOS Developers
elexis added a comment to rP22331: Roman helmets texture recolor.

Fixes rP22082.

Tue, Jun 25, 6:11 AM
elexis accepted D2009: Add a "new" checkbox to the map settings tab.
  • Task of the ticket is reasonable.
  • Task of the ticket was extended to entail the Trigger keywords.
  • Review remarks were addressed.
  • Didn't get more compiler warnings than I already had before.
  • Tested, works in accordance with the gamesetup filters.
  • Thanks for the patch!
  • Fix that map -> maps typo before the commit and perhaps 5 -> 15 for better visual layout
Tue, Jun 25, 6:03 AM · Restricted Project, macOS Developers
elexis added a comment to rP22323: Further cleanup of MikkTSpace.

Pass pointers instead of arrays

How are arrays passed?

Tue, Jun 25, 5:46 AM
elexis added a comment to rP22318: Re-upload the uncompressed PNG files for the previous commits..

(Fixes rP22317)

Tue, Jun 25, 5:30 AM
Vulcan added a comment to D2009: Add a "new" checkbox to the map settings tab.

Successful build - Chance fights ever on the side of the prudent.

Tue, Jun 25, 5:28 AM · Restricted Project, macOS Developers
trompetin17 updated the diff for D2009: Add a "new" checkbox to the map settings tab.

Fix messages description

Tue, Jun 25, 5:26 AM · Restricted Project, macOS Developers
elexis added a comment to D2009: Add a "new" checkbox to the map settings tab.

Looks good, I got some compile warnings however (gcc 9.1.0):

Tue, Jun 25, 5:22 AM · Restricted Project, macOS Developers
Vulcan added a comment to D2009: Add a "new" checkbox to the map settings tab.

Successful build - Chance fights ever on the side of the prudent.

Tue, Jun 25, 5:19 AM · Restricted Project, macOS Developers
trompetin17 updated the diff for D2009: Add a "new" checkbox to the map settings tab.

Add "trigger" Keyword in Map settings
Change Checkbox to be 2 by line

Tue, Jun 25, 5:18 AM · Restricted Project, macOS Developers
elexis added a comment to D2009: Add a "new" checkbox to the map settings tab.

You may want to add the trigger keyword, since there is also a filter for that in the gamesetup.

Tue, Jun 25, 4:59 AM · Restricted Project, macOS Developers
Vulcan added a comment to D2009: Add a "new" checkbox to the map settings tab.

Successful build - Chance fights ever on the side of the prudent.

Tue, Jun 25, 4:54 AM · Restricted Project, macOS Developers
trompetin17 created D2009: Add a "new" checkbox to the map settings tab.
Tue, Jun 25, 4:52 AM · Restricted Project, macOS Developers
elexis raised a concern with rP22386: 3 New temperate maps by BigTiger..

Only a small concern, but something that should be fixed for the release. The maps should have the "new" keyword, so that they appear in the "new maps" filter.

Tue, Jun 25, 4:18 AM
elexis added a comment to rP22315: New horse and cattle fauna template corrections.

Fixes rP22257, rP22260.

Tue, Jun 25, 3:27 AM
elexis added a comment to rP22314: Fix a crash on some system when Alt-tabbing during game setup..

@Stan what does "break sound for me" mean, no sound at all (on windows?)? Is this reproduced by others (on windows)?

Tue, Jun 25, 3:26 AM
elexis awarded rP22308: Add a build flag to prefer locally-built libraries (linux/bsd systems) a Like token.
Tue, Jun 25, 2:52 AM

Yesterday

elexis added a comment to rP22312: Don't clear pathnames in vfs::GetPathnames so it can be called several times..

(Audit comment at D1914#83746)

Mon, Jun 24, 11:45 PM
elexis added a comment to D1914: Don't clear pathnames in vfs::GetPathnames so it can be called several times..

grep for GetPathnames, notice that this is safe.

Performed, confirmed grep -R 'GetPathnames' -B1

i18n/L10n.cpp-	std::wstring dictName = GetFallbackToAvailableDictLocale(icu::Locale::createCanonical(locale.c_str()));
i18n/L10n.cpp:	vfs::GetPathnames(g_VFS, L"l10n/", dictName.append(L".*.po").c_str(), filenames);
--
i18n/L10n.cpp-	{
i18n/L10n.cpp:		if (vfs::GetPathnames(g_VFS, L"l10n/", L"long.*.po", filenames) < 0)
--
i18n/L10n.cpp-		std::wstring dictName = GetFallbackToAvailableDictLocale(currentLocale);
i18n/L10n.cpp:		if (vfs::GetPathnames(g_VFS, L"l10n/", dictName.append(L".*.po").c_str(), filenames) < 0)
--
i18n/L10n.cpp-	VfsPaths filenames;
i18n/L10n.cpp:	if (vfs::GetPathnames(g_VFS, L"l10n/", L"*.po", filenames) < 0)
--
graphics/MapGenerator.cpp-	// Load all scripts in mapgen directory
graphics/MapGenerator.cpp:	Status ret = vfs::GetPathnames(g_VFS, path, L"*.js", pathnames);
--
graphics/ColladaManager.cpp-		VfsPaths pathnames;
graphics/ColladaManager.cpp:		if (vfs::GetPathnames(m_VFS, L"art/skeletons/", L"*.xml", pathnames) < 0)
--
graphics/ColladaManager.cpp-			VfsPaths paths;
graphics/ColladaManager.cpp:			if (vfs::GetPathnames(m_VFS, L"art/skeletons/", L"*.xml", paths) != INFO::OK)
--
renderer/PostprocManager.cpp-	VfsPaths pathnames;
renderer/PostprocManager.cpp:	if (vfs::GetPathnames(g_VFS, path, 0, pathnames) < 0)
--
gui/GUIManager.cpp-			VfsPaths pathnames;
gui/GUIManager.cpp:			vfs::GetPathnames(g_VFS, directory, L"*.xml", pathnames);
--
gui/CGUI.cpp-				VfsPaths pathnames;
gui/CGUI.cpp:				vfs::GetPathnames(g_VFS, directory, L"*.xml", pathnames);
--
gui/CGUI.cpp-		VfsPaths pathnames;
gui/CGUI.cpp:		vfs::GetPathnames(g_VFS, directory, L"*.js", pathnames);
--
scriptinterface/ScriptInterface.cpp-	VfsPaths pathnames;
scriptinterface/ScriptInterface.cpp:	vfs::GetPathnames(g_VFS, L"globalscripts/", L"*.js", pathnames);
--
lib/file/vfs/vfs_util.cpp-
lib/file/vfs/vfs_util.cpp:Status GetPathnames(const PIVFS& fs, const VfsPath& path, const wchar_t* filter, VfsPaths& pathnames)
--
lib/file/vfs/vfs_util.h-
lib/file/vfs/vfs_util.h:extern Status GetPathnames(const PIVFS& fs, const VfsPath& path, const wchar_t* filter, VfsPaths& pathnames);
--
lib/file/vfs/tests/test_vfs_util.h-		VfsPaths pathNames;
lib/file/vfs/tests/test_vfs_util.h:		vfs::GetPathnames(g_VFS, "", L"*.txt", pathNames);
lib/file/vfs/tests/test_vfs_util.h-		TS_ASSERT_EQUALS(pathNames.size(), 3);
lib/file/vfs/tests/test_vfs_util.h:		vfs::GetPathnames(g_VFS, "sub_folder_a/", L"*.txt", pathNames);
lib/file/vfs/tests/test_vfs_util.h-		TS_ASSERT_EQUALS(pathNames.size(), 5);
lib/file/vfs/tests/test_vfs_util.h:		vfs::GetPathnames(g_VFS, "sub_folder_b/", L"*.txt", pathNames);
--
simulation2/Simulation2.cpp-	VfsPaths pathnames;
simulation2/Simulation2.cpp:	if (vfs::GetPathnames(g_VFS, path, L"*.js", pathnames) < 0)
--
simulation2/Simulation2.cpp-	VfsPaths pathnames;
simulation2/Simulation2.cpp:	Status ret = vfs::GetPathnames(g_VFS, path, L"*.json", pathnames);
--
simulation2/components/CCmpAIManager.cpp-		VfsPaths pathnames;
simulation2/components/CCmpAIManager.cpp:		if (vfs::GetPathnames(g_VFS, L"simulation/ai/" + moduleName + L"/", L"*.js", pathnames) < 0)
--
simulation2/components/tests/test_scripts.h-		VfsPaths paths;
simulation2/components/tests/test_scripts.h:		TS_ASSERT_OK(vfs::GetPathnames(g_VFS, L"simulation/components/tests/", L"test_*.js", paths));
--
ps/SavedGame.cpp-	VfsPaths pathnames;
ps/SavedGame.cpp:	err = vfs::GetPathnames(g_VFS, "saves/", L"*.0adsave", pathnames);
Mon, Jun 24, 11:44 PM
Krinkle added a comment to D2005: Standardize "Territory Influence" in tooltips.
In D2005#83640, @Nescio wrote:

! @Krinkle wrote:
I'm not very familiar with auras yet, can you elaborate on that? Is there a Trac task for that?

Have a look at the screenshots you posted. As you can see all relevant information of the aura is already displayed automatically (the "Religious Fervor" line). Which means the tooltips of iber_monument.xml, maur_pillar_ashoka.xml, and pers_ishtar_gate.xml can now be purged.

Mon, Jun 24, 11:25 PM
Freagarach added a comment to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Oh, I'm referring to saving and loading :)
That causes problems with Vector3D in D1971.

Mon, Jun 24, 9:03 PM
Krinkle updated subscribers of D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Yes. Test plan I wrote in the commit myself includes those steps, and I've confirmed them locally as well before submitting. The game compiles, starts, and can create a game and select/move units without errors.

Did you test (de)serialising?

Mon, Jun 24, 8:58 PM
Stan added a comment to D1971: Support attack-ground for ranged units..

If you have some time, maybe it would be nice to have a small video on youtube demonstrating the feature. Nothing fancy.

Mon, Jun 24, 8:57 PM
Vulcan added a comment to D1971: Support attack-ground for ranged units..

Successful build - Chance fights ever on the side of the prudent.

Mon, Jun 24, 8:43 PM
Freagarach updated the diff for D1971: Support attack-ground for ranged units..
  • Some target instanceof Vector3D -> `typeof target == "number".
  • Some objects split over multiple lines in "UnitAI.js".
Mon, Jun 24, 8:40 PM
Freagarach added a comment to D1991: simulation2: Remove Vector2D/Vector3D prototype workaround from EngineScriptConversions.

Yes. Test plan I wrote in the commit myself includes those steps, and I've confirmed them locally as well before submitting. The game compiles, starts, and can create a game and select/move units without errors.

Did you test (de)serialising?

Mon, Jun 24, 8:39 PM
Vulcan added a comment to D1337: Formation animation refactor.

Successful build - Chance fights ever on the side of the prudent.

Mon, Jun 24, 8:11 PM
Stan added a comment to D1337: Formation animation refactor.

Rebased - needs some cleaning, like the anti-cavalry formation no longer has a walk animation which is annoying - I guess I should group the animations better. The limit of one variant per file is quite annoying because it means one must change a lot of files every time -_-
Still would work with D1901

Mon, Jun 24, 8:00 PM
wraitii updated subscribers of D1979: Unit Motion - account for entity moving out of world.

Actually working correctly this time.

What exactly needs to happen for these fixes to land in the public repo? It seems a bunch are testing and get turn off when the unit motion doesn't work as expected?

Mon, Jun 24, 7:44 PM
wraitii updated the diff for D1337: Formation animation refactor.

Rebased - needs some cleaning, like the anti-cavalry formation no longer has a walk animation which is annoying - I guess I should group the animations better. The limit of one variant per file is quite annoying because it means one must change a lot of files every time -_-

Mon, Jun 24, 7:43 PM
wraitii commandeered D1337: Formation animation refactor.
Mon, Jun 24, 7:42 PM
minohaka added a comment to D1979: Unit Motion - account for entity moving out of world.

Actually working correctly this time.

Mon, Jun 24, 7:39 PM
wraitii added inline comments to rP22304: Allow entities to be affected by Status Effects from ranged attacks..
Mon, Jun 24, 7:38 PM
wraitii added a comment to rP22304: Allow entities to be affected by Status Effects from ranged attacks..

I guess you don't understand the concept of an iteration or an MVP.

Mon, Jun 24, 7:05 PM
Freagarach added a comment to D1971: Support attack-ground for ranged units..

Also, there are quite a few lines of these:

let attackGround = target instanceof Vector3D;
	if (!attackGround)

Would it not be better to instead check for what it *should* be? So target instanceof number -> do entity-related stuff.
This would also circumvent the problem that during saving/loading the fact that the target is a Vector3D is lost.

Mon, Jun 24, 7:01 PM
elexis raised a concern with rP22304: Allow entities to be affected by Status Effects from ranged attacks..

StatusEffects name is problematic I'm afraid.

Mon, Jun 24, 6:49 PM
wraitii added a comment to rP22305: Remove 'Async' from short/long path requests names.

If there were sync request member variables, it actually would be better to have the distinction.

Mon, Jun 24, 6:34 PM
Stan added inline comments to D1969: Support infinite max range checks again in IsInXRange // Adapt unitMotion to edge-edge distance checks.
Mon, Jun 24, 6:28 PM
elexis added a comment to rP22305: Remove 'Async' from short/long path requests names.

Reviewed By: Kuba386

Would have been good if there was mentioned which aspects were reviewed, what was tested.

Mon, Jun 24, 6:27 PM
Vulcan added a comment to D1969: Support infinite max range checks again in IsInXRange // Adapt unitMotion to edge-edge distance checks.

Successful build - Chance fights ever on the side of the prudent.

Mon, Jun 24, 6:04 PM
wraitii updated the diff for D1969: Support infinite max range checks again in IsInXRange // Adapt unitMotion to edge-edge distance checks.

Reworked slightly with better comments and no navcell fix which should not be needed. I believe the GOAL_DELTA was intended to do something slightly similar at some point, and is also removed.

Mon, Jun 24, 5:57 PM
Stan added inline comments to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
Mon, Jun 24, 5:56 PM
Vulcan added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

Successful build - Chance fights ever on the side of the prudent.

Mon, Jun 24, 5:49 PM
Freagarach updated the diff for D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..
  • Trade-window resizes to largest of "barterable" and "tradable".
  • Removed extra ")" in PetraAI's "diplomacyManager.js".
Mon, Jun 24, 5:47 PM
Freagarach commandeered D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

Commandeering to make small changes @ @wraitii's request.

Mon, Jun 24, 5:43 PM
Stan added a comment to D1971: Support attack-ground for ranged units..

Well it's up to wraitii to review those, so I guess up to him then.

Mon, Jun 24, 5:39 PM
Vulcan added a comment to D1979: Unit Motion - account for entity moving out of world.

Successful build - Chance fights ever on the side of the prudent.

Mon, Jun 24, 5:30 PM
wraitii updated the diff for D1979: Unit Motion - account for entity moving out of world.

Actually working correctly this time.

Mon, Jun 24, 5:28 PM
elexis added a comment to rP22302: Use pkg-config where possible instead of hard-coding or library-specific….

Without having looked at detail, the objectives of these two commits look very good. If I understand correctly rP22302 was only the consequential cleanup of rP21865, but did not fix some reported crash on Slackware on the forums (as rP22302 already fixed that), correct? (Otherwise it should be added to Alpha24)

Mon, Jun 24, 5:19 PM
Vulcan added a comment to D2008: Fix formation-related unitAI infinite loop.

Successful build - Chance fights ever on the side of the prudent.

Mon, Jun 24, 5:03 PM
wraitii added a comment to D1974: Tests for D1879 - Fix limit restriction for training units in ProductionQueue.

@Itms Can you close a revision or should I abandon this?

Mon, Jun 24, 5:02 PM
Freagarach added a comment to D1971: Support attack-ground for ranged units..

I think some changes I made in this diff should be moved to seperate minor diffs:

  • GetTargetPosition2D/3D-functions.
  • FaceTowardsTarget to be like in D1958.
  • Formation target/move ranges seperated from the normal function calls.

What do you think, @Stan, @wraitii?

Mon, Jun 24, 5:02 PM
wraitii added a comment to D1846: Adds a "properties"-property to resources and let mods be able to prevent resources from being bartered, traded and/or tributed..

@Freagarach feel free to commandeer this with the fixes above.

Mon, Jun 24, 5:00 PM
wraitii created D2008: Fix formation-related unitAI infinite loop.
Mon, Jun 24, 4:59 PM
Freagarach added a comment to rP22081: Rome Testudo & Anti-Cavalry formations animations:.

As noted on IRC, this triggers an infinite loop in JS (so contrary to what said above, the segfault is related), because of some unknown (so far) issue with attacking as formation (which was removed by D1220 otherwise).
I don't think we can sanely guarantee that attack-as-formation works right now, even if this particular case may be fixable - so it should probably be changed.

Mon, Jun 24, 4:50 PM
elexis awarded rP22302: Use pkg-config where possible instead of hard-coding or library-specific… a Like token.
Mon, Jun 24, 4:49 PM
wraitii added a comment to rP22278: Decouple long and hierarchical pathfinders to an extent..

There is a simple, infaillible logic to making the hierarchical pathfinder not a sub-class of the long-range pathfinder: you can perfectly use the hierarchical pathfinder without a long-range pathfinder (the reverse isn't true).
If anything, we could make the hierarchical pathfinder own the long-range pathfinder, but the opposite didn't make sense.

Mon, Jun 24, 4:48 PM
wraitii added a comment to rP22295: Target build version explicitly for Xcode.

I also made three of the patch's iterations. But it doesn't matter much.

Mon, Jun 24, 4:34 PM
Stan added a comment to rP22295: Target build version explicitly for Xcode.

Reviewed By: Wraitii

Reviewed By is reserved for people other than the author.
Comments By: Itms can be added when people influenced the patch without having accepting it.

Mon, Jun 24, 4:33 PM
wraitii added a comment to rP22299: ShouldConsiderOurselvesAtDestination renamed to….

The reason why I moved the stateful calls outside the functions was mostly in planning of further diffs, which remove StopMoving() and "FacePointAfterMove", i.e. the duplication.

Mon, Jun 24, 4:32 PM
Stan added a comment to rP22266: moves territory_pull.xml from other/ to special/ and updates the only file in….

No notes.
That these templates shall not appear in the list of placeable templates may be true, but there are also the generic templates that should not appear in that list.
Also that a template shall not appear to be placeable doesn't mean that it is impossible to place it if it would appear in the list.
Hence unplaceable/ would also be imperfect.
Another possibility would be hidden/, but that also is ambiguous. Everything is ambiguous.
Perhaps unplaceable/ and a README.txt defining unplaceable/ as not appearing in the Atlas list of entities would be the solution that satisfies all problems (including the clarification that a template that may technically be placed may be contained in that folder).

Mon, Jun 24, 4:30 PM
wraitii added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

True about the warning. I was merely following the spec at https://github.com/0ad/0ad/blob/master/source/simulation2/Simulation2.h#L193

Mon, Jun 24, 4:27 PM
elexis added a comment to rP22300: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

(Audit comment at https://code.wildfiregames.com/D1736#83668)

Mon, Jun 24, 4:21 PM
elexis added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

Destroying INVALID_ENTITY is valid and should do nothing.
The current code will send MT_Destroy messages when doing this, which is un-necessary work and feels kind of broken to me.
Early-exit instead.

Mon, Jun 24, 4:21 PM
elexis raised a concern with rP22299: ShouldConsiderOurselvesAtDestination renamed to….

ShouldConsiderOurselvesAtDestination from rP17226.
Agree with that previous name being broken because this is only about the unit, not about the reader.

Mon, Jun 24, 4:07 PM
elexis added inline comments to rP22298: Health.js cleanup: add tests, add an "IsInjured" function, use this.hitpoints….
Mon, Jun 24, 3:59 PM
elexis added a comment to rP22296: Add unit motion integration test map.

unit_motion_integration_test.js

trigger scripts usually contain the name triggers:

./random/elephantine_triggers.js
./random/extinct_volcano_triggers.js
./random/survivalofthefittest_triggers.js
./random/wall_demo_triggers.js
./random/danubius_triggers.js
./random/jebel_barkal_triggers.js
./random/polar_sea_triggers.js

Except for scenario folders:

./unit_motion_integration_test.js
./treasure_islands.js
./Units_demo.js
./Triggers_demo.js
./Cinema_Demo.js

(But I technically don't want to spawn another rename clean thing now)

Mon, Jun 24, 3:26 PM
elexis added a comment to rP22295: Target build version explicitly for Xcode.

Reviewed By: Wraitii

Reviewed By is reserved for people other than the author.
Comments By: Itms can be added when people influenced the patch without having accepting it.

Mon, Jun 24, 3:15 PM
elexis added a comment to rP22292: Use Alexandermb's shield for the gaul theatron..

refs rP22105.

Mon, Jun 24, 3:08 PM
elexis added a comment to rP22278: Decouple long and hierarchical pathfinders to an extent..

(I didn't check the includes)

Mon, Jun 24, 2:38 PM
wraitii added inline comments to D1901: UnitMotion / AI - remove the special walk animation and let unitMotion take charge.
Mon, Jun 24, 2:34 PM
wraitii added a comment to rP22081: Rome Testudo & Anti-Cavalry formations animations:.

As noted on IRC, this triggers an infinite loop in JS (so contrary to what said above, the segfault is related), because of some unknown (so far) issue with attacking as formation (which was removed by D1220 otherwise).

Mon, Jun 24, 1:14 PM
elexis added a comment to rP22270: Fix last checkrefs.pl warning because the cavalry variant was using an….

Fixes rP22269.

Mon, Jun 24, 12:47 PM
elexis added a comment to rP22266: moves territory_pull.xml from other/ to special/ and updates the only file in….

Regardless of whether and how special/ is renamed, territory_pull.xml must be moved to a different folder.

Mon, Jun 24, 12:45 PM
wraitii added inline comments to D1901: UnitMotion / AI - remove the special walk animation and let unitMotion take charge.
Mon, Jun 24, 12:33 PM
Vulcan added a comment to D1979: Unit Motion - account for entity moving out of world.

Successful build - Chance fights ever on the side of the prudent.

Mon, Jun 24, 12:30 PM
wraitii updated the diff for D1979: Unit Motion - account for entity moving out of world.

Do what I say above.

Mon, Jun 24, 12:25 PM