Page MenuHomeWildfire Games
Feed All Stories

Today

Langbart added a comment to D3849: Rework the pathfinder path computation setup for threading..

Start the game. Move units at long distances and short distances.

I got myself a couple of 100 British swordsmen and we walked around the "Sahel Watering Holes" map a bit, but couldn't find any unusual activity.

Tue, Apr 13, 10:28 PM
Langbart resigned from rP25242: Fix entities being able to attack allied structures in rare cases..
Tue, Apr 13, 9:38 PM
vladislavbelov added inline comments to rP25253: Fix --without-pch build. Phab:rP25225 was missing an include..
Tue, Apr 13, 8:17 PM
Harbormaster failed to build B16744: rP25253: Fix --without-pch build. Phab:rP25225 was missing an include. for rP25253: Fix --without-pch build. Phab:rP25225 was missing an include.!
Tue, Apr 13, 7:32 PM
Angen accepted D3347: Fix structure tree parsing wrong templates.

I did not find major flaw in the code.
Female citizens are displayed as trainable from all structures and their costs are now correct.
D3341 now works without civ element hack.

Tue, Apr 13, 7:31 PM
Stan committed rP25253: Fix --without-pch build. Phab:rP25225 was missing an include..
Fix --without-pch build. Phab:rP25225 was missing an include.
Tue, Apr 13, 7:28 PM
Harbormaster failed to build B16743: rP25252: Scale down turret icons so that they don't overflow. for rP25252: Scale down turret icons so that they don't overflow.!
Tue, Apr 13, 7:16 PM
Stan committed rP25252: Scale down turret icons so that they don't overflow..
Scale down turret icons so that they don't overflow.
Tue, Apr 13, 7:15 PM
Stan added a comment to D3849: Rework the pathfinder path computation setup for threading..

No more crash after disabling the AI. Replays work, airplanes work.

Tue, Apr 13, 6:32 PM
Stan added a comment to D3849: Rework the pathfinder path computation setup for threading..

I tested on pushing demo tried to add obstacles on giant maps. Tried quicksave and quickload. Save and load work on Combat huge. All fine.

Tue, Apr 13, 6:24 PM
wraitii requested review of D3849: Rework the pathfinder path computation setup for threading..
Tue, Apr 13, 5:28 PM
Stan requested changes to D2967: Cache the model-animation maximum bounds..

Breaks gates, not sure why.

Tue, Apr 13, 5:21 PM
wraitii added a reverting change for D1918: Move pathfinder work to a worker (not yet threaded - D14 prerequisite): D3849: Rework the pathfinder path computation setup for threading..
Tue, Apr 13, 5:02 PM
Stan added a comment to D3773: Split hotkeys of turrets..

It's not missing it but it's indeed too big

Tue, Apr 13, 4:24 PM
nwtour added a comment to D3773: Split hotkeys of turrets..

The icon is missing the bottom gray border. This creates the feeling that the icon is different in size from others.

Tue, Apr 13, 4:21 PM
wraitii committed rP25251: Destroy components in reverse order of construction..
Destroy components in reverse order of construction.
Tue, Apr 13, 3:48 PM
wraitii closed D3843: Destroy components in reverse order of construction..
Tue, Apr 13, 3:48 PM
wraitii committed rP25250: Use unique_ptr for secondary sim data..
Use unique_ptr for secondary sim data.
Tue, Apr 13, 3:47 PM
wraitii closed D3842: Use unique_ptr for secondary sim data..
Tue, Apr 13, 3:47 PM
Stan added inline comments to D3848: Implement a threadpool.
Tue, Apr 13, 3:29 PM
Stan added a comment to D3846: Combine area damage schema in Attacking.js-helper..

Could add some tests?

Tue, Apr 13, 3:22 PM
Vulcan added a comment to D3846: Combine area damage schema in Attacking.js-helper..

Successful build - Chance fights ever on the side of the prudent.

Tue, Apr 13, 3:21 PM
Vulcan added a comment to D3846: Combine area damage schema in Attacking.js-helper..

Successful build - Chance fights ever on the side of the prudent.

Tue, Apr 13, 3:20 PM
Freagarach updated the diff for D3846: Combine area damage schema in Attacking.js-helper..

Fallback for linear DeathDamage.

Tue, Apr 13, 3:14 PM
wraitii requested review of D3848: Implement a threadpool.
Tue, Apr 13, 3:00 PM
Vulcan added a comment to D3846: Combine area damage schema in Attacking.js-helper..

Successful build - Chance fights ever on the side of the prudent.

Tue, Apr 13, 2:33 PM
Vulcan added a comment to D3846: Combine area damage schema in Attacking.js-helper..

Successful build - Chance fights ever on the side of the prudent.

Tue, Apr 13, 2:31 PM
Freagarach updated the diff for D3846: Combine area damage schema in Attacking.js-helper..

Other way of putting things.

Tue, Apr 13, 2:27 PM
Freagarach requested review of D3847: [WIP] - Implement conical-shaped area damage..
Tue, Apr 13, 2:25 PM
Stan added inline comments to D3846: Combine area damage schema in Attacking.js-helper..
Tue, Apr 13, 2:17 PM
Stan added a comment to D3846: Combine area damage schema in Attacking.js-helper..

Looks alright, does it work? :P

Tue, Apr 13, 2:16 PM
Vulcan added a comment to D3846: Combine area damage schema in Attacking.js-helper..

Successful build - Chance fights ever on the side of the prudent.

Tue, Apr 13, 12:58 PM
Vulcan added a comment to D3846: Combine area damage schema in Attacking.js-helper..

Successful build - Chance fights ever on the side of the prudent.

Tue, Apr 13, 12:57 PM
Freagarach updated the diff for D3846: Combine area damage schema in Attacking.js-helper..

Indentation, add choice while at it.

Tue, Apr 13, 12:53 PM
Stan added a comment to D3575: Fix assert in topology.cpp.

@vladislavbelov thoughts? It looks okayish now

Tue, Apr 13, 12:12 PM
Freagarach requested review of D3846: Combine area damage schema in Attacking.js-helper..
Tue, Apr 13, 11:13 AM
Freagarach committed rP25249: Fix mismatching range checks in finding a new target when gathering..
Fix mismatching range checks in finding a new target when gathering.
Tue, Apr 13, 8:48 AM
Freagarach closed D3839: Fix mismatching range checks in finding a new target when gathering..
Tue, Apr 13, 8:48 AM
Freagarach updated subscribers of D3839: Fix mismatching range checks in finding a new target when gathering..

Tested by @gameboy: https://wildfiregames.com/forum/topic/38131-tutorial-bug/.

Tue, Apr 13, 8:41 AM
Stan added a comment to D3687: Color incompatible mods and add filter.

Not sure what I did with ffm_visiblity but I got this

Tue, Apr 13, 8:40 AM
wraitii added a comment to D2967: Cache the model-animation maximum bounds..
In D2967#166312, @Stan wrote:

Well each time you'll reach the limit you'll get kicked out of the game have to press continue until it happens again.

Tue, Apr 13, 7:44 AM
Stan added a comment to D2967: Cache the model-animation maximum bounds..

Well each time you'll reach the limit you'll get kicked out of the game have to press continue until it happens again.

Tue, Apr 13, 7:43 AM
autobuild committed rP25248: [Windows] Automated build..
[Windows] Automated build.
Tue, Apr 13, 7:33 AM
Freagarach requested review of D3845: Fix entities able to attack allied stuctures..
Tue, Apr 13, 7:30 AM
wraitii added inline comments to D2967: Cache the model-animation maximum bounds..
Tue, Apr 13, 7:25 AM
Freagarach requested verification of rP25242: Fix entities being able to attack allied structures in rare cases..

(Since it has been reverted.)

Tue, Apr 13, 6:33 AM

Yesterday

Stan added a comment to D3842: Use unique_ptr for secondary sim data..

Can you check PCH ? According to Vladislav it's still broken in svn nad I see potential missing includes in that patch :)

Mon, Apr 12, 10:44 PM
wraitii added a comment to D3842: Use unique_ptr for secondary sim data..
In D3842#166293, @Stan wrote:

What's the gain? Shorter code?

It's safer, because if one changes things one cannot forgot to call delete somewhere with this version.

Mon, Apr 12, 10:40 PM
wraitii committed rP25247: Implement mul_round in checkrefs..
Implement mul_round in checkrefs.
Mon, Apr 12, 6:34 PM
Harbormaster failed to build B16730: rP25246: Revert rP25242 - infinite loop in UnitAI when slaughtering. for rP25246: Revert rP25242 - infinite loop in UnitAI when slaughtering.!
Mon, Apr 12, 6:24 PM
wraitii added a comment to rP25242: Fix entities being able to attack allied structures in rare cases..

Reverted in rP25246.

Mon, Apr 12, 6:17 PM
wraitii added a reverting change for D3840: Fix entities able to attack allied structures.: rP25246: Revert rP25242 - infinite loop in UnitAI when slaughtering..
Mon, Apr 12, 6:17 PM
wraitii added a reverting change for rP25242: Fix entities being able to attack allied structures in rare cases.: rP25246: Revert rP25242 - infinite loop in UnitAI when slaughtering..
Mon, Apr 12, 6:17 PM
wraitii committed rP25246: Revert rP25242 - infinite loop in UnitAI when slaughtering..
Revert rP25242 - infinite loop in UnitAI when slaughtering.
Mon, Apr 12, 6:17 PM
Stan added a comment to D3842: Use unique_ptr for secondary sim data..

What's the gain? Shorter code?

Mon, Apr 12, 6:06 PM
wraitii added a comment to rP25242: Fix entities being able to attack allied structures in rare cases..

To reproduce: start Acropolis Bay skirmish map with an AI.

Mon, Apr 12, 6:03 PM
Stan added inline comments to D3844: Save the profiler2 JSON data after a visual replay.
Mon, Apr 12, 6:03 PM
wraitii requested review of D3844: Save the profiler2 JSON data after a visual replay.
Mon, Apr 12, 5:57 PM
Langbart raised a concern with rP25242: Fix entities being able to attack allied structures in rare cases..

Beginning with this changeset I get a segmentation fault, when starting a match.

Mon, Apr 12, 5:55 PM
Langbart resigned from rP25229: Draws GUI elements by Z order..

I have noticed some difficulties with the minimap buttons.

Please, try a newer revision, at least rP25241.

Mon, Apr 12, 5:49 PM
wraitii requested review of D3843: Destroy components in reverse order of construction..
Mon, Apr 12, 5:48 PM
Langbart resigned from rP25238: Mixins: Remove the special mercenary technology, apply template changes….

fixed with rP25245

Mon, Apr 12, 5:40 PM
wraitii requested review of D3842: Use unique_ptr for secondary sim data..
Mon, Apr 12, 5:38 PM
wraitii requested verification of rP25238: Mixins: Remove the special mercenary technology, apply template changes….

Fixed in rP25245

Mon, Apr 12, 5:37 PM
vladislavbelov added a comment to rP25229: Draws GUI elements by Z order..

I have noticed some difficulties with the minimap buttons.

Please, try a newer revision, at least rP25241.

Mon, Apr 12, 5:37 PM
Langbart raised a concern with rP25238: Mixins: Remove the special mercenary technology, apply template changes….

I get many errors when loading the "Units demo" scenario map with this changeset.

Mon, Apr 12, 5:36 PM
Langbart raised a concern with rP25229: Draws GUI elements by Z order..

I have noticed some difficulties with the minimap buttons.


Mon, Apr 12, 5:31 PM
Stan added inline comments to D2967: Cache the model-animation maximum bounds..
Mon, Apr 12, 4:48 PM
Vulcan added a comment to D2967: Cache the model-animation maximum bounds..

Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.

Mon, Apr 12, 4:46 PM
Vulcan added a comment to D2967: Cache the model-animation maximum bounds..

Successful build - Chance fights ever on the side of the prudent.

Mon, Apr 12, 4:32 PM
Vulcan added a comment to D2967: Cache the model-animation maximum bounds..

Successful build - Chance fights ever on the side of the prudent.

Mon, Apr 12, 4:32 PM
wraitii requested review of D3841: Fix 3 gamesetup issues.
Mon, Apr 12, 4:28 PM
nwtour added inline comments to D3243: Gamesetup cleanup - Separate Game Settings from the GUI Gamesetup.
Mon, Apr 12, 4:28 PM
wraitii updated the diff for D2967: Cache the model-animation maximum bounds..

I think hashable weak_ptr is better but it looks like we won't get that until C++23, so for now I'll go with this.

Mon, Apr 12, 4:23 PM
wraitii added inline comments to D3243: Gamesetup cleanup - Separate Game Settings from the GUI Gamesetup.
Mon, Apr 12, 4:21 PM
nwtour added inline comments to D3243: Gamesetup cleanup - Separate Game Settings from the GUI Gamesetup.
Mon, Apr 12, 4:18 PM
Harbormaster failed to build B16724: rP25245: Fix issue with r25238 for rP25245: Fix issue with r25238!
Mon, Apr 12, 4:16 PM
wraitii committed rP25245: Fix issue with r25238.
Fix issue with r25238
Mon, Apr 12, 4:08 PM
Freagarach requested changes to D3577: introduce template_unit_soldier and clean up unit templates.

It seems like you'd better use the new features introduced by @wraitii for this.

Mon, Apr 12, 4:01 PM
wraitii committed rP25244: Fix undefined values in barter tooltip..
Fix undefined values in barter tooltip.
Mon, Apr 12, 3:51 PM
wraitii closed D3829: Fix undefined values in barter tooltip.
Mon, Apr 12, 3:51 PM
wraitii accepted D3829: Fix undefined values in barter tooltip.
Mon, Apr 12, 3:50 PM
wraitii added a comment to D3833: Map browser: input filter, also filter random map entry.

I'm not sure what this does? It also seems to not work right, I can't see the "random" option?

Mon, Apr 12, 3:47 PM
wraitii accepted D3836: Partly revert rP23996..
Mon, Apr 12, 3:44 PM
wraitii added inline comments to D3243: Gamesetup cleanup - Separate Game Settings from the GUI Gamesetup.
Mon, Apr 12, 3:40 PM
nwtour added a comment to D3243: Gamesetup cleanup - Separate Game Settings from the GUI Gamesetup.

FYI @wraitii

Mon, Apr 12, 3:08 PM
vladislavbelov added a comment to rP25241: Crops minimap view bounds to map size..
CMiniMap.cpp
../../../source/gui/ObjectTypes/CMiniMap.cpp: In function ‘void {anonymous}::CropPointsByCircle(const std::array<CVector3D, 4>&, const CVector3D&, float, std::vector<CVector3D>*)’:
../../../source/gui/ObjectTypes/CMiniMap.cpp:78:14: warning: unused variable ‘radiusSquared’ [-Wunused-variable]
  const float radiusSquared = radius * radius;
              ^~~~~~~~~~~~~

I'll fix it.

Mon, Apr 12, 3:05 PM
Freagarach added a comment to rP25241: Crops minimap view bounds to map size..
CMiniMap.cpp
../../../source/gui/ObjectTypes/CMiniMap.cpp: In function ‘void {anonymous}::CropPointsByCircle(const std::array<CVector3D, 4>&, const CVector3D&, float, std::vector<CVector3D>*)’:
../../../source/gui/ObjectTypes/CMiniMap.cpp:78:14: warning: unused variable ‘radiusSquared’ [-Wunused-variable]
  const float radiusSquared = radius * radius;
Mon, Apr 12, 2:58 PM
Harbormaster failed to build B16720: rP25241: Crops minimap view bounds to map size. for rP25241: Crops minimap view bounds to map size.!
Mon, Apr 12, 2:51 PM
Freagarach committed rP25243: Minor fixes after Gathering refactoring..
Minor fixes after Gathering refactoring.
Mon, Apr 12, 2:50 PM
Freagarach committed rP25242: Fix entities being able to attack allied structures in rare cases..
Fix entities being able to attack allied structures in rare cases.
Mon, Apr 12, 2:42 PM
Freagarach closed D3840: Fix entities able to attack allied structures..
Mon, Apr 12, 2:41 PM
vladislavbelov committed rP25241: Crops minimap view bounds to map size..
Crops minimap view bounds to map size.
Mon, Apr 12, 2:39 PM
vladislavbelov closed D3837: Crops minimap view bounds to map size.
Mon, Apr 12, 2:39 PM
Freagarach committed rP25240: Split hotkeys of turrets..
Split hotkeys of turrets.
Mon, Apr 12, 2:31 PM
Freagarach closed D3773: Split hotkeys of turrets..
Mon, Apr 12, 2:31 PM
Vulcan added a comment to D3838: Minor fixes after Gathering refactoring..

Successful build - Chance fights ever on the side of the prudent.

Mon, Apr 12, 2:22 PM
Vulcan added a comment to D3838: Minor fixes after Gathering refactoring..

Successful build - Chance fights ever on the side of the prudent.

Mon, Apr 12, 2:19 PM
vladislavbelov added inline comments to D3775: Make dropdown keys change only the highlighted element - select on enter/click..
Mon, Apr 12, 2:13 PM
Freagarach updated the diff for D3838: Minor fixes after Gathering refactoring..

Reduce duplication in return resource order.

Mon, Apr 12, 2:10 PM