Page MenuHomeWildfire Games
Feed All Stories

Yesterday

Angen awarded rP22682: Use shared_ptr to avoid copying and deleting SGUIImageEffects, 2.5x faster in a… a Love token.
Sat, Aug 17, 3:59 PM
Alexandermb committed rP22683: Animations re-export "Cavalry Javelinist Rider Animations".
Animations re-export "Cavalry Javelinist Rider Animations"
Sat, Aug 17, 3:00 PM
elexis committed rP22682: Use shared_ptr to avoid copying and deleting SGUIImageEffects, 2.5x faster in a….
Use shared_ptr to avoid copying and deleting SGUIImageEffects, 2.5x faster in a…
Sat, Aug 17, 1:53 PM
elexis closed D2184: Use shared_ptr for SGUIImageEffects to avoid both copy and delete.
Sat, Aug 17, 1:53 PM
Vulcan added a comment to D2184: Use shared_ptr for SGUIImageEffects to avoid both copy and delete.

Successful build - Chance fights ever on the side of the prudent.

Sat, Aug 17, 1:48 PM
elexis updated the summary of D2184: Use shared_ptr for SGUIImageEffects to avoid both copy and delete.
Sat, Aug 17, 1:45 PM
elexis updated the test plan for D2184: Use shared_ptr for SGUIImageEffects to avoid both copy and delete.
Sat, Aug 17, 1:40 PM
elexis created D2184: Use shared_ptr for SGUIImageEffects to avoid both copy and delete.
Sat, Aug 17, 1:39 PM
elexis added a comment to rP22679: Move CGUI::GenerateText to CGUIText constructor, CGUI::DrawText to CGUIText….

5x faster for empty strings, not 30x according to previous me https://code.wildfiregames.com/D2168#90278

Sat, Aug 17, 12:56 PM
autobuild committed rP22681: [Windows] Automated build..
[Windows] Automated build.
Sat, Aug 17, 12:07 PM
Vulcan added a comment to D1806: standardized structure aura descriptions.

Successful build - Chance fights ever on the side of the prudent.

Sat, Aug 17, 12:00 PM
Nescio updated the diff for D1806: standardized structure aura descriptions.

the “” technology

Sat, Aug 17, 11:55 AM
Nescio added inline comments to D1806: standardized structure aura descriptions.
Sat, Aug 17, 11:54 AM
Nescio added a comment to D2006: standardize resource tooltips.

Units have different gather rates for resource subtypes, therefore it makes sense to mention both the subtype (what you gather) and the resource (what you gather) in the tooltip. We already have “Harvest grain for food.” in the field tooltip and my suggestion is to follow that format for the other resource entity tooltips. Flora has wood.tree or food.fruit. And animals have to be killed before resources can be collected, hence the “Kill to”.
But yeah, sentences should be proper English; robot language is undesirable.
(Also, lumber is something quite different than wood; look it up in a dictionary.)

Sat, Aug 17, 11:48 AM
Nescio added a comment to D2110: manual/intro.txt corrections.

I have no strong opinion on the tag changes; if someone else agrees with them, let’s go ahead. Otherwise, let’s keep them as before to minimize string changes.

In mark-up languages it's customary to close tags on the same line, e.g. LaTeX \textbf{lorem}, HTML <b>ipsum</b>, MarkDown **dolor**, hence my preference for [font="sans-bold-14"]sit[font="sans-14"] in this text file, which also makes it easier to see if a tag is forgotten.

Sat, Aug 17, 11:40 AM
Stan added a comment to D1274: Prevent CXeromyces ConvertFile crash on Win10 with G Data Internet Security.

I pinged them on twitter. We'll see.

Sat, Aug 17, 11:19 AM · Windows Developers
elexis committed rP22680: Improve performance of ScriptInterface::CreateObject from rP22528 / D2080 by….
Improve performance of ScriptInterface::CreateObject from rP22528 / D2080 by…
Sat, Aug 17, 5:30 AM
elexis closed D2127: ScriptInterface CreateObject performance improvement.
Sat, Aug 17, 5:30 AM
elexis added inline comments to D2127: ScriptInterface CreateObject performance improvement.
Sat, Aug 17, 5:22 AM
Harbormaster failed to build B8891: rP22679: Move CGUI::GenerateText to CGUIText constructor, CGUI::DrawText to CGUIText… for rP22679: Move CGUI::GenerateText to CGUIText constructor, CGUI::DrawText to CGUIText…!
Sat, Aug 17, 3:34 AM
elexis committed rP22679: Move CGUI::GenerateText to CGUIText constructor, CGUI::DrawText to CGUIText….
Move CGUI::GenerateText to CGUIText constructor, CGUI::DrawText to CGUIText…
Sat, Aug 17, 3:32 AM
elexis closed D2168: Move CGUI::GenerateText to CGUIText ctor and split into helper functions.
Sat, Aug 17, 3:32 AM
elexis updated subscribers of D2094: Fix unreported memory leaks, remove unused code and use c++ style casts in the glooxwrapper following rP19703.

Thank you for the review @JoshuaJB !

Sat, Aug 17, 2:22 AM
Harbormaster failed to build B8890: rP22678: Fix unreported glooxwrapper leaks following rP19703, refs #2305. for rP22678: Fix unreported glooxwrapper leaks following rP19703, refs #2305.!
Sat, Aug 17, 2:14 AM
elexis committed rP22678: Fix unreported glooxwrapper leaks following rP19703, refs #2305..
Fix unreported glooxwrapper leaks following rP19703, refs #2305.
Sat, Aug 17, 2:12 AM
elexis closed D2094: Fix unreported memory leaks, remove unused code and use c++ style casts in the glooxwrapper following rP19703.
Sat, Aug 17, 2:12 AM
Alexandermb added a comment to rP22673: Animations re-export "Skeleton and Bodies".

It might also be that the servers are timing out, not client(you). Unless you have someone already taking care of it, you might want to try to commit smaller batches of modified files if that is possible.
Thanks for taking care of this issue Alexandermb!

Sat, Aug 17, 12:00 AM

Fri, Aug 16

Harbormaster failed to build B8889: rP22677: Fix issue with two wrong path and name following rP22673 for rP22677: Fix issue with two wrong path and name following rP22673!
Fri, Aug 16, 11:59 PM
Alexandermb committed rP22677: Fix issue with two wrong path and name following rP22673.
Fix issue with two wrong path and name following rP22673
Fri, Aug 16, 11:58 PM
minohaka added a comment to rP22673: Animations re-export "Skeleton and Bodies".

Was playing and got these errors:
ERROR: Could not load mesh 'art/meshes/skeletal/new/armor/m_tunic_short.dae'
ERROR: CObjectEntry::BuildVariation(): Model art/meshes/skeletal/new/armor/m_tunic_short.dae failed to load
ERROR: Failed to build prop model "units/seleucids/elephantry_c_r.xml" on actor "turret_sele_champ_ele"
ERROR: Could not load mesh 'art/meshes/skeletal/new/armor/m_tunic_short.dae'
ERROR: CObjectEntry::BuildVariation(): Model art/meshes/skeletal/new/armor/m_tunic_short.dae failed to load
ERROR: Failed to build prop model "units/seleucids/elephantry_c_r.xml" on actor "turret_sele_champ_ele"

Fri, Aug 16, 11:52 PM
Gallaecio added reviewers for D2165: Upgrade into a %(name)s → Upgrade to %(name)s: Itms, Stan.
Fri, Aug 16, 9:39 PM
Gallaecio added inline comments to D1806: standardized structure aura descriptions.
Fri, Aug 16, 9:36 PM
Gallaecio added reviewers for D1807: standardized catafalque aura descriptions: Itms, elexis.
Fri, Aug 16, 9:29 PM
Gallaecio accepted D1807: standardized catafalque aura descriptions.
Fri, Aug 16, 9:29 PM
Gallaecio added a comment to D1808: standardized hero aura descriptions.
In D1808#90733, @Nescio wrote:

Before I can update this, we still need to find a proper format for the formation and garrison aura types.

Maybe what we need first is to have two completely different words to refer to (1) formation as in a way a group of units can organize themselves and (2) formation as in a specific group of units. For example, if we used ‘group’ for the latter, “Same group [class] [change] [attributes]” may work.

A group is an arbitrary selection of entities, which can be defined by e.g. Ctrl+1 and selected by pressing 1 or clicking on the group panel at the left of the screen.

Fri, Aug 16, 9:27 PM
Gallaecio added a comment to D2006: standardize resource tooltips.
In D2006#90693, @Nescio wrote:

So basically you prefer [verb] for [resource] instead of [verb] [subtype] for [resource]?

Fri, Aug 16, 9:21 PM
Gallaecio added reviewers for D2110: manual/intro.txt corrections: elexis, Itms.
Fri, Aug 16, 9:03 PM
Gallaecio added a comment to D2110: manual/intro.txt corrections.

I meant what @Freagarach said, and as I suspected is a no-go.

Fri, Aug 16, 9:03 PM
Gallaecio added reviewers for D2179: capitalize classes in team bonus descriptions: elexis, Itms.
Fri, Aug 16, 8:58 PM
Gallaecio accepted D2179: capitalize classes in team bonus descriptions.
Fri, Aug 16, 8:58 PM
Harbormaster failed to build B8888: rP22676: PushGuiPage support for passing a function instead of a function name. for rP22676: PushGuiPage support for passing a function instead of a function name.!
Fri, Aug 16, 8:48 PM
elexis removed 1 auditor(s) for rP14496: Removes g_ScriptingHost and implements global to compartment 1 to 1 relation.: elexis.

Passing callback functions as arguments instead of names fixed in rP22676.

Fri, Aug 16, 8:47 PM
elexis committed rP22676: PushGuiPage support for passing a function instead of a function name..
PushGuiPage support for passing a function instead of a function name.
Fri, Aug 16, 8:46 PM
elexis closed D1684: Pass callback function to PushGuiPage and unify PopGuiPage/PopGuiPageCB.
Fri, Aug 16, 8:46 PM
elexis added a comment to D1684: Pass callback function to PushGuiPage and unify PopGuiPage/PopGuiPageCB.

Vladislav was so kind to check the patch again, especially for the shared_ptr resigin on the SGUIPage.
http://irclogs.wildfiregames.com/2019-08/2019-08-14-QuakeNet-%230ad-dev.log

20:54 < Vladislav> elexis: I agree with your current shared_ptr, since SGUIPage has other members in shared_ptr. But it might (or should) be improved. We may write a smart lock.

Fri, Aug 16, 8:40 PM
elexis removed 1 auditor(s) for rP14372: Move UPnP port forwarding to a thread.: elexis.
Fri, Aug 16, 8:20 PM
elexis removed 1 auditor(s) for rP14370: Cache UPnP root URL to try to avoid searching each time. Also make searching…: elexis.

For real:

==15080== 148 bytes in 1 blocks are definitely lost in loss record 2,224 of 3,227
==15080==    at 0x483877F: malloc (vg_replace_malloc.c:299)
==15080==    by 0x630E7E5: ssdpDiscoverDevices (in /usr/lib/libminiupnpc.so.17)
==15080==    by 0x630973A: upnpDiscover (in /usr/lib/libminiupnpc.so.17)
==15080==    by 0x191253: CNetServerWorker::SetupUPnP(void*) (NetServer.cpp:252)
==15080==    by 0x667757E: start_thread (in /usr/lib/libpthread-2.29.so)
==15080==    by 0x678B0E2: clone (in /usr/lib/libc-2.29.so)
Fri, Aug 16, 8:11 PM
elexis added a comment to rP22673: Animations re-export "Skeleton and Bodies".

It might also be that the servers are timing out, not client(you). Unless you have someone already taking care of it, you might want to try to commit smaller batches of modified files if that is possible.
Thanks for taking care of this issue Alexandermb!

Fri, Aug 16, 8:10 PM
elexis committed rP22675: Fix miniupnp memory leak from rP14332 again after it was fixed in rP14348 and….
Fix miniupnp memory leak from rP14332 again after it was fixed in rP14348 and…
Fri, Aug 16, 8:07 PM
elexis closed D2183: Fix miniupnpc leak in rP14370.
Fri, Aug 16, 8:07 PM
elexis added a comment to D2183: Fix miniupnpc leak in rP14370.

See IRC discussion today, got a commit recommendation:
http://irclogs.wildfiregames.com/2019-08/2019-08-16-QuakeNet-%230ad-dev.log

Fri, Aug 16, 8:02 PM
elexis added a comment to rP22674: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit..

I tested again multiple times...
With the joinable() test there is no warning, without the condition there is!
Also says possible leak, not definite. So perhaps its testing the not impossible per se case that the thing was only default constructed.

9669== 480 bytes in 1 blocks are possibly lost in loss record 2,785 of 3,231

Fri, Aug 16, 8:01 PM
Alexandermb added a comment to rP22673: Animations re-export "Skeleton and Bodies".

This commit is supposed to have another wich adds the new re-exported animations and another with the deletions of the bugged ones. But i have a connection issue with the forrum/server since the first blackout of my country so im unnable of commit larger files. I told other art development contributors to commit the files if possible. I'll do the rest of the cleaning after everything is commited

Fri, Aug 16, 7:51 PM
elexis removed 1 auditor(s) for rP22666: pthread -> std::thread (4/7) - Replace pthread in remaining files: elexis.

Thanks for the excursion. One should probably check whether there are other calls that need a join instead of a detach, or that miss it completely like this one did, or whether joinable() safeguards are missing (and whether every modified code actually works)

Fri, Aug 16, 7:48 PM
wraitii committed rP22674: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit..
Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.
Fri, Aug 16, 7:39 PM
wraitii closed D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.
Fri, Aug 16, 7:39 PM
elexis added a comment to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

When using join(), the leak warning vanishes, so I was wrong, the // TODO should not be deleted, but it should say // TODO: Stop leaking the std::thread by using join()

Fri, Aug 16, 7:36 PM
Alexandermb committed rP22673: Animations re-export "Skeleton and Bodies".
Animations re-export "Skeleton and Bodies"
Fri, Aug 16, 7:32 PM
elexis added a comment to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

Hold on, actually I still get this after applying mine and yours:

==28068== 480 bytes in 1 blocks are possibly lost in loss record 2,787 of 3,234
==28068==    at 0x483AB65: calloc (vg_replace_malloc.c:752)
==28068==    by 0x4012AC1: allocate_dtv (in /usr/lib/ld-2.29.so)
==28068==    by 0x4013431: _dl_allocate_tls (in /usr/lib/ld-2.29.so)
==28068==    by 0x66781AD: pthread_create@@GLIBC_2.2.5 (in /usr/lib/libpthread-2.29.so)
==28068==    by 0x63F2FA9: __gthread_create (gthr-default.h:663)
==28068==    by 0x63F2FA9: std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)()) (thread.cc:135)
==28068==    by 0x1CC6D0: thread<void (&)()> (thread:130)
==28068==    by 0x1CC6D0: CNetServerWorker::SetupConnection(unsigned short) (NetServer.cpp:211)
==28068==    by 0x6C50E4: JSI_Network::StartNetworkHost(ScriptInterface::CxPrivate*, CStrW const&, unsigned short, CStr8 const&) (JSInterface_Network.cpp:62)
==28068==    by 0x6C7666: call<void(ScriptInterface::CxPrivate*, const CStrW&, short unsigned int, const CStr8&), CStrW, short unsigned int, CStr8> (NativeWrapperDefns.h:86)
==28068==    by 0x6C7666: bool ScriptInterface::call<void, CStrW, unsigned short, CStr8, &JSI_Network::StartNetworkHost>(JSContext*, unsigned int, JS::Value*) (NativeWrapperDefns.h:125)
==28068==    by 0x50969E7: CallJSNative (jscntxtinlines.h:235)
==28068==    by 0x50969E7: js::Invoke(JSContext*, JS::CallArgs const&, js::MaybeConstruct) (Interpreter.cpp:444)
==28068==    by 0x508C4DB: Interpret(JSContext*, js::RunState&) (Interpreter.cpp:2766)
==28068==    by 0x5096656: js::RunScript(JSContext*, js::RunState&) (Interpreter.cpp:391)
==28068==    by 0x509691C: js::Invoke(JSContext*, JS::CallArgs const&, js::MaybeConstruct) (Interpreter.cpp:462)
Fri, Aug 16, 7:08 PM
Vulcan added a comment to D2183: Fix miniupnpc leak in rP14370.

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 16, 6:18 PM
elexis updated the diff for D2183: Fix miniupnpc leak in rP14370.

Reference and order

Fri, Aug 16, 6:14 PM
Vulcan added a comment to D2183: Fix miniupnpc leak in rP14370.

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 16, 6:09 PM
elexis accepted D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

Given that the remaining leak is to be addressed in D2183, you can safely remove the TODO.
I suggest to check for joinable() since it definitely crashes if the thing has not been started.

Fri, Aug 16, 6:06 PM
elexis updated the diff for D2183: Fix miniupnpc leak in rP14370.

Use lambda.

Fri, Aug 16, 6:04 PM
Vulcan added a comment to D2176: Give an option to allow multiple controls groups share same entities..

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 16, 5:36 PM
Freagarach updated the diff for D2176: Give an option to allow multiple controls groups share same entities..

Negeted negation.

Fri, Aug 16, 5:32 PM
Vulcan added a comment to D2183: Fix miniupnpc leak in rP14370.

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 16, 5:22 PM
elexis retitled D2183: Fix miniupnpc leak in rP14370 from Fix miniupnpc leak in to Fix miniupnpc leak in rP14370.
Fri, Aug 16, 5:18 PM
elexis created D2183: Fix miniupnpc leak in rP14370.
Fri, Aug 16, 5:16 PM
elexis added inline comments to rP14332: UPnP-based automatic port-forwarding using miniupnpc. Breaks windows build at….
Fri, Aug 16, 5:12 PM
wraitii added inline comments to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.
Fri, Aug 16, 5:12 PM
elexis added inline comments to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.
Fri, Aug 16, 5:08 PM
elexis added a comment to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

Also the entire thing should become optional (default.cfg)!!

Fri, Aug 16, 4:51 PM
elexis updated the summary of D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.
Fri, Aug 16, 4:48 PM
elexis retitled D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit from Fix rP22666 - pThread 4/7 - NetServer / miniupnp crashes when quitting MP games to Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.
Fri, Aug 16, 4:47 PM
elexis raised a concern with rP14372: Move UPnP port forwarding to a thread..

From the IRClogs I understand that the purpose was very narrow, but someone should at some point have considered whether letting the thread just run around for a minute or something is the right thing to do after the NetServer was destroyed and possibly N more new ones created meanwhile.

Fri, Aug 16, 4:46 PM
elexis added inline comments to rP14372: Move UPnP port forwarding to a thread..
Fri, Aug 16, 3:51 PM
elexis added a comment to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

I agree to commit this in order to fix the crash asap and reflect the previous broken code behavior, so that possible leak fixes are in a separate commit (+1 savestate).

Fri, Aug 16, 3:37 PM
elexis raised a concern with rP14370: Cache UPnP root URL to try to avoid searching each time. Also make searching….

Please correct me if I'm wrong, but if I'm not mistaken the early returns invalidate the // Make sure everything is properly freed. part from rP14348.

Fri, Aug 16, 2:52 PM
elexis added a comment to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

rP14332 originally it ran in the same thread and froze the UI
rP14370 started to move it to the NetServer worker thread
rP14371 finished to move it to the NetServer worker thread
rP14372 moved it to a new UPNP worker thread and let it running if the NetServer closes

Fri, Aug 16, 1:49 PM
elexis retitled D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit from Fix rP22666 - pThread 4/7 - NetServer crashes when quitting MP games to Fix rP22666 - pThread 4/7 - NetServer / miniupnp crashes when quitting MP games.
Fri, Aug 16, 1:17 PM
Vulcan added a comment to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 16, 1:15 PM
wraitii updated the diff for D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

so, I think it's better to just detach() and let it live. It'll either clean up on its own or get cleaned up by the OS when exiting, and that's likely fine.

Fri, Aug 16, 1:10 PM
elexis added a comment to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

So the quetion is mostly what the 10 sec to 100ms change will do.
It sounds like 100ms lag could break it already depending on implementation? Depends on whether it only listens for a response or whether it also sends something prior each call. Specs say "execute the discovery process" only.
I saw someone using 2000ms, and no recommendation otherwise.
So looking at the UPNP discovery protocol, that's https://en.wikipedia.org/wiki/Simple_Service_Discovery_Protocol
i.e. https://tools.ietf.org/html/draft-cai-ssdp-v1-03#section-2.1
which says

Hence two types of SSDP requests will be sent across the SSDP

multicast channel/port. The first are discovery requests, a SSDP
client looking for SSDP services.

so 100ms sounds like too few time to send and receive a packet of any type.

Fri, Aug 16, 12:50 PM
wraitii added inline comments to D1921: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.
Fri, Aug 16, 12:08 PM
Harbormaster failed remote builds in B8878: Diff 9355 for D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit!
Fri, Aug 16, 12:08 PM
Vulcan added a comment to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Aug 16, 12:08 PM
wraitii updated the diff for D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

Cleanly exit to avoid hanging in upnp Discovery.

Fri, Aug 16, 12:07 PM
Angen added a comment to D1921: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.

builds without-pch

Fri, Aug 16, 12:03 PM
elexis requested changes to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.
  • that member is not defined is the macro is false
  • Alt+f4 netserver takes 20 seconds for me to end the program
Fri, Aug 16, 11:37 AM
elexis updated the summary of D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.
Fri, Aug 16, 11:26 AM
Stan added inline comments to D1921: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.
Fri, Aug 16, 11:18 AM
Vulcan added a comment to D1921: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 16, 11:07 AM
elexis added a comment to D1684: Pass callback function to PushGuiPage and unify PopGuiPage/PopGuiPageCB.

None, this doesn't change the stack model.

typedef std::vector<SGUIPage> PageStackType;
PageStackType m_PageStack;

Fri, Aug 16, 11:01 AM
wraitii updated the diff for D1921: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.

Fix test issue, fix remarks.

Fri, Aug 16, 10:03 AM
Vulcan added a comment to D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

Successful build - Chance fights ever on the side of the prudent.

Fri, Aug 16, 10:00 AM
autobuild committed rP22672: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Aug 16, 9:55 AM
autobuild committed rP22671: [Windows] Automated build..
[Windows] Automated build.
Fri, Aug 16, 9:48 AM
Harbormaster failed remote builds in B8875: Diff 9352 for D1684: Pass callback function to PushGuiPage and unify PopGuiPage/PopGuiPageCB!
Fri, Aug 16, 9:36 AM
Vulcan added a comment to D1684: Pass callback function to PushGuiPage and unify PopGuiPage/PopGuiPageCB.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Aug 16, 9:36 AM