Page MenuHomeWildfire Games
Feed All Stories

Today

autobuild committed rP24784: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Mon, Jan 25, 9:21 AM
Stan added inline comments to D3468: Don't initialise null values in cmpGarrisonHolder..
Mon, Jan 25, 8:24 AM
Stan added a comment to D3468: Don't initialise null values in cmpGarrisonHolder..

Think you forgot tests :)

Mon, Jan 25, 8:23 AM
Vulcan added a comment to D3468: Don't initialise null values in cmpGarrisonHolder..

Build is green

Mon, Jan 25, 8:23 AM
Freagarach updated the diff for D3468: Don't initialise null values in cmpGarrisonHolder..

Logic error.

Mon, Jan 25, 8:18 AM
Freagarach requested review of D3468: Don't initialise null values in cmpGarrisonHolder..
Mon, Jan 25, 7:57 AM
Vulcan added a comment to D2056: Resupport more garrisoned slots per entity..

Build is green

Mon, Jan 25, 7:38 AM
Freagarach updated the diff for D2056: Resupport more garrisoned slots per entity..

Check for cmpGarrisonable before using it.

Mon, Jan 25, 7:31 AM

Yesterday

wowgetoffyourcellphone added a comment to D2182: Support training of groups of units..

I could see this being very useful in differentiating some civs. Perhaps Romans, for example, only trains soldiers in these groups. Or maybe Champions train in groups. A group can include an officer (2x health, attack aura) and a bannerman (3x health, speed and health aura).

Sun, Jan 24, 11:10 PM
Stan added a comment to D3437: Move SSE.h to a better place.

Maybe although if there are a lot more files might make more sense

Sun, Jan 24, 11:10 PM
OptimusShepard added a comment to D3437: Move SSE.h to a better place.

Seems like a more useful place. But maybe you should rename the files to simd.cpp/h for more general use and preparation for future usage of AVX/AVX2?

Sun, Jan 24, 11:03 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build has FAILED

Sun, Jan 24, 10:26 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build is green

Sun, Jan 24, 10:25 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build is green

Sun, Jan 24, 10:18 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build is green

Sun, Jan 24, 10:10 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build is green

Sun, Jan 24, 9:52 PM
wraitii added a comment to D3466: Make wall turrets upgrade into proper towers..

Oh yeah this is almost a duplicate of that, in fact. I've posted some of my comments there, I'll change this bit here to be about upgrading wall turrets into proper towers then after that diff goes in.

Sun, Jan 24, 9:41 PM
wraitii requested changes to D2769: [gameplay] add visible garrison points to wall towers.

I failed to realised that this existed, but I fully agree with this and duplicate it somewhat in D3466.

Sun, Jan 24, 9:40 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build is green

Sun, Jan 24, 9:39 PM
Freagarach added a comment to D3466: Make wall turrets upgrade into proper towers..

So step one would be D2769.

Sun, Jan 24, 9:32 PM
wraitii added inline comments to D2269: Combine attacker data in "attackerData" in attack-related code..
Sun, Jan 24, 9:32 PM
wraitii added a comment to D3467: Limit possibility of brute force attacks when guessing password.

This looks OK to me, but haven't tested, make sure to check it still works after the changes (and forgot about const, sorry)

Sun, Jan 24, 9:30 PM
Freagarach added inline comments to D2269: Combine attacker data in "attackerData" in attack-related code..
Sun, Jan 24, 9:27 PM
Angen updated the diff for D3467: Limit possibility of brute force attacks when guessing password.

more comments

Sun, Jan 24, 9:27 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build is green

Sun, Jan 24, 9:22 PM
wraitii added inline comments to D2269: Combine attacker data in "attackerData" in attack-related code..
Sun, Jan 24, 9:21 PM
Angen updated the diff for D3467: Limit possibility of brute force attacks when guessing password.

fix comments

Sun, Jan 24, 9:20 PM
wraitii added a comment to D2269: Combine attacker data in "attackerData" in attack-related code..

Hm, indeed, I was wrong in that we need the object anyways for melee for attack effects.

Sun, Jan 24, 9:20 PM
wraitii added inline comments to D3467: Limit possibility of brute force attacks when guessing password.
Sun, Jan 24, 9:15 PM
Freagarach added a comment to D2269: Combine attacker data in "attackerData" in attack-related code..

So you would say rather two extra properties for D781?

Sun, Jan 24, 9:14 PM
wraitii added inline comments to D3467: Limit possibility of brute force attacks when guessing password.
Sun, Jan 24, 9:13 PM
Angen updated the diff for D3467: Limit possibility of brute force attacks when guessing password.

actually reuse already translated string

Sun, Jan 24, 9:06 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build is green

Sun, Jan 24, 8:51 PM
wraitii added inline comments to D3467: Limit possibility of brute force attacks when guessing password.
Sun, Jan 24, 8:41 PM
Angen updated the diff for D3467: Limit possibility of brute force attacks when guessing password.

reuse string

Sun, Jan 24, 8:38 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build is green

Sun, Jan 24, 8:35 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build is green

Sun, Jan 24, 8:29 PM
Angen updated the diff for D3467: Limit possibility of brute force attacks when guessing password.

restore counter after correct password so user can misstype when rejoining

Sun, Jan 24, 8:21 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build is green

Sun, Jan 24, 8:19 PM
Vulcan added a comment to D3467: Limit possibility of brute force attacks when guessing password.

Build is green

Sun, Jan 24, 8:13 PM
Angen updated the summary of D3467: Limit possibility of brute force attacks when guessing password.
Sun, Jan 24, 8:07 PM
Angen published D3467: Limit possibility of brute force attacks when guessing password for review.
Sun, Jan 24, 8:06 PM
Angen committed rP24783: Fix invalid variable used in getConnectionFailReason.
Fix invalid variable used in getConnectionFailReason
Sun, Jan 24, 6:59 PM
Angen committed rP24782: Limit gather rate tooltip to 2 decimal places.
Limit gather rate tooltip to 2 decimal places
Sun, Jan 24, 4:28 PM
Angen closed D3460: Limit gather rate tooltip to 2 decimal places.
Sun, Jan 24, 4:28 PM
Vulcan added a comment to D3465: Nerf wall towers.

Build is green

Sun, Jan 24, 3:42 PM
borg- added a comment to D3465: Nerf wall towers.

I see no reason to reduce health to 1000. In general, they are bigger than a town tower and also the walls. Decreasing the max range / vision is bad because they are the same height as a tower. What I would do is add garrison attack/vision depends of units like a outpost, decrease health by 10-15%, increase stone cost and construction time.

Sun, Jan 24, 2:12 PM
wraitii updated the diff for D3465: Nerf wall towers.

After discussing with FeldFeld, only do the HP change for A24.

Sun, Jan 24, 2:11 PM
wraitii published D3466: Make wall turrets upgrade into proper towers. for review.
Sun, Jan 24, 2:09 PM
wraitii published D3465: Nerf wall towers for review.
Sun, Jan 24, 2:09 PM
autobuild committed rP24781: [Windows] Automated build..
[Windows] Automated build.
Sun, Jan 24, 1:51 PM
Stan committed rP24780: Fix some issues found by @GunChleoc.
Fix some issues found by @GunChleoc
Sun, Jan 24, 12:38 PM
wraitii committed rP24779: Increase outpost base vision to 10.
Increase outpost base vision to 10
Sun, Jan 24, 12:07 PM
wraitii closed D3464: Increase outpost base vision to 10.
Sun, Jan 24, 12:05 PM
Angen added a comment to rP24769: [Petra/Ai] Fix not researching free and instant technologies.

Fixes: #5948

Sun, Jan 24, 11:58 AM
wraitii added inline comments to D3464: Increase outpost base vision to 10.
Sun, Jan 24, 11:55 AM
Vulcan added a comment to D3289: Only stop moving when state requests that..

Build was aborted

Sun, Jan 24, 11:29 AM
wraitii added a comment to D2269: Combine attacker data in "attackerData" in attack-related code..

I don't think the added object is a huge problem, but I agree that this currently seems like change for change's sake.

Sun, Jan 24, 11:25 AM
Stan added a comment to D2269: Combine attacker data in "attackerData" in attack-related code..

As angen said it adds a few object creations... It would remove the addition of parameters in the future though. Maybe it should be profiled.

Sun, Jan 24, 11:18 AM
Angen added a comment to D2269: Combine attacker data in "attackerData" in attack-related code..

without reading just that creates another object

Sun, Jan 24, 11:11 AM
wraitii added a comment to D2053: Implement wrapper around displaying numbers in gui.

I had a thought on this, basically 'rounding for humans':

  • As an upper limit, we never really need more than 2 significant digits for the decimal places: 0.25 is better than 0.246
  • However, we probably want 2 significant digits at least: 0.25 is also better than 0.3 or 0.2 (see gather rates).
  • But we're not scientists and we don't care about 'insignificant' significant digits: 0.1 is generally better than 0.10, a fortiori 1 is better than 1.00
    • This is debatable to an extent, and we might prefer 1.0 over 1 or 1.00 if all other related numbers have decimal places, just for visual coherence.
  • We probably don't want to round integers: 12455 over 12000, even though it's also 2 significant digits.
  • But we probably no longer care about decimals at that point: 124 over 124.2
    • I would say above 10, only 1 decimal place at most instead of 2, and above 100, none: 1.23 over 1.2, 12.6 over 12.57.
  • Multiples of .25 are probably readable enough compared to rounding to the upper/lower digit, e.g. 3.75 over 3.8 even in a "1 digit" context. Likewise, 24.25 over 24.3
    • Also debatable
Sun, Jan 24, 11:06 AM
Freagarach updated subscribers of D2269: Combine attacker data in "attackerData" in attack-related code..

Any conceptual objections against this patch, @Angen, @bb, @wraitii?

Sun, Jan 24, 11:01 AM
Freagarach updated the diff for D2646: Remove special Animal state..

Rebased.

Sun, Jan 24, 10:52 AM
Freagarach updated the diff for D3283: Properly discard orders in UnitAI.js..

Rebased (in anticipation of D3285).

Sun, Jan 24, 10:38 AM
Vulcan added a comment to D3289: Only stop moving when state requests that..

Build is green

Sun, Jan 24, 10:22 AM
Freagarach updated the diff for D3289: Only stop moving when state requests that..

Rebased in anticipation of D3463.

Sun, Jan 24, 10:17 AM
Freagarach added a comment to D3463: Fix StandGround freezing units..

(Refs. D3289.)

Sun, Jan 24, 10:13 AM
Angen added a comment to D3460: Limit gather rate tooltip to 2 decimal places.

yes we should but I was lazy to start that, see attached comments in https://code.wildfiregames.com/D2053

Sun, Jan 24, 10:10 AM
wraitii added a comment to D3464: Increase outpost base vision to 10.

Why 10 instead of 8?

Sun, Jan 24, 10:08 AM
Freagarach added a comment to D3464: Increase outpost base vision to 10.

Why 10 instead of 8?

Sun, Jan 24, 10:05 AM
wraitii added a comment to D3463: Fix StandGround freezing units..

I think we should probably change that as part of a more extensive stance rewrite ;)

Sun, Jan 24, 10:00 AM
wraitii requested review of D3464: Increase outpost base vision to 10.
Sun, Jan 24, 9:49 AM
Freagarach added a comment to D3463: Fix StandGround freezing units..

I would actually like to just remove those lines. I frequently order my units somewhere and thereafter set them to standground. But I guess I might be alone on that ;)
For now this makes sense more (A23b behaviour).

Sun, Jan 24, 9:34 AM
wraitii updated the Trac tickets for D3463: Fix StandGround freezing units..
Sun, Jan 24, 9:30 AM
wraitii requested review of D3463: Fix StandGround freezing units..
Sun, Jan 24, 9:20 AM
Freagarach added a comment to D3460: Limit gather rate tooltip to 2 decimal places.

We should have a function for max decimals I guess.

Sun, Jan 24, 9:10 AM
wraitii accepted D3460: Limit gather rate tooltip to 2 decimal places.

This writes 1 as 1.00 but I think it's actually OK for readability because all numbers use the same decimals.

Sun, Jan 24, 8:51 AM
Freagarach added a comment to D3460: Limit gather rate tooltip to 2 decimal places.

Two is fine for me, I was merely asking ;)

Sun, Jan 24, 7:59 AM
vladislavbelov requested review of D3462: Adds error shader name logging on reload.
Sun, Jan 24, 3:08 AM

Sat, Jan 23

wraitii committed rP24778: Fix error when deserializing following 24759.
Fix error when deserializing following 24759
Sat, Jan 23, 10:13 PM
wraitii closed D3461: Fix error when deserializing following 24759.
Sat, Jan 23, 10:13 PM
wraitii added a comment to D3460: Limit gather rate tooltip to 2 decimal places.

Why 2 and not 1?

Sat, Jan 23, 9:57 PM
Freagarach added a comment to D3460: Limit gather rate tooltip to 2 decimal places.

Why 2 and not 1?

Sat, Jan 23, 9:49 PM
Vulcan added a comment to D3460: Limit gather rate tooltip to 2 decimal places.

Build is green

Sat, Jan 23, 9:43 PM
vladislavbelov committed rP24777: Reduces shadow biases for landscape shaders..
Reduces shadow biases for landscape shaders.
Sat, Jan 23, 8:41 PM
vladislavbelov closed D3457: Removes shadow bias for landscape shader.
Sat, Jan 23, 8:41 PM
Stan added a comment to D3460: Limit gather rate tooltip to 2 decimal places.

Pics ?

Sat, Jan 23, 8:16 PM
Angen published D3460: Limit gather rate tooltip to 2 decimal places for review.
Sat, Jan 23, 8:12 PM
wraitii added a reverting change for D3169: [gameplay] Adjust aura ranges following rP24217: rP24776: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of….
Sat, Jan 23, 7:58 PM
wraitii added a reverting change for rP24643: Fix AI's handling of buildRestriction distances following rP24217: rP24776: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of….
Sat, Jan 23, 7:57 PM
wraitii added a reverting change for D3364: Fix AI's handling of buildRestriction distances following rP24217: rP24776: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of….
Sat, Jan 23, 7:57 PM
wraitii added a reverting change for rP24349: Adjust range visualisation and aura ranges following rP24217: rP24776: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of….
Sat, Jan 23, 7:57 PM
wraitii committed rP24776: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of….
Fix UnitAI range queries - allow queries to ignore sizes - partial revert of…
Sat, Jan 23, 7:57 PM
wraitii closed D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Sat, Jan 23, 7:57 PM
Angen added inline comments to D3456: Fix UnitAI range queries - allow queries to ignore sizes - partial revert of rP24217.
Sat, Jan 23, 7:53 PM
Stan edited P232 Convert maps to a certain version.
Sat, Jan 23, 7:46 PM
Angen added inline comments to D3459: Hash match passwords better..
Sat, Jan 23, 7:37 PM
borg- updated the summary of D3458: Fix pers conscription requires levy infantry/cavalry..
Sat, Jan 23, 7:21 PM
wraitii committed rP24775: Net Server: Verify password in Authenticate.
Net Server: Verify password in Authenticate
Sat, Jan 23, 7:04 PM
wraitii closed D3438: Verify password in Authenticate.
Sat, Jan 23, 7:04 PM