Page MenuHomeWildfire Games
Feed All Stories

Today

weberkai added a comment to rP19674: Fix replay menu loading time by using a cache file.

I've started;

gdb ../pyrogenesis
Fri, Apr 26, 2:56 PM
weberkai added a comment to rP19674: Fix replay menu loading time by using a cache file.

The crash happens here:

Fri, Apr 26, 2:47 PM
elexis added a comment to rP19674: Fix replay menu loading time by using a cache file.

So it sounds like it segfaults due to an attempt to dereference an uninitialized pointer p.

Fri, Apr 26, 2:43 PM
weberkai added a comment to rP19674: Fix replay menu loading time by using a cache file.
Fri, Apr 26, 2:30 PM
elexis added a comment to D1584: Seed random sounds.
In D1584#76329, @Stan wrote:

You refer to the constructor of std::mt19937, right?

No even the number generation is slow.

Okay, thanks for having tested.

Fri, Apr 26, 2:25 PM
elexis updated subscribers of rP19674: Fix replay menu loading time by using a cache file.

First of all thanks for the clear information, I agree that

static const OsPath tempCacheFileName = VisualReplay::GetDirectoryName() / L"replayCache_temp.json";

is wrong because it was intended to use the value after g_args was set in RunGameOrAtlas of main.cpp.

Fri, Apr 26, 2:14 PM
Stan added inline comments to D1846: Let mods prevent resources from being bartered, traded and/or tributed..
Fri, Apr 26, 2:11 PM
Freagarach added inline comments to D1846: Let mods prevent resources from being bartered, traded and/or tributed..
Fri, Apr 26, 1:54 PM
Freagarach added a comment to D1846: Let mods prevent resources from being bartered, traded and/or tributed..

:)
Do I need to make sure that Jenkins has nothing to complain about? Because quite a few things it says is not due to code I changed but was already there.

Fri, Apr 26, 1:51 PM
Stan added a comment to D1846: Let mods prevent resources from being bartered, traded and/or tributed..

It's okay ;)

Fri, Apr 26, 1:46 PM
Vulcan added a comment to D1846: Let mods prevent resources from being bartered, traded and/or tributed..

Successful build - Chance fights ever on the side of the prudent.

Fri, Apr 26, 1:46 PM
Freagarach updated the diff for D1846: Let mods prevent resources from being bartered, traded and/or tributed..

Sorry, didn't wait for reaction about the currency, I implemented it during lunch.

Fri, Apr 26, 1:43 PM
Stan added inline comments to D1846: Let mods prevent resources from being bartered, traded and/or tributed..
Fri, Apr 26, 1:38 PM
Stan added a comment to D1584: Seed random sounds.

It's also a Microsoft Implementation, used in Erlang and Cisco projects. (http://irclogs.wildfiregames.com/2019-04/2019-04-25-QuakeNet-%230ad-dev.log 22:05)
https://rosettacode.org/wiki/Linear_congruential_generator
http://pi.math.cornell.edu/~mec/Winter2009/Luo/Linear%20Congruential%20Generator/linear%20congruential%20gen1.html
https://github.com/cisco-system-traffic-generator/trex-core
https://github.com/erlang/otp

Fri, Apr 26, 1:32 PM
weberkai raised a concern with rP19674: Fix replay menu loading time by using a cache file.

During variable creation, tempCacheFileName and also cacheFileName are created at VisualReplay.cpp :

Fri, Apr 26, 12:52 PM
elexis added a comment to D1584: Seed random sounds.
In D1584#76094, @Stan wrote:

Yeah but it slow as hell.

You refer to the constructor of std::mt19937, right?

Fri, Apr 26, 12:18 PM
Freagarach added a comment to D1846: Let mods prevent resources from being bartered, traded and/or tributed..

Okay, from what I see it is almost done?
Things to discuss:

  • resourceTradable/resourceBarterable/resourceTributable Objects are not used by me and can be removed I guess? Unless someone sees any useful application for it?
  • Connected: If the above is done, the question about the caching is not relevant anymore, right?
  • Duplication in the Resources.js and in the test_Player.js can be reduced. (I'm sorry, but I do not consider myself up to that task.)
  • Should I add a currency parameter in this patch so that @wowgetoffyourcellphone and @Nescio are happy? ;) (see this thread)
  • Are there any other things that ought to be done?

And a question, there are no reviewers, should I invite them or do they pick differentials themselve?

Fri, Apr 26, 12:15 PM
elexis added a comment to D1190: Allow restoring lost wall turrets.
In D1190#76305, @Angen wrote:

if slot is in players territory, he can use it

I guess that's a use case for the player if he captured enemy walls.

Fri, Apr 26, 12:07 PM
elexis added inline comments to D1751: [WIP] Map ping.
Fri, Apr 26, 11:39 AM
elexis added a comment to D1751: [WIP] Map ping.

Perhaps draw vs. display can be made consistent.

Fri, Apr 26, 11:33 AM
elexis added a comment to D1849: Clarify the use of the macmouse config option.

Which two other places are traditionally kept in sync with this file?
Also, how many mac players will look at default.cfg?

Fri, Apr 26, 10:55 AM
Nescio added a comment to D1842: Set ship status bars in parent.

You're correct, currently the generic fishing boat template does not specify a status bar, which means it defaults to the values of the template_unit.xml file. If desired, I suppose I could insert those into the fishing boat to preserve its status bar size.
However, is it really important that the fishing boat has a status bar different from all other ships? Does it convey some information to the player that will be lost if it's standardized?
For comparison, without this patch:


and with implementing this patch:

Fri, Apr 26, 10:24 AM
Angen added a comment to D1190: Allow restoring lost wall turrets.

they are global, not local (territory capturing, range manager to get list of them)
if slot is in players territory, he can use it
they cannot be destroyed by selecting, because they are visible only when placing walls (and actually are green now)
but they are removed by any new foundation placed on them.

Fri, Apr 26, 10:02 AM
autobuild committed rP22233: [i18n] Updated POT and PO files..
[i18n] Updated POT and PO files.
Fri, Apr 26, 9:59 AM
Vulcan added a comment to D1846: Let mods prevent resources from being bartered, traded and/or tributed..

Successful build - Chance fights ever on the side of the prudent.

Fri, Apr 26, 8:38 AM
Freagarach updated the diff for D1846: Let mods prevent resources from being bartered, traded and/or tributed..

Fixed confusing names, AI tribute requests and removed unnecessary test in code.

Fri, Apr 26, 8:36 AM
autobuild committed rP22232: [Windows] Automated build..
[Windows] Automated build.
Fri, Apr 26, 7:24 AM
Vulcan added a comment to D1849: Clarify the use of the macmouse config option.

Successful build - Chance fights ever on the side of the prudent.

Fri, Apr 26, 2:17 AM
Imarok created D1849: Clarify the use of the macmouse config option.
Fri, Apr 26, 2:11 AM
Harbormaster failed remote builds in B7310: Diff 7864 for D1751: [WIP] Map ping!
Fri, Apr 26, 2:06 AM
Vulcan added a comment to D1751: [WIP] Map ping.

Build failure - The Moirai have given mortals hearts that can endure.

Fri, Apr 26, 2:06 AM
Imarok added a comment to D1751: [WIP] Map ping.

I think we should restrict the number of pings, because I'm sure there will be many spammer on servers.

Fri, Apr 26, 2:03 AM
Imarok updated the diff for D1751: [WIP] Map ping.

Rebase and apply the proposed changes

Fri, Apr 26, 2:03 AM
Imarok updated the summary of D1751: [WIP] Map ping.
Fri, Apr 26, 2:01 AM
Imarok updated the summary of D1751: [WIP] Map ping.
Fri, Apr 26, 1:16 AM
Stan committed rP22231: Seed unit sounds so that their pitch and their gain are always the same for the….
Seed unit sounds so that their pitch and their gain are always the same for the…
Fri, Apr 26, 12:37 AM
Stan closed D1584: Seed random sounds.
Fri, Apr 26, 12:37 AM
Vulcan added a comment to D1752: Add GUI events for middle mouse click.

Successful build - Chance fights ever on the side of the prudent.

Fri, Apr 26, 12:30 AM
Imarok added a comment to D1752: Add GUI events for middle mouse click.

Ok, seems like I shouldn't try using the private svn for phab ^^

Fri, Apr 26, 12:25 AM
Imarok updated the diff for D1752: Add GUI events for middle mouse click.

Rebase

Fri, Apr 26, 12:22 AM

Yesterday

vladislavbelov accepted D1584: Seed random sounds.
Thu, Apr 25, 11:53 PM
Imarok added a comment to rP22230: Fix forgotten tab in rP22227 line 1337..

So it was intended. :d

Thu, Apr 25, 11:13 PM
Polakrity added a comment to rP22230: Fix forgotten tab in rP22227 line 1337..

So it was intended. :d

Thu, Apr 25, 11:12 PM
Imarok committed rP22230: Fix forgotten tab in rP22227 line 1337..
Fix forgotten tab in rP22227 line 1337.
Thu, Apr 25, 11:06 PM
Angen added inline comments to D1846: Let mods prevent resources from being bartered, traded and/or tributed..
Thu, Apr 25, 10:59 PM
Imarok added inline comments to rP22227: Reload wheel-adjusted batchsize immediately.
Thu, Apr 25, 10:59 PM
Polakrity added inline comments to rP22227: Reload wheel-adjusted batchsize immediately.
Thu, Apr 25, 10:57 PM
Freagarach added inline comments to D1846: Let mods prevent resources from being bartered, traded and/or tributed..
Thu, Apr 25, 10:41 PM
Angen added inline comments to D1846: Let mods prevent resources from being bartered, traded and/or tributed..
Thu, Apr 25, 10:32 PM
Angen added inline comments to D1846: Let mods prevent resources from being bartered, traded and/or tributed..
Thu, Apr 25, 10:17 PM
Stan committed rP22229: Fix missing spaces and non compliant code with regards to the coding….
Fix missing spaces and non compliant code with regards to the coding…
Thu, Apr 25, 10:06 PM
Stan closed D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).
Thu, Apr 25, 10:06 PM
elexis accepted D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

The ones after {{ and before }} also, at least judging by the examples.

Thu, Apr 25, 9:54 PM
Stan added inline comments to D1846: Let mods prevent resources from being bartered, traded and/or tributed..
Thu, Apr 25, 9:53 PM
Vulcan added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

Successful build - Chance fights ever on the side of the prudent.

Thu, Apr 25, 9:46 PM
Stan updated the diff for D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

Remove spaces and quotes

Thu, Apr 25, 9:43 PM
Harbormaster failed remote builds in B7304: Diff 7859 for D1846: Let mods prevent resources from being bartered, traded and/or tributed.!
Thu, Apr 25, 9:38 PM
Vulcan added a comment to D1846: Let mods prevent resources from being bartered, traded and/or tributed..

Build failure - The Moirai have given mortals hearts that can endure.

Thu, Apr 25, 9:38 PM
Freagarach updated the diff for D1846: Let mods prevent resources from being bartered, traded and/or tributed..

Some minor fixes.

Thu, Apr 25, 9:32 PM
vladislavbelov committed rP22228: Fixes a misprint that was introduced in rP22143..
Fixes a misprint that was introduced in rP22143.
Thu, Apr 25, 8:59 PM
Freagarach added a comment to D1846: Let mods prevent resources from being bartered, traded and/or tributed..

@Nescio This:

Thu, Apr 25, 8:58 PM
elexis added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

(See remarks about quotes and spaces)

Thu, Apr 25, 8:30 PM
elexis added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
In D1754#76234, @Imarok wrote:
In D1754#76083, @elexis wrote:

(Also am I the only one using libboost 1.69.0-2 or am I just the only one too stupid to resolve the build errors? I better get them resolved if I want to commit my own patches)

See https://github.com/boostorg/random/issues/49 (Found by Vladislav)
(Also see discussion at irclogs 2019-04-04 around 21:44)
TLDR: just ignore the notes and wait for boost 1.70

Thu, Apr 25, 8:21 PM
elexis added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.

This several hundred times, since february or something:

In file included from /usr/include/boost/random/detail/integer_log2.hpp:19,
                 from /usr/include/boost/random/detail/large_arithmetic.hpp:19,
                 from /usr/include/boost/random/detail/const_mod.hpp:23,
                 from /usr/include/boost/random/detail/seed_impl.hpp:26,
                 from /usr/include/boost/random/mersenne_twister.hpp:30,
                 from ../../../source/graphics/ParticleManager.h:24,
                 from ../../../source/graphics/ParticleManager.cpp:20:
/usr/include/boost/pending/integer_log2.hpp:7:59: note: #pragma message: This header is deprecated. Use <boost/integer/integer_log2.hpp> instead.
 BOOST_HEADER_DEPRECATED("<boost/integer/integer_log2.hpp>");
                                                           ^
Thu, Apr 25, 8:19 PM
Vulcan added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

Successful build - Chance fights ever on the side of the prudent.

Thu, Apr 25, 7:58 PM
elexis added a comment to rP7109: Fix #251 (Config parser doesn't ignore comments), based on patch from Cygal.

Missing GUI credit, from 2009-08-12-QuakeNet-#0ad.log:

16:26  * Philip- ignores the licensing stuff for now, and just commits cygal's patch
16:31 < cygal> thanks for the commit :)
16:31 <@Philip-> Hmm, I suppose it'd also be useful to have a list of contributors' names, to go in the credits screen etc
16:32 <@Philip-> It's hard enough keeping track of all the official WFG members who've contributed :-(
16:32  * Philip- wonders if cygal has a real name he could add to the list, and maybe an email address if he doesn't mind it being public
16:33 < cygal> Quentin Pradet <email redacted>
16:33 < cygal> (but I don't really care about credits)
Thu, Apr 25, 7:57 PM
Stan updated the diff for D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

Update comment

Thu, Apr 25, 7:54 PM
Imarok added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
In D1754#76083, @elexis wrote:

(Also am I the only one using libboost 1.69.0-2 or am I just the only one too stupid to resolve the build errors? I better get them resolved if I want to commit my own patches)

See https://github.com/boostorg/random/issues/49 (Found by Vladislav)
(Also see discussion at irclogs 2019-04-04 around 21:44)

Thu, Apr 25, 7:51 PM
Itms added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
In D1754#76083, @elexis wrote:

(Also am I the only one using libboost 1.69.0-2 or am I just the only one too stupid to resolve the build errors? I better get them resolved if I want to commit my own patches)

Thu, Apr 25, 7:44 PM
elexis removed 1 auditor(s) for rP22196: Correctly handle receiving 0 damage as not receiving any damage.: elexis.

Actually JSdoc documentation is incomplete, see https://github.com/jsdoc3/jsdoc3.github.com/issues/115
Should still use Google Closure Compiler syntax that is part of JSdoc only exceptionally.

Thu, Apr 25, 7:34 PM
elexis added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).
  • @return {{ "killed": boolean, "change": number }} - the status change of the entity.
Thu, Apr 25, 7:32 PM
Imarok updated the summary of D1751: [WIP] Map ping.
Thu, Apr 25, 7:29 PM
Imarok added a comment to D1752: Add GUI events for middle mouse click.
In D1752#72574, @elexis wrote:

I guess worldclick doesn't work since it only reacts after left-click; unless we make that hotkey a modifier (minimap click + hotkey(default shift) for instance).

Yes.

So the question is how minimap ping should be implemented for the people who don't have a third mouse button.
Isn't the usual way to add a button near the minimap, that if clicked changes the input.js state, and if that state is set, both the minimap "worldclick" events and the clicks on the actual 3D world would equally trigger the 'minimap ping'?

Thu, Apr 25, 7:28 PM
Stan added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

Anything else we should fix ?

Thu, Apr 25, 7:27 PM
Imarok committed rP22227: Reload wheel-adjusted batchsize immediately.
Reload wheel-adjusted batchsize immediately
Thu, Apr 25, 7:20 PM
Imarok closed D1742: Reload wheel-adjusted batchsize immediately.
Thu, Apr 25, 7:20 PM
elexis added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

So the outer brace comes from the @return defined here https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#return-type-description
The inner brace denotes an object, defined here https://github.com/google/closure-compiler/wiki/A-word-about-the-type-Object

Thu, Apr 25, 7:15 PM
Vulcan added a comment to D1623: Fix button caption and enable in modmod.

Successful build - Chance fights ever on the side of the prudent.

Thu, Apr 25, 7:13 PM
Imarok updated the diff for D1623: Fix button caption and enable in modmod.

Fix indent spotted by Stan

Thu, Apr 25, 7:12 PM
Stan added inline comments to D1623: Fix button caption and enable in modmod.
Thu, Apr 25, 7:08 PM
Imarok updated the summary of D1623: Fix button caption and enable in modmod.
Thu, Apr 25, 7:03 PM
Vulcan added a comment to D1623: Fix button caption and enable in modmod.

Successful build - Chance fights ever on the side of the prudent.

Thu, Apr 25, 7:02 PM
Imarok updated the diff for D1623: Fix button caption and enable in modmod.

Rebase. Disable Website button if selected mod has no url.

Thu, Apr 25, 7:01 PM
Vulcan added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

Successful build - Chance fights ever on the side of the prudent.

Thu, Apr 25, 6:57 PM
Stan added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

@elexis Thanks for the detailed discussion and looking it up. Appreciated.

Thu, Apr 25, 6:55 PM
Stan updated the diff for D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).
  • Add dashes
  • Readd the anonymous return object.
Thu, Apr 25, 6:54 PM
elexis retitled D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196) from Consider Google JSdoc syntax in Health.js (rP22196) to Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).
Thu, Apr 25, 6:45 PM
elexis added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).
Thu, Apr 25, 6:45 PM
Vulcan added a comment to D1366: Don't add the period outside a translated string.

Successful build - Chance fights ever on the side of the prudent.

Thu, Apr 25, 6:36 PM
Stan added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

If the convention is wrong, we may not follow it but have to change it.

Thu, Apr 25, 6:22 PM
Imarok updated the diff for D1366: Don't add the period outside a translated string.

Apply comments of elexis

Thu, Apr 25, 6:19 PM
Imarok committed rP22226: Add an experience status bar.
Add an experience status bar
Thu, Apr 25, 5:59 PM
Imarok closed D1460: Add an experience status bar.
Thu, Apr 25, 5:59 PM
Vulcan added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

Successful build - Chance fights ever on the side of the prudent.

Thu, Apr 25, 5:49 PM
Stan added inline comments to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).
Thu, Apr 25, 5:49 PM
Stan updated the diff for D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).
  • Remove unneeded parenthesis.
Thu, Apr 25, 5:48 PM
elexis retitled D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196) from Fix rP22196 Health.js Coding Convention breach to Consider Google JSdoc syntax in Health.js (rP22196).
Thu, Apr 25, 5:30 PM
elexis added a comment to D1848: Consider Google Closure Compiler type expressions in JSdoc in Health.js (rP22196).

(Long discussion because it's a Coding Convention change in question)

Thu, Apr 25, 5:26 PM
fatherbushido added a comment to rP21954: Fix the deer feeling like it runs in slow motion, it is now like the gazelle..

The current rev makes it walk faster than before rP20230 and probably running (fleeing) at the same speed as before rP20230.
Possibly changed in rP22197.

Thu, Apr 25, 4:41 PM
Stan added inline comments to D1846: Let mods prevent resources from being bartered, traded and/or tributed..
Thu, Apr 25, 3:15 PM