Page MenuHomeWildfire Games

jprahman (Jason Rahman)
User

Projects

User Details

User Since
May 31 2022, 6:07 AM (11 w, 3 d)

Recent Activity

Tue, Aug 9

jprahman added a comment to D4718: Allocator and generator for component data..

Looks good from my end for the most part. A few lingering nit type comments left, but otherwise great.

Tue, Aug 9, 7:08 AM

Sat, Aug 6

jprahman added a comment to D4718: Allocator and generator for component data..

Awesome perf win! I play lots of large multiplayer matches, and definitely appreciate seeing the late game speed up with many units.

Sat, Aug 6, 12:22 AM

Jul 4 2022

jprahman added a comment to D4730: Type-erased SharedState.

Usually the overhead from std::function<> comes from one of two sources:

  1. Heap allocation for the functor/function pointer/callable std::function is wrapping (https://devblogs.microsoft.com/oldnewthing/20200514-00/?p=103749), including CPU cache misses when following the pointer
  2. Indirection when invoking the type erased std::function through a virtual method call
Jul 4 2022, 1:16 AM

Jun 13 2022

jprahman added a comment to D4695: Fix Naval Shipyard..

Curious as well what sort of tooling 0AD has for template scanning/validation? I saw the templateanalyzer under source/tools, but that appears to be about balance analysis, rather than validation.

Jun 13 2022, 8:18 AM
jprahman added a comment to D4695: Fix Naval Shipyard..

Is it possible there are other templates with this same issue?

Jun 13 2022, 7:52 AM

Jun 12 2022

jprahman published D4693: Fix clang warning for deprecated binary_negate<> for review.
Jun 12 2022, 5:58 AM
jprahman updated the test plan for D4673: [NetClient] Clean up g_xmppClient checking.
Jun 12 2022, 4:26 AM
jprahman updated the diff for D4673: [NetClient] Clean up g_xmppClient checking.

Update from feedback

Jun 12 2022, 4:24 AM

Jun 1 2022

jprahman added a comment to D3877: ThreadPool extension -> Timer for recurrent task & adapt netClient..

Hey @wraitii are you planning on cleaning up and landing these changes soon? Asking since I'd like to pull in changes with the AddRecurrentTask API and can either wait for this to land, or put up a diff with an updated version of TimerThread :)

Jun 1 2022, 5:00 AM
jprahman requested review of D4675: [TaskManager] Minor cleanup in Future + TaskManager.
Jun 1 2022, 4:36 AM
jprahman added a comment to D4673: [NetClient] Clean up g_xmppClient checking.
In D4673#198748, @Stan wrote:

Did you see https://trac.wildfiregames.com/wiki/Coding_Conventions?
Some braces are out of place ?

Did you check the logic change by running some networked matches ? :)

Jun 1 2022, 4:16 AM
jprahman added a comment to D4673: [NetClient] Clean up g_xmppClient checking.

Looking at the details, the ip and port values inferred in the three conditional blocks are not used in the actual connection attempt. But rather those two values are only used to establish a Stun tunnel. For that reason, I'm not convinced that QueryConnectionDetails() would be semantically accurate for the name. Instead, something like SetupStun() would more accurately reflect the intent. Additionally, naively extracting the middle section of TryToConnect() which is gated on g_XmppClient into a second function requires some gymnastics around the return value. There are three possibilities for the return value:

  1. One value indicating the original code had 'return true' in the initial TryToConnect() implementation, and the new TryToConnect() implementation should have an early 'return true' and not proceed further following the call to 'SetupStun()'
  2. Another value indicating the original code had 'return false' in the initial TryToConnect() implementation, and the new TryToConnect() implementation should have an early 'return false' and not proceed further following the call to 'SetupStun()'
  3. Another value indicating the original code extracted into SetupStun() had neither 'return false' nor 'return true' and TryToConnect() should continue to perform 'g_NetClient->SetupConnection(enetClient)' as before
Jun 1 2022, 4:07 AM

May 31 2022

jprahman added a comment to D4673: [NetClient] Clean up g_xmppClient checking.
In D4673#198742, @Stan wrote:

Hey thanks for the patch, can you add yourself to the credits ?

May 31 2022, 8:47 AM
jprahman updated the diff for D4673: [NetClient] Clean up g_xmppClient checking.

Added to programming.json credits file

May 31 2022, 8:47 AM
jprahman added a comment to D4664: Non-local condition_variable.

I suppose the underlying assumption here is the queue is expected to be empty the majority of the time, and thus worker threads should be able to idle themselves to free up CPU cores.

May 31 2022, 8:19 AM
jprahman added inline comments to D4664: Non-local condition_variable.
May 31 2022, 7:15 AM
jprahman added inline comments to D4664: Non-local condition_variable.
May 31 2022, 7:14 AM
jprahman added reviewers for D4673: [NetClient] Clean up g_xmppClient checking: Stan, wraitii, vladislavbelov.
May 31 2022, 6:20 AM
jprahman updated the diff for D4673: [NetClient] Clean up g_xmppClient checking.

Formatting fixes

May 31 2022, 6:17 AM
jprahman requested review of D4673: [NetClient] Clean up g_xmppClient checking.
May 31 2022, 6:13 AM