HomeWildfire Games

Complete the Kushite page.

Authored by Doktoreus on Tue, May 7, 9:55 PM.

Description

Complete the Kushite page.

Reviewed By: Itms
Differential Revision: https://code.wildfiregames.com/D1862

Details

Committed
DoktoreusTue, May 7, 11:52 PM
Pushed
ItmsTue, May 7, 11:53 PM
Reviewer
Itms
Differential Revision
Restricted Differential Revision
Parents
rDDe55be1dd1bd7: Kushites page for the Design Document.
Branches
Unknown
Tags
Unknown

Event Timeline

Nescio added a subscriber: Nescio.Wed, May 8, 12:10 AM
Nescio added inline comments.
/book/gameplay/civs/kushites.md
55

Why the full stop?

58

Weird sentence.

59

?

162

1.5× vs Cavalry

166

Nescio,

Thanks for your input. Any help you can provide would be most beneficial.

Ralph

/book/gameplay/civs/kushites.md
55

Hi Nescio,

Not sure what you mean by "full stop." I am still learning this coding, so if you see a mistake please edit it, if you can, or let me know and I will make the changes.

Question: How do I edit the file as it sits? Can I edit it here ("edit commit" at the top) or do I need to edit it on my local machine and then resubmit a new diff it for review?

58

I used military jargon. "Force" refers to a military entity that delivers to a winning situation. The use of archers was a big "force" component of the Kushite army.

59

I will be changing the word "garrison" for all the units to "Population Count" to show how many population units are needed to train a specific unit. Garrison will be used for structures to show how many units can garrison a specific structure.

Nescio added a subscriber: Itms.Wed, May 8, 10:24 AM

Question: How do I edit the file as it sits? Can I edit it here ("edit commit" at the top) or do I need to edit it on my local machine and then resubmit a new diff it for review?

How did you commit it in the first place?

@Itms, where is the design document repository located?

/book/gameplay/civs/kushites.md
55

The full stop, period, point, or dot is the symbol signifying the proper end of a sentence.
Because this is a list of items, not sentences, the interpunction at the end of each line is a bit out of place, so it would be better to omit it:
* **Generic Name**: *Nubian Archer*

58

Nonetheless, sentences still should be clear, unambiguous, and proper English.

59

To avoid further confusion I strongly recommend to follow to terminology used in the templates:

  • Garrison capacity
  • Population bonus
  • Population cost
Itms added a comment.Wed, May 8, 11:16 AM

Hi! Thanks for the input @Nescio. The DD is still a very experimental WIP but if you want to collaborate with Dok you are most welcome. It is located here on Phabricator: rDD. I am adding you to the group which can see differentials related to the DD.

@Doktoreus Yes you should create a new diff with the changes you want to make.