HomeWildfire Games
Diffusion 0 A.D. Public Repository rP15576

Commit coastal waves when activating fancy effects, and incidentally completely…
rP15576
Actions

Description

Commit coastal waves when activating fancy effects, and incidentally completely change how this effect work. Refs #48.

Details

Committed
wraitiiJul 28 2014, 12:14 PM
Parents
rP15575: petra: temporary fix, waiting to be able to deal with training restrictions
Branches
Unknown
Tags
Unknown

Event Timeline

wraitii committed rP15576: Commit coastal waves when activating fancy effects, and incidentally completely….Jul 28 2014, 12:14 PM
vladislavbelov raised a concern with this commit.Aug 15 2018, 10:53 PM
vladislavbelov added a subscriber: vladislavbelov.
vladislavbelov added inline comments.
/ps/trunk/source/renderer/WaterManager.cpp
513

#5288: This condition will be always false, because we break the loop after the first nbNeighb incrementing.

This commit now has outstanding concerns.Aug 15 2018, 10:53 PM
elexis mentioned this in D1683: Removes hardcoded SkyBox sizes and use infinity sky.Jan 5 2019, 4:02 PM
elexis mentioned this in D1804: Fixes black water glitches for certain wind angles.Mar 30 2019, 9:28 PM
elexis mentioned this in rP22004: Clean up and fix height of water vertex shader..Jun 21 2019, 3:10 PM
elexis mentioned this in rP22006: Clean up and speed up the water manager distance computations.Jun 21 2019, 8:14 PM
elexis mentioned this in rP22341: Fixes black water glitches for certain wind angles with the approximate….Jun 25 2019, 6:27 AM
wraitii removed an auditor: vladislavbelov.Jul 27 2020, 10:44 AM
wraitii added a subscriber: wraitii.

I don't think this is worth cluttering the concern list over... The feature is not extremely used/beautiful and it's reported by static analysers anyways so it's not impossible to find again.

This commit no longer requires audit.Jul 27 2020, 10:44 AM
vladislavbelov mentioned this in rP24046: Reduces memory usage for fancy water by merging two textures..Sep 16 2020, 8:04 PM
vladislavbelov mentioned this in rP24047: Render waves for fancy water effects only if we have water on screen..Sep 16 2020, 8:44 PM
vladislavbelov mentioned this in rP26615: Fixes rendering reflections even they are disabled, broken in rP15576. Fixes….Mar 10 2022, 5:36 PM

Changes (19)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
art/
textures/
terrain/
types/
water/
shaders/
glsl/
source/
ps/
renderer/
simulation2/
components/

rP15576

View Options

ps/trunk/binaries/data/mods/public/art/textures/terrain/types/water/coastalWave.png

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/water_effects.fs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/water_effects.vs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/water_effects.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/water_high.fs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/water_high.vs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/waves.fs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/waves.vs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/waves.xml

Loading...
View Options

ps/trunk/source/ps/CStrInternStatic.h

Loading...
View Options

ps/trunk/source/renderer/PatchRData.cpp

Loading...
View Options

ps/trunk/source/renderer/PatchRData.h

Loading...
View Options

ps/trunk/source/renderer/Renderer.cpp

Loading...
View Options

ps/trunk/source/renderer/Renderer.h

Loading...
View Options

ps/trunk/source/renderer/TerrainRenderer.cpp

Loading...
View Options

ps/trunk/source/renderer/WaterManager.cpp

Loading...
View Options

ps/trunk/source/renderer/WaterManager.h

Loading...
View Options

ps/trunk/source/simulation2/components/CCmpTerrain.cpp

Loading...
View Options

ps/trunk/source/simulation2/components/CCmpWaterManager.cpp

Loading...
Wildfire Games · Phabricator