HomeWildfire Games

Fix mirages not flushed properly, introduced in r15956.
AuditedrP15963

Description

Fix mirages not flushed properly, introduced in r15956.

Details

Auditors
wraitii
Committed
ItmsNov 13 2014, 10:04 PM
Parents
rP15962: prevent events from the first turn after deserialization to be thrown away
Branches
Unknown
Tags
Unknown

Event Timeline

wraitii raised a concern with this commit.EditedJan 6 2019, 10:10 AM
wraitii added a subscriber: wraitii.

This destroyed INVALID_ENTITY on some maps (which triggered the crash in rP22029).

This commit now has outstanding concerns.Jan 6 2019, 10:10 AM
wraitii accepted this commit.Jan 6 2019, 11:56 AM

This is actually WAD, as mirages are hidden when the original entity is visible, so we need to clean them up, and destroying INVALID_ENTITY is supposed to work.

Created D1735, D1736 and D1737 in reaction to this.

D8 may be re-committed following D1736.

All concerns with this commit have now been addressed.Jan 6 2019, 11:56 AM